Re: cleaning DHCP iface address/routes

2016-11-23 Thread Nadav Har'El
On Wed, Nov 23, 2016 at 9:52 PM, Justin Cinkelj wrote: > I wish to ask for comment or two about how to clean DHCP interface routes > after sending DHCP release. > It is one thing Nadav suggested (if I understood him correctly) to add. > I didn't ask for this, but you're right, it does make sense

Re: [PATCH 0/2] dhcp: remove IP from interface when DHCP release is send

2016-11-23 Thread Nadav Har'El
I didn't seem to get these patches... Can you please send them again? Thanks. -- Nadav Har'El n...@scylladb.com On Wed, Nov 23, 2016 at 11:07 PM, Justin Cinkelj wrote: > The first patch removes IP from iface when DHCP release is sent. > This one is needed, because otherwise we send release, bu

[PATCH 0/2] dhcp: remove IP from interface when DHCP release is send

2016-11-23 Thread Justin Cinkelj
The first patch removes IP from iface when DHCP release is sent. This one is needed, because otherwise we send release, but keep using the IP address. The second one clears DNS configuration at DHCP release event. Justin Cinkelj (2): dhcp: remove IP from interface when DHCP release is send dh

cleaning DHCP iface address/routes

2016-11-23 Thread Justin Cinkelj
I wish to ask for comment or two about how to clean DHCP interface routes after sending DHCP release. It is one thing Nadav suggested (if I understood him correctly) to add. In DORA cycle, after receiving ACK, the following things are called from dhcp_interface_state::state_request osv::s

[COMMIT osv master] cloud-init: trigger dynamic DNS update on hostname change

2016-11-23 Thread Commit Bot
From: Justin Cinkelj Committer: Nadav Har'El Branch: master cloud-init: trigger dynamic DNS update on hostname change When cloud-init changes VM hostname, VM DNS name should be updated too. We try to do this by releasing DHCP lease and requesting new lease with new name. This instructs DHCP se

[PATCH v3] cloud-init: trigger dynamic DNS update on hostname change

2016-11-23 Thread Justin Cinkelj
When cloud-init changes VM hostname, VM DNS name should be updated too. We try to do this by releasing DHCP lease and requesting new lease with new name. This instructs DHCP server to perform dynamic DNS update. DNS update will/should succeed if 1) new name is not already claimed by some other VM/

Re: [PATCH v2 2/2] cloud-init: trigger dynamic DNS update on hostname change

2016-11-23 Thread Nadav Har'El
On Wed, Nov 23, 2016 at 3:42 PM, Justin Cinkelj wrote: > > > On 11/23/2016 02:32 PM, Nadav Har'El wrote: > > > On Wed, Nov 23, 2016 at 3:27 PM, Justin Cinkelj > wrote: > >> When cloud-init changes VM hostname, VM DNS name should be updated too. >> We try to do this by releasing DHCP lease and re

[COMMIT osv master] dhcp: set src and dest IP in DHCP release packet

2016-11-23 Thread Commit Bot
From: Justin Cinkelj Committer: Nadav Har'El Branch: master dhcp: set src and dest IP in DHCP release packet DHCP release packet should have valid IP header. There is no need to use INADDR_ANY/INADDR_BROADCAST as src/dest address. Signed-off-by: Justin Cinkelj Message-Id: <20161123132746.275

Re: [PATCH v2 2/2] cloud-init: trigger dynamic DNS update on hostname change

2016-11-23 Thread Justin Cinkelj
On 11/23/2016 02:32 PM, Nadav Har'El wrote: On Wed, Nov 23, 2016 at 3:27 PM, Justin Cinkelj mailto:justin.cink...@xlab.si>> wrote: When cloud-init changes VM hostname, VM DNS name should be updated too. We try to do this by releasing DHCP lease and requesting new lease with

Re: [PATCH v2 2/2] cloud-init: trigger dynamic DNS update on hostname change

2016-11-23 Thread Nadav Har'El
On Wed, Nov 23, 2016 at 3:27 PM, Justin Cinkelj wrote: > When cloud-init changes VM hostname, VM DNS name should be updated too. > We try to do this by releasing DHCP lease and requesting new lease > with new name. This instructs DHCP server to perform dynamic DNS update. > DNS update will/should

[PATCH v2 2/2] cloud-init: trigger dynamic DNS update on hostname change

2016-11-23 Thread Justin Cinkelj
When cloud-init changes VM hostname, VM DNS name should be updated too. We try to do this by releasing DHCP lease and requesting new lease with new name. This instructs DHCP server to perform dynamic DNS update. DNS update will/should succeed if 1) new name is not already claimed by some other VM/

[PATCH v2 0/2] cloud-init: trigger dynamic DNS update on hostname change

2016-11-23 Thread Justin Cinkelj
Additional patch 1/2 added, to set src and dest IP in DHCP release packet. The 2/2 patch is updated. Also on second DORA try is the discovery packet resend if server doesn't respond in time. The dhcp_worker and dhcp_interface_state restart function was removed - as Nadav noted, the were not really

[PATCH v2 1/2] dhcp: set src and dest IP in DHCP release packet

2016-11-23 Thread Justin Cinkelj
DHCP release packet should have valid IP header. There is no need to use INADDR_ANY/INADDR_BROADCAST as src/dest address. Signed-off-by: Justin Cinkelj --- core/dhcp.cc| 12 ++-- include/osv/dhcp.hh | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/core/dhcp

Re: [PATCH] cloud-init: trigger dynamic DNS update on hostname change

2016-11-23 Thread Justin Cinkelj
On 11/23/2016 11:39 AM, Nadav Har'El wrote: On Wed, Nov 23, 2016 at 11:20 AM, Justin Cinkelj mailto:justin.cink...@xlab.si>> wrote: - Original Message - > From: "Nadav Har'El" mailto:n...@scylladb.com>> > To: "Justin Cinkelj" mailto:justin.cink...@xlab.si>> > Cc: "

Re: [PATCH] cloud-init: trigger dynamic DNS update on hostname change

2016-11-23 Thread Nadav Har'El
On Wed, Nov 23, 2016 at 11:20 AM, Justin Cinkelj wrote: > > > - Original Message - > > From: "Nadav Har'El" > > To: "Justin Cinkelj" > > Cc: "Osv Dev" > > Sent: Wednesday, November 23, 2016 8:31:01 AM > > Subject: Re: [PATCH] cloud-init: trigger dynamic DNS update on hostname > change

Re: [PATCH] cloud-init: trigger dynamic DNS update on hostname change

2016-11-23 Thread Justin Cinkelj
- Original Message - > From: "Nadav Har'El" > To: "Justin Cinkelj" > Cc: "Osv Dev" > Sent: Wednesday, November 23, 2016 8:31:01 AM > Subject: Re: [PATCH] cloud-init: trigger dynamic DNS update on hostname change > > Hi Justin, some comments inline below: > > On Tue, Nov 22, 2016 at 1