[osv-dev] Re: [PATCH 0/2] tests: add virtio-fs DAX manager tests

Thanks for the patch. Let me find some time to properly review the changes. It is highly valuable to have some automated tests of DAX window functionality. How confident are you that your changes to the fs/virtiofs/* to make it testable with stubs do not break anything? On Saturday, March 6,

[osv-dev] [COMMIT osv master] aarch64: use memory barrier to force completion of PTE writes

From: Waldemar Kozaczuk Committer: Waldemar Kozaczuk Branch: master aarch64: use memory barrier to force completion of PTE writes As the issue #1117 describes, OSv crashes very often early on when running on QEMU with KVM accelleration on with backtrace looking like this: ``` OSv

[osv-dev] [COMMIT osv master] Modifying times function to gracefully handle being passed a null pointer

From: Shawn Barber' via OSv Development Committer: Nadav Har'El Branch: master Modifying times function to gracefully handle being passed a null pointer Signed-off by: Shawn M Barber Message-Id: <20210309203029.20432-1-shawn.bar...@dornerworks.com> --- diff --git a/runtime.cc b/runtime.cc

[osv-dev] [PATCH] Modifying times function to gracefully handle being passed a null pointer

Signed-off by: Shawn M Barber --- runtime.cc | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/runtime.cc b/runtime.cc index 78710504..25ef7ea2 100644 --- a/runtime.cc +++ b/runtime.cc @@ -442,12 +442,15 @@ clock_t times(struct tms *buffer) clockseconds

RE: [osv-dev] [PATCH] Modifying times function to gracefully handle being passed a null pointer

Thanks, I did miss that part of the coding style guide. The single return is from my days in aviation and DOD work. It’s hard to shake! I will fix it up and resubmit. Shawn From: Nadav Har'El Sent: Tuesday, March 9, 2021 3:22 PM To: Shawn Barber Cc: OSv Development ; Waldek Kozaczuk

Re: [osv-dev] [PATCH] Modifying times function to gracefully handle being passed a null pointer

Good catch - this is a Linux-specific behavior (not part of Posix) which we indeed forgot to handle. Thanks for the patch! I just have a few stylistic requests below: On Tue, Mar 9, 2021 at 9:11 PM 'Shawn Barber' via OSv Development < osv-dev@googlegroups.com> wrote: > Signed-off by: Shawn M

Re: [osv-dev] OSv page_fault assert during "bsd: initializing"?

Is there a chance I could get a hold of the test app you are running on OSv? On other hand given it happens so early in the boot process (it seems at least) it probably does not matter. Also, which version of firecracker are you using? I am using v0.23.0 and the latest OSv master (you see to

[osv-dev] [PATCH] Modifying times function to gracefully handle being passed a null pointer

Signed-off by: Shawn M Barber --- runtime.cc | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/runtime.cc b/runtime.cc index 78710504..ad5bb07f 100644 --- a/runtime.cc +++ b/runtime.cc @@ -435,6 +435,7 @@ clock_t times(struct tms *buffer) { using

Re: [osv-dev] OSv page_fault assert during "bsd: initializing"?

To add weight to the timing issue theory, we are seeing the crash much more often (est. 1 in 20) when : - The -verbose OSv startup argument is supplied or - We TCP connect to the OSv instance whilst it is starting up Is there somewhere I can raise a bug report for this? On Friday,