[osv-dev] Re: [PATCH 0/2] tests: add virtio-fs DAX manager tests

2021-03-13 Thread Waldek Kozaczuk
No. I think it looks good. I have tested it as well and things still work. On Thursday, March 11, 2021 at 3:39:15 PM UTC-5 Fotis Xenakis wrote: > On Wednesday, March 10, 2021 at 12:57:01 AM UTC+2 jwkoz...@gmail.com > wrote: > >> Thanks for the patch. Let me find some time to properly review the

[osv-dev] Re: [PATCH 0/2] tests: add virtio-fs DAX manager tests

2021-03-11 Thread Fotis Xenakis
On Wednesday, March 10, 2021 at 12:57:01 AM UTC+2 jwkoz...@gmail.com wrote: > Thanks for the patch. Let me find some time to properly review the > changes. It is highly valuable to have some automated tests of DAX window > functionality. > > How confident are you that your changes to the

[osv-dev] Re: [PATCH 0/2] tests: add virtio-fs DAX manager tests

2021-03-09 Thread Waldek Kozaczuk
Thanks for the patch. Let me find some time to properly review the changes. It is highly valuable to have some automated tests of DAX window functionality. How confident are you that your changes to the fs/virtiofs/* to make it testable with stubs do not break anything? On Saturday, March 6,