[osv-dev] [PATCH] java: eliminate openjdk7

2020-01-14 Thread Waldemar Kozaczuk
Java 7 reached end of life almost 5 years ago and has since been largely replaced by Java 8 which is still widely used. This patch eliminates openjdk7 module and makes openjdk8-zull-full a default java module. This patch also replaces dependencies in the main makefile on antique openjdk7 in

Re: [osv-dev] Fail to read data from large file

2020-01-14 Thread Dor Laor
A classical good OSS reporter and a good (!) committer On Tue, Jan 14, 2020 at 2:47 AM Nadav Har'El wrote: > > On Tue, Jan 14, 2020 at 12:41 PM Lewis Tian wrote: >> >> >> >> On Tuesday, January 14, 2020 at 4:45:27 PM UTC+8, Nadav Har'El wrote: >>> >>> >>> Interesting. Smells like a serious

[osv-dev] Re: [PATCH] Signed-off-by: BassMatt

2020-01-14 Thread Waldek Kozaczuk
Hi, Would you mind re-submitting this patch with signature? Or giving us line: Signed-off-by: Real Name so we can apply this patch? Thanks in advance, Waldek On Thursday, December 12, 2019 at 3:02:54 PM UTC-5, BassMatt wrote: > > Main scripts in scripts/ folder updated to use Python3 > > I

Re: [osv-dev] [COMMIT osv master] procfs: add meminfo pseudo-file

2020-01-14 Thread Waldek Kozaczuk
On Sunday, January 12, 2020 at 5:43:48 AM UTC-5, Nadav Har'El wrote: > > > On Fri, Jan 10, 2020 at 6:28 AM Commit Bot > wrote: > >> From: Waldemar Kozaczuk > >> Committer: Waldemar Kozaczuk > >> Branch: master >> >> procfs: add meminfo pseudo-file >> > > Can you please say a few words on the

[osv-dev] [COMMIT osv master] elf: separate loading segments from processing headers

2020-01-14 Thread Commit Bot
From: Waldemar Kozaczuk Committer: Nadav Har'El Branch: master elf: separate loading segments from processing headers The issue #1045 exposed a bug in the dynamic linker when processing some headers like PT_NOTE require accessing data in the PT_LOAD segments. If PT_NOTE headers come earlier

[osv-dev] [COMMIT osv master] externals: eliminate unused glibcbase build parameter

2020-01-14 Thread Commit Bot
From: Waldemar Kozaczuk Committer: Waldemar Kozaczuk Branch: master externals: eliminate unused glibcbase build parameter References #743 Signed-off-by: Waldemar Kozaczuk --- diff --git a/Makefile b/Makefile --- a/Makefile +++ b/Makefile @@ -231,7 +231,6 @@ local-includes = INCLUDES =

[osv-dev] [COMMIT osv master] httpserver: use libyaml header from host instead of external

2020-01-14 Thread Commit Bot
From: Waldemar Kozaczuk Committer: Waldemar Kozaczuk Branch: master httpserver: use libyaml header from host instead of external Signed-off-by: Waldemar Kozaczuk --- diff --git a/modules/httpserver-api/global_server.hh b/modules/httpserver-api/global_server.hh ---

Re: [osv-dev] Fail to read data from large file

2020-01-14 Thread Nadav Har'El
On Tue, Jan 14, 2020 at 10:15 AM Lewis Tian wrote: > > > On Tuesday, January 14, 2020 at 3:45:09 PM UTC+8, Nadav Har'El wrote: >> >> >> On Tue, Jan 14, 2020 at 9:28 AM Lewis Tian wrote: >> >>> When I run pagerank on Ubuntu, the code works fine. (the graph data is >>> stored in

Re: [osv-dev] Fail to read data from large file

2020-01-14 Thread Lewis Tian
On Tuesday, January 14, 2020 at 3:45:09 PM UTC+8, Nadav Har'El wrote: > > > On Tue, Jan 14, 2020 at 9:28 AM Lewis Tian > wrote: > >> When I run pagerank on Ubuntu, the code works fine. (the graph data is >> stored in web-NotreDame.txt, 21M) >> > > 21M isn't very large, it shouldn't present any

[osv-dev] [COMMIT osv master] git: ignore JSON Compilation Database files used by CLion IDE

2020-01-14 Thread Commit Bot
From: Waldemar Kozaczuk Committer: Waldemar Kozaczuk Branch: master git: ignore JSON Compilation Database files used by CLion IDE Signed-off-by: Waldemar Kozaczuk --- diff --git a/.gitignore b/.gitignore --- a/.gitignore +++ b/.gitignore @@ -49,3 +49,4 @@ modules/libyaml/usr.manifest

[osv-dev] [COMMIT osv master] stdio: fix scanf bug

2020-01-14 Thread Commit Bot
From: Nadav Har'El Committer: Waldemar Kozaczuk Branch: master stdio: fix scanf bug Lewis Tian noted on the mailing list that an application reading with fscanf() from a large file fails after passing one BUFSIZ of data. It turns out that the old Musl code we were using was only correct

Re: [osv-dev] Fail to read data from large file

2020-01-14 Thread Lewis Tian
On Tuesday, January 14, 2020 at 4:45:27 PM UTC+8, Nadav Har'El wrote: > > > On Tue, Jan 14, 2020 at 10:15 AM Lewis Tian > wrote: > >> >> >> On Tuesday, January 14, 2020 at 3:45:09 PM UTC+8, Nadav Har'El wrote: >>> >>> >>> On Tue, Jan 14, 2020 at 9:28 AM Lewis Tian wrote: >>> When I run

Re: [osv-dev] Fail to read data from large file

2020-01-14 Thread Nadav Har'El
On Tue, Jan 14, 2020 at 12:41 PM Lewis Tian wrote: > > > On Tuesday, January 14, 2020 at 4:45:27 PM UTC+8, Nadav Har'El wrote: >> >> >> Interesting. Smells like a serious stdio bug that needs to be debugged :-( >> I think it's not a coincidence that position is 1025, with stdio's >> BUFSIZ=1024.

[osv-dev] [PATCH] stdio: fix scanf bug

2020-01-14 Thread Nadav Har'El
Lewis Tian noted on the mailing list that an application reading with fscanf() from a large file fails after passing one BUFSIZ of data. It turns out that the old Musl code we were using was only correct assuming a certain bizarre readv() bug workaround which OSv dropped in commit

[osv-dev] [PATCH] elf: separate loading segments from processing headers

2020-01-14 Thread Waldemar Kozaczuk
The issue #1045 exposed a bug in the dynamic linker when processing some headers like PT_NOTE require accessing data in the PT_LOAD segments. If PT_NOTE headers come earlier than PT_NOTE we end up with the page fault as the portions of ELF file have not been mapped yet. This patch separates