Re: [osv-dev] [PATCH] java: eliminate openjdk7

2020-01-15 Thread Nadav Har'El
On Wed, Jan 15, 2020 at 6:07 AM Waldemar Kozaczuk wrote: > Java 7 reached end of life almost 5 years ago and has since > been largely replaced by Java 8 which is still widely used. > > This patch eliminates openjdk7 module and makes openjdk8-zull-full > a default java module. This patch also repl

Re: [osv-dev] [PATCH] java: eliminate openjdk7

2020-01-15 Thread Waldek Kozaczuk
On Wednesday, January 15, 2020 at 3:45:13 AM UTC-5, Nadav Har'El wrote: > > > On Wed, Jan 15, 2020 at 6:07 AM Waldemar Kozaczuk > wrote: > >> Java 7 reached end of life almost 5 years ago and has since >> been largely replaced by Java 8 which is still widely used. >> >> This patch eliminates ope

[osv-dev] Re: [PATCH 3/3] Implement RTLD_NEXT

2020-01-15 Thread Waldek Kozaczuk
Any reason we should not apply this patch? I have opened new issue - https://github.com/cloudius-systems/osv/issues/1072 - to cover things we want to fix in dlopen/dlsym. Zhiting please verify I have not missed anything and add what I missed. Now we can reference this issue. On Monday, Januar

Re: [osv-dev] [PATCH 3/3] Implement RTLD_NEXT

2020-01-15 Thread Nadav Har'El
On Mon, Jan 13, 2020 at 8:10 PM Zhiting Zhu wrote: > Signed-off-by: Zhiting Zhu > --- > core/elf.cc| 33 + > include/osv/elf.hh | 1 + > libc/dlfcn.cc | 4 ++-- > tests/tst-dlfcn.cc | 2 +- > 4 files changed, 37 insertions(+), 3 deletions(-) > > d

[osv-dev] [PATCH 1/2] Lookup symbol deeper

2020-01-15 Thread Zhiting Zhu
dlsym function doesn't seem to lookup symbol deep enough. This patch fixes test_dlsym_from_sofile_with_preload and dlsym_with_dependencies Signed-off-by: Waldemar Kozaczuk Signed-off-by: Zhiting Zhu --- core/elf.cc| 14 ++ include/osv/elf.hh | 1 + libc/dlfcn.cc | 2 +

[osv-dev] [PATCH 2/2] Implement RTLD_NEXT

2020-01-15 Thread Zhiting Zhu
Signed-off-by: Zhiting Zhu --- core/elf.cc| 33 + include/osv/elf.hh | 1 + libc/dlfcn.cc | 4 ++-- tests/tst-dlfcn.cc | 2 +- 4 files changed, 37 insertions(+), 3 deletions(-) diff --git a/core/elf.cc b/core/elf.cc index 26a25c43..69dbd7ed 100644

Re: [osv-dev] [PATCH 1/2] Lookup symbol deeper

2020-01-15 Thread Nadav Har'El
When you send a second version of a patch, please label it with "v2" and so on (if you use git format-patch, you can do "git format-patch -v2" to do this automatically) and write below the fold (the "--" line) some comments about what changed. Because it's hard for me to keep track what are new pat

Re: [osv-dev] [PATCH 1/2] Lookup symbol deeper

2020-01-15 Thread zhiting zhu
Sorry, I might miss your reply. Thanks for the tip on format-patch. I will do it in the future. This patch is written by Waldemar for a fix on the test errors. I'm not familiar with the elf spec. I don't know whether DT_NEEDED would have a cycle. I feel the order of the objects matter, especially

Re: [osv-dev] [PATCH 1/2] Lookup symbol deeper

2020-01-15 Thread Nadav Har'El
On Thu, Jan 16, 2020 at 2:00 AM zhiting zhu wrote: > Sorry, I might miss your reply. Thanks for the tip on format-patch. I will > do it in the future. This patch is written by Waldemar for a fix on the > test errors. I'm not familiar with the elf spec. I don't know whether > DT_NEEDED would have

[osv-dev] [COMMIT osv master] externals: removed unneeded x64 git submodules - glibc.bin and glibc-testsuite

2020-01-15 Thread Commit Bot
From: Waldemar Kozaczuk Committer: Waldemar Kozaczuk Branch: master externals: removed unneeded x64 git submodules - glibc.bin and glibc-testsuite Signed-off-by: Waldemar Kozaczuk --- diff --git a/.gitmodules b/.gitmodules --- a/.gitmodules +++ b/.gitmodules @@ -6,14 +6,6 @@ path

[osv-dev] [PATCH] java: move java_api and jni_helpers to java modules

2020-01-15 Thread Waldemar Kozaczuk
The java_api.* and jni_helpers.* are actually only used by java.cc and following httpserver java-related plugins: - httpserver-jolokia-plugin - httpserver-jvm-plugin - josvsym This patch moves the relevant code out from kernel and makes it part of java.so. Signed-off-by: Waldemar Kozaczuk --- M