Re: [osv-dev] Using PERCPU in application or module

2020-05-24 Thread Nadav Har'El
On Sat, May 23, 2020 at 6:35 PM Wonsup Yoon wrote: > Hi, > > I'm trying to use PERCPU macro in application or module. > Hi, The PERCPU macro does not support this. What it does is to add information about this variable in a special section of the executable (".percpu"), then arch/x64/loader.ld

[osv-dev] Re: [PATCH v2 4/4] virtio-fs: refactor driver / fs

2020-05-24 Thread Waldek Kozaczuk
Hi, I think both 3 and 4 parts of your patches look good. But I guess it would not hurt if Nadav could scrutinize at them from C++ perspective as well. However, I am having a bit of trouble testing those. I do not think anything is wrong with your patches but possibly something has changed on

Re: [osv-dev] [PATCH 2/3] lzloader: fix memset() implementation

2020-05-24 Thread Rick Payne
I think this is also related to 913. I'll try without my patch (which we've been having to use since then). Rick On Sat, 2020-05-23 at 23:47 +0300, Nadav Har'El wrote: > Some compilers apparently optimize code in fastlz/ to call memset(), > so > the uncompressing boot loader,

[osv-dev] [COMMIT osv master] lzloader: fix memset() implementation

2020-05-24 Thread Commit Bot
From: Nadav Har'El Committer: Nadav Har'El Branch: master lzloader: fix memset() implementation Some compilers apparently optimize code in fastlz/ to call memset(), so the uncompressing boot loader, fastlz/lzloader.cc, needs to implement this function. The current implementation called the

[osv-dev] [COMMIT osv master] scripts: fix setup.py for Ubuntu versions

2020-05-24 Thread Commit Bot
From: Robin Gögge Committer: Nadav Har'El Branch: master scripts: fix setup.py for Ubuntu versions As explained in issue #1085 the setup script is broken for some Ubuntu versions. This commit installs the packages `python-dpkt` and `python3-dpkt` for the respective Ubuntu version.

[osv-dev] [COMMIT osv master] libosv.so: fix warnings on truncated symbol names

2020-05-24 Thread Commit Bot
From: Nadav Har'El Committer: Nadav Har'El Branch: master libosv.so: fix warnings on truncated symbol names The code in Makefile which builds the esoteric libosv.so library used "readelf" to get a list of symbols from the kernel. However, readelf by default truncates the symbol names after

[osv-dev] [COMMIT osv master] memset_base(): avoid warnings in stricter C++ compiler

2020-05-24 Thread Commit Bot
From: Nadav Har'El Committer: Nadav Har'El Branch: master memset_base(): avoid warnings in stricter C++ compiler If we try to compile memset.c with a C++ compiler, we get warnings on various implied pointer conversions. Let's make them explict, and this way the code can compile as either C or

[osv-dev] [COMMIT osv master] setup.py: support Fedora 32

2020-05-24 Thread Commit Bot
From: Nadav Har'El Committer: Nadav Har'El Branch: master setup.py: support Fedora 32 After the previous patches, OSv now correctly builds on Fedora 32. So support Fedora 32 in setup.py. The same packages needed in previous Fedora releases are also needed in Fedora 32. Signed-off-by: Nadav

Re: [osv-dev] [PATCH 3/3] setup.py: support Fedora 32

2020-05-24 Thread Waldek Kozaczuk
Great investigative work! Now we support latest Ubuntu and Fedora. Sent from my iPhone > On May 23, 2020, at 15:47, Nadav Har'El wrote: > > After the previous patches, OSv now correctly builds on Fedora 32. > So support Fedora 32 in setup.py. The same packages needed in previous Fedora >