Re: [PATCH] Changed java-example to use java.so directly to start example Hello application

2016-10-14 Thread Waldek Kozaczuk
Tomasz,

You can ignore this patch. I create new issue #800 and send corresponding 
patch that addresses the problem in a better way.

I will be sending another patch that cleans the apps later.

Waldek

On Thursday, September 22, 2016 at 11:44:59 AM UTC-4, Tomasz Grabiec wrote:
>
> On Wed, Sep 21, 2016 at 6:44 PM, Waldek Kozaczuk  > wrote: 
> > But in order to run multiple java modules/apps it need MultiJarLoader 
> which 
> > would not work on compact profile JRE. On other hand it is just an 
> example. 
> > 
> > My motivation for this patch was to get rid of 3 extra 
> java_compact*_example 
> > apps. But maybe instead of changing java_example I can simply reduce 
> > java_compact*_example to something like java_singleapp_example that 
> would 
> > use java.so. Thoughts? 
>
> Perhaps java module linking should detect if compact-profile runtime 
> is used and fall back to not using isolation framework, and complain 
> during build if more than one JVM application is being compiled into 
> the image. 
>
> This way all java modules could keep using run_java() and be generic. 
>

-- 
You received this message because you are subscribed to the Google Groups "OSv 
Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to osv-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [PATCH] Changed java-example to use java.so directly to start example Hello application

2016-09-21 Thread Tomasz Grabiec
On Wed, Sep 21, 2016 at 5:05 PM, Waldek Kozaczuk 
wrote:

> Please see my answers below.
>
> Sent from my iPhone
>
> On Sep 21, 2016, at 03:17, Tomasz Grabiec  wrote:
>
>
>
> On Wed, Sep 21, 2016 at 6:32 AM, Waldemar Kozaczuk 
> wrote:
>
>> This change makes the java-example app universal so that it can be used
>> with any
>> Java runtime module like so:
>>
>> ./scripts/build image=java,java-example
>> ./scripts/build image=openjdk8-fedora,java-example
>> ./scripts/build image=openjdk8-zulu-compact1,java-example
>> ./scripts/build image=openjdk8-zulu-compact2,java-example
>> ./scripts/build image=openjdk8-zulu-compact3,java-example
>>
>> Signed-off-by: Waldemar Kozaczuk 
>> ---
>>  java-compact1-example/Hello.java   | 5 -
>>  java-compact1-example/Makefile | 7 ---
>>  java-compact1-example/module.py| 5 -
>>  java-compact1-example/usr.manifest | 1 -
>>  java-compact2-example/Hello.java   | 5 -
>>  java-compact2-example/Makefile | 7 ---
>>  java-compact2-example/module.py| 5 -
>>  java-compact2-example/usr.manifest | 1 -
>>  java-compact3-example/Hello.java   | 5 -
>>  java-compact3-example/Makefile | 7 ---
>>  java-compact3-example/module.py| 5 -
>>  java-compact3-example/usr.manifest | 1 -
>>  java-example/module.py | 2 +-
>>  13 files changed, 1 insertion(+), 55 deletions(-)
>>  delete mode 100644 java-compact1-example/Hello.java
>>  delete mode 100644 java-compact1-example/Makefile
>>  delete mode 100644 java-compact1-example/module.py
>>  delete mode 100644 java-compact1-example/usr.manifest
>>  delete mode 100644 java-compact2-example/Hello.java
>>  delete mode 100644 java-compact2-example/Makefile
>>  delete mode 100644 java-compact2-example/module.py
>>  delete mode 100644 java-compact2-example/usr.manifest
>>  delete mode 100644 java-compact3-example/Hello.java
>>  delete mode 100644 java-compact3-example/Makefile
>>  delete mode 100644 java-compact3-example/module.py
>>  delete mode 100644 java-compact3-example/usr.manifest
>>
>> diff --git a/java-compact1-example/Hello.java
>> b/java-compact1-example/Hello.java
>> deleted file mode 100644
>> index a605554..000
>> --- a/java-compact1-example/Hello.java
>> +++ /dev/null
>> @@ -1,5 +0,0 @@
>> -public class Hello {
>> -public static void main(String[] args) {
>> -System.out.println("Hello, World!");
>> -}
>> -}
>> diff --git a/java-compact1-example/Makefile
>> b/java-compact1-example/Makefile
>> deleted file mode 100644
>> index 8a385c9..000
>> --- a/java-compact1-example/Makefile
>> +++ /dev/null
>> @@ -1,7 +0,0 @@
>> -module: Hello.class
>> -
>> -%.class: %.java
>> -   javac -target 7 -source 7 $^
>> -
>> -clean:
>> -   rm -rf *.class
>> diff --git a/java-compact1-example/module.py
>> b/java-compact1-example/module.py
>> deleted file mode 100644
>> index 216cf35..000
>> --- a/java-compact1-example/module.py
>> +++ /dev/null
>> @@ -1,5 +0,0 @@
>> -from osv.modules import api
>> -
>> -api.require('openjdk8-zulu-compact1')
>> -
>> -default = api.run('/java.so -cp /java-example Hello')
>> diff --git a/java-compact1-example/usr.manifest b/java-compact1-example/
>> usr.manifest
>> deleted file mode 100644
>> index f62abc7..000
>> --- a/java-compact1-example/usr.manifest
>> +++ /dev/null
>> @@ -1 +0,0 @@
>> -/java-example/Hello.class: ${MODULE_DIR}/Hello.class
>> diff --git a/java-compact2-example/Hello.java
>> b/java-compact2-example/Hello.java
>> deleted file mode 100644
>> index a605554..000
>> --- a/java-compact2-example/Hello.java
>> +++ /dev/null
>> @@ -1,5 +0,0 @@
>> -public class Hello {
>> -public static void main(String[] args) {
>> -System.out.println("Hello, World!");
>> -}
>> -}
>> diff --git a/java-compact2-example/Makefile
>> b/java-compact2-example/Makefile
>> deleted file mode 100644
>> index 8a385c9..000
>> --- a/java-compact2-example/Makefile
>> +++ /dev/null
>> @@ -1,7 +0,0 @@
>> -module: Hello.class
>> -
>> -%.class: %.java
>> -   javac -target 7 -source 7 $^
>> -
>> -clean:
>> -   rm -rf *.class
>> diff --git a/java-compact2-example/module.py
>> b/java-compact2-example/module.py
>> deleted file mode 100644
>> index f17ac37..000
>> --- a/java-compact2-example/module.py
>> +++ /dev/null
>> @@ -1,5 +0,0 @@
>> -from osv.modules import api
>> -
>> -api.require('openjdk8-zulu-compact2')
>> -
>> -default = api.run('/java.so -cp /java-example Hello')
>> diff --git a/java-compact2-example/usr.manifest b/java-compact2-example/
>> usr.manifest
>> deleted file mode 100644
>> index f62abc7..000
>> --- a/java-compact2-example/usr.manifest
>> +++ /dev/null
>> @@ -1 +0,0 @@
>> -/java-example/Hello.class: ${MODULE_DIR}/Hello.class
>> diff --git a/java-compact3-example/Hello.java
>> b/java-compact3-example/Hello.java
>> deleted file mode 100644
>> index a605554..000
>> --- a/java-compact3-example/Hello.java
>> 

Re: [PATCH] Changed java-example to use java.so directly to start example Hello application

2016-09-21 Thread Waldek Kozaczuk
Please see my answers below. 

Sent from my iPhone

> On Sep 21, 2016, at 03:17, Tomasz Grabiec  wrote:
> 
> 
> 
>> On Wed, Sep 21, 2016 at 6:32 AM, Waldemar Kozaczuk  
>> wrote:
>> This change makes the java-example app universal so that it can be used with 
>> any
>> Java runtime module like so:
>> 
>> ./scripts/build image=java,java-example
>> ./scripts/build image=openjdk8-fedora,java-example
>> ./scripts/build image=openjdk8-zulu-compact1,java-example
>> ./scripts/build image=openjdk8-zulu-compact2,java-example
>> ./scripts/build image=openjdk8-zulu-compact3,java-example
>> 
>> Signed-off-by: Waldemar Kozaczuk 
>> ---
>>  java-compact1-example/Hello.java   | 5 -
>>  java-compact1-example/Makefile | 7 ---
>>  java-compact1-example/module.py| 5 -
>>  java-compact1-example/usr.manifest | 1 -
>>  java-compact2-example/Hello.java   | 5 -
>>  java-compact2-example/Makefile | 7 ---
>>  java-compact2-example/module.py| 5 -
>>  java-compact2-example/usr.manifest | 1 -
>>  java-compact3-example/Hello.java   | 5 -
>>  java-compact3-example/Makefile | 7 ---
>>  java-compact3-example/module.py| 5 -
>>  java-compact3-example/usr.manifest | 1 -
>>  java-example/module.py | 2 +-
>>  13 files changed, 1 insertion(+), 55 deletions(-)
>>  delete mode 100644 java-compact1-example/Hello.java
>>  delete mode 100644 java-compact1-example/Makefile
>>  delete mode 100644 java-compact1-example/module.py
>>  delete mode 100644 java-compact1-example/usr.manifest
>>  delete mode 100644 java-compact2-example/Hello.java
>>  delete mode 100644 java-compact2-example/Makefile
>>  delete mode 100644 java-compact2-example/module.py
>>  delete mode 100644 java-compact2-example/usr.manifest
>>  delete mode 100644 java-compact3-example/Hello.java
>>  delete mode 100644 java-compact3-example/Makefile
>>  delete mode 100644 java-compact3-example/module.py
>>  delete mode 100644 java-compact3-example/usr.manifest
>> 
>> diff --git a/java-compact1-example/Hello.java 
>> b/java-compact1-example/Hello.java
>> deleted file mode 100644
>> index a605554..000
>> --- a/java-compact1-example/Hello.java
>> +++ /dev/null
>> @@ -1,5 +0,0 @@
>> -public class Hello {
>> -public static void main(String[] args) {
>> -System.out.println("Hello, World!");
>> -}
>> -}
>> diff --git a/java-compact1-example/Makefile b/java-compact1-example/Makefile
>> deleted file mode 100644
>> index 8a385c9..000
>> --- a/java-compact1-example/Makefile
>> +++ /dev/null
>> @@ -1,7 +0,0 @@
>> -module: Hello.class
>> -
>> -%.class: %.java
>> -   javac -target 7 -source 7 $^
>> -
>> -clean:
>> -   rm -rf *.class
>> diff --git a/java-compact1-example/module.py 
>> b/java-compact1-example/module.py
>> deleted file mode 100644
>> index 216cf35..000
>> --- a/java-compact1-example/module.py
>> +++ /dev/null
>> @@ -1,5 +0,0 @@
>> -from osv.modules import api
>> -
>> -api.require('openjdk8-zulu-compact1')
>> -
>> -default = api.run('/java.so -cp /java-example Hello')
>> diff --git a/java-compact1-example/usr.manifest 
>> b/java-compact1-example/usr.manifest
>> deleted file mode 100644
>> index f62abc7..000
>> --- a/java-compact1-example/usr.manifest
>> +++ /dev/null
>> @@ -1 +0,0 @@
>> -/java-example/Hello.class: ${MODULE_DIR}/Hello.class
>> diff --git a/java-compact2-example/Hello.java 
>> b/java-compact2-example/Hello.java
>> deleted file mode 100644
>> index a605554..000
>> --- a/java-compact2-example/Hello.java
>> +++ /dev/null
>> @@ -1,5 +0,0 @@
>> -public class Hello {
>> -public static void main(String[] args) {
>> -System.out.println("Hello, World!");
>> -}
>> -}
>> diff --git a/java-compact2-example/Makefile b/java-compact2-example/Makefile
>> deleted file mode 100644
>> index 8a385c9..000
>> --- a/java-compact2-example/Makefile
>> +++ /dev/null
>> @@ -1,7 +0,0 @@
>> -module: Hello.class
>> -
>> -%.class: %.java
>> -   javac -target 7 -source 7 $^
>> -
>> -clean:
>> -   rm -rf *.class
>> diff --git a/java-compact2-example/module.py 
>> b/java-compact2-example/module.py
>> deleted file mode 100644
>> index f17ac37..000
>> --- a/java-compact2-example/module.py
>> +++ /dev/null
>> @@ -1,5 +0,0 @@
>> -from osv.modules import api
>> -
>> -api.require('openjdk8-zulu-compact2')
>> -
>> -default = api.run('/java.so -cp /java-example Hello')
>> diff --git a/java-compact2-example/usr.manifest 
>> b/java-compact2-example/usr.manifest
>> deleted file mode 100644
>> index f62abc7..000
>> --- a/java-compact2-example/usr.manifest
>> +++ /dev/null
>> @@ -1 +0,0 @@
>> -/java-example/Hello.class: ${MODULE_DIR}/Hello.class
>> diff --git a/java-compact3-example/Hello.java 
>> b/java-compact3-example/Hello.java
>> deleted file mode 100644
>> index a605554..000
>> --- a/java-compact3-example/Hello.java
>> +++ /dev/null
>> @@ -1,5 +0,0 @@
>> -public class Hello {
>> -public 

Re: [PATCH] Changed java-example to use java.so directly to start example Hello application

2016-09-21 Thread Tomasz Grabiec
On Wed, Sep 21, 2016 at 6:32 AM, Waldemar Kozaczuk 
wrote:

> This change makes the java-example app universal so that it can be used
> with any
> Java runtime module like so:
>
> ./scripts/build image=java,java-example
> ./scripts/build image=openjdk8-fedora,java-example
> ./scripts/build image=openjdk8-zulu-compact1,java-example
> ./scripts/build image=openjdk8-zulu-compact2,java-example
> ./scripts/build image=openjdk8-zulu-compact3,java-example
>
> Signed-off-by: Waldemar Kozaczuk 
> ---
>  java-compact1-example/Hello.java   | 5 -
>  java-compact1-example/Makefile | 7 ---
>  java-compact1-example/module.py| 5 -
>  java-compact1-example/usr.manifest | 1 -
>  java-compact2-example/Hello.java   | 5 -
>  java-compact2-example/Makefile | 7 ---
>  java-compact2-example/module.py| 5 -
>  java-compact2-example/usr.manifest | 1 -
>  java-compact3-example/Hello.java   | 5 -
>  java-compact3-example/Makefile | 7 ---
>  java-compact3-example/module.py| 5 -
>  java-compact3-example/usr.manifest | 1 -
>  java-example/module.py | 2 +-
>  13 files changed, 1 insertion(+), 55 deletions(-)
>  delete mode 100644 java-compact1-example/Hello.java
>  delete mode 100644 java-compact1-example/Makefile
>  delete mode 100644 java-compact1-example/module.py
>  delete mode 100644 java-compact1-example/usr.manifest
>  delete mode 100644 java-compact2-example/Hello.java
>  delete mode 100644 java-compact2-example/Makefile
>  delete mode 100644 java-compact2-example/module.py
>  delete mode 100644 java-compact2-example/usr.manifest
>  delete mode 100644 java-compact3-example/Hello.java
>  delete mode 100644 java-compact3-example/Makefile
>  delete mode 100644 java-compact3-example/module.py
>  delete mode 100644 java-compact3-example/usr.manifest
>
> diff --git a/java-compact1-example/Hello.java
> b/java-compact1-example/Hello.java
> deleted file mode 100644
> index a605554..000
> --- a/java-compact1-example/Hello.java
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -public class Hello {
> -public static void main(String[] args) {
> -System.out.println("Hello, World!");
> -}
> -}
> diff --git a/java-compact1-example/Makefile b/java-compact1-example/
> Makefile
> deleted file mode 100644
> index 8a385c9..000
> --- a/java-compact1-example/Makefile
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -module: Hello.class
> -
> -%.class: %.java
> -   javac -target 7 -source 7 $^
> -
> -clean:
> -   rm -rf *.class
> diff --git a/java-compact1-example/module.py b/java-compact1-example/
> module.py
> deleted file mode 100644
> index 216cf35..000
> --- a/java-compact1-example/module.py
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -from osv.modules import api
> -
> -api.require('openjdk8-zulu-compact1')
> -
> -default = api.run('/java.so -cp /java-example Hello')
> diff --git a/java-compact1-example/usr.manifest
> b/java-compact1-example/usr.manifest
> deleted file mode 100644
> index f62abc7..000
> --- a/java-compact1-example/usr.manifest
> +++ /dev/null
> @@ -1 +0,0 @@
> -/java-example/Hello.class: ${MODULE_DIR}/Hello.class
> diff --git a/java-compact2-example/Hello.java
> b/java-compact2-example/Hello.java
> deleted file mode 100644
> index a605554..000
> --- a/java-compact2-example/Hello.java
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -public class Hello {
> -public static void main(String[] args) {
> -System.out.println("Hello, World!");
> -}
> -}
> diff --git a/java-compact2-example/Makefile b/java-compact2-example/
> Makefile
> deleted file mode 100644
> index 8a385c9..000
> --- a/java-compact2-example/Makefile
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -module: Hello.class
> -
> -%.class: %.java
> -   javac -target 7 -source 7 $^
> -
> -clean:
> -   rm -rf *.class
> diff --git a/java-compact2-example/module.py b/java-compact2-example/
> module.py
> deleted file mode 100644
> index f17ac37..000
> --- a/java-compact2-example/module.py
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -from osv.modules import api
> -
> -api.require('openjdk8-zulu-compact2')
> -
> -default = api.run('/java.so -cp /java-example Hello')
> diff --git a/java-compact2-example/usr.manifest
> b/java-compact2-example/usr.manifest
> deleted file mode 100644
> index f62abc7..000
> --- a/java-compact2-example/usr.manifest
> +++ /dev/null
> @@ -1 +0,0 @@
> -/java-example/Hello.class: ${MODULE_DIR}/Hello.class
> diff --git a/java-compact3-example/Hello.java
> b/java-compact3-example/Hello.java
> deleted file mode 100644
> index a605554..000
> --- a/java-compact3-example/Hello.java
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -public class Hello {
> -public static void main(String[] args) {
> -System.out.println("Hello, World!");
> -}
> -}
> diff --git a/java-compact3-example/Makefile b/java-compact3-example/
> Makefile
> deleted file mode 100644
> index 8a385c9..000
> --- a/java-compact3-example/Makefile
> +++ /dev/null
>