Re: [osv-dev] [PATCH 1/2] Lookup symbol deeper

2020-01-15 Thread Nadav Har'El
On Thu, Jan 16, 2020 at 2:00 AM zhiting zhu wrote: > Sorry, I might miss your reply. Thanks for the tip on format-patch. I will > do it in the future. This patch is written by Waldemar for a fix on the > test errors. I'm not familiar with the elf spec. I don't know whether > DT_NEEDED would have

Re: [osv-dev] [PATCH 1/2] Lookup symbol deeper

2020-01-15 Thread zhiting zhu
Sorry, I might miss your reply. Thanks for the tip on format-patch. I will do it in the future. This patch is written by Waldemar for a fix on the test errors. I'm not familiar with the elf spec. I don't know whether DT_NEEDED would have a cycle. I feel the order of the objects matter, especially

Re: [osv-dev] [PATCH 1/2] Lookup symbol deeper

2020-01-15 Thread Nadav Har'El
When you send a second version of a patch, please label it with "v2" and so on (if you use git format-patch, you can do "git format-patch -v2" to do this automatically) and write below the fold (the "--" line) some comments about what changed. Because it's hard for me to keep track what are new

[osv-dev] [PATCH 1/2] Lookup symbol deeper

2020-01-15 Thread Zhiting Zhu
dlsym function doesn't seem to lookup symbol deep enough. This patch fixes test_dlsym_from_sofile_with_preload and dlsym_with_dependencies Signed-off-by: Waldemar Kozaczuk Signed-off-by: Zhiting Zhu --- core/elf.cc| 14 ++ include/osv/elf.hh | 1 + libc/dlfcn.cc | 2