Re: [PATCH] Fixed bug in futex implementation

2018-03-07 Thread Benoît CANET
Hi Nadav, It's probably a random patch I wrote in a second state. I don't remember writing it :( Best regards Benoît 2018-03-07 18:17 GMT+01:00 Nadav Har'El : > Ok, I opened https://github.com/cloudius-systems/osv/issues/951 > where I explain what I think is the real bug that you fixed in thi

Re: [PATCH] Fixed bug in futex implementation

2018-03-07 Thread Nadav Har'El
Ok, I opened https://github.com/cloudius-systems/osv/issues/951 where I explain what I think is the real bug that you fixed in this patch :-) Waldek, Benoit - since my explanation is very different from yours, is it possible my description of the bug is correct? Finally, Waldek or Benoit, can you

Re: [PATCH] Fixed bug in futex implementation

2018-03-07 Thread Nadav Har'El
Ok, so I gave the futex code a second look. First of all - I remembered why this is related to Go - as I explained in https://github.com/cloudius-systems/osv/issues/853, the futex code was very lightly used, but could be much more heavily used in Go - in one network benchmark that Benoit was runni

Re: [PATCH] Fixed bug in futex implementation

2018-03-07 Thread Nadav Har'El
On Tue, Mar 6, 2018 at 3:46 PM, Waldemar Kozaczuk wrote: > This patch adds logic to make sure that waitqueue object actually > exists in queues map before it tries to dereference it. > > The content of this patch was authored by Benoit Canet. > Hi, I already reviewed this patch with Benoit, but