Re: [ovs-dev] Invitation: OVS-DPDK bi-weekly meeting @ Every 2 weeks from 5pm to 6pm on Thursday from Thu Dec 15 to Thu Jun 29, 2017 (GMT) (d...@openvswitch.org)

2017-01-03 Thread John Fastabend
On 16-12-16 10:04 AM, Kevin Traynor wrote: > Thanks for the meeting notes Robin, I've edited a bit. > Hi, Delayed significantly but I can provide additional details related to _my_ opinions around connection tracking and would be interested in feedback. (warning it might be a bit off-topic for

Re: [ovs-dev] [PATCH RFC] dpcls: Avoid one 8-byte chunk in subtable mask.

2017-01-03 Thread Jarno Rajahalme
> On Dec 22, 2016, at 4:02 AM, Fischetti, Antonio > wrote: > > Thanks Jarno for your feedback, please find below my replies inline. > >> -Original Message- >> From: Jarno Rajahalme [mailto:ja...@ovn.org ] >> Sent: Tuesday, December

Re: [ovs-dev] [PATCH] Conntrack: Fix L4 Checksums in kernel <4.6 when using NAT and helpers

2017-01-03 Thread Jarno Rajahalme
> On Dec 28, 2016, at 3:05 PM, John Hurley wrote: > > sorry, updated patch…. This patch is still whitespace damaged. Maybe use git format-patch and git send-email to send it? > > > > Fix for a bug when sending a NATed packet to

Re: [ovs-dev] [PATCH] tunneling: Combining actions to avoid packet recirculation in tunnel encapsulation.

2017-01-03 Thread Jarno Rajahalme
Sugesh, So the issue is that instead of recirculating on the datapath, we can compute the “recirculation” actions on the tunnel push translation time, as these actions only depend on the tunnel attributes? This explains why the recirculation in this case is unnecessary, and mentioning this in

Re: [ovs-dev] [PATCH v2 2/3] conntrack: Return NEW for IPv6 ND packets without tracking.

2017-01-03 Thread Darrell Ball
On 12/23/16, 5:31 PM, "Daniele Di Proietto" wrote: On 22/12/2016 21:20, "Darrell Ball" wrote: >Some comments inline Thanks for the review, I've sent a v3 > >On 12/22/16, 6:36 PM, "Daniele Di

[ovs-dev] [PATCH] doc: Use ovs theme

2017-01-03 Thread Stephen Finucane
The recently published 'ovs' theme [1] copies the styling of the Open vSwitch website. Start using this, with fallbacks for users who do not have the package installed. This extends support for building docs to users of Sphinx 1.2 as the previous theme - bizstyle - was only available in 1.3+.

[ovs-dev] [PATCH] doc: Add missing ':'

2017-01-03 Thread Stephen Finucane
Signed-off-by: Stephen Finucane --- Documentation/tutorials/ovs-advanced.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/tutorials/ovs-advanced.rst b/Documentation/tutorials/ovs-advanced.rst index d14b2f9..de1e7d0 100644 ---

Re: [ovs-dev] [PATCH V4 1/5] Python tests: Add winutils.py module

2017-01-03 Thread Guru Shetty
On 3 January 2017 at 12:10, Alin Balutoiu wrote: > From: Alin Balutoiu > > This patch adds a new python module which contains > helper functions. These will be neccessary for the > Windows implementation. > > They cover the

[ovs-dev] [PATCH net-next v2 17/27] OVS: remove use of VLAN_TAG_PRESENT

2017-01-03 Thread Michał Mirosław
This is a minimal change to allow removing of VLAN_TAG_PRESENT. It leaves OVS unable to use CFI bit, as fixing this would need a deeper surgery involving userspace interface. Signed-off-by: Michał Mirosław --- v2: removed userspace-facing changes

Re: [ovs-dev] [PATCH 1/2] doc: Remove ivshmem instructions.

2017-01-03 Thread Mauricio Vasquez
On 01/03/2017 01:21 PM, Kevin Traynor wrote: ivshmem is a path to the guest using DPDK rings that was introduced before userspace vhost was available in the OVS-DPDK datapath. ivshmem is external to OVS but the scheme of using it with DPDK rings is documented. Remove ivshmem instruction

[ovs-dev] [PATCH V4 5/5] Python tests: Enable python tests on Windows

2017-01-03 Thread Alin Balutoiu
From: Alin Balutoiu Updated the Readme with additional library required for the python tests. Remove the code which disable python tests to be run on Windows. Signed-off-by: Alin-Gheorghe Balutoiu --- V2: Changed code-block

[ovs-dev] [PATCH V4 3/5] Python tests: Daemon ported to Windows

2017-01-03 Thread Alin Balutoiu
From: Alin Balutoiu Instead of using os.fork (not supported on Windows), subprocess.Popen is used and os.pipe was replaced with Windows pipes. To be able to identify the child process, an extra parameter was added to daemon process '--pipe-handle'. This

Re: [ovs-dev] [PATCH V3 5/5] Python tests: Enable python tests on Windows

2017-01-03 Thread Alin Balutoiu
Yes, "pip" is included in the MSI installer from http://python.org > From: Guru Shetty [mailto:g...@ovn.org] > Sent: Tuesday, January 3, 2017 9:33 PM > To: Alin Balutoiu > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH V3 5/5] Python tests: Enable

Re: [ovs-dev] [PATCH V3 5/5] Python tests: Enable python tests on Windows

2017-01-03 Thread Guru Shetty
On 3 January 2017 at 08:46, Alin Balutoiu wrote: > From: Alin Balutoiu > > Updated the Readme with additional library required for > the python tests. > > Remove the code which disable python tests to > be run on Windows. > >

Re: [ovs-dev] [PATCH V3 2/5] Python tests: Ported UNIX sockets to Windows

2017-01-03 Thread Alin Balutoiu
Ok, I'll include that in the next version. Mind if I respin the series after you take a look over the rest of the patches? > From: Guru Shetty [mailto:g...@ovn.org] > Sent: Tuesday, January 3, 2017 9:09 PM > To: Alin Balutoiu > Cc: d...@openvswitch.org >

Re: [ovs-dev] [PATCH V3 2/5] Python tests: Ported UNIX sockets to Windows

2017-01-03 Thread Guru Shetty
On 3 January 2017 at 11:03, Alin Balutoiu wrote: > Thanks for the comment. > The socket attribute of the class Stream cannot be None if the code runs > on Unix. > Therefore the condition "self.socket is not None" is True only if sockets > are not used, > and

Re: [ovs-dev] [PATCH V3 2/5] Python tests: Ported UNIX sockets to Windows

2017-01-03 Thread Alin Balutoiu
Thanks for the comment. The socket attribute of the class Stream cannot be None if the code runs on Unix. Therefore the condition "self.socket is not None" is True only if sockets are not used, and named pipes are used instead (i.e. it runs on Windows). However, if you prefer I can replace it

[ovs-dev] Pricelist Week 1 2017

2017-01-03 Thread Bonesca -Marianne
Deze email nieuwsbrief werd in grafisch HTML formaat verzonden. Als u deze tekstversie ziet, verkiest uw email programma "gewone tekst" emails. U kan de originele nieuwsbrief online bekijken: http://ymlp96.com/zxjyjB

[ovs-dev] [PATCH 1/2] doc: Remove ivshmem instructions.

2017-01-03 Thread Kevin Traynor
ivshmem is a path to the guest using DPDK rings that was introduced before userspace vhost was available in the OVS-DPDK datapath. ivshmem is external to OVS but the scheme of using it with DPDK rings is documented. Remove ivshmem instruction documentation because: - The ivshmem library has been

Re: [ovs-dev] [PATCH V3 2/5] Python tests: Ported UNIX sockets to Windows

2017-01-03 Thread Guru Shetty
On 3 January 2017 at 08:46, Alin Balutoiu wrote: > From: Alin Balutoiu > > Unix sockets (AF_UNIX) are not supported on Windows. > The replacement of Unix sockets on Windows is implemented > using named pipes, we are trying to

[ovs-dev] [PATCHv2] ovs-ofctl.8: Document automatic helper assignment.

2017-01-03 Thread Joe Stringer
Due to upstream Linux feature "automatic helper assignment", up until recently when using ct() action with FTP traffic, it has not been necessary to specify the ALG parameter. However, automatic helper assignment was disabled in Linux 4.7 or later, in upstream commit 3bb398d925ec ("netfilter:

Re: [ovs-dev] [PATCHv2 2/2] test-l7.py: Tidy up and python3-ify.

2017-01-03 Thread Joe Stringer
On 22 December 2016 at 15:57, Ben Pfaff wrote: > On Thu, Dec 22, 2016 at 10:58:26AM -0800, Joe Stringer wrote: >> Haul test-l7.py into the 202nd decade by supporting python3. >> >> TFTPY still doesn't support python3, so work around this by handling >> import syntax errors so that

Re: [ovs-dev] [PATCHv2 1/2] lib: Add support for tftp ct helper.

2017-01-03 Thread Joe Stringer
On 22 December 2016 at 15:56, Ben Pfaff wrote: > On Thu, Dec 22, 2016 at 10:58:25AM -0800, Joe Stringer wrote: >> The kernel datapath provides support for TFTP helpers, so add support >> for this ALG to the commandline and OpenFlow encoding/decoding. >> >> Signed-off-by: Joe

Re: [ovs-dev] [PATCH] atlocal: Fix findcommand function style.

2017-01-03 Thread Joe Stringer
On 22 December 2016 at 15:39, Ben Pfaff wrote: > On Thu, Dec 22, 2016 at 10:44:53AM -0800, Joe Stringer wrote: >> Signed-off-by: Joe Stringer > > Acked-by: Ben Pfaff Thanks, applied to master. ___ dev mailing

[ovs-dev] [PATCH V3 5/5] Python tests: Enable python tests on Windows

2017-01-03 Thread Alin Balutoiu
From: Alin Balutoiu Updated the Readme with additional library required for the python tests. Remove the code which disable python tests to be run on Windows. Signed-off-by: Alin Balutoiu --- V2: Changed code-block from bash

[ovs-dev] [PATCH V3 4/5] Python tests: Set CREATE_NO_WINDOW flag for Popen

2017-01-03 Thread Alin Balutoiu
From: Alin Balutoiu On Windows if the flag CREATE_NO_WINDOW is not specified when using subprocess.Popen, a new window will appear with the new process. The window is not necessary for the tests. This patch addresses this issue by adding the flag

[ovs-dev] [PATCH V3 3/5] Python tests: Daemon ported to Windows

2017-01-03 Thread Alin Balutoiu
From: Alin Balutoiu Instead of using os.fork (not supported on Windows), subprocess.Popen is used and os.pipe was replaced with Windows pipes. To be able to identify the child process, an extra parameter was added to daemon process '--pipe-handle'. This

[ovs-dev] [PATCH V3 1/5] Python tests: Add winutils.py module

2017-01-03 Thread Alin Balutoiu
From: Alin Balutoiu This patch adds a new python module which contains helper functions. These will be neccessary for the Windows implementation. They cover the following aspects: sockets and namedpipes. Signed-off-by: Alin Balutoiu

[ovs-dev] openvswitch 2.6.2~pre+git20161223-2 MIGRATED to testing

2017-01-03 Thread Debian testing watch
FYI: The status of the openvswitch source package in Debian's testing distribution has changed. Previous version: 2.3.0+git20140819-4 Current version: 2.6.2~pre+git20161223-2 -- This email is automatically generated once a day. As the installation of new packages into testing happens

Re: [ovs-dev] [PATCH V2 5/5] Python tests: Enable python tests on Windows

2017-01-03 Thread Alin Balutoiu
Please ignore this patch, I will send another one soon. Thanks, Alin Balutoiu. > -Original Message- > From: Alin Balutoiu > Sent: Tuesday, January 3, 2017 5:17 PM > To: d...@openvswitch.org > Cc: Alin Balutoiu > Subject: [PATCH V2 5/5] Python tests:

Re: [ovs-dev] [PATCH V2 4/5] Python tests: Set CREATE_NO_WINDOW flag for Popen

2017-01-03 Thread Alin Balutoiu
Please ignore this patch, I will send another one soon. Thanks, Alin Balutoiu. > -Original Message- > From: Alin Balutoiu > Sent: Tuesday, January 3, 2017 5:17 PM > To: d...@openvswitch.org > Cc: Alin Balutoiu > Subject: [PATCH V2 4/5] Python tests: Set

Re: [ovs-dev] [PATCH V2 3/5] Python tests: Daemon ported to Windows

2017-01-03 Thread Alin Balutoiu
Please ignore this patch, I will send another one soon. Thanks, Alin Balutoiu. > -Original Message- > From: Alin Balutoiu > Sent: Tuesday, January 3, 2017 5:17 PM > To: d...@openvswitch.org > Cc: Alin Balutoiu ; Paul Boca >

Re: [ovs-dev] [PATCH V2 1/5] Python tests: Add winutils.py module

2017-01-03 Thread Alin Balutoiu
Please ignore this patch, I will send another one soon. Thanks, Alin Balutoiu. > -Original Message- > From: Alin Balutoiu > Sent: Tuesday, January 3, 2017 5:17 PM > To: d...@openvswitch.org > Cc: Alin Balutoiu > Subject: [PATCH V2 1/5] Python tests: Add

Re: [ovs-dev] [PATCH V2 0/5] Adds python tests support for Windows

2017-01-03 Thread Alin Balutoiu
Please ignore this patch, I will send another one soon. Thanks, Alin Balutoiu. > -Original Message- > From: Alin Balutoiu > Sent: Tuesday, January 3, 2017 5:17 PM > To: d...@openvswitch.org > Cc: Alin Balutoiu > Subject: [PATCH V2 0/5] Adds python tests

Re: [ovs-dev] [PATCH V2 1/5] Python tests: Add winutils.py module

2017-01-03 Thread Guru Shetty
On 3 January 2017 at 07:16, Alin Balutoiu wrote: > From: Alin Balutoiu > > This patch adds a new python module which contains > helper functions. These will be neccessary for the > Windows implementation. > > They cover the

Re: [ovs-dev] [PATCH 2/2 v2] datapath-windows: Conntrack disable type truncation warning

2017-01-03 Thread Guru Shetty
On 28 December 2016 at 16:25, Alin Serdean wrote: > Compiling with the WDK 10 gave the following warning: > Warning C4311 'type cast': pointer truncation from 'POVS_CT_ENTRY' to > 'UINT32' > ovsext (OVSExt\ovsext) Conntrack.c 1139 > > This patch disables

Re: [ovs-dev] [PATCH 1/2 v2] datapath-windows: Add Windows 10 family to solution

2017-01-03 Thread Guru Shetty
On 28 December 2016 at 16:25, Alin Serdean wrote: > This patch adds two more compiling targets: > - one for Windows 10 release > - one for Windows 10 Debug > > The new targets are flagged properly to use the new Windows 10 kernel mode > driver and its

[ovs-dev] [PATCH V2 5/5] Python tests: Enable python tests on Windows

2017-01-03 Thread Alin Balutoiu
From: Alin Balutoiu Updated the Readme with additional library required for the python tests. Remove the code which disable python tests to be run on Windows. Signed-off-by: Alin-Gheorghe Balutoiu --- V2: Changed code-block

[ovs-dev] [PATCH V2 4/5] Python tests: Set CREATE_NO_WINDOW flag for Popen

2017-01-03 Thread Alin Balutoiu
From: Alin Balutoiu On Windows if the flag CREATE_NO_WINDOW is not specified when using subprocess.Popen, a new window will appear with the new process. The window is not necessary for the tests. This patch addresses this issue by adding the flag

[ovs-dev] [PATCH V2 2/5] Python tests: Ported UNIX sockets to Windows

2017-01-03 Thread Alin Balutoiu
From: Alin Balutoiu Unix sockets (AF_UNIX) are not supported on Windows. The replacement of Unix sockets on Windows is implemented using named pipes, we are trying to mimic the behaviour of unix sockets. Instead of using Unix sockets to communicate between

[ovs-dev] [PATCH V2 1/5] Python tests: Add winutils.py module

2017-01-03 Thread Alin Balutoiu
From: Alin Balutoiu This patch adds a new python module which contains helper functions. These will be neccessary for the Windows implementation. They cover the following aspects: sockets and namedpipes. Signed-off-by: Alin-Gheorghe Balutoiu

[ovs-dev] [PATCH V2 0/5] Adds python tests support for Windows

2017-01-03 Thread Alin Balutoiu
This series of patches ports python daemon and unixctl to Windows. All patches depend on each other. The the daemon was ported using the Win32 API available in the python library pypiwin32. Unixctl was ported using named-pipes in order to be compatible with OVS Windows applications. An

Re: [ovs-dev] [PATCH 4/5] Python tests: Set CREATE_NO_WINDOW flag for Popen

2017-01-03 Thread Alin Balutoiu
Actually they are not needed, only the changes from ovs-vtep are needed. Thanks, Alin Balutoiu. > -Original Message- > From: Alin Serdean > Sent: Friday, December 30, 2016 12:29 AM > To: Alin Balutoiu ; > d...@openvswitch.org > Cc: Alin Balutoiu

Re: [ovs-dev] [PATCH 5/5] Python tests: Enable python tests on Windows

2017-01-03 Thread Alin Balutoiu
Replied to the comment inlined. Thanks, Alin Balutoiu. > -Original Message- > From: Alin Serdean > Sent: Friday, December 30, 2016 12:00 AM > To: Alin Balutoiu ; > d...@openvswitch.org > Cc: Alin Balutoiu > Subject: RE:

[ovs-dev] Issues with the use of the clone action for resubmission to the pipeline

2017-01-03 Thread Mickey Spiegel
One of the motivations for clone is to use it as a lightweight way to resubmit to an earlier table at the beginning of the pipeline, without incurring all of the overhead associated with openflow patch ports. One such usage is in OVN, where a recent patch set replaced the use of openflow patch

[ovs-dev] ovn support DPDK?

2017-01-03 Thread 赵占旭
I installed ovn and ovs-dpdk. when I created two VMs on one host, they could communicate, but I created two VMs on diffrent hosts, they couldn't communicate. I think the problem is geneve, ovs and ovs-dpdk has different flows, so my question is the ovn support dpdk? I need to configure sth, or I

[ovs-dev] [PATCH v5 6/6] ovn: distributed NAT flows

2017-01-03 Thread Mickey Spiegel
This patch implements the flows required in the ingress and egress pipeline stages in order to support NAT on a distributed logical router. NAT functionality is associated with the logical router gateway port. The flows that carry out NAT functionality all have match conditions on inport or

[ovs-dev] [PATCH v5 5/6] ovn: avoid snat recirc only on gateway routers

2017-01-03 Thread Mickey Spiegel
Currently, for performance reasons on gateway routers, ct_snat that does not specify an IP address does not immediately trigger recirculation. On gateway routers, ct_snat that does not specify an IP address happens in the UNSNAT pipeline stage, which is followed by the DNAT pipeline stage that

[ovs-dev] [PATCH v5 2/6] ovn: Introduce "chassisredirect" port binding

2017-01-03 Thread Mickey Spiegel
Currently OVN handles all logical router ports in a distributed manner, creating instances on each chassis. The logical router ingress and egress pipelines are traversed locally on the source chassis. In order to support advanced features such as one-to-many NAT (aka IP masquerading), where

[ovs-dev] [PATCH v5 4/6] ovn: move load balancing flows after NAT flows

2017-01-03 Thread Mickey Spiegel
This will make it easy for distributed NAT to reuse some of the existing code for NAT flows, while leaving load balancing and defrag as functionality specific to gateway routers. There is no intent to change any functionality in this patch. Signed-off-by: Mickey Spiegel

[ovs-dev] [PATCH v5 3/6] ovn: add egress loopback capability

2017-01-03 Thread Mickey Spiegel
This patch adds the capability to force loopback at the end of the egress pipeline. A new flags.force_egress_loopback symbol is defined, along with corresponding flags bits. When flags.force_egress_loopback is set, at OFTABLE_LOG_TO_PHY, instead of the packet being sent out to the peer patch

[ovs-dev] [PATCH v5 1/6] ovn: add is_chassis_resident match expression component

2017-01-03 Thread Mickey Spiegel
This patch introduces a new match expression component is_chassis_resident(). Unlike match expression comparisons, is_chassis_resident is not pushed down to OpenFlow. It is a conditional that is evaluated in the controller during expr_simplify(), when it is replaced by a boolean expression. The

[ovs-dev] [PATCH v5 0/6] ovn: add distributed NAT capability

2017-01-03 Thread Mickey Spiegel
Currently OVN supports NAT functionality by connecting each distributed logical router to a centralized "l3gateway" router that resides on a single chassis. NAT is only carried out in the "l3gateway" router. This patch set introduces NAT capability in the distributed logical router itself,

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Adding IGMP/MLD checksum verification

2017-01-03 Thread Eelco Chaudron
On 22/12/16 17:14, Ben Pfaff wrote: On Wed, Dec 14, 2016 at 07:08:27PM +0100, Eelco Chaudron wrote: When IGMP or MLD packets arrive their content is used without the checksum being verified. With this change the checksum is verified, and the packet is not used for multicast snooping on failure.