Re: [ovs-dev] [patch_v4 4/6] Unset CS_NEW for established connections.

2017-01-27 Thread Daniele Di Proietto
2017-01-24 20:40 GMT-08:00 Darrell Ball : > Signed-off-by: Darrell Ball > --- > lib/conntrack.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/conntrack.c b/lib/conntrack.c > index 34728a6..aaecb00 100644 > --- a/lib/conntrack.c > +++

Re: [ovs-dev] [patch_v4 3/6] Userspace Datapath: Introduce NAT support.

2017-01-27 Thread Daniele Di Proietto
2017-01-24 20:40 GMT-08:00 Darrell Ball : > This patch introduces NAT support for the userspace datapath. > The conntrack module changes are in this patch. > > The per packet scope of lookups for NAT and un_NAT is at > the bucket level rather than global. One hash table is >

Re: [ovs-dev] [patch_v4 2/6] Parse NAT netlink for userspace datapath.

2017-01-27 Thread Daniele Di Proietto
2017-01-24 10:50 GMT-08:00 Darrell Ball : > Signed-off-by: Darrell Ball > --- > lib/conntrack-private.h | 9 -- > lib/conntrack.c | 3 +- > lib/conntrack.h | 31 +- > lib/dpif-netdev.c | 85 >

Re: [ovs-dev] [patch_v4 0/6] Userspace Datapath: Introduce NAT support.

2017-01-27 Thread Daniele Di Proietto
2017-01-24 20:40 GMT-08:00 Darrell Ball : > This patch series introduces NAT support for the userspace datapath. > > The per packet scope of lookups for NAT and un_NAT is at > the bucket level rather than global. One hash table is > introduced to support create/delete handling.

Re: [ovs-dev] [PATCH v2] dpif-netdev: Conditional EMC insert

2017-01-27 Thread Daniele Di Proietto
2017-01-26 9:51 GMT-08:00 Ciara Loftus : > Unconditional insertion of EMC entries results in EMC thrashing at high > numbers of parallel flows. When this occurs, the performance of the EMC > often falls below that of the dpcls classifier, rendering the EMC > practically

[ovs-dev] [PATCH] dpif-netdev: Pass Openvswitch other_config smap to dpif.

2017-01-27 Thread Daniele Di Proietto
Currently we parse the 'other_config' column in Openvswitch table in bridge.c. We extract the values (just 'pmd-cpu-mask' for now) and we pass them down to the datapath, via different layers. If we want to pass other values to dpif-netdev.c (like we recently discussed) we would have to touch

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2017-01-27 Thread Jarno Rajahalme
> On Jan 27, 2017, at 1:01 PM, Thomas Morin wrote: > > Jarno, > > 2017-01-27, Jarno Rajahalme: >> Cleanest solution would be to use the new clone action for the datapath, >> which, if important, we could also backport to OVS 2.5.x. > > Yes, clone is indeed much more

Re: [ovs-dev] [PATCH 1/3] ovn-trace: Possible null dereference

2017-01-27 Thread Guru Shetty
On 26 January 2017 at 23:14, Alin Serdean wrote: > Found by inspection. > > Signed-off-by: Alin Gabriel Serdean > --- > ovn/utilities/ovn-trace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [ovs-dev] [PATCH v3 1/5] datapath-windows: Added a new file to support Ipv4 fragments.

2017-01-27 Thread Guru Shetty
On 27 January 2017 at 14:13, Anand Kumar wrote: > This patch adds functionalities to support IPv4 fragments, which will be > used by Conntrack module. > > Added a new structure to hold the Ipv4 fragments and a hash table to > hold Ipv4 datagram entries. Also added a clean

Re: [ovs-dev] [PATCH] python windows: Allow clients to read from server before disconnect

2017-01-27 Thread Guru Shetty
On 26 January 2017 at 11:44, Alin Serdean wrote: > Wait for clients to read from the pipe before disconnecting the server. > > Signed-off-by: Alin Gabriel Serdean > --- > Intended for master and branch-2.7 > Applied. > --- >

Re: [ovs-dev] [PATCH v2 1/5] datapath-windows: Added a new file to support Ipv4 fragments.

2017-01-27 Thread Anand Kumar
Hi Shashank, Thank you for reviewing the patch. I have sent out a new version of the patch series addressing your comments. Based on your suggestion, I’m using an event to signal the clean up thread to free up the memory. Regards, Anand Kumar From: Shashank Ram Date:

Re: [ovs-dev] [PATCH] windows: Allow clients to read from server before disconnect

2017-01-27 Thread Guru Shetty
On 26 January 2017 at 11:12, Alin Serdean wrote: > Wait for clients to read from the pipe before disconnecting the server. > > Found while testing. > > Signed-off-by: Alin Gabriel Serdean > --- > Intended for master and

Re: [ovs-dev] [PATCH] tests windows: change service test

2017-01-27 Thread Guru Shetty
On 26 January 2017 at 10:32, Alin Serdean wrote: > Skip the test if the service 'ovsdb-server' is already defined. > > The arguments of the service are incomplete: in the former state > it will try to create the pidfile and unixctl in the configuration path. >

[ovs-dev] [PATCH v3 1/5] datapath-windows: Added a new file to support Ipv4 fragments.

2017-01-27 Thread Anand Kumar
This patch adds functionalities to support IPv4 fragments, which will be used by Conntrack module. Added a new structure to hold the Ipv4 fragments and a hash table to hold Ipv4 datagram entries. Also added a clean up thread that runs every minute to delete the expired IPv4 datagram entries. The

[ovs-dev] [PATCH v3 5/5] datapath-windows: Fragment NBL based on MRU size

2017-01-27 Thread Anand Kumar
This patch adds support for Fragmenting NBL based on the MRU value. MRU value is updated only for Ipv4 fragments, if it is non zero, then fragment the NBL and send out the new NBL to the vnic. v2->v3: - Updated log message v1->v2: No change Signed-off-by: Anand Kumar

[ovs-dev] [PATCH v3 2/5] datapath-windows: Added Ipv4 fragments support in Conntrack

2017-01-27 Thread Anand Kumar
This patch adds support for tracking Ipv4 fragments in conntrack module. Individual fragments are not tracked and are consumed by the fragmentation/reassembly. Only the reassembled Ipv4 datagram is tracked and treated as a single ct entry. Added MRU field in OvsForwardingContext, to keep track of

Re: [ovs-dev] [userspace meter v3 3/5] dpif: Meter framework.

2017-01-27 Thread Andy Zhou
On Thu, Jan 26, 2017 at 6:34 PM, Jarno Rajahalme wrote: > It feels weird reviewing my own code from past. What if I make a pass of > fixing the problems I see and send a new version of the remaining patches > for review? > > Sounds like a plan. I have pushed the first 2 patches in

Re: [ovs-dev] [PATCH v3 4/4] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

2017-01-27 Thread Guru Shetty
On 26 January 2017 at 15:43, Alin Serdean wrote: > From: Alin Serdean > > This patch adds support for set action with OVS_KEY_ATTR_TCP attribute > (change TCP source or destination port). > > If the source or destination TCP port

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2017-01-27 Thread Jarno Rajahalme
> On Jan 27, 2017, at 7:40 AM, Thomas Morin wrote: > > Hi Jarno, all, > > Sorry for being slow to react. > I'd be glad to test a fix, but I'm unclear if there is one ready to be tested. > > Perhasp "xlate: Recirculate also when MPLS POP is implicit." but I'm not sure

Re: [ovs-dev] [PATCH] windows: wmi add include

2017-01-27 Thread Guru Shetty
On 26 January 2017 at 14:15, Alin Serdean wrote: > Add 'util.h' to includes otherwise the definition of the function > ovs_format_message will be unknown and an abort with the following > stacktrace will be triggered: > *1 ovs-vswitchd.exe!_output_l(_iobuf *

Re: [ovs-dev] [PATCH] windows: wmi add include

2017-01-27 Thread Sairam Venugopal
Alin, Can you open a bug in ovs-issues and move the stack trace to that instead? You can tag the commit message with the ovs-issue id. Thanks, Sairam On 1/27/17, 12:41 PM, "ovs-dev-boun...@openvswitch.org on behalf of Guru Shetty"

Re: [ovs-dev] [PATCH v12 6/6] ovn: specify options:nat-addresses as "router"

2017-01-27 Thread Mickey Spiegel
On Fri, Jan 27, 2017 at 11:16 AM, Guru Shetty wrote: > >> >> I should clarify that statement. It is a good thing if the chassis >> changes, for example if doing simple high availability. The GARP >> packet will fix L2 learning. >> >> As I think about it, if anyone uses logical

Re: [ovs-dev] [PATCH v12 6/6] ovn: specify options:nat-addresses as "router"

2017-01-27 Thread Guru Shetty
> > > > I should clarify that statement. It is a good thing if the chassis > changes, for example if doing simple high availability. The GARP > packet will fix L2 learning. > > As I think about it, if anyone uses logical routers without NAT > or load balancers, and the chassis changes, then GARP

Re: [ovs-dev] [PATCH v12 6/6] ovn: specify options:nat-addresses as "router"

2017-01-27 Thread Mickey Spiegel
On Fri, Jan 27, 2017 at 10:29 AM, Mickey Spiegel wrote: > Thanks for the review. > > On Fri, Jan 27, 2017 at 10:20 AM, Guru Shetty wrote: > >> >> >> On 26 January 2017 at 01:20, Mickey Spiegel >> wrote: >> >>> Currently in OVN, the

Re: [ovs-dev] [PATCH v12 6/6] ovn: specify options:nat-addresses as "router"

2017-01-27 Thread Guru Shetty
On 26 January 2017 at 01:20, Mickey Spiegel wrote: > Currently in OVN, the "nat-addresses" in the "options" column of a > logical switch port of type "router" must be specified manually. > Typically the user would specify as "nat-addresses" all of the NAT > external IP

Re: [ovs-dev] assertion failing in commit_set_ipv4_action(), flow->nw_proto != base_flow->nw_proto

2017-01-27 Thread Thomas Morin
Hi Jarno, all, Sorry for being slow to react. I'd be glad to test a fix, but I'm unclear if there is one ready to be tested. Perhasp "xlate: Recirculate also when MPLS POP is implicit." but I'm not sure there has been a follow-up to the discuss between you and Ben? Or is the new clone action

[ovs-dev] Supply Chain Management

2017-01-27 Thread Amelia Harper
Hi, Would you be interested in an email lead list of Supply Chain Executives? We can help you reach out to key Top decision makers like: Title includes: * VP of Supply Chain * Director of Supply Chain * Supply Chain Manager * Purchasing Manager * Purchasing Director *

[ovs-dev] WITH RESPECT FROM MISS ELENA

2017-01-27 Thread Elena Nana via dev
WITH RESPECT FROM MISS ELENA I am Elena Nana. My parents Mr.and Mrs.Jerry Nana were assassinated here in IVORY COAST. Before my father's death he had US$12.5M (TWELVE MILLION FIVE HUNDRED THOUSAND UNITED STATES DOLLARS) deposited in a bank here in Abidjan. I want you to do me a favour to

Re: [ovs-dev] [PATCH v2] Windows: Fix wmi.c to use count of wchar_t instead of sizeof

2017-01-27 Thread Alin Serdean
Thanks for addressing the comment! Acked-by: Alin Gabriel Serdean Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Sairam Venugopal > Sent: Friday, January 27, 2017 9:56 AM > To:

Re: [ovs-dev] [PATCH v3 1/4] datapath-windows: OvsUpdateIPv4Header remove unnecessary addition

2017-01-27 Thread Sairam Venugopal
Re-Acking - Acked-by: Sairam Venugopal On 1/26/17, 3:38 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >From: Alin Serdean >

Re: [ovs-dev] [PATCH v3 2/4] datapath-windows: Add function to get continuous buffer from context

2017-01-27 Thread Sairam Venugopal
Re-acking - Acked-by: Sairam Venugopal On 1/26/17, 3:45 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >From: Alin Serdean > >This

Re: [ovs-dev] [PATCH v3 4/4] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

2017-01-27 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 1/26/17, 3:43 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >From: Alin Serdean > >This patch adds