[ovs-dev] [PATCH] odp: Add datapath clone action parser.

2017-01-31 Thread Andy Zhou
When adding userspace datapath clone action, the corresponding odp actions parser and unit tests were missing. This patch adds them. Reported-by: Ben Pfaff Signed-off-by: Andy Zhou --- Note: back port to branch-2.7 --- lib/odp-util.c | 56

Re: [ovs-dev] [PATCH V2] netdev-dpdk: fix ifindex assignment for DPDK ports

2017-01-31 Thread Daniele Di Proietto
On 31/01/2017 13:52, "Ben Pfaff" wrote: >On Thu, Dec 08, 2016 at 01:16:22PM +0100, Przemyslaw Lal wrote: >> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c >> index de78ddd..ef99eb3 100644 >> --- a/lib/netdev-dpdk.c >> +++ b/lib/netdev-dpdk.c >> @@ -2075,7 +2075,13 @@

Re: [ovs-dev] branching commits

2017-01-31 Thread Justin Pettit
> On Jan 31, 2017, at 3:03 PM, Ben Pfaff wrote: > > Hi Justin. We branched a couple of weeks ago but at the time we forgot > to update NEWS, etc. either on master or the branch. Usually you submit > those patches; do you want to do the honors this time too? Okay, I sent out

[ovs-dev] [branch-2.7] Prepare for 2.7.0.

2017-01-31 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 2 +- configure.ac | 2 +- debian/changelog | 79 +--- 3 files changed, 77 insertions(+), 6 deletions(-) diff --git a/NEWS b/NEWS index 0a9551c..1a3787d 100644 ---

Re: [ovs-dev] [PATCH] Windows: Implement Hyper-V VIF discovery agent.

2017-01-31 Thread Alin Serdean
Hi Yin, Please see my answers inlined. Thanks, Alin. From: Yin Lin [mailto:li...@vmware.com] Sent: Wednesday, February 1, 2017 12:31 AM To: Alin Serdean ; d...@openvswitch.org Subject: RE: [ovs-dev] [PATCH] Windows: Implement Hyper-V VIF discovery agent. Hi

Re: [ovs-dev] [PATCH] ovn: Support ARP proxy in logical switches.

2017-01-31 Thread Han Zhou
On Tue, Jan 31, 2017 at 2:49 PM, Ben Pfaff wrote: > > On Thu, Jan 05, 2017 at 12:33:51AM -0800, Han Zhou wrote: > > On Wed, Jan 4, 2017 at 3:29 PM, Ben Pfaff wrote: > > > However, I'm concerned about the general utility here. I usually think > > > of proxy ARP as

Re: [ovs-dev] [PATCH v2] windows: wmi add include

2017-01-31 Thread Alin Serdean
> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, January 31, 2017 11:35 PM > To: Alin Serdean > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2] windows: wmi add include > > On Mon, Jan 30, 2017 at 07:42:31AM

Re: [ovs-dev] [PATCH v2] ofp-actions: Fix variable length meta-flow field usage in flow actions.

2017-01-31 Thread Joe Stringer
On 20 January 2017 at 15:12, Yi-Hung Wei wrote: > Previously, if a flow action that involves a tunnel metadata meta-flow > field is dumped from vswitchd, the replied field length in the OXM header > is filled with the maximum possible field length, instead of the length >

Re: [ovs-dev] [PATCH v3 1/2] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

2017-01-31 Thread Ben Pfaff
On Thu, Jan 26, 2017 at 03:22:24PM +, Zoltán Balogh wrote: > From: Sugesh Chandran > > Openvswitch datapath recirculates packets for tunneling, i.e. > the incoming packets are encapsulated at first pass. Further actions are > applied on encapsulated packets on the

Re: [ovs-dev] [PATCH] ovn: fix slave node can not connect to the master node using SSL, for pacemaker

2017-01-31 Thread Andy Zhou
On Tue, Jan 31, 2017 at 3:51 PM, Ben Pfaff wrote: > On Tue, Jan 31, 2017 at 03:44:38PM -0800, Andy Zhou wrote: >> On Wed, Jan 11, 2017 at 4:11 AM, Guoshuai Li wrote: >> > The default slave node connect to the master node using TCP, and the >> > pacemaker >> > can

Re: [ovs-dev] [PATCH] ovn: fix slave node can not connect to the master node using SSL, for pacemaker

2017-01-31 Thread Ben Pfaff
On Tue, Jan 31, 2017 at 03:44:38PM -0800, Andy Zhou wrote: > On Wed, Jan 11, 2017 at 4:11 AM, Guoshuai Li wrote: > > The default slave node connect to the master node using TCP, and the > > pacemaker > > can not modify the protocol and port of the connection. > > Add pacemaker

Re: [ovs-dev] [PATCH] ovn: fix slave node can not connect to the master node using SSL, for pacemaker

2017-01-31 Thread Andy Zhou
On Wed, Jan 11, 2017 at 4:11 AM, Guoshuai Li wrote: > The default slave node connect to the master node using TCP, and the pacemaker > can not modify the protocol and port of the connection. > Add pacemaker parameters to support the connection of the slave node to the > master

Re: [ovs-dev] [PATCH] ovsdb: fix data loss when OVSDB replication from itself

2017-01-31 Thread Andy Zhou
On Mon, Jan 2, 2017 at 7:09 PM, Guoshuai Li wrote: > Delete the local database after receiving the master data, > this is safer for data. > This patch is used by HA cluster that have no way to > control the order of resources, such as kubernetes. > > Signed-off-by: Guoshuai Li

Re: [ovs-dev] [PATCH] ofproto-dpif: Reduce the time of creating large mount of bridges

2017-01-31 Thread Ben Pfaff
On Tue, Jan 17, 2017 at 12:45:00PM +, zhangsha (A) wrote: > From e7623970cd71f8af7c3849a5beff87fd31fbdf68 Mon Sep 17 00:00:00 2001 > From: Sha Zhang > Date: Tue, 17 Jan 2017 11:34:24 +0800 > Subject: [PATCH] ofproto-dpif: Reduce the time of creating large mount of >

[ovs-dev] branching commits

2017-01-31 Thread Ben Pfaff
Hi Justin. We branched a couple of weeks ago but at the time we forgot to update NEWS, etc. either on master or the branch. Usually you submit those patches; do you want to do the honors this time too? Thanks, Ben. ___ dev mailing list

Re: [ovs-dev] [RFC PATCH 2/5] OVN: SFC Implementation: New stage for SFC and modified ACL stage

2017-01-31 Thread John McDowall
Ah, my bad do you want me to create a single patch file? Regards John On 1/31/17, 2:44 PM, "Ben Pfaff" wrote: Now that I glance at the patch titles, I guess that the problem might be that this patch depends on some of the later patches. In general, each patch should

Re: [ovs-dev] [PATCH v2] ovn-controller: Provide the option to set Encap.options:csum

2017-01-31 Thread Ben Pfaff
On Sun, Jan 15, 2017 at 12:36:09PM +0530, Numan Siddique wrote: > ovn-controller by default enables tunnel encapsulation checksums > for geneve tunnels. With this patch user can set the desired value > in Open_vSwitch.external_ids:ovn_encap_csum. > > This option will be useful in cases where

Re: [ovs-dev] [PATCH] ovn: Support ARP proxy in logical switches.

2017-01-31 Thread Ben Pfaff
On Thu, Jan 05, 2017 at 12:33:51AM -0800, Han Zhou wrote: > On Wed, Jan 4, 2017 at 3:29 PM, Ben Pfaff wrote: > > However, I'm concerned about the general utility here. I usually think > > of proxy ARP as being used for the kinds of applications you see in the > > wikipedia on proxy

Re: [ovs-dev] [RFC PATCH 2/5] OVN: SFC Implementation: New stage for SFC and modified ACL stage

2017-01-31 Thread Ben Pfaff
Now that I glance at the patch titles, I guess that the problem might be that this patch depends on some of the later patches. In general, each patch should apply, build, and test properly whether or not later patches have been applied. On Tue, Jan 31, 2017 at 10:03:21PM +, John McDowall

Re: [ovs-dev] [PATCH v12 6/6] ovn: specify options:nat-addresses as "router"

2017-01-31 Thread Ben Pfaff
On Fri, Jan 27, 2017 at 11:49:25AM -0800, Mickey Spiegel wrote: > On Fri, Jan 27, 2017 at 11:16 AM, Guru Shetty wrote: > > > > >> > >> I should clarify that statement. It is a good thing if the chassis > >> changes, for example if doing simple high availability. The GARP > >>

Re: [ovs-dev] [PATCH] appveyor: Bump OpenSSL version

2017-01-31 Thread Ben Pfaff
On Tue, Jan 31, 2017 at 10:00:51PM +, Alin Serdean wrote: > The URL https://slproweb.com/download/Win32OpenSSL-1_0_2j.exe is > no longer valid. > > Bump to the variables to the latest version of OpenSSL version. > > Signed-off-by: Alin Gabriel Serdean

Re: [ovs-dev] [RFC PATCH 2/5] OVN: SFC Implementation: New stage for SFC and modified ACL stage

2017-01-31 Thread John McDowall
Ben, Let me create a new patch set against the top of tree. Regards John On 1/31/17, 1:46 PM, "Ben Pfaff" wrote: On Tue, Dec 27, 2016 at 02:11:43PM -0800, John McDowall wrote: > This is the major body of code that implements SFC. There is a new L2 stage added to >

[ovs-dev] [PATCH] appveyor: Bump OpenSSL version

2017-01-31 Thread Alin Serdean
The URL https://slproweb.com/download/Win32OpenSSL-1_0_2j.exe is no longer valid. Bump to the variables to the latest version of OpenSSL version. Signed-off-by: Alin Gabriel Serdean --- appveyor.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [ovs-dev] [PATCH V2] netdev-dpdk: fix ifindex assignment for DPDK ports

2017-01-31 Thread Ben Pfaff
On Thu, Dec 08, 2016 at 01:16:22PM +0100, Przemyslaw Lal wrote: > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index de78ddd..ef99eb3 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > @@ -2075,7 +2075,13 @@ netdev_dpdk_get_ifindex(const struct netdev *netdev) > int ifindex;

Re: [ovs-dev] [RFC PATCH] Pipeline packet processing in OVS using FVL flow director.

2017-01-31 Thread Ben Pfaff
We thawed master a couple of weeks ago, so it's a good time to rebase and repost. On Mon, Jan 16, 2017 at 09:08:53AM +, Chandran, Sugesh wrote: > Hi Ben, > Many thanks for the reply.. > Will send out another version after the end of freeze > > Regards > _Sugesh > > > > -Original

[ovs-dev] Zong Kai Li's patches

2017-01-31 Thread Ben Pfaff
Hi Justin, I believe that you were planning to review Zong Kai Li's OVN patches that have been languishing since October: https://patchwork.ozlabs.org/project/openvswitch/list/?submitter=69084 Are you still planning to review them? ___ dev

Re: [ovs-dev] [RFC PATCH 2/5] OVN: SFC Implementation: New stage for SFC and modified ACL stage

2017-01-31 Thread Ben Pfaff
On Tue, Dec 27, 2016 at 02:11:43PM -0800, John McDowall wrote: > This is the major body of code that implements SFC. There is a new L2 stage > added to > perform the chaining operations and modifications to the ACL stage to direct > flows > to the service chain. > > Co-authored-by: Flavio

Re: [ovs-dev] [RFC PATCH 1/5] OVN: SFC Implemnentation - documentation for SFC ACL Action

2017-01-31 Thread Ben Pfaff
On Tue, Dec 27, 2016 at 02:11:42PM -0800, John McDowall wrote: > This is minor changes to documentation to support additional ACL action. > > Co-authored-by: Flavio Fernandes > Reported at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2016-March/040381.html > Reported at: >

Re: [ovs-dev] [PATCH] documentation: Windows support multiple VTEP/NICs

2017-01-31 Thread Ben Pfaff
Applied, thanks Sairam and Alin! On Fri, Jan 27, 2017 at 07:58:09AM +, Sairam Venugopal wrote: > Acked-by: Sairam Venugopal > > > > > > On 1/26/17, 6:30 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin > Serdean"

Re: [ovs-dev] [PATCH v2] windows: wmi add include

2017-01-31 Thread Ben Pfaff
On Mon, Jan 30, 2017 at 07:42:31AM +, Alin Serdean wrote: > Add 'util.h' to includes otherwise the result of the function > 'ovs_format_message' will be unknown and be converted to int, > triggering an abort of vswitchd. Is there a way to make MSVC fail the compile if a function is called

Re: [ovs-dev] [PATCH 1/1] OVN: Firewall service files for OVN

2017-01-31 Thread Russell Bryant
On Tue, Jan 31, 2017 at 1:11 PM, Ben Pfaff wrote: > On Tue, Jan 31, 2017 at 05:25:26PM +0100, Marcin Mirecki wrote: > > Firewall service files allowing to open firewalld > > ports required for running OVN. > > > > > > Current OVN installation does not configure firewalld. > >

Re: [ovs-dev] [PATCH v2] packet: proper return type for vlan_tci_to_pcp()

2017-01-31 Thread Ben Pfaff
By my count, vlan_tci_to_pcp() is used in printf-like format specifiers in 7 places in the tree. Before this patch, it is used with the following format specifiers: %d 3 times %x 1 time PRIu8 1 time PRIx8 1 time Both %d and %x are obviously correct,

Re: [ovs-dev] [PATCH 6/6] datapath-windows: GENEVE Check for flow destination port

2017-01-31 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 1/10/17, 8:48 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >Change the UDP destination port(GENEVE header) to check if it was set by

Re: [ovs-dev] [PATCH 5/6] datapath-windows: STT Check for flow destination port

2017-01-31 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 1/10/17, 8:48 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >Change the TCP destination port(STT header) to check if it was set by >the

Re: [ovs-dev] [PATCH 4/6] datapath-windows: VXLAN Check for flow destination port

2017-01-31 Thread Sairam Venugopal
Acked-by: Sairam Venugopal On 1/10/17, 8:48 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >Change the UDP destination port(VXLAN header) to check if it was set by

[ovs-dev] [PATCH v3] dpif-netdev: Conditional EMC insert

2017-01-31 Thread Ciara Loftus
Unconditional insertion of EMC entries results in EMC thrashing at high numbers of parallel flows. When this occurs, the performance of the EMC often falls below that of the dpcls classifier, rendering the EMC practically useless. Instead of unconditionally inserting entries into the EMC when a

[ovs-dev] [PATCH 1/1] OVN: Firewall service files for OVN

2017-01-31 Thread Marcin Mirecki
Firewall service files allowing to open firewalld ports required for running OVN. Current OVN installation does not configure firewalld. Running firewalld prevents OVN from working properly. Signed-off-by: Marcin Mirecki ___ dev

Re: [ovs-dev] [PATCH] netlink-socket: Fix possiblity of nl_transact dereferncing null pointer

2017-01-31 Thread Ben Pfaff
On Tue, Jan 31, 2017 at 08:40:08AM +0200, Roi Dayan wrote: > Many nl_transact callers and its wrapper tc_transact pass NULL for replyp > which is being accessed in error flow without being checked if null or not. > > Signed-off-by: Roi Dayan > Reviewed-by: Paul Blakey