Re: [ovs-dev] [PATCH v2] windows: wmi add include

> -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Wednesday, February 1, 2017 7:36 PM > To: Alin Serdean > Cc: Guru Shetty ; Sairam Venugopal > ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH

Re: [ovs-dev] [PATCH 0/7] userspace: Support for L3 tunneling

Thanks for this contribution, Jan & al! I’ll start reviewing these right away. Please find my comment addressing your concern below, > On Feb 3, 2017, at 2:37 AM, Jan Scheurich wrote: > > This patch set is part of an initiative to deal with non-Ethernet packets in

Re: [ovs-dev] [ovs-dev, RFC] ovn: support for service function chaining

The approach of using OVN logical ports to build the chain seems clean, but I wonder whether it's general-purpose enough to do what users want. If not, that is, if some users want to use physical appliances rather than VMs or containers that are integrated into OVN, the question arises of how to

Re: [ovs-dev] [ovs-dev, RFC] ovn: support for service function chaining

Ben, Thanks for the thorough review, I will update the code and resubmit the patch. Any thoughts on the general approach to service chaining etc? Regards John On 2/3/17, 2:10 PM, "Ben Pfaff" wrote: On Thu, Feb 02, 2017 at 03:22:56PM -0800, jmcdow...@paloaltonetworks.com

Re: [ovs-dev] [PATCH] odp: Fix sample action in userspace

On Thu, Feb 2, 2017 at 10:56 AM, Ben Pfaff wrote: > On Wed, Jan 11, 2017 at 04:00:04PM -0800, Andy Zhou wrote: >> User space implementation of the sample action is not consistent with >> kernel datapath. In kernel datapath, the side effects of actions >> within the sample actions

Re: [ovs-dev] [PATCH 2/2] ovs-vsctl: Disallow empty bridge, port, and interface names.

On Fri, Feb 03, 2017 at 01:58:14PM -0800, Andy Zhou wrote: > On Fri, Feb 3, 2017 at 9:06 AM, Ben Pfaff wrote: > > Reported-by: Gabor Locsei > > Reported-at: > > https://mail.openvswitch.org/pipermail/ovs-discuss/2017-February/043613.html > >

Re: [ovs-dev] [RFC PATCH v4 0/6] create tunnel devices using rtnetlink interface

On 3 February 2017 at 13:07, Eric Garver wrote: > On Thu, Feb 02, 2017 at 02:37:22PM -0800, Joe Stringer wrote: >> There's a few patches in this series with co-authored-by, but missing >> signed-off-by from the co-author. Also, the author does not need to be >> listed as a

Re: [ovs-dev] [RFC PATCH v4 3/6] dpif-netlink: Probe for out-of-tree datapath.

On 3 February 2017 at 12:56, Eric Garver wrote: > On Thu, Feb 02, 2017 at 02:50:01PM -0800, Joe Stringer wrote: >> On 18 January 2017 at 11:45, Eric Garver wrote: >> > For out-of-tree datapath, only try genetlink/compat. >> > For in-tree kernel datapath, try rtnetlink

Re: [ovs-dev] [ovs-dev, RFC] ovn: support for service function chaining

On Thu, Feb 02, 2017 at 03:22:56PM -0800, jmcdow...@paloaltonetworks.com wrote: > From: John McDowall > > This patchset is the first round at having Service Function Chaining > functionality through OVN. The implementation is done entirely > on the northbound side

Re: [ovs-dev] [PATCH 2/2] ovs-vsctl: Disallow empty bridge, port, and interface names.

On Fri, Feb 3, 2017 at 9:06 AM, Ben Pfaff wrote: > Reported-by: Gabor Locsei > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2017-February/043613.html > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou

Re: [ovs-dev] [PATCH v2] ofp-actions: Fix variable length meta-flow field usage in flow actions.

On 2 February 2017 at 13:40, Joe Stringer wrote: > On 1 February 2017 at 11:06, Joe Stringer wrote: >> On 31 January 2017 at 16:57, Joe Stringer wrote: >>> /* Returns true if a variable length meta-flow field 'mff' is not mapped in >>> * the

Re: [ovs-dev] [RFC PATCH v4 0/6] create tunnel devices using rtnetlink interface

On Thu, Feb 02, 2017 at 02:37:22PM -0800, Joe Stringer wrote: > Hi Eric, Hi Joe, Thanks for your feedback! Much appreciated. > There's a few patches in this series with co-authored-by, but missing > signed-off-by from the co-author. Also, the author does not need to be > listed as a co-author.

Re: [ovs-dev] SFC patches for OVN

Jason, I checked it against top of the git tree. So just download the patch and clone the lastest and then $ git apply –directory=ovn If you have any questions/feedback let me know. Regards John ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [RFC PATCH v4 4/6] dpif-netlink: add VXLAN creation support

On Thu, Feb 02, 2017 at 02:59:42PM -0800, Joe Stringer wrote: > On 18 January 2017 at 11:45, Eric Garver wrote: > > Creates VXLAN devices using rtnetlink and tunnel metadata. > > > > Co-Authored-by: Thadeu Lima de Souza Cascardo > > Co-Authored-by: Eric Garver

Re: [ovs-dev] SFC patches for OVN

> > >> > Hi Guru, > > Thank you for your reply. I found the post. It was posted by John McDowall > yesterday. > > I'd like to try it. Just wonder which ovs version/branch it should be > applied to. 2.6.1 or the master branch? > > Master branch. > Thank you > Jason > >

Re: [ovs-dev] [RFC PATCH v4 3/6] dpif-netlink: Probe for out-of-tree datapath.

On Thu, Feb 02, 2017 at 02:50:01PM -0800, Joe Stringer wrote: > On 18 January 2017 at 11:45, Eric Garver wrote: > > For out-of-tree datapath, only try genetlink/compat. > > For in-tree kernel datapath, try rtnetlink then genetlink. > > > > Signed-off-by: Eric Garver >

Re: [ovs-dev] [PATCH v2] rhel: Firewall service files for OVN.

On Fri, Feb 3, 2017 at 3:50 PM, Russell Bryant wrote: > From: Marcin Mirecki > > Firewall service files allowing to open firewalld > ports required for running OVN > > Signed-off-by: Marcin Mirecki > Acked-by: Ben Pfaff

[ovs-dev] [PATCH v2] rhel: Firewall service files for OVN.

From: Marcin Mirecki Firewall service files allowing to open firewalld ports required for running OVN Signed-off-by: Marcin Mirecki Acked-by: Ben Pfaff Signed-off-by: Russell Bryant --- AUTHORS.rst

Re: [ovs-dev] [RFC PATCH v4 2/6] dpif-netlink: break out code to add compat and non-compat vports

On Thu, Feb 02, 2017 at 02:39:30PM -0800, Joe Stringer wrote: > On 18 January 2017 at 11:45, Eric Garver wrote: > > From: Thadeu Lima de Souza Cascardo > > > > The vport type for adding tunnels is now compatibility code and any new > > features > > from

Re: [ovs-dev] SFC patches for OVN

On 3 February 2017 at 11:59, Shuaijun Zhang wrote: > Hi All, > > I found a link (see below) it mentioned that a set of patches are developed > to support SFC within OVN > https://mail.openvswitch.org/pipermail/ovs-dev/2016-November/324909.html > > Can anyone please let me

[ovs-dev] SFC patches for OVN

Hi All, I found a link (see below) it mentioned that a set of patches are developed to support SFC within OVN https://mail.openvswitch.org/pipermail/ovs-dev/2016-November/324909.html Can anyone please let me know where are these patches, are they in the OVS repo in github? Thank you, Jason

Re: [ovs-dev] [PATCH v3] dpif-netdev: Conditional EMC insert

2017-01-31 9:55 GMT-08:00 Ciara Loftus : > Unconditional insertion of EMC entries results in EMC thrashing at high > numbers of parallel flows. When this occurs, the performance of the EMC > often falls below that of the dpcls classifier, rendering the EMC > practically

Re: [ovs-dev] [PATCH v2 1/1] doc: Remove "experimental" warning for userspace.

2017-02-03 9:38 GMT-08:00 Kevin Traynor : > On 02/02/2017 08:22 PM, Stokes, Ian wrote: >>> On 02/02/2017 04:44 PM, Ian Stokes wrote: Remove the experimental warning tag in documentation regarding OVS deployed via userspace. Signed-off-by: Ian Stokes

Re: [ovs-dev] [PATCH] doc: Update DPDK version for 2.7 release.

2017-02-02 8:59 GMT-08:00 Kevin Traynor : > On 02/02/2017 04:30 PM, Ian Stokes wrote: >> Add DPDK version required for the OVS 2.7 release in documentation. >> >> Signed-off-by: Ian Stokes > > Acked-by: Kevin Traynor Thanks, pushed

Re: [ovs-dev] [PATCH 2/3] rhel: Remove obsolete OVSDPDKVhostPort from ifdown script.

On 02/02/2017 11:49, "Ben Pfaff" wrote: >On Tue, Jan 24, 2017 at 06:21:52PM -0800, Daniele Di Proietto wrote: >> The support for vhost cuse port has been removed long ago. >> >> Fixes:419876444357("netdev-dpdk: Remove dpdkvhostcuse ports") >> Signed-off-by: Daniele Di

Re: [ovs-dev] [PATCH] ovn: Add missing netdev_close in setup_qos.

On Thu, Feb 2, 2017 at 12:41 PM, Ben Pfaff wrote: > On Thu, Feb 02, 2017 at 02:04:07AM -0500, Russell Bryant wrote: > > We missed calling netdev_close in a couple of places. One was in an > error > > condition rarely hit. The second was just introduced and would be hit in > > all

Re: [ovs-dev] [PATCH] docs: Add OVS and OVN headings to pages.

On Thu, Feb 2, 2017 at 12:40 PM, Ben Pfaff wrote: > On Thu, Feb 02, 2017 at 02:02:34AM -0500, Russell Bryant wrote: > > Update the "deep dive" and "howto" pages with headings that more clearly > > indicate the separate lists of OVS or OVN content. Also add a link to > >

Re: [ovs-dev] [RFC PATCH 2/5] OVN: SFC Implementation: New stage for SFC and modified ACL stage

Great, I'll have a look. On Thu, Feb 02, 2017 at 11:50:17PM +, John McDowall wrote: > Ben, > > Posted an updated patch – then downloaded it from patchwork and applied to > top to tree and ran make check and all tests passed. > > Regards > > John > > On 1/31/17, 3:49 PM, "Ben Pfaff"

[ovs-dev] [PATCH 2/2] ovs-vsctl: Disallow empty bridge, port, and interface names.

Reported-by: Gabor Locsei Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2017-February/043613.html Signed-off-by: Ben Pfaff --- tests/ovs-vsctl.at| 12 utilities/ovs-vsctl.c | 12 2 files changed, 24

[ovs-dev] [PATCH 1/2] netdev: Reject empty names in netdev_open().

The empty string is not a valid name for a network device. I would have expected that each of the netdev provider implementations would reject an empty string, but there was a special case for Linux tap devices where they instead caused unexpected behavior. This commit should fix the problem for

Re: [ovs-dev] [RFC] Vhost-user backends cross-version migration support

On Fri, Feb 03, 2017 at 03:54:52PM +, Daniel P. Berrange wrote: > On Fri, Feb 03, 2017 at 05:34:07PM +0200, Michael S. Tsirkin wrote: > > On Fri, Feb 03, 2017 at 03:11:10PM +0100, Maxime Coquelin wrote: > > > Hi, > > > > > > On 02/01/2017 09:35 AM, Maxime Coquelin wrote: > > > > Hi, > > > >

Re: [ovs-dev] [RFC] Vhost-user backends cross-version migration support

On Fri, Feb 03, 2017 at 05:34:07PM +0200, Michael S. Tsirkin wrote: > On Fri, Feb 03, 2017 at 03:11:10PM +0100, Maxime Coquelin wrote: > > Hi, > > > > On 02/01/2017 09:35 AM, Maxime Coquelin wrote: > > > Hi, > > > > > > Few months ago, Michael reported a problem about migrating VMs relying > >

Re: [ovs-dev] [RFC] Vhost-user backends cross-version migration support

On Fri, Feb 03, 2017 at 03:11:10PM +0100, Maxime Coquelin wrote: > Hi, > > On 02/01/2017 09:35 AM, Maxime Coquelin wrote: > > Hi, > > > > Few months ago, Michael reported a problem about migrating VMs relying > > on vhost-user between hosts supporting different backend versions: > > -

Re: [ovs-dev] [RFC] Vhost-user backends cross-version migration support

Hi, On 02/01/2017 09:35 AM, Maxime Coquelin wrote: Hi, Few months ago, Michael reported a problem about migrating VMs relying on vhost-user between hosts supporting different backend versions: - Message-Id: <20161011173526-mutt-send-email-...@kernel.org> -

[ovs-dev] [PATCH 1/3] datapath: backport: openvswitch: 802.1ad uapi changes.

commit 8c146bb9d59aa2ac45222171916ece186c4b3943 Author: Thomas F Herbert Date: Wed Sep 7 12:56:57 2016 -0400 openvswitch: Add support for 8021.AD Change the description of the VLAN tpid field. Signed-off-by: Thomas F Herbert

[ovs-dev] [PATCH 0/3] Backport 802.1ad patches

This patch set is to backport 802.1ad patches Eric Garver did to ovs, per discussion in ovs-dev mailing list, this fix patch "openvswitch: upcall: Fix vlan handling" depends on them, l3 patch set depends on this patch set and "openvswitch: upcall: Fix vlan handling". Once this patch set is

Re: [ovs-dev] [libvirt] [RFC] Vhost-user backends cross-version migration support

On 02/03/2017 11:11 AM, Daniel P. Berrange wrote: On Fri, Feb 03, 2017 at 10:41:12AM +0100, Maxime Coquelin wrote: On 02/03/2017 10:27 AM, Daniel P. Berrange wrote: On Thu, Feb 02, 2017 at 08:27:18PM +0200, Michael S. Tsirkin wrote: On Thu, Feb 02, 2017 at 06:21:55PM +, Daniel P.

[ovs-dev] [PATCH 7/7] ofproto-dpif-xlate: refactor compose_output_action__

The very long function compose_output_action__() has been re-factored to make the different cases for output to patch-port, native tunnel port, kernel tunnel port, recirculation, or termination of a native tunnel at output to LOCAL port clearer. Larger, self-contained blocks have been split out

[ovs-dev] [PATCH 6/7] dpif-netlink: Don't send PACKET_TYPE to kernel

The kernel datapath does not support the packet_type match field. Instead it encodes the packet type implicitly by the presence or absence of the Ethernet attribute in the flow key and mask. This patch filters the PACKET_TYPE attribute out of netlink flow key and mask to be sent to the kernel

[ovs-dev] [PATCH 3/7] userspace: Switching of L3 packets in L2 pipeline

Ports have a new layer3 attribute if they send/receive L3 packets. The packet_type included in structs dp_packet and flow is considered in ofproto-dpif. The classical L2 match fields (dl_src, dl_dst, dl_type, and vlan_tci, vlan_vid, vlan_pcp) now have Ethernet as pre-requisite. A dummy ethernet

[ovs-dev] [PATCH 5/7] userspace: L3 tunnel support for GRE and LISP

Add a boolean "layer3" configuration option for tunnel vports. The layer3 option defaults to false for all ports except LISP. GRE ports accept both true and false for "layer3". A tunnel vport configured with layer3=true receives L3 packets. which are then converted to Ethernet packets by pushing

[ovs-dev] [PATCH 2/7] userspace: Support for push_eth and pop_eth actions

Add support for actions push_eth and pop_eth to the netdev datapath and the supporting libraries. This patch relies on the support for these actions in the kernel datapath to be present. Signed-off-by: Lorand Jakab Signed-off-by: Simon Horman

[ovs-dev] [PATCH 4/7] ofproto-dpif-upcall: Intialize dump-seq of new flow to zero

This forces updating of flow stat at the next re-validation, even for flows that are being created when the revalidation has already commenced. It enables reliable testing of fast path flow stats using ovs-appctl time/warp after flow creation. Signed-off-by: Jan Scheurich

[ovs-dev] [PATCH 1/7] userspace: Add packet_type in dp_packet and flow

This commit adds a packet_type attribute to the structs dp_packet and flow to explicitly carry the type of the packet as preparation for the introduction of the so-called packet type-aware pipeline (PTAP) in OVS. The packet_type is a big-endian 32 bit integer with the encoding as specified in

Re: [ovs-dev] [libvirt] [RFC] Vhost-user backends cross-version migration support

On Fri, Feb 03, 2017 at 10:41:12AM +0100, Maxime Coquelin wrote: > > > On 02/03/2017 10:27 AM, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 08:27:18PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Feb 02, 2017 at 06:21:55PM +, Daniel P. Berrange wrote: > > > > On Thu, Feb 02, 2017

Re: [ovs-dev] [libvirt] [RFC] Vhost-user backends cross-version migration support

On 02/03/2017 10:27 AM, Daniel P. Berrange wrote: On Thu, Feb 02, 2017 at 08:27:18PM +0200, Michael S. Tsirkin wrote: On Thu, Feb 02, 2017 at 06:21:55PM +, Daniel P. Berrange wrote: On Thu, Feb 02, 2017 at 07:31:49PM +0200, Michael S. Tsirkin wrote: On Thu, Feb 02, 2017 at 05:29:08PM

Re: [ovs-dev] [libvirt] [RFC] Vhost-user backends cross-version migration support

On Thu, Feb 02, 2017 at 08:27:18PM +0200, Michael S. Tsirkin wrote: > On Thu, Feb 02, 2017 at 06:21:55PM +, Daniel P. Berrange wrote: > > On Thu, Feb 02, 2017 at 07:31:49PM +0200, Michael S. Tsirkin wrote: > > > On Thu, Feb 02, 2017 at 05:29:08PM +, Daniel P. Berrange wrote: > > > > On