Re: [ovs-dev] [PATCH v4 2/2] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

2017-03-24 Thread Chandran, Sugesh
Can anyone have a look and let me know the comments/suggestions? Regards _Sugesh > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Chandran, Sugesh > Sent: Wednesday, March 8, 2017 1:52 PM > To: 'Ben Pfaff'

Re: [ovs-dev] [PATCH ovs V5 01/24] tc: Add tc flower interface

2017-03-24 Thread Joe Stringer
On 22 March 2017 at 04:10, Roi Dayan wrote: > From: Paul Blakey > > Add tc flower interface that will be used to offload flows via tc > flower classifier. Depending on the flag used (skip_sw/hw) flower > will pass those to HW or handle them itself. > Move

[ovs-dev] [PATCH v6 5/5] datapath-windows: Fragment NBL based on MRU size

2017-03-24 Thread Anand Kumar
This patch adds support for Fragmenting NBL based on the MRU value. MRU value is updated only for Ipv4 fragments, if it is non zero, then fragment the NBL and send out the new NBL to the vnic. Signed-off-by: Anand Kumar --- v5->v6: No Change v4->v5: - Use MRU

[ovs-dev] [PATCH v6 2/5] datapath-windows: Added Ipv4 fragments support in Conntrack

2017-03-24 Thread Anand Kumar
This patch adds support for tracking Ipv4 fragments in conntrack module. Individual fragments are not tracked and are consumed by the fragmentation/reassembly. Only the reassembled Ipv4 datagram is tracked and treated as a single ct entry. Signed-off-by: Anand Kumar ---

[ovs-dev] [PATCH v6 3/5] datapath-windows: Retain MRU value in the _OVS_BUFFER_CONTEXT.

2017-03-24 Thread Anand Kumar
This patch introduces a new field MRU(Maximum Recieved Unit) in the _OVS_BUFFER_CONTEXT and it is used only for Ip Fragments to retain MRU for the reassembled IP datagram when the packet is forwarded to userspace. Signed-off-by: Anand Kumar --- v5->v6: No Change v4->v5:

[ovs-dev] [PATCH v6 1/5] datapath-windows: Added a new file to support Ipv4 fragments.

2017-03-24 Thread Anand Kumar
This patch adds functionalities to support IPv4 fragments, which will be used by Conntrack module. Added a new structure to hold the Ipv4 fragments and a hash table to hold Ipv4 datagram entries. Also added a clean up thread that runs every minute to delete the expired IPv4 datagram entries. The

[ovs-dev] [PATCH v6 4/5] datapath-windows: Updated OvsTcpSegmentNBL to handle IP fragments.

2017-03-24 Thread Anand Kumar
With this patch, OvsTcpSegmentNBL not only supports fragmenting NBL to TCP segments but also Ipv4 fragments. To reflect the new changes, renamed function name from OvsTcpSegmentNBL to OvsFragmentNBL and created a wrapper for OvsTcpSegmentNBL. Signed-off-by: Anand Kumar

[ovs-dev] [PATCH v6 0/5] datapath-windows: Add support for Ipv4 fragments

2017-03-24 Thread Anand Kumar
Add support for maintaining and tracking IPv4 fragments. This patch series adds a new file IpFragment.c and IpFragment.h which includes Ipv4 fragment related API's. --- v5->v6: Rebase v4->v5: - Modified Patch 3 to retain MRU in _OVS_BUFFER_CONTEXT instead of using it in

Re: [ovs-dev] [PATCH] meta-flow: Remove metadata prerequisite on ether type.

2017-03-24 Thread Jarno Rajahalme
Ben & Numan, Thanks for the reviews, pushed to master. Jarno > On Mar 24, 2017, at 11:06 AM, Ben Pfaff wrote: > > On Wed, Mar 22, 2017 at 04:48:07PM -0700, Jarno Rajahalme wrote: >> Conntrack original direction tuple fields depend on the conntrack >> state and the type of the

Re: [ovs-dev] [PATCH] meta-flow: Remove metadata prerequisite on ether type.

2017-03-24 Thread Ben Pfaff
On Wed, Mar 22, 2017 at 04:48:07PM -0700, Jarno Rajahalme wrote: > Conntrack original direction tuple fields depend on the conntrack > state and the type of the packet that was tracked. These dependencies > were encoded as OpenFlow prerequisites in commit daf4d3c18da4 ("odp: > Support conntrack

Re: [ovs-dev] [PATCH 2/3 v2] datapath-windows: Add NAT module in conntrack

2017-03-24 Thread Yin Lin
Hi Sai, You are right. Locking is a little bit tricky here than in Conntrack.c because we cannot grab the lock during the entire Conntrack transaction. I will have to address thread safety in another patch. Best regards, Yin Lin On Thu, Mar 23, 2017 at 11:58 PM, Sairam Venugopal

Re: [ovs-dev] Invitation: OVS-DPDK bi-weekly meeting...

2017-03-24 Thread Kevin Traynor
24 March 2017 ATTENDEES: Johann, Antonio, Rashid, Eelco, Flavio, Simon, Georg, Jan, Robin, Ian, Bhanu, Darren, Billy, Fikkie, Vinod, Rick, Niaz, Kevin GENERAL If anyone doesn't have the calendar invite and wants it, drop me a mail (Kevin) User guide / blog location in OvS.org - where is the

Re: [ovs-dev] [RFC] lib/automake.mk: remove runtime directories

2017-03-24 Thread Ben Pfaff
On Tue, Mar 21, 2017 at 02:20:30PM -0400, Aaron Conole wrote: > Aaron Conole writes: > > > The Open vSwitch run, log, and DB directories are installed as part of the > > normal `make install` process. However, this means they are created with > > user and group ownership

[ovs-dev] Openstack Users Lists

2017-03-24 Thread ana.olive
Hi, We are glad to inform you about our recent list release of Openstack users and we are know to learn your interest in acquiring the list. Our list contains information fields like: Amazon S3, Microsoft Azure, Verizon Cloud, ProfitBricks, OpenNebula, Cisco Cloud Infrastructure

[ovs-dev] [PATCH] ofproto: Limit log rate when controller disconnected.

2017-03-24 Thread nickcooper-zhangtonghao
There are a lot of logs when OvS bridges can’t connect to controllers. The controller may stop or something causes a disruption in network traffic. Signed-off-by: nickcooper-zhangtonghao --- lib/rconn.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

Re: [ovs-dev] [PATCH v3] netdev-dpdk: leverage the mempool offload support

2017-03-24 Thread Jianbo Liu
The 03/24/2017 12:57, Hemant Agrawal wrote: > DPDK 16.07 introduced the support for mempool offload support. > rte_pktmbuf_pool_create is the recommended method for creating pktmbuf > pools. Buffer pools created with rte_mempool_create may not get offloaded > to the underlying offloaded mempools.

[ovs-dev] [patch_v7 8/9] dpdk: Enable NAT tests for userspace datapath.

2017-03-24 Thread Darrell Ball
Signed-off-by: Darrell Ball Acked-by: Flavio Leitner --- tests/system-userspace-macros.at | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/system-userspace-macros.at b/tests/system-userspace-macros.at index 631f71a..6e3d468

[ovs-dev] [patch_v7 9/9] dpdk: Update feature alert documentation.

2017-03-24 Thread Darrell Ball
Signed-off-by: Darrell Ball Acked-by: Flavio Leitner --- Documentation/faq/releases.rst | 2 +- NEWS | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/faq/releases.rst

[ovs-dev] [patch_v7 7/9] Add some system test fixes

2017-03-24 Thread Darrell Ball
Signed-off-by: Darrell Ball --- tests/system-traffic.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 59eae7e..8ade448 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -2437,8

[ovs-dev] [patch_v7 6/9] System Tests: Enhance NAT tests.

2017-03-24 Thread Darrell Ball
Two new tests are added and two other tests were enhanced. Signed-off-by: Darrell Ball --- tests/atlocal.in| 3 ++ tests/system-traffic.at | 109 +++- 2 files changed, 110 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [patch_v7 3/9] dpdk: Userspace Datapath: Introduce NAT Support.

2017-03-24 Thread Darrell Ball
This patch introduces NAT support for the userspace datapath. Most conntrack module changes are in this patch, with the exception of icmp related handling and recent orig tuple support. The per packet scope of lookups for NAT and un_NAT is at the bucket level rather than global. One hash table is

[ovs-dev] [patch_v7 5/9] dpdk: Add orig tuple context recovery.

2017-03-24 Thread Darrell Ball
This patch adds orig tuple checking and context recovery; NAT interactions are factored in. Orig tuple support exists to better handle policy changes. Signed-off-by: Darrell Ball --- lib/conntrack.c | 69 + 1 file

[ovs-dev] [patch_v7 1/9] dpdk: Parse NAT netlink for userspace datapath.

2017-03-24 Thread Darrell Ball
Signed-off-by: Darrell Ball Acked-by: Flavio Leitner --- lib/conntrack-private.h | 9 -- lib/conntrack.c | 3 +- lib/conntrack.h | 29 - lib/dpif-netdev.c | 85 +++--

[ovs-dev] [patch_v7 4/9] dpdk: Add more ICMP Related NAT support.

2017-03-24 Thread Darrell Ball
This patch includes more complete support for icmp4 and icmp6 related NAT handling. Signed-off-by: Darrell Ball --- lib/conntrack.c | 99 +++-- lib/packets.h | 7 2 files changed, 104 insertions(+), 2 deletions(-)

[ovs-dev] [patch_v7 2/9] dpdk: Remove batch sorting in userspace conntrack.

2017-03-24 Thread Darrell Ball
Signed-off-by: Darrell Ball Acked-by: Flavio Leitner --- lib/conntrack.c | 58 +++-- 1 file changed, 11 insertions(+), 47 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 4f490fb..9a0763e

[ovs-dev] [patch_v7 0/9] Userspace Datapath: Introduce NAT support.

2017-03-24 Thread Darrell Ball
This patch series introduces NAT support for the userspace datapath. The per packet scope of lookups for NAT and un_NAT is at the bucket level rather than global. One hash table is introduced to support create/delete handling. The create/delete events may be further optimized, if the need becomes

[ovs-dev] [PATCH] ofproto-dpif-xlate: Fix the memory leak in netflow.

2017-03-24 Thread zhangsha (A)
From c4066ad97d4f9e39cd80f6d43f0592092423e0b6 Mon Sep 17 00:00:00 2001 From: Sha Zhang Date: Sat, 25 Mar 2017 04:43:56 +0800 Subject: [PATCH] ofproto-dpif-xlate: Fix the memory leak in netflow. The memory leak was triggered each time on creating a netflow and

[ovs-dev] [PATCH v3] netdev-dpdk: leverage the mempool offload support

2017-03-24 Thread Hemant Agrawal
DPDK 16.07 introduced the support for mempool offload support. rte_pktmbuf_pool_create is the recommended method for creating pktmbuf pools. Buffer pools created with rte_mempool_create may not get offloaded to the underlying offloaded mempools. This patch, changes the rte_mempool_create to use

Re: [ovs-dev] [PATCH 2/3 v2] datapath-windows: Add NAT module in conntrack

2017-03-24 Thread Sairam Venugopal
Hi Yin, Thanks for sending over the patch. While it looks good for the most part, there are certain indentations that need fixing. I will send those out separately. I see that you have allocated - ovsNatLock and have added in stubs for flush and cleanup similar to Conntrack.c. However, I

[ovs-dev] [PATCH v2 2/2] ovn-detrace: A tool decoding ofproto/trace output for ovn debugging.

2017-03-24 Thread Han Zhou
A python script to decode ofproto/trace output to add ovn lflow information inline. It expands lflow further to ACLs when relevant. $ ovs-appctl ofproto/trace ... | ovn-decode Signed-off-by: Han Zhou --- Notes: v1->v2: fix hardcoded RUNDIR in ovn-detrace.in manpages.mk