Re: [ovs-dev] [PATCH v5 3/3] ovn: Gratuitous ARP for distributed NAT rules

On Wed, Mar 29, 2017 at 10:16 AM, Guru Shetty wrote: > > > On 27 March 2017 at 18:34, Mickey Spiegel wrote: > >> This patch extends gratuitous ARP support for NAT addresses so that it >> applies to distributed NAT rules on a distributed logical router. >>

Re: [ovs-dev] [PATCH] faq: Expand on answer about packet buffering removal.

On Wed, Mar 29, 2017 at 11:25 AM, Ben Pfaff wrote: > On Wed, Mar 29, 2017 at 10:25:31AM -0700, Andy Zhou wrote: >> On Fri, Mar 17, 2017 at 8:16 AM, Ben Pfaff wrote: >> > Signed-off-by: Ben Pfaff >> > --- >> > Documentation/faq/openflow.rst | 8

Re: [ovs-dev] [PATCH] selinux: Allow creating tap devices.

Aaron Conole writes: > Aaron Conole writes: >> Daniele Di Proietto writes: >>> On 26/01/2017 12:35, "Ansis Atteka" wrote: On 26 January 2017 at 21:24, Aaron Conole wrote:

[ovs-dev] [PATCH] Makefile: Fix name of coding style guide.

Signed-off-by: Ben Pfaff --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 6ad50b6af391..1b61d27fa6d9 100644 --- a/Makefile.am +++ b/Makefile.am @@ -249,7 +249,7 @@ printf-check: then \ echo "See

[ovs-dev] [PATCH 2/2] selinux: enable dpdk permissions

Set the selinux permissions for DPDK. After this patch, the openvswitch context label has access to the following resources: * hugepage filesystems * vfio devices * additional unix socket permissions * additional filesystem permissions Additionally, the openvswitch policy is now stored

Re: [ovs-dev] [PATCH v3 2/2] ovn-northd: Add logical flows to support native DNS

On Wed, Mar 29, 2017 at 11:47 PM, Guru Shetty wrote: > >> >> Agree. It was in my mind. I somehow missed it out. >> >> >>> >>> The above would mean that for each logical port, we need to create a DNS >>> record in the DNS table. Having the schema like the above has advantages. >>>

Re: [ovs-dev] [PATCH] faq: Expand on answer about packet buffering removal.

On Wed, Mar 29, 2017 at 10:25:31AM -0700, Andy Zhou wrote: > On Fri, Mar 17, 2017 at 8:16 AM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > > Documentation/faq/openflow.rst | 8 > > 1 file changed, 8 insertions(+) > > > > diff --git

Re: [ovs-dev] [PATCH] ovsdb-server: Drop unnecessary find_db() function.

On Mon, Mar 20, 2017 at 12:44:47PM -0700, Andy Zhou wrote: > On Mon, Mar 20, 2017 at 10:50 AM, Ben Pfaff wrote: > > 'all_dbs' maps from a schema name to its struct db, so there's no need to > > iterate the whole thing to find a database by schema name; instead, just > > use the

Re: [ovs-dev] [PATCH] ofproto: Use macros to define DPIF support fields

On 16 March 2017 at 16:32, Andy Zhou wrote: > When adding a new field in the 'struct dpif_backer_support', the > corresponding appctl show command should be updated to display > the new field. Currently, there is nothing to remind the developer > that to update the show command.

Re: [ovs-dev] [PATCH] ovsdb-server: Fix memory leak in update_remote_status() error path.

On Mon, Mar 20, 2017 at 12:46:37PM -0700, Andy Zhou wrote: > On Sun, Mar 19, 2017 at 10:22 AM, Ben Pfaff wrote: > > Found by inspection. > > > > Signed-off-by: Ben Pfaff > Acked-by: Andy Zhou Thanks, applied to master.

Re: [ovs-dev] [PATCH v3 2/2] ovn-northd: Add logical flows to support native DNS

> > > > Agree. It was in my mind. I somehow missed it out. > > >> >> The above would mean that for each logical port, we need to create a DNS >> record in the DNS table. Having the schema like the above has advantages. >> In the future, if we have to add new options for DNS, then it becomes >>

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Don't save pkt_mark in compose_output_action__().

Thanks, applied to master. On Fri, Mar 17, 2017 at 11:07:30AM -0700, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > > On Mar 17, 2017, at 10:55 AM, Ben Pfaff wrote: > > > > Previously, this function could modify the pkt_mark field as part of IPsec > >

Re: [ovs-dev] [PATCH] doc: Minor improvements to install instructions.

On Wed, Mar 29, 2017 at 10:27:34AM -0700, Andy Zhou wrote: > On Fri, Mar 17, 2017 at 2:40 PM, Ben Pfaff wrote: > > Clang 3.4 and later should now be widespread, so it's not worth suggesting > > where to find it. > > > > OVS needs a variety of shared libraries at runtime and it's not

Re: [ovs-dev] [PATCH] Document how to get Open vSwitch source code.

On Wed, Mar 29, 2017 at 10:28:31AM -0700, Guru Shetty wrote: > On 29 March 2017 at 10:19, Ben Pfaff wrote: > > > Suggested-by: "Nadathur, Sundar" > > Signed-off-by: Ben Pfaff > > > Acked-by: Gurucharan Shetty Thanks,

Re: [ovs-dev] [PATCH v3 2/2] ovn-northd: Add logical flows to support native DNS

On Mon, Mar 27, 2017 at 07:43:24PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > OVN implements native DNS resolution which can be used to resolve the > internal DNS names belonging to a logical datapath. > > To support this, a new table 'DNS' is added in the

Re: [ovs-dev] [PATCH v3 1/2] ovn-controller: Add 'dns_lookup' action

On Wed, Mar 29, 2017 at 11:12 PM, Ben Pfaff wrote: > On Mon, Mar 27, 2017 at 07:42:58PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > This patch adds a new OVN action 'dns_lookup' to support native DNS. > > ovn-controller parses this

Re: [ovs-dev] [PATCH v3 1/2] ovn-controller: Add 'dns_lookup' action

On Mon, Mar 27, 2017 at 07:42:58PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > This patch adds a new OVN action 'dns_lookup' to support native DNS. > ovn-controller parses this action and adds a NXT_PACKET_IN2 > OF flow with 'pause' flag set. > > A new

Re: [ovs-dev] dpif-netdev: Assign ports to pmds on non-local numa node.

I see there is warning log added for the non-local case. I wonder if during setup, there will be no issues with basic connectivity seen. Then some long time later at high PPS usage, unexpected low performance will be seen. I am not sure whether the log will be immediately consulted to check for

Re: [ovs-dev] [PATCH] doc: Minor improvements to install instructions.

On Fri, Mar 17, 2017 at 2:40 PM, Ben Pfaff wrote: > Clang 3.4 and later should now be widespread, so it's not worth suggesting > where to find it. > > OVS needs a variety of shared libraries at runtime and it's not worth > mentioning each one by name. > > The Linux kernel datapath

Re: [ovs-dev] [PATCH] faq: Expand on answer about packet buffering removal.

On Fri, Mar 17, 2017 at 8:16 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > Documentation/faq/openflow.rst | 8 > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/faq/openflow.rst b/Documentation/faq/openflow.rst > index

[ovs-dev] [PATCH] Document how to get Open vSwitch source code.

Suggested-by: "Nadathur, Sundar" Signed-off-by: Ben Pfaff --- AUTHORS.rst | 1 + Documentation/intro/install/general.rst | 28 2 files changed, 29 insertions(+) diff --git a/AUTHORS.rst

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix flow setup/delete race.

On 28 March 2017 at 23:59, Paul Blakey wrote: > > > On 27/03/2017 22:55, Joe Stringer wrote: >> >> On 21 March 2017 at 02:44, Paul Blakey wrote: >>> >>> >>> >>> On 21/03/2017 10:04, Paul Blakey wrote: On 20/03/2017 23:08, Joe

Re: [ovs-dev] [PATCH v5 3/3] ovn: Gratuitous ARP for distributed NAT rules

On 27 March 2017 at 18:34, Mickey Spiegel wrote: > This patch extends gratuitous ARP support for NAT addresses so that it > applies to distributed NAT rules on a distributed logical router. > Distributed NAT rules have type "dnat_and_snat" and specify > 'external_mac' and

Re: [ovs-dev] [PATCH ovs V5 00/24] Introducing HW offload support for openvswitch

On 29 March 2017 at 04:50, Roi Dayan wrote: > > > On 23/03/2017 09:01, Joe Stringer wrote: >> >> I ran the make check-offloads tests on a recent net-next kernel and it >> failed, output was not as expected: >> >> ../../tests/system-offloaded-traffic.at:54 >>

Re: [ovs-dev] [PATCH v5 2/3] ovn: Gratuitous ARP for centralized NAT rules on a distributed router

On 27 March 2017 at 18:34, Mickey Spiegel wrote: > This patch extends gratuitous ARP support for NAT addresses so that it > applies to centralized NAT rules on a distributed router, in addition to > the existing gratuitous ARP support for NAT addresses on gateway routers.

Re: [ovs-dev] [PATCH] Documentation: fix typo in documentation-style.rst

On Wed, Mar 29, 2017 at 04:15:52PM +0200, Timothy Redaelli wrote: > s/indenation/indentation/ > > Signed-off-by: Timothy Redaelli Thanks, applied to master. ___ dev mailing list d...@openvswitch.org

[ovs-dev] Planes Online 2017 - En Línea

En este 2017 nos gustaría hacerle una grata invitación a adquirir nuestros Programas de Capacitación Indispensables para los Responsables de Contabilidad y Finanzas, Recursos Humanos, Auditoría,Compras y Ventas. 3x2 o 60% de descuento en nuestros Planes Integrales Podrá obtener 12

[ovs-dev] [PATCH] Documentation: fix typo in documentation-style.rst

s/indenation/indentation/ Signed-off-by: Timothy Redaelli --- Documentation/internals/contributing/documentation-style.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/internals/contributing/documentation-style.rst

[ovs-dev] [PATCH ovs V6 17/24] netdev-tc-offloads: Implement flow get using tc interface

From: Paul Blakey Search the requested ufid for a offloaded flow, and if found, dump and parse it back to required format. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman ---

[ovs-dev] [PATCH ovs V6 16/24] dpif-netlink: Use netdev flow get api to query a flow

From: Paul Blakey Search all datapath added netdevs for a given flow using netdev flow api and parse it back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman ---

[ovs-dev] [PATCH ovs V6 15/24] netdev-tc-offloads: Implement netdev flow del using tc interface

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 33 ++--- 1 file changed, 30 insertions(+), 3

[ovs-dev] [PATCH ovs V6 13/24] netdev-tc-offloads: Implement netdev flow put using tc interface

From: Paul Blakey Currently only tunnel offload is supported. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 2 +- lib/netdev-tc-offloads.c |

[ovs-dev] [PATCH ovs V6 14/24] dpif-netlink: Use netdev flow del api to delete a flow

From: Paul Blakey If a flow was offloaded to a netdev we delete it using netdev flow api. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/dpif-netlink.c | 12

[ovs-dev] [PATCH ovs V6 23/24] compat: Add tc compatibility headers for old kernels

From: Paul Blakey Added compatibility headers for actions vlan and tunnel key. Do not use compat code when compiling kernel datapath there is no need for it as TC compatibility is not provided there. In other words, the compat code is only used when compiling user-space code

[ovs-dev] [PATCH ovs V6 18/24] netdev-linux: Disallow setting policing when configured with hw offload

From: Paul Blakey Notify as not supported. Otherwise the ingress qdisc is being removed and offload rules will be removed. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman ---

[ovs-dev] [PATCH ovs V6 24/24] netdev: Init flow api on already added ports on offload enable

From: Paul Blakey Ports already added to a switch are not being initialized for offloading so when enabling offload we need to go over those ports. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman

[ovs-dev] [PATCH ovs V6 12/24] netdev-tc-offloads: Add flower mask to priority map

From: Paul Blakey Flower classifer requires a different priority per mask, so we hash the mask and generate a new priority for each new mask used. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman

[ovs-dev] [PATCH ovs V6 22/24] tests: Add system-offloads-testsuite

From: Paul Blakey The new system-offloads-testsuite, which can be launched via `make check-offloads`, tests offloading capabilities to makes sure that certian flows are actually offloaded. The tests run on virtual netdevices (VETH). Signed-off-by: Paul Blakey

[ovs-dev] [PATCH ovs V6 21/24] dpctl: Add an option to dump only certain kinds of flows

From: Paul Blakey Usage: # to dump all datapath flows (default): ovs-dpctl dump-flows # to dump only flows that in kernel datapath: ovs-dpctl dump-flows type=ovs # to dump only flows that are offloaded: ovs-dpctl dump-flows type=offloaded

[ovs-dev] [PATCH ovs V6 20/24] netdev-tc-offloads: Add ingress on netdev flow api init

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 23 ++- 1 file changed, 22 insertions(+), 1 deletion(-)

[ovs-dev] [PATCH ovs V6 19/24] netdev-vport: Use common offloads interface

From: Paul Blakey netdev vports are backed by actualy netdev at the kernel level, so they can use the common netdev-tc offloads interface for flow offloading (if enabled). Signed-off-by: Paul Blakey Signed-off-by: Simon Horman

[ovs-dev] [PATCH ovs V6 10/24] netdev-tc-offloads: Implement netdev flow dump api using tc interface

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 182 --- 1 file changed, 174

[ovs-dev] [PATCH ovs V6 11/24] dpif-netlink: Use netdev flow put api to insert a flow

From: Paul Blakey Using the new netdev flow api operate will now try and offload flows to the relevant netdev of the input port. Other operate methods flows will come in later patches. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan

[ovs-dev] [PATCH ovs V6 08/24] dpif-netlink: Dump netdevs flows on flow dump

From: Paul Blakey While dumping flows, dump flows that were offloaded to netdev and parse them back to dpif flow. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman ---

[ovs-dev] [PATCH ovs V6 09/24] netdev-tc-offloads: Add ufid to tc/netdev map

From: Paul Blakey Flows offloaded to tc are identified by priority and handle pair while OVS flows are identified by ufid. Added a hash map to convert between the two for later retrieval and deleting of offloaded flows. Signed-off-by: Paul Blakey

[ovs-dev] [PATCH ovs V6 07/24] netdev-tc-offloads: Implement netdev flow flush using tc interface

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/netdev-tc-offloads.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [PATCH ovs V6 02/24] netdev: Adding a new netdev api to be used for offloading flows

From: Paul Blakey Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan Reviewed-by: Simon Horman --- lib/automake.mk | 2 + lib/netdev-bsd.c | 2 + lib/netdev-dpdk.c| 1 +

[ovs-dev] [PATCH ovs V6 00/24] Introducing HW offload support for openvswitch

This patch series introduces rule offload functionality to dpif-netlink via netdev ports new flow offloading API. The user can specify whether to enable rule offloading or not via OVS configuration. Netdev providers are able to implement netdev flow offload API in order to offload rules. This

[ovs-dev] [PATCH ovs V6 05/24] dpif: Save added ports in a port map for netdev flow api use

From: Paul Blakey To use netdev flow offloading api, dpifs needs to iterate over added ports. This addition inserts the added dpif ports in a hash map, The map will also be used to translate dpif ports to netdevs. Signed-off-by: Paul Blakey Reviewed-by:

[ovs-dev] [PATCH ovs V6 03/24] other-config: Add hw-offload switch to control netdev flow offloading

From: Paul Blakey Add a new configuration option - hw-offload that enables netdev flow api. Enabling this option will allow offloading flows using netdev implementation instead of the kernel datapath. This configuration option defaults to false - disabled. Signed-off-by:

[ovs-dev] [PATCH ovs V6 04/24] other-config: Add tc-policy switch to control tc flower flag

From: Paul Blakey Add a new configuration tc-policy option that controls tc flower flag. Possible options are none, skip_sw, skip_hw. The default is none which is to insert the rule both to sw and hw. This option is only relevant if hw-offload is enabled. Signed-off-by: Paul

Re: [ovs-dev] [PATCH ovs V5 00/24] Introducing HW offload support for openvswitch

On 23/03/2017 09:01, Joe Stringer wrote: I ran the make check-offloads tests on a recent net-next kernel and it failed, output was not as expected: ../../tests/system-offloaded-traffic.at:54 : ovs-appctl dpctl/dump-flows | grep "eth_type(0x0800)" | sed

[ovs-dev] [PATCH] m4: Add hard requirements for python in "configure"

Since Python 2.7 and python-six are needed to build Open vSwitch, ./configure should return an error if they are missing or if they are too old Signed-off-by: Timothy Redaelli --- m4/openvswitch.m4 | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff

Re: [ovs-dev] New custom Message - unknown OpenFlow message

I've tried to debug the vswichtd process but seems like something is not working... Attaching to process 2772 Reading symbols from /usr/sbin/ovs-vswitchd...(no debugging symbols found)...done. Reading symbols from /usr/lib/libofproto.so.1...(no debugging symbols found)...done. Reading

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Fix flow setup/delete race.

On 27/03/2017 22:55, Joe Stringer wrote: On 21 March 2017 at 02:44, Paul Blakey wrote: On 21/03/2017 10:04, Paul Blakey wrote: On 20/03/2017 23:08, Joe Stringer wrote: If a handler thread takes a long time to set up a set of flows, it is possible for one of the