Re: [ovs-dev] [patch_v7 0/9] Userspace Datapath: Introduce NAT support.

2017-04-29 Thread Daniele Di Proietto
Hi Darrell, I took another look at the series and provided a few comments inline. Other than those the patches look good to me, but I haven't looked at every possible corner case :-) Thanks, Daniele 2017-03-24 2:15 GMT-07:00 Darrell Ball : > This patch series introduces NAT

Re: [ovs-dev] [patch_v7 6/9] System Tests: Enhance NAT tests.

2017-04-29 Thread Daniele Di Proietto
Not sure this is very important: so far we managed to avoid using tcpdump in the tests. Would it be possible to use ovs-ofctl monitor? In any case, maybe, it shouldn't be prefixed by sudo 2017-03-24 2:15 GMT-07:00 Darrell Ball : > Two new tests are added and two other tests

Re: [ovs-dev] [patch_v7 5/9] dpdk: Add orig tuple context recovery.

2017-04-29 Thread Daniele Di Proietto
2017-03-24 2:15 GMT-07:00 Darrell Ball : > This patch adds orig tuple checking and context > recovery; NAT interactions are factored in. > Orig tuple support exists to better handle policy > changes. > > Signed-off-by: Darrell Ball > --- > lib/conntrack.c | 69

Re: [ovs-dev] [patch_v7 2/9] dpdk: Remove batch sorting in userspace conntrack.

2017-04-29 Thread Daniele Di Proietto
Thanks for doing this Acked-by: Daniele Di Proietto 2017-03-24 2:15 GMT-07:00 Darrell Ball : > Signed-off-by: Darrell Ball > Acked-by: Flavio Leitner > --- > lib/conntrack.c | 58 >

Re: [ovs-dev] [PATCH] tests/pmd.at: Fix race in "PMD - change numa node" test

2017-04-29 Thread Daniele Di Proietto
Thanks! Applied to master, branch-2.7 and branch-2.6 2017-04-21 6:38 GMT-07:00 Timothy Redaelli : > Sometimes the test fails since dpif-netdev may process the 2 packets > in the "wrong" order. > > This commit avoids the problem by printing (monitor) and verifying > any

Re: [ovs-dev] [ovs and ovn missing respawn]

2017-04-29 Thread Aliasgar Mikail Ginwala
You took it wrong. :) Even killing the pid with monitoring process running also doesn't bring it up. Yes, to of-course humans do mistake so we better can handle it via respawn which is what I am trying to convey. So was thinking, can we add that feature in current code base too as an additional

Re: [ovs-dev] [ovs and ovn missing respawn]

2017-04-29 Thread Ben Pfaff
You killed the monitor process, of course it couldn't revive the monitored process. If you have people going around killing processes without thinking, that's your problem. On Sat, Apr 29, 2017 at 12:59:50PM -0700, Aliasgar Mikail Ginwala wrote: > Same is reproducible using SIGABRT (kill -6) >

Re: [ovs-dev] [ovs and ovn missing respawn]

2017-04-29 Thread Aliasgar Mikail Ginwala
Same is reproducible using SIGABRT (kill -6) ps aux | grep ovn-controller root 927884 0.0 0.0 26792 956 ?S wrote: > Please read the ovs-vswitchd manpage. It says: > >--monitor > Creates an additional process to monitor the ovs-vswitchd > dae‐ >

Re: [ovs-dev] [ovs and ovn missing respawn]

2017-04-29 Thread Ben Pfaff
Please read the ovs-vswitchd manpage. It says: --monitor Creates an additional process to monitor the ovs-vswitchd dae‐ mon. If the daemon dies due to a signal that indicates a pro‐ gramming error (SIGABRT, SIGALRM, SIGBUS, SIGFPE, SIGILL,

Re: [ovs-dev] [ovs and ovn missing respawn]

2017-04-29 Thread Ben Pfaff
When you say that ovn-controller crashed, what do you mean? Do you mean that you killed it? Which process, and how did you kill it? On Fri, Apr 28, 2017 at 10:51:04PM -0700, Aliasgar Mikail Ginwala wrote: > Yes: > > ps aux | grep controller > root 3639845 0.0 0.0 26792 952 ?S

[ovs-dev] [PATCHv2] bridge: Prohibit "default" and "all" bridge name.

2017-04-29 Thread William Tu
Under Linux, when users create bridge named "default" or "all", although ovs-vsctl fails but vswitchd in the background will keep retrying it, causing the systemd-udev to reach 100% cpu utilization. The patch prevents any attempt to create or open a netdev named "default" or "all" because these

[ovs-dev] [PATCH] doc: Fix sphinx reference warning for windows.

2017-04-29 Thread William Tu
Footnote reference 5, 8, and 9 are not referenced in the windws.rst content, causing the following error: Warning, treated as error: /root/ovs/Documentation/topics/windows.rst:506:Footnote [5] is not referenced. Signed-off-by: William Tu --- Documentation/topics/windows.rst