Hi Darrell,
I took another look at the series and provided a few comments inline.
Other than those the patches look good to me, but I haven't looked at
every possible corner case :-)
Thanks,
Daniele
2017-03-24 2:15 GMT-07:00 Darrell Ball :
> This patch series introduces NAT
Not sure this is very important: so far we managed to avoid using tcpdump in
the tests. Would it be possible to use ovs-ofctl monitor?
In any case, maybe, it shouldn't be prefixed by sudo
2017-03-24 2:15 GMT-07:00 Darrell Ball :
> Two new tests are added and two other tests
2017-03-24 2:15 GMT-07:00 Darrell Ball :
> This patch adds orig tuple checking and context
> recovery; NAT interactions are factored in.
> Orig tuple support exists to better handle policy
> changes.
>
> Signed-off-by: Darrell Ball
> ---
> lib/conntrack.c | 69
Thanks for doing this
Acked-by: Daniele Di Proietto
2017-03-24 2:15 GMT-07:00 Darrell Ball :
> Signed-off-by: Darrell Ball
> Acked-by: Flavio Leitner
> ---
> lib/conntrack.c | 58
>
Thanks!
Applied to master, branch-2.7 and branch-2.6
2017-04-21 6:38 GMT-07:00 Timothy Redaelli :
> Sometimes the test fails since dpif-netdev may process the 2 packets
> in the "wrong" order.
>
> This commit avoids the problem by printing (monitor) and verifying
> any
You took it wrong. :) Even killing the pid with monitoring process running
also doesn't bring it up. Yes, to of-course humans do mistake so we better
can handle it via respawn which is what I am trying to convey. So was
thinking, can we add that feature in current code base too as an additional
You killed the monitor process, of course it couldn't revive the
monitored process.
If you have people going around killing processes without thinking,
that's your problem.
On Sat, Apr 29, 2017 at 12:59:50PM -0700, Aliasgar Mikail Ginwala wrote:
> Same is reproducible using SIGABRT (kill -6)
>
Same is reproducible using SIGABRT (kill -6)
ps aux | grep ovn-controller
root 927884 0.0 0.0 26792 956 ?S wrote:
> Please read the ovs-vswitchd manpage. It says:
>
>--monitor
> Creates an additional process to monitor the ovs-vswitchd
> dae‐
>
Please read the ovs-vswitchd manpage. It says:
--monitor
Creates an additional process to monitor the ovs-vswitchd dae‐
mon. If the daemon dies due to a signal that indicates a pro‐
gramming error (SIGABRT, SIGALRM, SIGBUS, SIGFPE, SIGILL,
When you say that ovn-controller crashed, what do you mean? Do you mean
that you killed it? Which process, and how did you kill it?
On Fri, Apr 28, 2017 at 10:51:04PM -0700, Aliasgar Mikail Ginwala wrote:
> Yes:
>
> ps aux | grep controller
> root 3639845 0.0 0.0 26792 952 ?S
Under Linux, when users create bridge named "default" or "all", although
ovs-vsctl fails but vswitchd in the background will keep retrying it,
causing the systemd-udev to reach 100% cpu utilization. The patch prevents
any attempt to create or open a netdev named "default" or "all" because
these
Footnote reference 5, 8, and 9 are not referenced in the windws.rst content,
causing the following error:
Warning, treated as error:
/root/ovs/Documentation/topics/windows.rst:506:Footnote [5] is not referenced.
Signed-off-by: William Tu
---
Documentation/topics/windows.rst
12 matches
Mail list logo