Re: [ovs-dev] [PATCH] ovn.at: Fix "ovn -- 1 LR with distributed router gateway port" test

2017-05-01 Thread Takashi YAMAMOTO
On Tue, May 2, 2017 at 5:21 AM, Ben Pfaff wrote: > On Fri, Apr 21, 2017 at 10:32:57AM +0900, YAMAMOTO Takashi wrote: > > NetBSD implementation of wc command outputs extra whitespaces > > like the following. Tweak the test to success on such environments. > > > > % echo hoge|wc

Re: [ovs-dev] [PATCH 23/27] ovn-trace: Add some basic tracing for ct_snat and ct_dnat actions.

2017-05-01 Thread Mickey Spiegel
On Mon, May 1, 2017 at 5:12 PM, Ben Pfaff wrote: > On Mon, May 01, 2017 at 03:39:32PM -0700, Mickey Spiegel wrote: > > On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff wrote: > > > > > Without this support, ovn-trace is not very useful with OpenStack, > which > > > uses

Re: [ovs-dev] [PATCH v2] Avoid update probe interval to non-zero for unix socket.

2017-05-01 Thread Han Zhou
On Mon, May 1, 2017 at 11:19 AM, Ben Pfaff wrote: > > On Tue, Apr 18, 2017 at 11:12:14AM -0700, Han Zhou wrote: > > In commit c1bfdd9d it disables probe when not needed, but commit > > 715038b6 updates ovn-controller probe interval for OVNSB DB > > periodically according to

Re: [ovs-dev] [PATCH 23/27] ovn-trace: Add some basic tracing for ct_snat and ct_dnat actions.

2017-05-01 Thread Ben Pfaff
On Mon, May 01, 2017 at 03:39:32PM -0700, Mickey Spiegel wrote: > On Sun, Apr 30, 2017 at 4:22 PM, Ben Pfaff wrote: > > > Without this support, ovn-trace is not very useful with OpenStack, which > > uses connection tracking extensively. > > > > I scanned the patch set briefly, not

Re: [ovs-dev] [PATCH v2 0/6] Add OVS DPDK keep-alive functionality

2017-05-01 Thread Ben Pfaff
On Mon, May 01, 2017 at 10:55:55PM +, Bodireddy, Bhanuprakash wrote: > >> > This patch is aimed at achieving Fastpath Service Assurance in > >> > OVS-DPDK deployments. This commit adds support for monitoring the > >> > packet processing cores(pmd thread cores) by dispatching heartbeats > >> >

Re: [ovs-dev] [PATCH v2 0/6] Add OVS DPDK keep-alive functionality

2017-05-01 Thread Bodireddy, Bhanuprakash
>There two ways to go with the design. > >1) Make it generic, so that it is not so PMD specific, as it is now. >2) If it stays PMD specific, make it stronger; right now, the health check is >limited – it detects that a PMD thread is proceeding or not. >For something like DPDK, I don’t think that

Re: [ovs-dev] [PATCH v2 0/6] Add OVS DPDK keep-alive functionality

2017-05-01 Thread Bodireddy, Bhanuprakash
>> > This patch is aimed at achieving Fastpath Service Assurance in >> > OVS-DPDK deployments. This commit adds support for monitoring the >> > packet processing cores(pmd thread cores) by dispatching heartbeats >> > at regular intervals. Incase of heartbeat miss the failure shall be >> > detected

Re: [ovs-dev] [PATCH v2 1/3] ovsdb: add xml equivalents of remote man page fragments

2017-05-01 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Lance Richardson" > Cc: d...@openvswitch.org > Sent: Monday, 1 May, 2017 5:57:43 PM > Subject: Re: [ovs-dev] [PATCH v2 1/3] ovsdb: add xml equivalents of remote > man page fragments > > On Mon, Apr 24, 2017 at 02:57:11PM -0400,

Re: [ovs-dev] [PATCH 2/2] ovn-controller: add quiet mode

2017-05-01 Thread Han Zhou
On Mon, May 1, 2017 at 2:44 PM, Ben Pfaff wrote: > > On Fri, Apr 21, 2017 at 06:55:28PM -0700, Han Zhou wrote: > > As discussed in [1], what the incremental processing code > > actually accomplished was that the ovn-controller would > > be "quiet" and not burn CPU when things

Re: [ovs-dev] [PATCH v2 1/3] ovsdb: add xml equivalents of remote man page fragments

2017-05-01 Thread Ben Pfaff
On Mon, Apr 24, 2017 at 02:57:11PM -0400, Lance Richardson wrote: > Add XML equivalents for remote-active.man and remote-passive.man > for inclusion by man pages using XML format. > > Signed-off-by: Lance Richardson Thanks a lot! I really appreciate updating the

Re: [ovs-dev] [PATCH] docs: Add some detail about dpdk-socket-mem.

2017-05-01 Thread Ben Pfaff
On Tue, Apr 25, 2017 at 02:06:25PM +0100, Kevin Traynor wrote: > On 04/24/2017 07:50 PM, Ben Pfaff wrote: > > On Mon, Apr 24, 2017 at 06:48:34PM +0100, Kevin Traynor wrote: > >> Using dpdk-socket-mem to allocate memory for some NUMA nodes > >> but leaving blank for subsequent ones is equivalent of

Re: [ovs-dev] [PATCH branch-2.6] docs: Add some detail about dpdk-socket-mem.

2017-05-01 Thread Ben Pfaff
On Tue, Apr 25, 2017 at 02:04:44PM +0100, Kevin Traynor wrote: > Using dpdk-socket-mem to allocate memory for some NUMA nodes > but leaving blank for subsequent ones is equivalent of assigning > 0 MB memory to those subsequent nodes. Document this behavior. > > Signed-off-by: Kevin Traynor

Re: [ovs-dev] [PATCH] ovn: Document limitation in the L3HA plan

2017-05-01 Thread Ben Pfaff
On Mon, Apr 24, 2017 at 10:21:18AM +0200, majop...@redhat.com wrote: > From: Miguel Angel Ajo > > The intergateway monitoring covers host failure well, but > it doesn't cover path failure which is a more complicated > problem. > > By this change I don't mean we should

Re: [ovs-dev] [PATCH 2/2] ovn-controller: add quiet mode

2017-05-01 Thread Ben Pfaff
On Fri, Apr 21, 2017 at 06:55:28PM -0700, Han Zhou wrote: > As discussed in [1], what the incremental processing code > actually accomplished was that the ovn-controller would > be "quiet" and not burn CPU when things weren't changing. > This patch set recreates this state by calculating whether >

Re: [ovs-dev] [PATCH 1/2] ovn-controller: Avoid recomputing when there are in-flight msgs.

2017-05-01 Thread Ben Pfaff
On Fri, Apr 21, 2017 at 06:55:27PM -0700, Han Zhou wrote: > When there are in-flight msgs being sent to OVS, ofctrl_put will > skip, which makes all the flows computed in that main loop > iteration useless. To avoid the wasted CPU cycles, a check is added > before lflow/physical flow run in each

Re: [ovs-dev] Cover letters (was Re: [PATCH 0/7] Add OVS DPDK keep-alive functionality)

2017-05-01 Thread Ben Pfaff
On Mon, May 01, 2017 at 04:45:56PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > ... > > I think it'd be even better to include measurements in one of the commit > > messages, because those are available in the repository after the > > patches are applied. It's harder to find

Re: [ovs-dev] [PATCH v4 7/7] checkpatch: fix pointer declaration

2017-05-01 Thread Ben Pfaff
On Mon, May 01, 2017 at 04:39:30PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Mon, May 01, 2017 at 04:14:09PM -0400, Aaron Conole wrote: > >> A common way of expressing 'raise to the power of' when authoring > >> comments uses **. This is currently getting caught by

Re: [ovs-dev] [PATCH v2 0/6] Add OVS DPDK keep-alive functionality

2017-05-01 Thread Ben Pfaff
On Thu, Apr 27, 2017 at 05:18:04PM -0400, Aaron Conole wrote: > Bhanuprakash Bodireddy writes: > > > This patch is aimed at achieving Fastpath Service Assurance in > > OVS-DPDK deployments. This commit adds support for monitoring the packet > > processing

[ovs-dev] Cover letters (was Re: [PATCH 0/7] Add OVS DPDK keep-alive functionality)

2017-05-01 Thread Aaron Conole
Hi Ben, Ben Pfaff writes: ... > I think it'd be even better to include measurements in one of the commit > messages, because those are available in the repository after the > patches are applied. It's harder to find cover letters because they're > only on the mailing list. One

Re: [ovs-dev] [PATCH] ovn-controller: Remove ct_zones from lflow_run.

2017-05-01 Thread Ben Pfaff
On Wed, Apr 26, 2017 at 10:38:08AM -0700, Han Zhou wrote: > ct_zones is not really used in lflow_run, so remove the dependency. > > Signed-off-by: Han Zhou Thanks for noticing! I wonder how this came about. I applied this to master.

Re: [ovs-dev] [PATCH v4 7/7] checkpatch: fix pointer declaration

2017-05-01 Thread Aaron Conole
Ben Pfaff writes: > On Mon, May 01, 2017 at 04:14:09PM -0400, Aaron Conole wrote: >> A common way of expressing 'raise to the power of' when authoring >> comments uses **. This is currently getting caught by the pointer >> spacing warning. So, catch it here. >> >> Reported-by:

Re: [ovs-dev] [PATCH v4 7/7] checkpatch: fix pointer declaration

2017-05-01 Thread Ben Pfaff
On Mon, May 01, 2017 at 04:14:09PM -0400, Aaron Conole wrote: > A common way of expressing 'raise to the power of' when authoring > comments uses **. This is currently getting caught by the pointer > spacing warning. So, catch it here. > > Reported-by: Lance Richardson >

Re: [ovs-dev] [PATCH v4 3/7] checkpatch: move the checks to the framework

2017-05-01 Thread Ben Pfaff
On Mon, May 01, 2017 at 04:14:05PM -0400, Aaron Conole wrote: > All of the checks are now part of the new 'check' framework. > > Signed-off-by: Aaron Conole > --- > utilities/checkpatch.py | 41 ++--- > 1 file changed, 26 insertions(+), 15

Re: [ovs-dev] [PATCH v3 1/7] checkpatch: introduce a flexible framework

2017-05-01 Thread Ben Pfaff
On Mon, May 01, 2017 at 04:01:12PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Mon, May 01, 2017 at 03:44:37PM -0400, Aaron Conole wrote: > >> Developers wishing to add checks to checkpatch sift through an adhoc mess, > >> currently. The process goes something like: >

Re: [ovs-dev] [PATCH] ovn.at: Fix "ovn -- 1 LR with distributed router gateway port" test

2017-05-01 Thread Ben Pfaff
On Fri, Apr 21, 2017 at 10:32:57AM +0900, YAMAMOTO Takashi wrote: > NetBSD implementation of wc command outputs extra whitespaces > like the following. Tweak the test to success on such environments. > > % echo hoge|wc -l|hexdump -C > 20 20 20 20 20 20 20 31 0a

[ovs-dev] [PATCH v4 7/7] checkpatch: fix pointer declaration

2017-05-01 Thread Aaron Conole
A common way of expressing 'raise to the power of' when authoring comments uses **. This is currently getting caught by the pointer spacing warning. So, catch it here. Reported-by: Lance Richardson Signed-off-by: Aaron Conole ---

[ovs-dev] [PATCH v4 6/7] checkpatch: filename from hunks fix

2017-05-01 Thread Aaron Conole
Filenames that come from the hunks match include the git-ified 'b/' prefix, which makes jumping to the error file that much harder. This patch corrects that by simply skipping those bytes. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 2 +- 1 file changed, 1

[ovs-dev] [PATCH v4 5/7] checkpatch: print conformance

2017-05-01 Thread Aaron Conole
Other utilities (notoriously the linux kernel's checkpatch.pl) have a more standardized form for printing file and lines. With this change, the template used to print gains two enhancements: 1. Color 2. Conformance with the kernel's version of checkpatch.pl Signed-off-by: Aaron Conole

[ovs-dev] [PATCH v4 4/7] checkpatch: correct a parsing issue

2017-05-01 Thread Aaron Conole
Occasionally, characters will be sent which violate the ascii decoder's sense of propriety. In fact, in-tree there are a few such files (ex: tests/atlocal.in), and they cause an exception to be raised when they are encountered. Set the policy to ignore these cases. This means these bytes are

[ovs-dev] [PATCH v4 3/7] checkpatch: move the checks to the framework

2017-05-01 Thread Aaron Conole
All of the checks are now part of the new 'check' framework. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 41 ++--- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/utilities/checkpatch.py

[ovs-dev] [PATCH v4 2/7] checkpatch: common print_line

2017-05-01 Thread Aaron Conole
With the new framework, print_line can be moved out to the checks framework. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index

[ovs-dev] [PATCH v4 1/7] checkpatch: introduce a flexible framework

2017-05-01 Thread Aaron Conole
Developers wishing to add checks to checkpatch sift through an adhoc mess, currently. The process goes something like: 1. Figure out what to test in the patch 2. Write some code, quickly, that checks for that condition 3. Look through the statemachine to find where the check should go 4. ignore

[ovs-dev] [PATCH v4 0/7] checkpatch: enhancements

2017-05-01 Thread Aaron Conole
The following series refactors checkpatch to make file-type specific checks. This lets checkpatch have finer grained checks, and should reduce the amount of false positives. Additionally, I've incorporated an older request to print files in the more standard `filename:lineno: ` form that most

Re: [ovs-dev] [PATCH 2/2] revalidator: Fix logging of xlate_key() failure.

2017-05-01 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On May 1, 2017, at 12:58 PM, Joe Stringer wrote: > > This was being logged using xlate_strerror(), but the return code is > actually an errno code. Use ovs_strerror() instead. > > Fixes: dd0dc9eda0e0 ("revalidator: Reuse xlate_ukey from

Re: [ovs-dev] [PATCH 1/2] revalidator: Revalidate ukeys created from flows.

2017-05-01 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme > On May 1, 2017, at 12:58 PM, Joe Stringer wrote: > > If there is no active ukey for a particular datapath flow, and it is > dumped from the datapath, then the revalidator threads will assemble a > ukey based on the datapath flow. This

Re: [ovs-dev] [PATCH v3 1/7] checkpatch: introduce a flexible framework

2017-05-01 Thread Aaron Conole
Ben Pfaff writes: > On Mon, May 01, 2017 at 03:44:37PM -0400, Aaron Conole wrote: >> Developers wishing to add checks to checkpatch sift through an adhoc mess, >> currently. The process goes something like: >> 1. Figure out what to test in the patch >> 2. Write some code, quickly,

[ovs-dev] [PATCH 2/2] revalidator: Fix logging of xlate_key() failure.

2017-05-01 Thread Joe Stringer
This was being logged using xlate_strerror(), but the return code is actually an errno code. Use ovs_strerror() instead. Fixes: dd0dc9eda0e0 ("revalidator: Reuse xlate_ukey from deletion.") Signed-off-by: Joe Stringer --- ofproto/ofproto-dpif-upcall.c | 4 ++-- 1 file changed, 2

Re: [ovs-dev] [PATCH v3 1/7] checkpatch: introduce a flexible framework

2017-05-01 Thread Ben Pfaff
On Mon, May 01, 2017 at 03:44:37PM -0400, Aaron Conole wrote: > Developers wishing to add checks to checkpatch sift through an adhoc mess, > currently. The process goes something like: > 1. Figure out what to test in the patch > 2. Write some code, quickly, that checks for that condition > 3.

[ovs-dev] Urgent

2017-05-01 Thread Anoopam Dadiala
Corresponding Business Partnership needed. Kindly get back to me urgently. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v3 7/7] checkpatch: fix pointer declaration

2017-05-01 Thread Aaron Conole
A common way of expressing 'raise to the power of' when authoring comments uses **. This is currently getting caught by the pointer spacing warning. So, catch it here. Reported-by: Lance Richardson Signed-off-by: Aaron Conole ---

[ovs-dev] [PATCH v3 6/7] checkpatch: filename from hunks fix

2017-05-01 Thread Aaron Conole
Filenames that come from the hunks match include the git-ified 'b/' prefix, which makes jumping to the error file that much harder. This patch corrects that by simply skipping those bytes. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 2 +- 1 file changed, 1

[ovs-dev] [PATCH v3 5/7] checkpatch: print conformance

2017-05-01 Thread Aaron Conole
Other utilities (notoriously the linux kernel's checkpatch.pl) have a more standardized form for printing file and lines. With this change, the template used to print gains two enhancements: 1. Color 2. Conformance with the kernel's version of checkpatch.pl Signed-off-by: Aaron Conole

[ovs-dev] [PATCH v3 4/7] checkpatch: correct a parsing issue

2017-05-01 Thread Aaron Conole
Occasionally, characters will be sent which violate the ascii decoder's sense of propriety. In fact, in-tree there are a few such files (ex: tests/atlocal.in), and they cause an exception to be raised when they are encountered. Set the policy to ignore these cases. This means these bytes are

[ovs-dev] [PATCH v3 3/7] checkpatch: move the checks to the framework

2017-05-01 Thread Aaron Conole
All of the checks are now part of the new 'check' framework. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 41 ++--- 1 file changed, 26 insertions(+), 15 deletions(-) diff --git a/utilities/checkpatch.py

[ovs-dev] [PATCH v3 2/7] checkpatch: common print_line

2017-05-01 Thread Aaron Conole
With the new framework, print_line can be moved out to the checks framework. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index

[ovs-dev] [PATCH v3 1/7] checkpatch: introduce a flexible framework

2017-05-01 Thread Aaron Conole
Developers wishing to add checks to checkpatch sift through an adhoc mess, currently. The process goes something like: 1. Figure out what to test in the patch 2. Write some code, quickly, that checks for that condition 3. Look through the statemachine to find where the check should go 4. ignore

[ovs-dev] [PATCH v3 0/7] checkpatch: enhancements

2017-05-01 Thread Aaron Conole
The following series refactors checkpatch to make file-type specific checks. This lets checkpatch have finer grained checks, and should reduce the amount of false positives. Additionally, I've incorporated an older request to print files in the more standard `filename:lineno: ` form that most

Re: [ovs-dev] [PATCH v2] ofproto-dpif-ipfix: total counters.

2017-05-01 Thread Ben Pfaff
On Thu, Apr 20, 2017 at 03:25:13PM +0100, mweglicx wrote: > Implementation of IPFix counters which hold > total values measured since metering process startup. > > v2: Patch is reapplied for a review because > it hasn't been correctly marked in patchwork. > > Signed-off-by: Michal Weglicki

Re: [ovs-dev] [PATCH v2 0/8] checkpatch: enhancements

2017-05-01 Thread Aaron Conole
Ben Pfaff writes: > On Wed, Apr 26, 2017 at 11:54:52AM -0400, Aaron Conole wrote: >> The following series refactors checkpatch to make >> file-type specific checks. This lets checkpatch have >> finer grained checks, and should reduce the amount >> of false positives. >> >>

Re: [ovs-dev] [patch_v7 2/9] dpdk: Remove batch sorting in userspace conntrack.

2017-05-01 Thread Darrell Ball
Thanks for pointing that out; it was on my todo list from before and I forgot about it. On 5/1/17, 10:54 AM, "ovs-dev-boun...@openvswitch.org on behalf of Jarno Rajahalme" wrote: Would be nice to have a commit message, with the

Re: [ovs-dev] [patch_v0 0/3] OF1.5-EXT-334: Extensible Flow Entry Statistics Implementation

2017-05-01 Thread Ben Pfaff
On Thu, Apr 20, 2017 at 05:46:58PM +0530, Satyavalli Rama wrote: > OpenFlow 1.5 introduces the Extensible Statistics (OXS) by redefining the > existing flow entry statistics with OXS Fields. > This Patch provide implementation for OXS fields encoding in TLV format. Thanks a lot for working on

Re: [ovs-dev] [PATCH v2] Avoid update probe interval to non-zero for unix socket.

2017-05-01 Thread Ben Pfaff
On Tue, Apr 18, 2017 at 11:12:14AM -0700, Han Zhou wrote: > In commit c1bfdd9d it disables probe when not needed, but commit > 715038b6 updates ovn-controller probe interval for OVNSB DB > periodically according to ovn-remote-probe-interval config, and sets > it to DEFAULT_PROBE_INTERVAL_MSEC if

Re: [ovs-dev] [PATCH v2 1/2] install-doc: suggest to use ovs-ctl for start/stop

2017-05-01 Thread Ben Pfaff
On Mon, May 01, 2017 at 01:51:35PM -0400, Aaron Conole wrote: > Ben Pfaff writes: > > > On Mon, Apr 17, 2017 at 01:59:49PM -0400, Aaron Conole wrote: > >> The install documentation guided users to manually start/stop > >> daemons. This is good information to have, but with the >

Re: [ovs-dev] [PATCH v2 0/8] checkpatch: enhancements

2017-05-01 Thread Ben Pfaff
On Wed, Apr 26, 2017 at 11:54:52AM -0400, Aaron Conole wrote: > The following series refactors checkpatch to make > file-type specific checks. This lets checkpatch have > finer grained checks, and should reduce the amount > of false positives. > > Additionally, I've incorporated an older request

Re: [ovs-dev] [PATCH v3 0/7] create tunnel devices using rtnetlink interface

2017-05-01 Thread Eric Garver
On Thu, Apr 27, 2017 at 02:36:18PM -0700, Joe Stringer wrote: > On 13 April 2017 at 13:47, Eric Garver wrote: > > This series adds support for the creation of tunnels using the rtnetlink > > interface. This will open the possibility for new features and flags on > > those > >

[ovs-dev] Bug#860479: Bug#860479: openvswitch-datapath-dkms (and openvswitch-datapath-source) fail compiling on fresh install of 7.11

2017-05-01 Thread Ben Pfaff
On Mon, Apr 17, 2017 at 07:04:12PM +0300, Bogdan Ilisei wrote: > Package: openvswitch-datapath-dkms > Version: 1.4.2+git20120612-9.1~deb7u1.1 > Severity: grave > Justification: renders package unusable > > Dear Maintainer, > > Installing openvswitch-datapath-dkms (OR openvswitch-datapath-source)

Re: [ovs-dev] [patch_v7 2/9] dpdk: Remove batch sorting in userspace conntrack.

2017-05-01 Thread Jarno Rajahalme
Would be nice to have a commit message, with the motivation for the change. Jarno > On Mar 24, 2017, at 2:15 AM, Darrell Ball wrote: > > Signed-off-by: Darrell Ball > Acked-by: Flavio Leitner > --- > lib/conntrack.c | 58

Re: [ovs-dev] [PATCH v2 1/2] install-doc: suggest to use ovs-ctl for start/stop

2017-05-01 Thread Aaron Conole
Ben Pfaff writes: > On Mon, Apr 17, 2017 at 01:59:49PM -0400, Aaron Conole wrote: >> The install documentation guided users to manually start/stop >> daemons. This is good information to have, but with the >> existence of ovs-ctl, is probably not the best way to start >> guiding

Re: [ovs-dev] [PATCH v2 1/2] install-doc: suggest to use ovs-ctl for start/stop

2017-05-01 Thread Ben Pfaff
On Mon, Apr 17, 2017 at 01:59:49PM -0400, Aaron Conole wrote: > The install documentation guided users to manually start/stop > daemons. This is good information to have, but with the > existence of ovs-ctl, is probably not the best way to start > guiding new users of ovs. > > Suggest that users

Re: [ovs-dev] [PATCH] OpenFlow: Enable OpenFlow 1.4 by default.

2017-05-01 Thread Ben Pfaff
Thank you! I applied this to master. On Thu, Apr 27, 2017 at 09:56:45AM -0700, Yi-Hung Wei wrote: > Thanks for the patch. I cross-check this patch with 6dc5374435cc > ("Enable OpenFlow 1.0, 1.1, 1.2, and 1.3 by default."). It LGTM. > > Acked-by: Yi-Hung Wei > > On Mon,

Re: [ovs-dev] [PATCH] configure: Fix check for rte_config.h to handle cross-compilation.

2017-05-01 Thread Ben Pfaff
Hemant, does this fix the problem you reported? On Fri, Apr 14, 2017 at 09:14:55PM -0700, Ben Pfaff wrote: > The check for rte_config.h in acinclude.m4 used AC_CHECK_FILE, but this > macro is intended to check for a file on the host system, not the build > system, which means that it fails

Re: [ovs-dev] [PATCHv2] bridge: Prohibit "default" and "all" bridge name.

2017-05-01 Thread Ben Pfaff
On Sat, Apr 29, 2017 at 06:30:59AM -0700, William Tu wrote: > Under Linux, when users create bridge named "default" or "all", although > ovs-vsctl fails but vswitchd in the background will keep retrying it, > causing the systemd-udev to reach 100% cpu utilization. The patch prevents > any attempt

[ovs-dev] flake8 checking for release branches

2017-05-01 Thread Ben Pfaff
There's a bit of a problem with flake8 and release branches. The release branches mainly stay the same, but flake8 marches on, and the result is that building an old branch, e.g. branch-2.6, with modern flake8 causes errors that break the build. I can think of several ways to deal with this:

[ovs-dev] [PATCH v4 5/5] system-traffic: Add test for mpls actions

2017-05-01 Thread Yi-Hung Wei
Add ping test to verify the behavior of mpls_push/pop actions. In this test, we use the resubmit action to trigger recirulation for making sure the flow key is revalidated after mpls_push/pop. This test depends on commit 5ba0c107c51e ("datapath: Fix ovs_flow_key_update()") to behave correctly.

[ovs-dev] [PATCH v4 4/5] datapath: Fix ovs_flow_key_update()

2017-05-01 Thread Yi-Hung Wei
Upstream commit: commit 6f56f6186c18e3fd54122b73da68e870687b8c59 Author: Yi-Hung Wei Date: Thu Mar 30 12:36:03 2017 -0700 ovs_flow_key_update() is called when the flow key is invalid, and it is used to update and revalidate the flow key. Commit

[ovs-dev] [PATCH v4 3/5] datapath: correctly fragment packet with mpls headers

2017-05-01 Thread Yi-Hung Wei
Upstream commit: commit c66549ffd05831abf6cf19ce0571ad868e39 Author: Jiri Benc Date: Wed Oct 5 15:01:57 2016 +0200 openvswitch: correctly fragment packet with mpls headers If mpls headers were pushed to a defragmented packet, the refragmentation no

[ovs-dev] [PATCH v4 2/5] datapath: set network header correctly on key extract

2017-05-01 Thread Yi-Hung Wei
Upstream commit: commit f7d49bce8e741e1e6aa14ce4db1b6cea7e4be4e8 Author: Jiri Benc Date: Fri Sep 30 19:08:05 2016 +0200 openvswitch: mpls: set network header correctly on key extract After the 48d2ab609b6b ("net: mpls: Fixups for GSO"), MPLS handling in

Re: [ovs-dev] [PATCH v3 1/5] datapath: Fixups for MPLS GSO

2017-05-01 Thread Yi-Hung Wei
Sure, I will rebase the patch set and post the v4. Thanks, -Yi-Hung On Mon, May 1, 2017 at 3:42 AM, Simon Horman wrote: > Hi Yi-Hung, > > I'm having a little trouble following the status of this patchset. > Would it be possible to repost v3 (or post v4 if that is

[ovs-dev] [PATCH v4 1/5] datapath: Fixups for MPLS GSO

2017-05-01 Thread Yi-Hung Wei
This patch backports the following two upstream commits to fix MPLS GSO in ovs datapath. Starting from upstream commit 48d2ab609b6b ("net: mpls: Fixups for GSO"), the mpls_gso kernel module relies on the fact that skb_network_header() points to the mpls header and skb_inner_network_header() points

[ovs-dev] [PATCH v4 0/5] Backport upstream mpls fix

2017-05-01 Thread Yi-Hung Wei
This series backports the upstream mpls fixes and add a system traffic test for mpls actions. v2: - rebase to master - seperate the first patch to 3 patches v3: - rebase to master - rename HAVE_MPLS_HDR to MPLS_HEADER_IS_L3 - add comments about the mpls_hdr() backport v4: - rebase

Re: [ovs-dev] [PATCH] travis: Break Mac OS build for format specifier warnings.

2017-05-01 Thread Ben Pfaff
Thanks! Applied to master. On Fri, Apr 28, 2017 at 04:50:30PM -0700, Jarno Rajahalme wrote: > Acked-by: Jarno Rajahalme > > > On Mar 20, 2017, at 10:10 PM, Ben Pfaff wrote: > > > > Until now, the Travis build for Mac OS X has been configured to ignore > > format

Re: [ovs-dev] [PATCH] ofp-actions: Document that learn(limit=0) is no limit.

2017-05-01 Thread Joe Stringer
On 28 April 2017 at 17:02, Jarno Rajahalme wrote: > A commit message would be nice. > > Acked-by: Jarno Rajahalme Thanks, I wrote a commit message and applied to master. ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH 6/6] ovn-sbctl: support setting rbac role for remote connections

2017-05-01 Thread Lance Richardson
Add support for specifying rbac "role" when setting remote connection configuration in the southbound database. Prior to this change, usage examples included: ovn-sbctl set-connection ptcp:6642 ovn-sbctl set-connection pssl:6642 \ read-only ptcp: \

[ovs-dev] [PATCH 5/6] ovn: add rbac tables to ovn southbound schema

2017-05-01 Thread Lance Richardson
Add rbac "roles" and "permissions" tables to ovn southbound database schema, add support to ovn-northd for managing these tables. Signed-off-by: Lance Richardson --- ovn/northd/ovn-northd.c| 190 + ovn/ovn-architecture.7.xml |

[ovs-dev] [PATCH 4/6] ovsdb: add support for role-based access controls

2017-05-01 Thread Lance Richardson
Add suport for ovsdb RBAC (role-based access control). This includes: - Support for "RBAC_Role" table. A db schema containing a table by this name will enable role-based access controls using this table for RBAC role configuration. The "RBAC_Role" table has one row per role,

[ovs-dev] [PATCH 3/6] ovs-pki: add option to suppress generated id in common name

2017-05-01 Thread Lance Richardson
For some applications, it is desirable to have full control of the common name field in generated certificates. Add a command-line option to suppress appending " id:" to the user- specified name. Signed-off-by: Lance Richardson --- utilities/ovs-pki.8.in | 9 +

[ovs-dev] [PATCH 2/6] ovsdb: refactor utility functions into separate file

2017-05-01 Thread Lance Richardson
Move local db access functions to a new file and make give them global scope so they can be included in the ovsdb library and used by other ovsdb library functions. Signed-off-by: Lance Richardson --- ovsdb/automake.mk| 4 +- ovsdb/ovsdb-server.c | 187

[ovs-dev] [PATCH 1/6] stream: store stream peer id with stream state

2017-05-01 Thread Lance Richardson
Track authenticated stream peer ID. For SSL connections, the authenticated ID is the CN (Common Name) field extracted from the peer's SSL certificate. Signed-off-by: Lance Richardson --- lib/stream-provider.h | 1 + lib/stream-ssl.c | 44

[ovs-dev] [PATCH 0/6] role-based access controls for ovsdb-server, ovn-sb

2017-05-01 Thread Lance Richardson
This series implements role-based access control infrastructure for ovsdb-server, and uses that infrastructure to apply role-based access controls to the OVN_Southbound database. This implementation follows the outline discussed at:

Re: [ovs-dev] [PATCH v3 1/5] datapath: Fixups for MPLS GSO

2017-05-01 Thread Simon Horman
Hi Yi-Hung, I'm having a little trouble following the status of this patchset. Would it be possible to repost v3 (or post v4 if that is pending) with: * A cover letter including: - An overview of the patchset - An overview of the changes between v2 and v3 (and v4 is there is one).