[ovs-dev] ovs-dpdk 2.8.0 add-meter problem

2017-09-13 Thread wenxu
Hi all, I build a ovs-dpdk 2.8 and try to add a meter to br0. But get NXBRC_UNENCODABLE_ERROR # ovs-ofctl -O OpenFlow13 add-meter br0 'meter=1 pktps burst stats bands=type=drop rate=1 burst_size=1' OFPT_ERROR (OF1.3) (xid=0x2): NXBRC_UNENCODABLE_ERROR OFPT_METER_MOD (OF1.3) (xid=0x2): ADD

Re: [ovs-dev] [v2] bridge: Fix controller status update to passive connections

2017-09-13 Thread Joe Stringer
On 13 September 2017 at 13:05, Andy Zhou wrote: > The bug can cause ovs-vswitchd to crash (due to assert) when it is > set up with a passive controller connection. Since only active > connections are kept, the passive connection status update should be > ignored and not trigger

Re: [ovs-dev] [PATCH v2 8/8] netdev-dpdk: set FDIR config

2017-09-13 Thread Yuanhan Liu
On Wed, Sep 13, 2017 at 01:57:22AM +, Darrell Ball wrote: > > > On 9/11/17, 1:14 AM, "ovs-dev-boun...@openvswitch.org on behalf of Finn > Christensen" > wrote: > > -Original Message- > From:

Re: [ovs-dev] [PATCH v2 2/8] dpif-netdev: retrieve flow directly from the flow mark

2017-09-13 Thread Yuanhan Liu
On Wed, Sep 13, 2017 at 05:20:58AM +, Darrell Ball wrote: > > > On 9/5/17, 2:23 AM, "Yuanhan Liu" wrote: > > So that we could skip the heavy emc processing, notably, the > miniflow_extract function. A simple PHY-PHY forwarding testing > shows 53%

[ovs-dev] [RFC] Question about ovn-controller performance

2017-09-13 Thread wang . qianyu
I configure 5 networks, every network have about 80 ports, the total ports is 400, all in same security group. When I bind some port on HVs, the ovn-controller is always running with 100% cpu, and the total openflow table entities in ovs is more than 300,000. Most of the entities is table 52,

Re: [ovs-dev] [PATCH v2 4/8] netdev-dpdk: implement flow put with rte flow

2017-09-13 Thread Yuanhan Liu
On Wed, Sep 13, 2017 at 05:18:03AM +, Darrell Ball wrote: > +/* IP v4 */ > +uint8_t proto = 0; > +struct rte_flow_item_ipv4 ipv4_spec; > +struct rte_flow_item_ipv4 ipv4_mask; > +memset(_mask, 0, sizeof(ipv4_mask)); > +if

Re: [ovs-dev] [PATCH v2 4/8] netdev-dpdk: implement flow put with rte flow

2017-09-13 Thread Yuanhan Liu
On Wed, Sep 13, 2017 at 11:45:30AM +0200, Simon Horman wrote: > > > > +rte_memcpy(_spec.dst, >flow.dl_dst, > > sizeof(eth_spec.dst)); > > > > +rte_memcpy(_spec.src, >flow.dl_src, > > sizeof(eth_spec.src)); > > > > +eth_spec.type = match->flow.dl_type; > >

Re: [ovs-dev] [PATCH] tests/stp: Use long warps instead of multiple calls.

2017-09-13 Thread Tonghao Zhang
Thanks for your work. Tested-by: Tonghao Zhang On Wed, Sep 13, 2017 at 4:46 PM, Ilya Maximets wrote: > This change fixes constant test failure on RHEL 7 system with > CFLAGS='-march=native':

[ovs-dev] [RFC PATCH v1] docs: Add release feature roadmap.

2017-09-13 Thread Ian Stokes
Add a document to outline the roadmap of features contributors are targeting for upcoming OVS releases. Signed-off-by: Ian Stokes --- Documentation/automake.mk |1 + Documentation/faq/index.rst |1 +

Re: [ovs-dev] [PATCH] Fix C++ build issue when static_assert() is not available

2017-09-13 Thread Ben Pfaff
On Wed, Sep 13, 2017 at 01:27:09PM -0700, Ben Pfaff wrote: > On Tue, Sep 12, 2017 at 03:43:03PM -0700, Yi-Hung Wei wrote: > > This patch prevents compile errors if the C++ compiler does not support > > C++11 or the support is not enabled. > n> > > VMWare-BZ: #1953215 > > Fixes: 994bfc298502

Re: [ovs-dev] [PATCH] Fix C++ build issue when static_assert() is not available

2017-09-13 Thread Ben Pfaff
On Tue, Sep 12, 2017 at 03:43:03PM -0700, Yi-Hung Wei wrote: > This patch prevents compile errors if the C++ compiler does not support > C++11 or the support is not enabled. n> > VMWare-BZ: #1953215 > Fixes: 994bfc298502 ("Automatically verify that OVS header files work OK in > C++ also.") >

[ovs-dev] [v2] bridge: Fix controller status update to passive connections

2017-09-13 Thread Andy Zhou
The bug can cause ovs-vswitchd to crash (due to assert) when it is set up with a passive controller connection. Since only active connections are kept, the passive connection status update should be ignored and not trigger asserts. Fixes: 85c55772a453 ("bridge: Fix controller status update")

Re: [ovs-dev] [PATCH v4 3/7] dpif-netdev: Register packet processing cores to KA framework.

2017-09-13 Thread Aaron Conole
"Bodireddy, Bhanuprakash" writes: >>"Bodireddy, Bhanuprakash" writes: >> Bhanuprakash Bodireddy writes: > This commit registers the packet processing PMD cores to keepalive >

[ovs-dev] Jona Fishballs

2017-09-13 Thread Bonesca - Jona
  [ View in browser ]( http://r.newsletter.bonescamail.nl/7xa28ju5aoatrf.html )         Premium Quality Jona Fishball range : 5 + 1 BOX ***FREE*** PROMO!   Mixing of varieties allowed. If you did not start selling Jona fishballs yet this is a very good oportunity to buy each type 1 box

[ovs-dev] Jona Fishballs

2017-09-13 Thread Bonesca - Jona
  [ View in browser ]( http://r.newsletter.bonescamail.nl/7xa28ju5aoatrf.html )         Premium Quality Jona Fishball range : 5 + 1 BOX ***FREE*** PROMO!   Mixing of varieties allowed. If you did not start selling Jona fishballs yet this is a very good oportunity to buy each type 1 box

Re: [ovs-dev] [PATCH v2 6/8] netdev-dpdk: retry with queue action

2017-09-13 Thread Darrell Ball
On 9/13/17, 2:57 AM, "Simon Horman" wrote: On Tue, Sep 12, 2017 at 08:36:19AM +, Darrell Ball wrote: > > On 9/10/17, 11:14 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yuanhan Liu"

Re: [ovs-dev] [PATCH v4 3/7] dpif-netdev: Register packet processing cores to KA framework.

2017-09-13 Thread Bodireddy, Bhanuprakash
>"Bodireddy, Bhanuprakash" writes: > >>>Bhanuprakash Bodireddy writes: >>> This commit registers the packet processing PMD cores to keepalive framework. Only PMDs that have rxqs mapped will be registered and

Re: [ovs-dev] [PATCH v6 0/6] OVS-DPDK rxq to pmd assignment improvements.

2017-09-13 Thread Kevin Traynor
On 09/12/2017 12:09 AM, Darrell Ball wrote: > > > On 9/11/17, 12:25 PM, "Federico Iezzi" wrote: > > On Fri, Aug 25, 2017 at 10:36 AM, Darrell Ball wrote: > > I applied the series to >

Re: [ovs-dev] [PATCH V2 0/2] fix odp parsing of set masked action

2017-09-13 Thread Simon Horman
On Wed, Sep 13, 2017 at 04:57:23PM +0300, Roi Dayan wrote: > > > On 13/09/2017 16:44, Simon Horman wrote: > >On Sun, Sep 10, 2017 at 08:00:05AM +0300, Roi Dayan wrote: > >>Hi, > >> > >>The first commit is a fix for parsing set masked action > >>and the second commit is adding a test. > >> >

[ovs-dev] [PATCH V2] netdev-tc-offloads: Fix vxlan tunnel offloading

2017-09-13 Thread Roi Dayan
From: Paul Blakey This commit fixes offloading when tunnel id is 0 by checking for valid tunnel dst ipv4 or ipv6, like done in the normal flow. Also need to reset the tunnel mask outside the condition because in the special case, when adding a port with key=flow, the match

[ovs-dev] [PATCH] docs: Use DPDK 17.05.2 release.

2017-09-13 Thread Ian Stokes
Modify docs and travis linux build script to use the DPDK 17.05.2 release branch to benefit from most recent bug fixes. There are no new features introduced in the DPDK release, only back ported bug fixes. For completeness these bug fixes have been documented under the 17.05.2 section in the link

[ovs-dev] [PATCH branch-2.8] docs: Use DPDK 17.05.2 release.

2017-09-13 Thread Ian Stokes
Modify docs and travis linux build script to use the DPDK 17.05.2 release branch to benefit from most recent bug fixes. There are no new features introduced in the DPDK release, only back ported bug fixes. For completeness these bug fixes have been documented under the 17.05.2 section in the link

Re: [ovs-dev] [PATCH V2 0/2] fix odp parsing of set masked action

2017-09-13 Thread Roi Dayan
On 13/09/2017 16:44, Simon Horman wrote: On Sun, Sep 10, 2017 at 08:00:05AM +0300, Roi Dayan wrote: Hi, The first commit is a fix for parsing set masked action and the second commit is adding a test. Before the fix the addtion of the tests fails with the following: # make check

[ovs-dev] [PATCH 2/2] dpctl: init CT entry variable.

2017-09-13 Thread antonio . fischetti
ct_dpif_entry_uninit could potentially be called even if ct_dpif_dump_next failed. As ct_dpif_entry_uninit receives a pointer to a CT entry - and just checks it is not null - it's safer to init to zero any instantiated ct_dpif_entry variable before its usage. Signed-off-by: Antonio Fischetti

[ovs-dev] [PATCH 1/2] dpctl: manage ret value when dumping CT entries.

2017-09-13 Thread antonio . fischetti
Manage error value returned by ct_dpif_dump_next. Signed-off-by: Antonio Fischetti --- lib/dpctl.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/lib/dpctl.c b/lib/dpctl.c index 8951d6e..86d0f90 100644 ---

Re: [ovs-dev] [PATCH] netdev-tc-offloads: Fix offloading when tunnel id is 0

2017-09-13 Thread Roi Dayan
On 07/09/2017 19:15, Simon Horman wrote: On Tue, Aug 29, 2017 at 07:29:57AM +0300, Roi Dayan wrote: From: Paul Blakey Currently we test the tunnel id value and not the mask so matching on tunnel id 0 is skipped and we fail to offload the rule with an unknown attribute

Re: [ovs-dev] [PATCH] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2017-09-13 Thread Satyavalli Rama
Hi Ben, We have addressed all the review comments and submitted the updated patch. Kindly review it once and provide your inputs for the same. Thanks & Regards Satya Valli Tata Consultancy Services Mailto: satyavalli.r...@tcs.com Website: http://www.tcs.com

[ovs-dev] [PATCH] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2017-09-13 Thread SatyaValli
From: SatyaValli This Patch provides implementation Existing flow entry statistics are redefined as standard OXS(OpenFlow Extensible Statistics) fields for displaying the arbitrary flow stats.The existing Flow Stats were renamed as Flow Description. To support this

Re: [ovs-dev] [PATCH v2 6/8] netdev-dpdk: retry with queue action

2017-09-13 Thread Simon Horman
On Tue, Sep 12, 2017 at 08:36:19AM +, Darrell Ball wrote: > > On 9/10/17, 11:14 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yuanhan > Liu" > wrote: > > On Fri, Sep 08, 2017 at 06:48:50PM +0200, Simon Horman

Re: [ovs-dev] [PATCH v2 3/8] netdev-dpdk: convert ufid to dpdk flow

2017-09-13 Thread Simon Horman
On Mon, Sep 11, 2017 at 01:46:28PM +0800, Yuanhan Liu wrote: > On Fri, Sep 08, 2017 at 05:48:36PM +, Darrell Ball wrote: > > > > > +static inline void > > > +del_ufid_dpdk_flow_mapping(const ovs_u128 *ufid) > > > +{ > > > +struct ufid_dpdk_flow_data *data; > > > + > >

Re: [ovs-dev] [PATCH v2 4/8] netdev-dpdk: implement flow put with rte flow

2017-09-13 Thread Simon Horman
On Tue, Sep 12, 2017 at 08:34:44AM +, Darrell Ball wrote: > > > On 9/10/17, 11:11 PM, "ovs-dev-boun...@openvswitch.org on behalf of Yuanhan > Liu" > wrote: > > On Fri, Sep 08, 2017 at 06:47:55PM +0200, Simon Horman

Re: [ovs-dev] [PATCH v2 2/8] dpif-netdev: retrieve flow directly from the flow mark

2017-09-13 Thread Simon Horman
On Mon, Sep 11, 2017 at 01:37:10PM +0800, Yuanhan Liu wrote: > On Fri, Sep 08, 2017 at 05:38:07PM +, Darrell Ball wrote: > > > +static inline bool > > > +dp_packet_has_flow_mark(struct dp_packet *p OVS_UNUSED, > > > +uint32_t *mark OVS_UNUSED) > > > +{ >

Re: [ovs-dev] [PATCH v5] dpif-netdev: Avoid reading RSS hash when EMC is disabled

2017-09-13 Thread O Mahony, Billy
Hi All, It's a pity the performance gain couldn't be got without introducing the new function. But it is a clear performance gain none the less. Regards, /Billy. > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Wednesday, September 13, 2017 6:32 AM > To:

[ovs-dev] [PATCH] tests/stp: Use long warps instead of multiple calls.

2017-09-13 Thread Ilya Maximets
This change fixes constant test failure on RHEL 7 system with CFLAGS='-march=native': >---< : STP - flush the fdb and mdb when topology changed FAILED ... ./stp.at:609: ovs-appctl fdb/show br0 --- - +++

Re: [ovs-dev] [PATCH 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-09-13 Thread Stokes, Ian
> Enabled per port like so: > ovs-vsctl set Interface dpdkvhostuserclient0 options:dq-zero-copy=true > > Zero Copy can only be enabled/disabled when a vHost port is down. > > When packets from a vHost device with zero copy enabled are destined for a > 'dpdk' port, the number of tx descriptors on

[ovs-dev] [PATCH v4 2/2] rhel: Add systemd support to delete transient ports only on boot

2017-09-13 Thread Timothy Redaelli
Using the dependencies feature of systemd ovs-delete-transient-ports.service is only started once and so transient ports are only deleted only the first time after boot. Acked-by: Aaron Conole Signed-off-by: Timothy Redaelli --- rhel/automake.mk

[ovs-dev] [PATCH v4 1/2] ovs-ctl: Add delete-transient-ports command

2017-09-13 Thread Timothy Redaelli
Add a command to delete all ports that have the other_config:transient value set to true. Acked-by: Aaron Conole Signed-off-by: Timothy Redaelli --- utilities/ovs-ctl.8 | 6 ++ utilities/ovs-ctl.in | 24 ++-- 2 files changed,

[ovs-dev] [PATCH v4 0/2] Add system service to delete transient ports on boot.

2017-09-13 Thread Timothy Redaelli
Add a systemd service file that is only executed the first time ovsdb-server starts after boot and that removes all transient ports (--delete-transient-ports). This is important on certain environments where some ports are going to be recreated after reboot, but other ports need to be persisted