Correction inline:
s/committed/commented
On 9/21/17, 9:16 PM, "Darrell Ball" wrote:
Hi Guoshuai
I commented on the Version 2 patch format and requested Ben to take a look.
Thanks Darrell
On 9/21/17, 7:55 PM, "Guoshuai Li"
Hi Guoshuai
I committed on the Version 2 patch format and requested Ben to take a look.
Thanks Darrell
On 9/21/17, 7:55 PM, "Guoshuai Li" wrote:
I send a patch to change DEPTH 6, It is Ok for my cases.
Hi Guoshuai
It looks like when you committed the patch locally you missed ‘—signoff’.
A valid patch must have a signoff.
Also, it would be good to have Ben take a look at this.
Thanks Darrell
On 9/21/17, 12:32 AM, "ovs-dev-boun...@openvswitch.org on behalf of Guoshuai
Li"
I send a patch to change DEPTH 6, It is Ok for my cases.
https://mail.openvswitch.org/pipermail/ovs-dev/2017-September/339034.html
It will warning log for 7 recirc, "dpif_netdev(pmd36)|WARN|Packet
dropped. Max recirculation depth exceeded."
on 2017/9/20 23:57, Darrell Ball write:
On
The Debian packages that come with Open vSwitch do not support DPDK.
On Fri, Sep 22, 2017 at 09:33:53AM +0800, ychen wrote:
> I have read this document, but following this guide, I can not build package
> for openvswitch-switch-dpdk.
> I want to build package with our own libdpdk, and is there
I have read this document, but following this guide, I can not build package
for openvswitch-switch-dpdk.
I want to build package with our own libdpdk, and is there any guides?
At 2017-09-21 16:25:58, "Bodireddy, Bhanuprakash"
wrote:
>>we modified
For this commit, ovn-northd will now accept both IPv4 and IPv6 addresses
in the northbound database for a load balancer VIP or destination
addresses. For IPv4, the behavior remains the same. For IPv6, the
following logical flows will be added to the southbound database:
* An ND_NA response for
ovn-nbctl will now accept IPv6 addresses for load balancer VIPs and
desetination addresses.
In addition, the ovn-nbctl lb-list, lr-lb-list, and ls-lb-list have been
modified to be able to fit IPv6 addresses on screen.
Signed-off-by: Mark Michelson
---
The ct_lb action previously assumed that any address arguments were
IPv4. This patch expands the parsing, formatting, and encoding of ct_lb
to be amenable to IPv6 addresses as well.
Signed-off-by: Mark Michelson
---
include/ovn/actions.h | 6 +++-
ovn/lib/actions.c |
OVS has functions for parsing IPv4 addresses, parsing IPv4 addresses
with a port, and parsing IPv6 addresses. What is lacking though is a
function that can take an IPv4 or IPv6 address, with or without a port.
This commit adds ipv46_parse(), which breaks the given input string into
its component
This patchset adds the necessary items in order to support IPv6 load
balancers in OVN. No syntax has changed in ovn-nbctl or in the
northbound database to support this. Appropriate tests have been
added to the testsuite as well.
V1->V2:
Patch 1/4: Unchanged.
Patch 2/4: Used an anonymous union
On Thu, Sep 21, 2017 at 11:35:32PM +0530, Numan Siddique wrote:
> On Thu, Sep 21, 2017 at 11:13 PM, Ben Pfaff wrote:
>
> > On Tue, Sep 12, 2017 at 02:22:03PM +0530, nusid...@redhat.com wrote:
> > > From: Numan Siddique
> > >
> > > When a patch port is deleted
On 9/21/17, 3:19 AM, "ovs-dev-boun...@openvswitch.org on behalf of Bodireddy,
Bhanuprakash" wrote:
>Create a separate function from existing code, so the code can be reused
in a
>subsequent patch; no
On 9/21/17, 4:01 AM, "ovs-dev-boun...@openvswitch.org on behalf of Fischetti,
Antonio" wrote:
Looks a good improvement to report on an intentional exploit, or
other issues.
LGTM, just one comment. Now this
On 09/12/2017 12:49 PM, Andy Zhou wrote:
Merge native tunnel handling with patch port handling
as much as possible.
Current native tunnel handling logic inspects the generated actions
to determine if truncate has been applied to the packet. (since if
it is then recirculation should be used).
On Thu, Sep 21, 2017 at 11:13 PM, Ben Pfaff wrote:
> On Tue, Sep 12, 2017 at 02:22:03PM +0530, nusid...@redhat.com wrote:
> > From: Numan Siddique
> >
> > When a patch port is deleted from the bridge (with no other ports
> > in the bridge) and if the bridge
On 09/12/2017 12:49 PM, Andy Zhou wrote:
To patch_port_output(). The original function name does not make
much sense.
I think the commit message is a little mangled. Perhaps like this:
Rename apply_nested_clone_actions() to patch_port_output(). The
original function name does not make much
On 09/12/2017 12:49 PM, Andy Zhou wrote:
Allow xlate_table_actions() to generate actions with or without
enclosed in clone().
Signed-off-by: Andy Zhou
---
ofproto/ofproto-dpif-xlate.c | 32 +---
1 file changed, 21 insertions(+), 11 deletions(-)
On Thu, Sep 21, 2017 at 09:28:46AM -0700, Greg Rose wrote:
> On 09/19/2017 03:34 PM, Ben Pfaff wrote:
> >Without this, "man ovs-test" and "man ovs-vlan-test" won't work in the
> >sandbox.
> >
> >Signed-off-by: Ben Pfaff
> >---
> > tutorial/ovs-sandbox | 2 +-
> > 1 file changed, 1
Found by libFuzzer.
Reported-by: Bhargava Shastry
Signed-off-by: Ben Pfaff
---
lib/ofp-util.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 2309a2ad2515..16c4f191a340
Found by libFuzzer.
Reported-by: Bhargava Shastry
Signed-off-by: Ben Pfaff
---
lib/ofp-util.c | 82 ++
1 file changed, 48 insertions(+), 34 deletions(-)
diff --git a/lib/ofp-util.c
v1->v2: Add memory leak fix patch.
v2->v3: Extend memory leak fix patch.
v3->v4; Add another memory leak fix patch.
Ben Pfaff (3):
ofp-util: Fix buffer overread in ofputil_decode_bundle_add().
ofp-util: Fix memory leaks on error cases in
ofputil_decode_group_mod().
ofp-util: Fix memory
On 09/12/2017 12:49 PM, Andy Zhou wrote:
Add a new function clone_xlate_actions(), which shares the same
signature as do_xlate_actions(); Later patch will make use
of this function.
Signed-off-by: Andy Zhou
---
ofproto/ofproto-dpif-xlate.c | 20 ++--
1 file
On 09/19/2017 03:34 PM, Ben Pfaff wrote:
Without this, "man ovs-test" and "man ovs-vlan-test" won't work in the
sandbox.
Signed-off-by: Ben Pfaff
---
tutorial/ovs-sandbox | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tutorial/ovs-sandbox
From: Numan Siddique
In the router ingress pipeline, if the destination mac is unresolved
by the time the packet reaches the ARP_REQUEST stage, OVN should generate an
IPv6 Neighbor Solicitation packet to learn the MAC address. This feature is
presently missing. This patch
From: Zongkai LI
This patch adds logical flows which sends IPv6 Router Advertisement
packet in response to the IPv6 Router Solicitation request. It uses
the actions "put_nd_ra_opts" to transform the RS packet to RA packet
in the newly added ingress stage "lr_in_nd_ra_options"
From: Numan Siddique
This patch adds a new OVN action 'put_nd_ra_opts' to support native
IPv6 Router Advertisement in OVN. This action can be used to respond
to the IPv6 Router Solicitation requests.
ovn-controller parses this action and adds a NXT_PACKET_IN2 OF flow
with
From: Numan Siddique
Renamed 'struct dhcp_opts_map' to 'struct gen_opts_map' and
renamed ovn-dhcp.h to ovn-l7.h. An upcoming commit to support IPv6
Router Advertisement, will make use of the refactored code to store
the IPv6 ND RA options in 'struct gen_opts_map'.
From: Numan Siddique
v7 -> v8
Rebased p2.
v6 -> v7
In version 7, a new patch p4 is added which adds the support to generate a
Neighbor Solicitation packet for IPv6
packets whose destination MAC is still unresolved by the time it reaches the
ARP_REQUEST
On 09/21/2017 08:35 AM, Greg Rose wrote:
The final line of a conditional search for the nf_conntrack_helper_put
function does not actually define HAVE_NF_CONNTRACK_HELPER_PUT used
in datapath/linux/compat/include/net/netfilter/nf_conntrack_helper.h.
Signed-off-by: Greg Rose
From: Numan Siddique
This patch adds support for associating a load balancer to a
logical router with gateway router port which was missing earlier.
Signed-off-by: Numan Siddique
---
ovn/northd/ovn-northd.8.xml | 70 +++---
The final line of a conditional search for the nf_conntrack_helper_put
function does not actually define HAVE_NF_CONNTRACK_HELPER_PUT used
in datapath/linux/compat/include/net/netfilter/nf_conntrack_helper.h.
Signed-off-by: Greg Rose
---
acinclude.m4 | 3 ++-
1 file
Hi all,
We seriously want to pursue this kind of ingress traffic prioritization from
physical ports in OVS-DPDK for the use case I mentioned earlier: prioritization
of in-band control plane traffic running on the same physical network as the
tenant data traffic.
We have first focused on
On Thu, Sep 21, 2017 at 2:21 PM, Gao Zhenyu wrote:
> I think the S/N or E/W are not the matter we should considering now.
>
> The multipath implementation is based on the existing ovn workflows. If
> you can use route to dispatch traffics to different node/logical port,
Hi Bhanu,
"Bodireddy, Bhanuprakash" writes:
> Hi,
>
>
>
> ovs-tcpdump throws the below error when trying to capture packets on one of
> the
> vhostuserports.
>
>
>
> $ ovs-tcpdump -i dpdkvhostuser0
>
>ERROR: Please create an interface called
Userspace switch meter implementation has been added to the master and 2.8
https://github.com/openvswitch/ovs/blob/master/lib/dpif-netdev.c#L4262
But kernel meter not implementaton:
https://github.com/openvswitch/ovs/blob/master/lib/dpif-netlink.c#L2907
on 2017/9/21 19:03, Miguel Angel Ajo
Update email address.
Signed-off-by: Daniele Venturino
---
AUTHORS.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/AUTHORS.rst b/AUTHORS.rst
index 5d8b723f62..5f339b599c 100644
--- a/AUTHORS.rst
+++ b/AUTHORS.rst
@@ -93,7 +93,7 @@ Daniel
On Thu, Sep 21, 2017 at 7:01 PM, Jakub Sitnicki wrote:
> Hi Mark,
>
> On Wed, 6 Sep 2017 16:08:35 -0500
> Mark Michelson wrote:
>
> > This patchset adds the necessary items in order to support IPv6 load
> > balancers in OVN. No syntax has changed in
Hi Mark,
On Wed, 6 Sep 2017 16:08:35 -0500
Mark Michelson wrote:
> This patchset adds the necessary items in order to support IPv6 load
> balancers in OVN. No syntax has changed in ovn-nbctl or in the
> northbound database to support this. Appropriate tests have been
>
Hi,
ovs-tcpdump throws the below error when trying to capture packets on one of the
vhostuserports.
$ ovs-tcpdump -i dpdkvhostuser0
ERROR: Please create an interface called `midpdkvhostuser0`
See your OS guide for how to do this.
Ex: ip link add midpdkvhostuser0 type veth peer name
I think the S/N or E/W are not the matter we should considering now.
The multipath implementation is based on the existing ovn workflows. If you
can use route to dispatch traffics to different node/logical port, then the
multipath can make it. Otherwise it must get bug in multipath.
If the static
>From 80260a2950f10544e307d6f20cb1cfe8c9bb885f Mon Sep 17 00:00:00 2001
From: wang qianyu
Date: Thu, 21 Sep 2017 18:05:16 +0800
Subject: [PATCH] ovn: reduce logical flow applied to ovn-controller
Add a logical_port column in Logical_Flow table. If logical flow generated
Thank you, that was my doing, thanks for finding and fixing!!
On Tue, Sep 19, 2017 at 8:07 PM, Russell Bryant wrote:
> On Tue, Sep 19, 2017 at 5:49 AM, wrote:
> > op->sb->gateway_chassis[0]->chassis may null in some special cases, need
> > to add a
Makes sense. Is there any way to control the number of retries, and the
retry time?
Acked-by: Miguel Angel Ajo
On Wed, Sep 20, 2017 at 12:01 AM, Ben Pfaff wrote:
> Most of the OVS database-manipulation utilities (ovn-sbctl, ovn-nbctl,
> ovs-vsctl, vtep-ctl)
Only fix the commit message s/destroy/destroyed/g
On Thu, Sep 21, 2017 at 1:14 PM, Miguel Angel Ajo Pelayo <
majop...@redhat.com> wrote:
> Acked-by: Miguel Angel Ajo
>
> On Wed, Sep 20, 2017 at 7:57 AM, wrote:
>
>> pending_ct_zones in ovn-controller
Acked-by: Miguel Angel Ajo
On Wed, Sep 20, 2017 at 7:57 AM, wrote:
> pending_ct_zones in ovn-controller main should be destroy when exit.
>
> Signed-off-by: xu rong
>
> ---
> ovn/controller/ovn-controller.c | 1 +
> 1 file changed,
May be I missed something, but when I tried setting logical routers into
specific chassis, still the E/W traffic was handled in a distributed way
(from original chassis to destination chassis without going through the
router chassis), such chassis was only used for N/S, but may be I got
something
The patch makes sense,
could we add some testing to make sure this is happening and ensure that we
don't hit regressions later?
On Wed, Sep 20, 2017 at 5:12 PM, Guoshuai Li wrote:
> When sending a localnet port with vlan, the GARP packet needs push_vlan.
> ---
>
> v2:
>
I thought we didn't have meters yet in OvS switch implementation (beyond
openflow protocol support) as per:
http://docs.openvswitch.org/en/latest/faq/qos/
Has this changed in master?
On Wed, Sep 20, 2017 at 1:52 PM, Guoshuai Li wrote:
> ovn-northd modify:
> add bandwidth
Looks a good improvement to report on an intentional exploit, or
other issues.
LGTM, just one comment. Now this new print fn is called just from
create_un_nat_conn but in the future it could potentially be called
from any other CT function. As the function call could affect the
performance,
>Create a separate function from existing code, so the code can be reused in a
>subsequent patch; no change in functionality.
>
>Signed-off-by: Darrell Ball
>---
> lib/conntrack.c | 42 +-
> 1 file changed, 29 insertions(+), 13 deletions(-)
On Thu, Sep 21, 2017 at 11:17:59AM +0200, Adrien Mazarguil wrote:
> On Wed, Sep 20, 2017 at 06:33:43PM +0100, Kevin Traynor wrote:
> > On 09/08/2017 10:56 AM, Loftus, Ciara wrote:
> > >> Hi,
> > >>
> > >> I have compiled and built ovs-dpdk using DPDK v17.08 and OVS v2.8.0. The
> > >> NIC that I am
On Wed, Sep 20, 2017 at 06:33:43PM +0100, Kevin Traynor wrote:
> On 09/08/2017 10:56 AM, Loftus, Ciara wrote:
> >> Hi,
> >>
> >> I have compiled and built ovs-dpdk using DPDK v17.08 and OVS v2.8.0. The
> >> NIC that I am using is Mellanox ConnectX-3 Pro, which is a dual port 10G
> >> NIC. The
>Add an OVS_UNLIKELY and reorder a few variable condition checks.
>
>Signed-off-by: Darrell Ball
>---
> lib/conntrack.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/lib/conntrack.c b/lib/conntrack.c index 59d3c4e..c94bc27 100644
>---
>These dead assignment warnings do not affect functionality.
>In one case, a local variable could be removed and in another case, the
>working pointer should be used rather than the start pointer.
>
>Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
>Reported-by: Bhanuprakash
On 9/21/17, 1:51 AM, "Yuanhan Liu" wrote:
On Thu, Sep 21, 2017 at 07:55:53AM +, Darrell Ball wrote:
> Hi Yuanhan
>
> We discussed the RTE_FLOW_ACTION_TYPE_RSS action, in the dpdk meeting.
> There is related discussion and details in this thread.
On Thu, Sep 21, 2017 at 09:00:10AM +, Darrell Ball wrote:
>
>
> On 9/21/17, 1:54 AM, "Yuanhan Liu" wrote:
>
> On Thu, Sep 21, 2017 at 08:04:45AM +, Darrell Ball wrote:
> > Hi Yuanhan/Finn
> >
> > I think we may need to caveat the Fortville nics
-Original Message-
From: Darrell Ball [mailto:db...@vmware.com]
Sent: 21. september 2017 11:00
To: Yuanhan Liu
Cc: Chandran, Sugesh ; Finn Christensen
; d...@openvswitch.org
Subject: Re:
On 9/21/17, 1:54 AM, "Yuanhan Liu" wrote:
On Thu, Sep 21, 2017 at 08:04:45AM +, Darrell Ball wrote:
> Hi Yuanhan/Finn
>
> I think we may need to caveat the Fortville nics due to the global mask
> limitation;
Sorry, I didn't follow you.
On Thu, Sep 21, 2017 at 08:04:45AM +, Darrell Ball wrote:
> Hi Yuanhan/Finn
>
> I think we may need to caveat the Fortville nics due to the global mask
> limitation;
Sorry, I didn't follow you. Like how? Or what specifically I could/should
do?
--yliu
> we also discussed this in the
On Thu, Sep 21, 2017 at 07:55:53AM +, Darrell Ball wrote:
> Hi Yuanhan
>
> We discussed the RTE_FLOW_ACTION_TYPE_RSS action, in the dpdk meeting.
> There is related discussion and details in this thread.
> It seems the RTE_FLOW_ACTION_TYPE_RSS action can be supported by the drivers.
> If this
> 21/09/2017 10:04, Loftus, Ciara:
> > > 20/09/2017 19:33, Kevin Traynor:
> > > > On 09/08/2017 10:56 AM, Loftus, Ciara wrote:
> > > > > It seems the DPDK function rte_eth_dev_get_port_by_name() will
> > > > > always return the port ID of the first port on your NIC,
> > > > > when you specify the
>we modified little code for dpdk, so we must rebuild ovs debian package with
>dpdk by ourself.
>so is there any guide about how to build openvswith-dpdk package?
There is a guide on this here
http://docs.openvswitch.org/en/latest/intro/install/debian/
- Bhanuprakash.
21/09/2017 10:04, Loftus, Ciara:
> > 20/09/2017 19:33, Kevin Traynor:
> > > On 09/08/2017 10:56 AM, Loftus, Ciara wrote:
> > > > It seems the DPDK function rte_eth_dev_get_port_by_name() will
> > > > always return the port ID of the first port on your NIC,
> > > > when you specify the single PCI
Hi Yuanhan/Finn
I think we may need to caveat the Fortville nics due to the global mask
limitation; we also discussed this in the dpdk meeting yesterday.
What do you think ?
Thanks Darrell
On 9/20/17, 6:47 AM, "Chandran, Sugesh" wrote:
Regards
> 20/09/2017 19:33, Kevin Traynor:
> > On 09/08/2017 10:56 AM, Loftus, Ciara wrote:
> > >> Hi,
> > >>
> > >> I have compiled and built ovs-dpdk using DPDK v17.08 and OVS v2.8.0.
> The
> > >> NIC that I am using is Mellanox ConnectX-3 Pro, which is a dual port 10G
> > >> NIC. The problem with this
Hi Yuanhan
We discussed the RTE_FLOW_ACTION_TYPE_RSS action, in the dpdk meeting.
There is related discussion and details in this thread.
It seems the RTE_FLOW_ACTION_TYPE_RSS action can be supported by the drivers.
If this is the case, then:
1/ We could program only one try with this action.
2/
we modified little code for dpdk, so we must rebuild ovs debian package with
dpdk by ourself.
so is there any guide about how to build openvswith-dpdk package?
___
dev mailing list
d...@openvswitch.org
In an ovn gateway node with DPDK, the RECIRC_DEPTH may be greater than 5.
Scenes:
VM ping self floating IP, or
VM ping Floating IP of VMs with the same network.
It need process UNDNAT SNAT in LRouter egress and
UNSNAT DNAT in LRouter ingress, and
output to geneve tunnel also need recirc.
This
Close a theoretical race delete/create corner case for alg
reverse conns and add debugging around this that may point to
an intentional exploit, unintentional problem or just a rare
condition.
Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
Signed-off-by: Darrell Ball
A new debug function is added and used in a
subsequent patch.
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 53 +
1 file changed, 53 insertions(+)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index 2eca38d..8deeec9
Create a separate function from existing code, so the
code can be reused in a subsequent patch; no change
in functionality.
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 42 +-
1 file changed, 29 insertions(+), 13 deletions(-)
diff
Add an OVS_UNLIKELY and reorder a few variable condition
checks.
Signed-off-by: Darrell Ball
---
lib/conntrack.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/conntrack.c b/lib/conntrack.c
index 59d3c4e..c94bc27 100644
--- a/lib/conntrack.c
+++
These dead assignment warnings do not affect functionality.
In one case, a local variable could be removed and in another
case, the working pointer should be used rather than the start
pointer.
Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
Reported-by: Bhanuprakash Bodireddy
On 9/20/17, 11:33 AM, "Fischetti, Antonio" wrote:
> -Original Message-
> From: Darrell Ball [mailto:db...@vmware.com]
> Sent: Tuesday, September 19, 2017 9:28 PM
> To: Fischetti, Antonio ;
75 matches
Mail list logo