Re: [ovs-dev] [PATCH v3 5/8] ovsdb-client: Add new "backup" command.

2017-12-14 Thread Justin Pettit
> On Dec 13, 2017, at 3:10 PM, Ben Pfaff wrote: > > diff --git a/ovsdb/ovsdb-client.1.in b/ovsdb/ovsdb-client.1.in > index 694a7abed46d..2e2df5e5aa7f 100644 > --- a/ovsdb/ovsdb-client.1.in > +++ b/ovsdb/ovsdb-client.1.in > @@ -30,6 +30,9 @@ ovsdb\-client \- command-line interface

Re: [ovs-dev] [PATCH v3 1/8] ovsdb: Improve documentation.

2017-12-14 Thread Yifeng Sun
Thanks. It is a good reading and learning. I found a small issue in the line below. +A boolean value, true if authorized insertions and authorized are allowed, For "insertions and authorized", maybe you are saying "insertions and deletions". Other than that, it looks good to me.

[ovs-dev] [PATCHv2] DNS: Add basic support for asynchronous DNS resolving

2017-12-14 Thread Yifeng Sun
v1 -> v2: refactored and improved code based on reviewer's comments. Signed-off-by: Yifeng Sun --- configure.ac| 1 + lib/automake.mk | 6 ++ lib/dns-resolve.c | 244 lib/dns-resolve.h |

Re: [ovs-dev] [PATCH v2] windows/lib: Fix Windows C++ compilation issues on common headers

2017-12-14 Thread Ben Pfaff
On Wed, Dec 13, 2017 at 04:13:20PM -0800, Sairam Venugopal wrote: > Found when compiling the code with C++ binaries. Most of the issues are > due to missing explicit cast. > > Changes in PADDED_MEMBERS* is because MSVC does not allow to re-define > unnamed structure in union. Thus, this fix

Re: [ovs-dev] [PATCH v3 4/8] log: New function ovsdb_log_compose_record().

2017-12-14 Thread Ben Pfaff
On Thu, Dec 14, 2017 at 12:18:16PM -0800, Justin Pettit wrote: > > > On Dec 13, 2017, at 3:10 PM, Ben Pfaff wrote: > > > > @@ -317,16 +318,30 @@ ovsdb_log_unread(struct ovsdb_log *file) > > file->offset = file->prev_offset; > > } > > > > +void > >

[ovs-dev] Ética y la Profesión Contable

2017-12-14 Thread Desarróllese en un ambiente profesional honesto
Aplique los principios fundamentales y juicio profesional Ética y la Profesión Contable 17 de Enero - Mtro. David Lozada Martínez - 9am-2pm El código de ética bajo el cual se rigen los contadores públicos en México es el Código de ética profesional de la Comisión de ética del Instituto

Re: [ovs-dev] [PATCH v3 4/8] log: New function ovsdb_log_compose_record().

2017-12-14 Thread Justin Pettit
> On Dec 13, 2017, at 3:10 PM, Ben Pfaff wrote: > > @@ -317,16 +318,30 @@ ovsdb_log_unread(struct ovsdb_log *file) > file->offset = file->prev_offset; > } > > +void > +ovsdb_log_compose_record(const struct json *json, > + struct ds *header, struct ds

Re: [ovs-dev] [PATCH] openvswitch: Trim off padding before L3 conntrack processing

2017-12-14 Thread Ed Swierk via dev
On Wed, Dec 13, 2017 at 4:58 PM, Pravin Shelar wrote: > On Tue, Dec 12, 2017 at 8:17 AM, Ed Swierk wrote: >> A short IPv4 packet may have up to 6 bytes of padding following the IP >> payload when received on an Ethernet device. >> >> In the normal

Re: [ovs-dev] [PATCH v2] ovsdb: Improve documentation.

2017-12-14 Thread Ben Pfaff
These are all great comments. Thanks, I fixed up this stuff as much as I could. I'm going to apply this to master in a minute. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] Paid consulting

2017-12-14 Thread Nigel Kukard via dev
Hi guys, Is it possible to pay one of the devs for 15 min to 30 min of consulting regarding a problem I have with 2.8.1 and localnet? I must be missing something in my config and just need someone to look over my shell commands. Kind Regards Nigel

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-12-14 Thread Kevin Traynor
On 12/14/2017 03:30 PM, Ilya Maximets wrote: > Hello Ciara, > Thanks for the patches. > > I did not review the code. But I have few general concerns about number > of tx descriptors in HW NICs inline. > > Best regards, Ilya Maximets. > > On 08.12.2017 18:26, Ciara Loftus wrote: >> Enabled per

Re: [ovs-dev] [ovs-dev, v5, 2/2] netdev-dpdk: Enable optional dequeue zero copy for vHost User

2017-12-14 Thread Ilya Maximets
Hello Ciara, Thanks for the patches. I did not review the code. But I have few general concerns about number of tx descriptors in HW NICs inline. Best regards, Ilya Maximets. On 08.12.2017 18:26, Ciara Loftus wrote: > Enabled per port like so: > ovs-vsctl set Interface dpdkvhostuserclient0

Re: [ovs-dev] OVS-DPDK public meeting

2017-12-14 Thread Kevin Traynor
13th December 2017 Attendees: Vishal, Billy, Thomas, Ian, Eelco, Simon, Aaron, Antonio, Yipeng, Ben, Sameh, Johann, Sugesh, Olga, Frikkie, Kevin. === GENERAL === - Next Meeting January 10th - Prioritization of patches for OVS 2.9? -- Discussed the patches in the PERF/FEATURES section --

[ovs-dev] [PATCH v8 6/6] dpif-netdev: Count sent packets and batches.

2017-12-14 Thread Ilya Maximets
New statistics for 'pmd-stats-show' command: average number of packets per output batch. Acked-by: Eelco Chaudron Signed-off-by: Ilya Maximets --- lib/dpif-netdev.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-)

[ovs-dev] [PATCH v8 5/6] dpif-netdev: Time based output batching.

2017-12-14 Thread Ilya Maximets
This allows to collect packets from more than one RX burst and send them together with a configurable intervals. 'other_config:tx-flush-interval' can be used to configure time that a packet can wait in output batch for sending. dpif-netdev turned to microsecond resolution for time measuring to

[ovs-dev] [PATCH v8 3/6] netdev: Remove unused may_steal.

2017-12-14 Thread Ilya Maximets
Not needed anymore because 'may_steal' already handled on dpif-netdev layer and always true. Acked-by: Eelco Chaudron Signed-off-by: Ilya Maximets --- lib/dpif-netdev.c | 2 +- lib/netdev-bsd.c | 4 ++-- lib/netdev-dpdk.c | 25

[ovs-dev] [PATCH v8 2/6] dpif-netdev: Output packet batching.

2017-12-14 Thread Ilya Maximets
While processing incoming batch of packets they are scattered across many per-flow batches and sent separately. This becomes an issue while using more than a few flows. For example if we have balanced-tcp OvS bonding with 2 ports there will be 256 datapath internal flows for each dp_hash

[ovs-dev] [PATCH v8 1/6] dpif-netdev: Keep latest measured time for PMD thread.

2017-12-14 Thread Ilya Maximets
In current implementation 'now' variable updated once on each receive cycle and passed through the whole datapath via function arguments. It'll be better to keep this variable inside PMD thread structure to be able to get it at any time. Such solution will save the stack memory and simplify

[ovs-dev] [PATCH v8 0/6] Output packet batching.

2017-12-14 Thread Ilya Maximets
This patch-set inspired by [1] from Bhanuprakash Bodireddy. Implementation of [1] looks very complex and introduces many pitfalls [2] for later code modifications like possible packet stucks. This version targeted to make simple and flexible output packet batching on higher level without

[ovs-dev] [PATCH] tests: Add system-dpdk-testsuite

2017-12-14 Thread marcinx . rybka
From: Marcin Rybka New OVS-DPDK testsuite, which can be launched via `make check-dpdk`, tests OVS using a DPDK datapath. The testsuite contains already initial tests: 1. EAL init 2. Add standard DPDK PHY port 3. Add vhost-user-client port Signed-off-by: Marcin Rybka

[ovs-dev] [PATCH v2 2/3] tests: modify ARP snoop tests for tunneling with clone

2017-12-14 Thread Zoltan Balogh
If ARP reply is received on LOCAL port of underlay bridge, then packets pushed to tunnel port in overlay bridge will be dropped in the underlay. This commit modifies this by receiving ARP replies on a different dummy port. This fix is needed for an upcomming correction for ARP snooping.

[ovs-dev] [PATCH v2 3/3] xlate: call tnl_neigh_snoop() from terminate_native_tunnel()

2017-12-14 Thread Zoltan Balogh
Move tunnel neigh snooping from do_xlate_actions() to terminate_native_tunnel() in order to keep ARP neighbor cache clean. Furthermore filter ARP reply and Neighbor Advertisement messages addressing tunnel endpoint. Signed-off-by: Zoltan Balogh ---

[ovs-dev] [PATCH v2 0/3] Fix tunnel neighbor cache population

2017-12-14 Thread Zoltan Balogh
Currenlty, OVS snoops any ARP or ND packets in any bridge and populates the tunnel neighbor cache with the retreived data. For instance, when ARP reply originated by a tenant is received on an overlay bridge, the ARP message is snooped and tunnel neighbor cache is filled with tenant data, however

[ovs-dev] [PATCH v2 1/3] ofproto-dpif-sflow: propagate actions within clone

2017-12-14 Thread Zoltan Balogh
By avoiding Tx recirculation and embracing tnl_push action within clone, the tunnel metadata is not propagated. Unless clone action is handled in the dpif_sflow_read_actions() function as well. This commit resolves this issue. In addition, some sflow data needs to be stored and restored in