Re: [ovs-dev] [PATCH v5 0/5] OVS-DPDK flow offload with rte_flow

2017-12-24 Thread Yuanhan Liu
Hi Sugesh, On Fri, Dec 22, 2017 at 06:02:16PM +, Chandran, Sugesh wrote: > Hi Yuanhan, > > Thank you for working on this. > I will be reviewing this patch when I am back office after my Xmas/New Year > vacation. Thank you for that. And enjoy your new year vacation! > I do have some comment

Re: [ovs-dev] [PATCH v5 0/5] OVS-DPDK flow offload with rte_flow

2017-12-24 Thread Yuanhan Liu
On Fri, Dec 22, 2017 at 11:28:45AM +, Finn Christensen wrote: > Hi, > > The addition of the offload thread is an great addition, furthermore, RSS > action usage for target queues, works now well with our NICs, I just had to > do some additional drive work, to make it all work. > > The suppo

[ovs-dev] Hacemos llegar tu negocio a miles de nuevos clientes

2017-12-24 Thread MKT NEGOCIOS
Necesitas captar mas clientes? Hola hemos visto que tienes tu negocio y te hacemos llegar un presupuesto para que des a conocerlo a nuevos clientes y de esa forma puedas mejorar tus ventas. Si estas interesado solicita asesoramiento por medio del boton azul y te hago llegar mas informacion. ¿Qu

Re: [ovs-dev] [PATCH] ovs-ofctl: Better document stack push and pop actions.

2017-12-24 Thread Ben Pfaff
On Sun, Dec 24, 2017 at 04:59:05PM -0700, Justin Pettit wrote: > > > On Dec 24, 2017, at 12:31 PM, Ben Pfaff wrote: > > > > Requested-by: Leonid Ryzhyk > > Signed-off-by: Ben Pfaff > > Thanks for writing this up. > > Acked-by: Justin Pettit Thanks, applied to master. __

Re: [ovs-dev] [PATCH 12/13] log: Use absolute name of log file.

2017-12-24 Thread Ben Pfaff
On Sat, Dec 23, 2017 at 05:52:38PM -0700, Justin Pettit wrote: > > > > On Dec 7, 2017, at 5:12 PM, Ben Pfaff wrote: > > > > @@ -487,6 +507,24 @@ ovsdb_log_unread(struct ovsdb_log *file) > > file->offset = file->prev_offset; > > } > > > > +static struct ovsdb_error * > > +ovsdb_log_truncate

Re: [ovs-dev] how to use ofctl/packet-out command???

2017-12-24 Thread lin huang
Hi Ben, If I want to redirect the data from the controller which send the Packet Out message to OVS, do I need to add a flow rules like “in_port=controller,action=output:xxx” ??? Thank for you help! >>-Original Message- >>From: Ben Pfaff [mailto:b...@ovn.org] >>Sent: Saturday,

Re: [ovs-dev] [PATCH 11/13] log: Replace ovsdb_log_get_offset() by a more abstract mechanism.

2017-12-24 Thread Ben Pfaff
On Sat, Dec 23, 2017 at 05:30:59PM -0700, Justin Pettit wrote: > > > On Dec 7, 2017, at 5:12 PM, Ben Pfaff wrote: > > > > +/* Returns true if 'log' has grown enough above the base that it's > > worthwhile > > + * to compact it, false otherwise. */ > > +bool > > +ovsdb_log_has_grown(const struct

Re: [ovs-dev] [PATCH 1/2] ovsdb-server: Update description for "compact" command in man page.

2017-12-24 Thread Justin Pettit
> On Dec 24, 2017, at 5:24 PM, Ben Pfaff wrote: > > On Fri, Dec 22, 2017 at 10:40:05PM -0800, Justin Pettit wrote: >> The man page indicated that multiple databases could be specified, but >> only one is allowed. >> >> Signed-off-by:Justin Pettit > > Missing space in the SoB line above. > >

Re: [ovs-dev] [PATCH 2/2] ovsdb-client: Remove extraneous markup from man page.

2017-12-24 Thread Ben Pfaff
On Fri, Dec 22, 2017 at 10:40:06PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit I'll just assume this is correct. Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/2] ovsdb-server: Update description for "compact" command in man page.

2017-12-24 Thread Ben Pfaff
On Fri, Dec 22, 2017 at 10:40:05PM -0800, Justin Pettit wrote: > The man page indicated that multiple databases could be specified, but > only one is allowed. > > Signed-off-by:Justin Pettit Missing space in the SoB line above. Acked-by: Ben Pfaff __

Re: [ovs-dev] [PATCH] ovs-ofctl: Better document stack push and pop actions.

2017-12-24 Thread Justin Pettit
> On Dec 24, 2017, at 12:31 PM, Ben Pfaff wrote: > > Requested-by: Leonid Ryzhyk > Signed-off-by: Ben Pfaff Thanks for writing this up. Acked-by: Justin Pettit --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mail

Re: [ovs-dev] [PATCH 10/13] log: Support multiple magic.

2017-12-24 Thread Ben Pfaff
On Sat, Dec 23, 2017 at 04:41:50PM -0700, Justin Pettit wrote: > > > On Dec 7, 2017, at 5:12 PM, Ben Pfaff wrote: > > > > diff --git a/ovsdb/log.c b/ovsdb/log.c > > index d25f766474dc..dd641884a2ee 100644 > > --- a/ovsdb/log.c > > +++ b/ovsdb/log.c > > > > +/* Read the magic from the first

Re: [ovs-dev] [PATCH 09/13] log: Support using /dev/stdin for opening logs read-only.

2017-12-24 Thread Ben Pfaff
On Fri, Dec 22, 2017 at 09:50:23PM -0800, Justin Pettit wrote: > > > On Dec 7, 2017, at 4:12 PM, Ben Pfaff wrote: > > > > On Unix-like systems, usually /dev/stdin opens a duplicate of fd 0, and > > this will be convenient in a few places later on. This commit makes this > > support universal. >

Re: [ovs-dev] [PATCH] ofp-actions: Mention OFPACT_STACK_POP.

2017-12-24 Thread Justin Pettit
> On Dec 24, 2017, at 11:52 AM, Ben Pfaff wrote: > > On Sat, Dec 23, 2017 at 08:30:08PM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Ben Pfaff Thanks. I pushed this to master. --Justin ___ dev mailing list d...@open

Re: [ovs-dev] [PATCH 06/13] log: Make reading in writing mode less of an error.

2017-12-24 Thread Ben Pfaff
On Fri, Dec 22, 2017 at 08:13:39PM -0800, Justin Pettit wrote: > > > On Dec 7, 2017, at 4:12 PM, Ben Pfaff wrote: > > > > Clients are intended to use the OVSDB log code by reading zero or more > > records and then writing zero or more records, but not reading after any > > write has occurred. U

Re: [ovs-dev] [PATCH 07/13] log: New functions for replacing a log's contents.

2017-12-24 Thread Ben Pfaff
On Fri, Dec 22, 2017 at 09:39:11PM -0800, Justin Pettit wrote: > > > > On Dec 7, 2017, at 4:12 PM, Ben Pfaff wrote: > > > > These functions will acquire users in future commits. > > > > This new functionality made the internal state machine of the log hard > > enough to understand that I thoug

Re: [ovs-dev] [PATCH 08/13] log: New function ovsdb_log_compose_record().

2017-12-24 Thread Ben Pfaff
On Fri, Dec 22, 2017 at 09:48:25PM -0800, Justin Pettit wrote: > > > On Dec 7, 2017, at 4:12 PM, Ben Pfaff wrote: > > > > This will acquire a new user later on. > > > > Signed-off-by: Ben Pfaff > > I think this patch has already been reviewed and merged. Yes, that is true, thanks. __

Re: [ovs-dev] [PATCH 05/13] log: Add new open mode OVSDB_LOG_CREATE_EXCL.

2017-12-24 Thread Ben Pfaff
On Fri, Dec 22, 2017 at 08:13:33PM -0800, Justin Pettit wrote: > > > > On Dec 7, 2017, at 4:12 PM, Ben Pfaff wrote: > > > > Until now, OVSDB_LOG_CREATE implied EXCL, but this commit breaks them > > apart. > > > > Signed-off-by: Ben Pfaff > > Acked-by: Justin Pettit Thanks for the reviews.

Re: [ovs-dev] [PATCH 01/13] log: Allow client to specify magic.

2017-12-24 Thread Ben Pfaff
On Fri, Dec 22, 2017 at 08:13:09PM -0800, Justin Pettit wrote: > > > > On Dec 7, 2017, at 4:12 PM, Ben Pfaff wrote: > > > > diff --git a/ovsdb/log.c b/ovsdb/log.c > > index 380f5e93d464..e6f66e668fe5 100644 > > --- a/ovsdb/log.c > > +++ b/ovsdb/log.c > > ... > > @@ -53,12 +54,17 @@ struct ovsdb

[ovs-dev] [PATCH] ovs-ofctl: Better document stack push and pop actions.

2017-12-24 Thread Ben Pfaff
Requested-by: Leonid Ryzhyk Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.8.in | 39 --- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in index c65de97f5e2e..5cdf48ce849f 100644 --- a/utilit

Re: [ovs-dev] [PATCH v2] ovs-vsctl: show DPDK version

2017-12-24 Thread Ben Pfaff
On Sun, Dec 24, 2017 at 02:58:37PM +0100, Matteo Croce wrote: > Show DPDK version if Open vSwitch is compiled with DPDK support. > Add a `dpdk_version` column in the datamodel, change ovs-ctl and ovs-dev.py > to populate the field with the right value. > > Signed-off-by: Matteo Croce > --- > v2:

Re: [ovs-dev] [PATCH] ofp-actions: Mention OFPACT_STACK_POP.

2017-12-24 Thread Ben Pfaff
On Sat, Dec 23, 2017 at 08:30:08PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v2] ovs-vsctl: show DPDK version

2017-12-24 Thread Matteo Croce
Show DPDK version if Open vSwitch is compiled with DPDK support. Add a `dpdk_version` column in the datamodel, change ovs-ctl and ovs-dev.py to populate the field with the right value. Signed-off-by: Matteo Croce --- v2: edit ovs-ctl as well utilities/ovs-ctl.in | 7 +++ utilities/ov