[ovs-dev] [PATCH] netdev-dpdk: fix ingress_policer leak on error path

2017-12-28 Thread zhangliping
From: zhangliping Signed-off-by: zhangliping --- lib/netdev-dpdk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 8f22264b3..a3eb3c720 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -2258,6 +2258,7 @@ netdev_dpdk_policer_construct(uint

[ovs-dev] [PATCH] gre: strip gre-tso offload flags

2017-12-28 Thread wenxu
From: wenxu if the gro enable, ipgre receive a gre-tso package. After pop the gre-tunnel the encapsulation and GSO_ENCAP flags should be striped. or the packet encap again and will be dropped in ovs_iptunnel_handle_offloads Signed-off-by: wenxu --- datapath/linux/compat/ip_gre.c | 2 ++ 1 file

[ovs-dev] API for connecting ovs bridge to manage packets

2017-12-28 Thread Gao Zhenyu
Hi guys, As you know ovn consumes rconn functions in pinctrl.c to connect the bridge. But the rconn functions are private functions. I mean those functions are not exposed in include/openvswitch/*.h file, so they are not regular APIs, right? So do you know if we get a way to connect the

Re: [ovs-dev] [no-slow 4/6] ofproto: Add 'ofproto_uuid' and 'ofp_in_port' to user action cookie.

2017-12-28 Thread Gregory Rose
On 12/21/2017 2:25 PM, Justin Pettit wrote: Previously, the ofproto instance and OpenFlow port have been derived based on the datapath port number. This change explicitly declares them both, which will be helpful in future commits that no longer can depend on having a unique datapath port (e.g.,

Re: [ovs-dev] Pravin Shelar

2017-12-28 Thread Pravin Shelar
On Wed, Dec 27, 2017 at 10:33 AM, Joe Perches wrote: > On Wed, 2017-12-27 at 10:25 -0800, Ben Pfaff wrote: >> On Wed, Dec 27, 2017 at 04:22:55PM +0100, Julia Lawall wrote: >> > The email address pshe...@nicira.com listed for Pravin Shelar in >> > MAINTAINERS (OPENVSWITCH section) seems to bounce.

Re: [ovs-dev] [PATCH] MAINTAINERS: Update Pravin's email address.

2017-12-28 Thread Pravin Shelar
On Wed, Dec 27, 2017 at 10:24 AM, Ben Pfaff wrote: > Reported-by: Julia Lawall > CC: Pravin Shelar > Signed-off-by: Ben Pfaff Thanks Ben, I pushed it to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/o

Re: [ovs-dev] [no-slow 2/6] ofproto-dpif: Reorganize upcall handling.

2017-12-28 Thread Gregory Rose
On 12/21/2017 2:25 PM, Justin Pettit wrote: - This reduces the number of times upcall cookies are processed. - It separate true miss calls from slow-path actions. The reorganization will also be useful for a future commit. Signed-off-by: Justin Pettit Justin, The problem I'm seein

Re: [ovs-dev] [PATCH 2/3] tunnel: Log sanely in tnl_port_receive().

2017-12-28 Thread Yifeng Sun
Looks good, thanks. Reviewed-by: Yifeng Sun On Thu, Dec 28, 2017 at 12:34 PM, Ben Pfaff wrote: > When this function was introduced in 2012, it modified its 'flow' argument > and logged the changes (at debug level). However, since 2013 it has no > longer modified its 'flow' argument, but the l

Re: [ovs-dev] [PATCH 1/3] tunnel: Avoid flow_to_string() call when rate-limited.

2017-12-28 Thread Yifeng Sun
Looks good, thanks for the change. Reviewed-by: Yifeng Sun On Thu, Dec 28, 2017 at 12:34 PM, Ben Pfaff wrote: > flow_to_string() is relatively expensive. It is better to avoid it if the > string is not actually going to be used. > > Signed-off-by: Ben Pfaff > --- > ofproto/tunnel.c | 9

[ovs-dev] [PATCH V2] lib: Make error messages more useful

2017-12-28 Thread Greg Rose
There are many "opening datapath" error messages and when one occurs it is impossible to know just from the log message which of the "opening datapath" errors occurred. Add a helper function that incorporates the calling function's name to help identify where the datapath open error occurred. Sig

Re: [ovs-dev] [PATCH] lib: Make error messages more useful

2017-12-28 Thread Gregory Rose
On 12/28/2017 11:25 AM, Ben Pfaff wrote: On Thu, Dec 28, 2017 at 10:22:35AM -0800, Greg Rose wrote: There are many "opening datapath" error messages and when one occurs it is impossible to know just from the log message which of the "opening datapath" errors occurred. Add additional log informa

[ovs-dev] [PATCH 3/3] tunnel: Add ofproto/list-tunnels command for troubleshooting.

2017-12-28 Thread Ben Pfaff
I've recently had to debug some issues related to tunnel implementation. This command would make it easier to have some confidence in how tunnels are actually set up inside OVS. Signed-off-by: Ben Pfaff --- ofproto/tunnel.c | 74 +--- tests/cfm

[ovs-dev] [PATCH 2/3] tunnel: Log sanely in tnl_port_receive().

2017-12-28 Thread Ben Pfaff
When this function was introduced in 2012, it modified its 'flow' argument and logged the changes (at debug level). However, since 2013 it has no longer modified its 'flow' argument, but the logging was still oriented around the idea that it did. This commit fixes up the logging to make sense aga

[ovs-dev] [PATCH 1/3] tunnel: Avoid flow_to_string() call when rate-limited.

2017-12-28 Thread Ben Pfaff
flow_to_string() is relatively expensive. It is better to avoid it if the string is not actually going to be used. Signed-off-by: Ben Pfaff --- ofproto/tunnel.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/ofproto/tunnel.c b/ofproto/tunnel.c index 1676f4d46fdf..9

Re: [ovs-dev] [PATCH] lib: Make error messages more useful

2017-12-28 Thread Ben Pfaff
On Thu, Dec 28, 2017 at 10:22:35AM -0800, Greg Rose wrote: > There are many "opening datapath" error messages and when one occurs > it is impossible to know just from the log message which of the > "opening datapath" errors occurred. Add additional log information > identifying the datapath argume

[ovs-dev] [PATCH] lib: Make error messages more useful

2017-12-28 Thread Greg Rose
There are many "opening datapath" error messages and when one occurs it is impossible to know just from the log message which of the "opening datapath" errors occurred. Add additional log information identifying the datapath argument name and the line number. Signed-off-by: Greg Rose --- lib/dp

[ovs-dev] (no subject)

2017-12-28 Thread Rick Mikulski
http://second.vidajavaqueen.com Rick Mikulski ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [patch v2] conntrack: Some style improvements.

2017-12-28 Thread Flavio Leitner
I missed this one when I reviewed V1, but looks like some comments still applies. fbl On Mon, Dec 11, 2017 at 08:00:08AM -0800, Darrell Ball wrote: > Fix up some instances where variable declarations were not close > enough to their use, as these were missed before. This is the > preferred ar

Re: [ovs-dev] [patch v1 1/4] conntrack: Some formatting improvements.

2017-12-28 Thread Flavio Leitner
Hi Darrell, I am coming back from vacations, sorry the delay. The patch doesn't apply anymore, but I reviewed anyways. On Sun, Nov 19, 2017 at 01:02:19PM -0800, Darrell Ball wrote: > Fix up some instances where variable declarations were not close > enough to their use, as these were missed be