Re: [ovs-dev] [PATCH] datapath-windows: Update ct stats when packet is processed by conntrack

2018-04-26 Thread Sairam Venugopal
Anand, Thanks for the patch. Can you update the commit message to better describe the underlying issue? Prevent conntrack-counters from getting redundantly incremented for recirculated packets. The counters ought to be incremented only if it's a new lookup or if it's recirculated through a

Re: [ovs-dev] [PATCH] tests: Fix ovn test failures in sandbox test env.

2018-04-26 Thread Han Zhou
On Mon, Apr 23, 2018 at 1:46 AM, aginwala wrote: > > > > On Sun, Apr 22, 2018 at 9:53 AM, Han Zhou wrote: >> >> When clustering support is introduced, the naming convention of >> environment variables OVN_NB_DB and OVN_SB_DB changed (something >> like

Re: [ovs-dev] [PATCH v1] Enhance conjunctive match support in OVN

2018-04-26 Thread Jakub Sitnicki
Hi Numan, I've started reviewing your patch and it occurred to me that we can complicate the annotation a bit (but not much) and achieve the same effect. Please take a look at the proposed change [1]. It seems to be passing your tests, with the changes as below: 1) I believe sets with just two

[ovs-dev] [PATCH] Factor prerequisites out of AND/OR trees with unique symbol

2018-04-26 Thread Jakub Sitnicki
Appending prerequisites to sub-expressions of OR that are all over one symbol prevents the expression-to-matches converter from applying conjunctive matching. This happens during the annotation phase. input: s1 == { c1, c2 } && s2 == { c3, c4 } expanded: (s1 == c1 || s1 == c2) && (s2 == c3

Re: [ovs-dev] [PATCH v12 2/3] dpif-netdev: Detailed performance stats for PMDs

2018-04-26 Thread Jan Scheurich
> > I hope that Clang is intelligent enough to recognize this. If not, I > > wouldn't know how to fix it other than by removing OVS_REQUIRES(s- > > >stats_mutex) from pmd_perf_stats_clear_lock() and just rely on comments. > > > > BR, Jan > > Thanks Jan, that resolves the issue and there's a clear

Re: [ovs-dev] [PATCH v12 2/3] dpif-netdev: Detailed performance stats for PMDs

2018-04-26 Thread Stokes, Ian
> Hi Ian, > > Thanks for checking this. I suggest to address Clang's compliant by the > following incremental: > > diff --git a/lib/dpif-netdev-perf.c b/lib/dpif-netdev-perf.c index > 47ce2c2..c7b8e7b 100644 > --- a/lib/dpif-netdev-perf.c > +++ b/lib/dpif-netdev-perf.c > @@ -442,6 +442,7 @@

Re: [ovs-dev] [PATCH 1/1] netdev-dpdk: Don't use PMD driver if not configured successfully

2018-04-26 Thread Stokes, Ian
> When initialization of the DPDK PMD driver fails (dpdk_eth_dev_init()), > the reconfigure_datapath() function will remove the port from dp_netdev, > and the port is not used. > > Now when bridge_reconfigure() is called again, no changes to the previous > failing netdev configuration are

Re: [ovs-dev] [PATCH v3 1/1] netdev-dpdk: remove enabling scatter for jumbo RX support

2018-04-26 Thread Stokes, Ian
> On 04/26/2018 04:26 PM, Stokes, Ian wrote: > >> Currently to RX jumbo packets fails for NICs not supporting scatter. > >> Scatter is not strictly needed for jumbo RX support. This change > >> fixes the issue by only enabling scatter for NICs known to need it to > >> support jumbo RX. Add a quirk

[ovs-dev] Ausentismo e Incumplimiento de Horarios

2018-04-26 Thread Causas y efectos
En línea y en Vivo / Para todo su Equipo con una sola Conexión Cómo manejar los problemas de ausentismo e incumplimiento de horarios de los empleados. 09 de mayo - Online en Vivo - 10:00 a 13:00 y de 15:00 a 18:00 Hrs La red de profesionales más grande del mundo se ha convertido en

Re: [ovs-dev] [PATCH v3 1/1] netdev-dpdk: remove enabling scatter for jumbo RX support

2018-04-26 Thread Kevin Traynor
On 04/26/2018 04:26 PM, Stokes, Ian wrote: >> Currently to RX jumbo packets fails for NICs not supporting scatter. >> Scatter is not strictly needed for jumbo RX support. This change fixes the >> issue by only enabling scatter for NICs known to need it to support jumbo >> RX. Add a quirk for "igb"

Re: [ovs-dev] [PATCH] ovsdb.7: Clarify description of OVSDB.

2018-04-26 Thread Ben Pfaff
On Thu, Apr 26, 2018 at 12:41:02PM -0400, Justin Pettit wrote: > > > > On Apr 26, 2018, at 12:39 PM, Ben Pfaff wrote: > > > > A reader reported that "network database system" made it sound like OVSDB > > was specialized for databases about networks. It's not, it's just > >

Re: [ovs-dev] [PATCH] ovsdb.7: Clarify description of OVSDB.

2018-04-26 Thread Justin Pettit
> On Apr 26, 2018, at 12:39 PM, Ben Pfaff wrote: > > A reader reported that "network database system" made it sound like OVSDB > was specialized for databases about networks. It's not, it's just > accessible over the network. > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH v3 1/1] netdev-dpdk: remove enabling scatter for jumbo RX support

2018-04-26 Thread Stokes, Ian
> Currently to RX jumbo packets fails for NICs not supporting scatter. > Scatter is not strictly needed for jumbo RX support. This change fixes the > issue by only enabling scatter for NICs known to need it to support jumbo > RX. Add a quirk for "igb" while the PMD is fixed. > Thanks for the v3

[ovs-dev] [PATCH v2] OVN: show gw chassis in decreasing prio order

2018-04-26 Thread Lorenzo Bianconi
Report gateway chassis in decreasing priority order running ovn-nbctl show sub-command. Add get_ordered_gw_chassis_prio_list routine to sort gw chassis according to the configured priority Acked-by: Mark Michelson Signed-off-by: Lorenzo Bianconi

[ovs-dev] Mempool redesign for OVS 2.10

2018-04-26 Thread Jan Scheurich
Hi, Thanks, everyone, for re-opening the discussion around the new packet mempool handling for 2.10. Before we agree on what to actually implement I’d like to summarize my understanding of the requirements that have been discussed so far. Based on those I want to share some thoughts about

[ovs-dev] [PATCH] Documentation: Fix binary representation of 80 and 8080 in Faucet tutorial

2018-04-26 Thread axel
The binary representation of 80 and 8080 are switched in the Faucet tutorial. Signed-off-by: Axel Tripier --- Documentation/tutorials/faucet.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/tutorials/faucet.rst

Re: [ovs-dev] [PATCH] odp-util: Remove unnecessary TOS ECN bits rewrite for tunnels

2018-04-26 Thread Simon Horman
Thanks Jianbo, On 26 April 2018 at 07:54, Jianbo Liu wrote: > For tunnels, TOS ECN bits are never wildcard for the reason that they > are always inherited. OVS will create a rewrite action if we add rule > to modify other IP headers. But it also adds an extra ECN rewrite

[ovs-dev] [PATCH 1/1] netdev-dpdk: Don't use PMD driver if not configured successfully

2018-04-26 Thread Eelco Chaudron
When initialization of the DPDK PMD driver fails (dpdk_eth_dev_init()), the reconfigure_datapath() function will remove the port from dp_netdev, and the port is not used. Now when bridge_reconfigure() is called again, no changes to the previous failing netdev configuration are detected and

Re: [ovs-dev] [PATCH v3 1/1] netdev-dpdk: remove enabling scatter for jumbo RX support

2018-04-26 Thread Simon Horman
On 26 April 2018 at 12:44, Stokes, Ian wrote: > > On Fri, Apr 20, 2018 at 05:24:37PM +0100, Pablo Cascón wrote: > > > Currently to RX jumbo packets fails for NICs not supporting scatter. > > > Scatter is not strictly needed for jumbo RX support. This change fixes > > > the

Re: [ovs-dev] [PATCH v3 1/1] netdev-dpdk: remove enabling scatter for jumbo RX support

2018-04-26 Thread Stokes, Ian
> On Fri, Apr 20, 2018 at 05:24:37PM +0100, Pablo Cascón wrote: > > Currently to RX jumbo packets fails for NICs not supporting scatter. > > Scatter is not strictly needed for jumbo RX support. This change fixes > > the issue by only enabling scatter for NICs known to need it to > > support jumbo

Re: [ovs-dev] [PATCH v3 1/1] netdev-dpdk: remove enabling scatter for jumbo RX support

2018-04-26 Thread Simon Horman
On Fri, Apr 20, 2018 at 05:24:37PM +0100, Pablo Cascón wrote: > Currently to RX jumbo packets fails for NICs not supporting scatter. > Scatter is not strictly needed for jumbo RX support. This change fixes > the issue by only enabling scatter for NICs known to need it to > support jumbo RX. Add a

Re: [ovs-dev] GDB macro's for Open vSwitch

2018-04-26 Thread Eelco Chaudron
On 25/04/18 21:42, Ben Pfaff wrote: On Wed, Apr 25, 2018 at 06:12:03PM +0200, Eelco Chaudron wrote: Hi All, I could not find any GDB macros or commands in the OVS project, and as I was debugging some vague crash I started to create some. As I was trying to do this while debugging I copied

[ovs-dev] Backlink Service - PBN Links Service - Link Building Service - by goyizseo

2018-04-26 Thread p...@goyizseo.com
Hi, Iam Backlink Service - PBN Links Service - Link Building Service Can you connected with marketing division ? I have 2000+ sites with good metric and different niche My PBN Links can increase your metric site We can discuss for details of course, but first i wanted to see if this is

[ovs-dev] [PATCH v2] ovn-ctl: Handle whitespaces when using eval for start_ovsdb:

2018-04-26 Thread aginwala
eval doesn't understand white space for local var which was introduced in commit 79c7961b8b3c4b7ea0251dea2ffacfa84c84fecb for starting clustered ovn dbs. As ovn-ctl uses sh instead of bash, parsing local var with white space will fail. e.g. /usr/share/openvswitch/scripts/ovn-ctl

[ovs-dev] [PATCH] dpif-netdev:Delete port check in do_add_port

2018-04-26 Thread Haifeng Lin
It is not need check port exist in do_add_port because it had check in port_add. Change-Id: Ie66206b40e305cef5f5b20af765c3128ccec6782 Signed-off-by: Haifeng Lin --- lib/dpif-netdev.c | 5 - 1 file changed, 5 deletions(-) diff --git a/lib/dpif-netdev.c