> On Jun 21, 2018, at 7:45 PM, Han Zhou wrote:
>
> As pointed out by Justin in today's ovn meeting, the "ovs-appctl -t
> ovn-controller inject-pkt" already takes care of checksum calculation, which
> can be used to replace the dummy/receive tool in tests when checksum is
> needed.
> So I
On Thu, Jun 21, 2018 at 12:07 AM, Han Zhou wrote:
>
>
>
> On Tue, Jun 19, 2018 at 7:15 PM, Han Zhou wrote:
> >
> >
> >
> > On Tue, Jun 19, 2018 at 5:49 PM, Ben Pfaff wrote:
> > >
> > > On Tue, Jun 19, 2018 at 05:27:20PM -0700, Han Zhou wrote:
> > > > All looks good to me except that the test
On Tue, Jun 19, 2018 at 7:18 PM, Daniel Alvarez wrote:
>
> When using Port Groups, the pre ACLs were not applied so the
> conntrack action was not performed. This patch takes Port Groups
> into account when processing the pre ACLs.
>
> As a follow up, we could enhance this patch by creating an
A bug was reported on the feature of applying ACLs on port groups [1].
This bug was not detected by the original test case, because it didn't
test the return traffic and so didn't ensure the stateful feature is
working. The fix [2] causes the original test case fail, because
once the conntrack is
On Wed, Jun 20, 2018 at 2:38 AM, Ian Stokes wrote:
> On 6/14/2018 11:31 PM, William Tu wrote:
>>
>> On Thu, Jun 14, 2018 at 3:25 PM, Ben Pfaff wrote:
>>>
>>> On Mon, Jun 11, 2018 at 10:32:52AM +, Stokes, Ian wrote:
Hi all,
The recent DPDK 18.05 release provides BPF
On Thu, Jun 21, 2018 at 06:27:19PM +0200, Simon Horman wrote:
> On 21 June 2018 at 18:15, Ben Pfaff wrote:
>
> > Simon, I see that you have reviewed these patches. Are you handling
> > this series?
> >
>
> Hi Ben,
>
> yes, I reviewed these patches during internal review.
> I'm happy to handle
OK.
I think that it's the dpif itself that should really be doing the check
(the kernel datapath especially needs to do this for itself), so I sent
an alternative patch that works that way:
https://patchwork.ozlabs.org/patch/932991/
Will you test it?
Thanks,
Ben.
On Thu, Jun 21, 2018
The port_add() function checks whether the port about to be added to the
dpif is already present and adds it only if it is not. This duplicates a
check also present (and necessary) in each dpif and races with it as well.
When a dpif has a large number of ports, the check can be expensive (it is
Hi everyone,
I am writing this email to propose adding encryption support to OVN
tunnel. The plan is described as below. Any feedbacks and suggestions
are appreciated!
Regards,
Qiuyu Xiao
Motivation
--
OVN tunnel traffic goes through physical routers and switches. These
physical
Hi Shahaf,
These are exactly the same bugs I found today.
I added the calculation of the offset l3_ofs and l4_ofs into the
parse_tcp_flags() and here these can be calculated more or less without
additional performance penalty.
I also made it not use the MARK in emc_processing if recirc depth >
When adding a route to a bridge, by executing "$appctl ovs/route/add
$IP/$MASK $BR", a reference to the existing netdev is taken and stored
in an instantiated ip_dev struct which is then stored in an addr_list
list in tnl-ports.c. When OvS is signaled to exit, as a result of a
"$appctl $OVS_PID
Hi Finn,
Finally I was able to reproduce the error behavior w/ VXLAN traffic.
I found 2 issues related to the design being made:
1. The VXLAN decap requires more fields apart from the TCP header like the
l3_ofs and l4_ofs which are missing because of bypassing the miniflow extract.
2.
On 21 June 2018 at 18:15, Ben Pfaff wrote:
> Simon, I see that you have reviewed these patches. Are you handling
> this series?
>
Hi Ben,
yes, I reviewed these patches during internal review.
I'm happy to handle the series now its in external review.
> On Thu, Jun 21, 2018 at 02:35:55PM
Simon, I see that you have reviewed these patches. Are you handling
this series?
Thanks,
Ben.
On Thu, Jun 21, 2018 at 02:35:55PM +0100, John Hurley wrote:
> This patchset extends OvS TC and the linux-netdev implementation to
> support the offloading of Linux Link Aggregation devices (LAG) and
Hi,
Requesting to get this patch merged to master and branches till 2.6 if there
are no issues with the fix.
Warm Regards,
Vishal Ajmera
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Vishal Deep Ajmera
> Sent: Thursday, June 21,
Hi Mallesh and Shahaf,
I have tried to reproduce the issue Mallesh is reporting, using a Napatech NIC.
The result is that I'm able to reproduce the error and are not getting the
decap functionality to work when using VxLan tunneling together with partial
hw-offload. Mainly the VxLAN POP is not
A LAG slave cannot be added directly to an OvS bridge, nor can a OvS
bridge port be added to a LAG dev. However, LAG masters can be added to
OvS.
Use TC blocks to indirectly offload slaves when their master is attached
as a linux-netdev to an OvS bridge. In the kernel TC datapath, blocks link
Assign block ids to LAG masters that are added to OvS as linux-netdevs and
offloaded via offload API calls. Only LAG masters are assigned to blocks.
To ensure uniqueness, the block ids are determined by the netdev ifindex.
Implement a get_block_id op for linux netdevs to achieve this.
If a linux netdev is added to OvS that is a LAG master (for example, a
bond or team netdev) then record this in bool form in the dev struct. Use
the link info extracted from rtnetlink calls to determine this.
Signed-off-by: John Hurley
Reviewed-by: Dirk van der Merwe
Reviewed-by: Simon Horman
Extend the rtnetlink_parse function to look for linkinfo attributes and,
in turn, store pointers to the master and slave kinds (if any) in the
rtnetlink_change struct.
Signed-off-by: John Hurley
Reviewed-by: Simon Horman
Reviewed-by: Dirk van der Merwe
---
lib/rtnetlink.c | 43
Add a new class op for netdevs to get the block_id if one exists. The
block_id is used in offload ops to group multiple qdiscs together.
Stub calls are made to the new class op (implementation to follow in
further patches). The default block_id of 0 (no block) will be used in
these cases.
Blocks, in tc classifiers, allow the grouping of multiple qdiscs with an
associated block id. Whenever a filter is added to/removed from this
block, the filter is added to/removed from all associated qdiscs.
Extend TC offload functions to take a block id as a parameter. If the id
is zero then the
This patchset extends OvS TC and the linux-netdev implementation to
support the offloading of Linux Link Aggregation devices (LAG) and their
slaves. TC blocks are used to provide this offload. Blocks, in TC, group
together a series of qdiscs. If a filter is added to one of these qdiscs
then it
Tests are added to cover out of order and overlapping fragments.
Signed-off-by: Darrell Ball
---
tests/system-kmod-macros.at | 8
tests/system-traffic.at | 96
tests/system-userspace-macros.at | 8
3 files changed, 112
The ipv4 fragmentation check is broken and allows fragments through.
There were fragile and poorly maintainable checks in extract_l3_ipv*
designed to save a few cycles. The checks make assumptions about what
sanity checks may have been done and could be skipped based on inferring
from the value
On Tue, Jun 19, 2018 at 7:15 PM, Han Zhou wrote:
>
>
>
> On Tue, Jun 19, 2018 at 5:49 PM, Ben Pfaff wrote:
> >
> > On Tue, Jun 19, 2018 at 05:27:20PM -0700, Han Zhou wrote:
> > > All looks good to me except that the test case "ovn -- ACLs on Port
Groups"
> > > is broken with this change. I think
For the performance problem. When add 3000 or more ports it costs too more time
and it is not needed.
port_add function in ofproto-dpif.c have checked it used dpif_port_exists so we
really not need to check it again in do_add_port
-邮件原件-
发件人: Ben Pfaff [mailto:b...@ovn.org]
发送时间:
On Thu, Jun 14, 2018 at 11:57:19AM -0700, Han Zhou wrote:
> On Thu, Jun 14, 2018 at 10:40 AM, Ben Pfaff wrote:
> >
> > On Thu, Jun 14, 2018 at 10:17:58AM -0700, Han Zhou wrote:
> > > On Thu, Jun 14, 2018 at 10:09 AM, Ben Pfaff wrote:
> > > >
> > > > On Wed, Jun 13, 2018 at 08:29:28PM -0700, Han
28 matches
Mail list logo
