Re: [ovs-dev] [PATCH] ovsdb-idl: Fix recently introduced Python 3 tests.

2018-08-18 Thread Ben Pfaff
On Sat, Aug 18, 2018 at 04:20:42PM -0700, Justin Pettit wrote: > > > > On Aug 18, 2018, at 3:11 PM, Ben Pfaff wrote: > > > > CC: Numan Siddique > > Fixes: c1aa16d191d2 ("ovs python: ovs.stream.open_block() returns success > > even if the remote is unreachable") > > Reported-at: > >

Re: [ovs-dev] [PATCH] ovsdb-idl: Fix recently introduced Python 3 tests.

2018-08-18 Thread Justin Pettit
> On Aug 18, 2018, at 3:11 PM, Ben Pfaff wrote: > > CC: Numan Siddique > Fixes: c1aa16d191d2 ("ovs python: ovs.stream.open_block() returns success > even if the remote is unreachable") > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/351311.html > Reported-by:

Re: [ovs-dev] [PATCH v4 1/2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

2018-08-18 Thread Ben Pfaff
On Sat, Aug 18, 2018 at 09:40:05PM +0200, Simon Horman wrote: > On Tue, Aug 07, 2018 at 05:07:58PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > The python function ovs.socket_util.check_connection_completion() uses > > select() > > (provided by python) to monitor the

[ovs-dev] [PATCH] ovsdb-idl: Fix recently introduced Python 3 tests.

2018-08-18 Thread Ben Pfaff
CC: Numan Siddique Fixes: c1aa16d191d2 ("ovs python: ovs.stream.open_block() returns success even if the remote is unreachable") Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-August/351311.html Reported-by: Simon Horman Signed-off-by: Ben Pfaff --- tests/ovsdb-idl.at | 4

Re: [ovs-dev] [branch-2.10 1/2] Set release dates for 2.10.0.

2018-08-18 Thread Justin Pettit
> On Aug 18, 2018, at 11:51 AM, Ben Pfaff wrote: > > On Sat, Aug 18, 2018 at 10:40:38AM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Acked-by: Ben Pfaff Thanks. I pushed this to branch-2.10. I'll package this over the weekend, so that we can release on Monday.

Re: [ovs-dev] [PATCH v4 1/2] ovs python: ovs.stream.open_block() returns success even if the remote is unreachable

2018-08-18 Thread Simon Horman
On Tue, Aug 07, 2018 at 05:07:58PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > The python function ovs.socket_util.check_connection_completion() uses > select() > (provided by python) to monitor the socket file descriptor. The select() > returns 1 when the file descriptor

Re: [ovs-dev] [branch-2.10 2/2] Prepare for 2.10.1.

2018-08-18 Thread Ben Pfaff
On Sat, Aug 18, 2018 at 10:40:39AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [branch-2.10 1/2] Set release dates for 2.10.0.

2018-08-18 Thread Ben Pfaff
On Sat, Aug 18, 2018 at 10:40:38AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [ovs-dev,branch-2.10,2 of 2] Prepare for 2.10.1.

2018-08-18 Thread 0-day Robot
Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Too many signoffs; are you missing Co-authored-by lines? Lines checked: 56, Warnings:

Re: [ovs-dev] [ovs-dev, branch-2.10, 1 of 2] Set release dates for 2.10.0.

2018-08-18 Thread 0-day Robot
Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Too many signoffs; are you missing Co-authored-by lines? Lines checked: 39, Warnings:

[ovs-dev] [branch-2.10 2/2] Prepare for 2.10.1.

2018-08-18 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 4 configure.ac | 2 +- debian/changelog | 6 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 8e21180537db..04de80781dc4 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v2.10.1 - xx xxx

[ovs-dev] [branch-2.10 1/2] Set release dates for 2.10.0.

2018-08-18 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 2 +- debian/changelog | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 9f05bf3dc3ec..8e21180537db 100644 --- a/NEWS +++ b/NEWS @@ -1,4 +1,4 @@ -v2.10.0 - xx xxx +v2.10.0 - 18 Aug 2018

[ovs-dev] [PATCH] netdev-linux: Avoid division by 0 if kernel reports bad scheduler data.

2018-08-18 Thread Ben Pfaff
If the kernel reported a value of 0 for the second value in /proc/net/psched, it would cause a division-by-zero fault in read_psched(). I don't know of a kernel that would actually do that, but it's still better to be safe. Found by clang static analyzer Reported-by: Bhargava Shastry

Re: [ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

2018-08-18 Thread Ben Pfaff
On August 18, 2018 8:18:51 AM PDT, Daniel Alvarez Sanchez wrote: >Thanks a lot Ben. >It was fixed in glibc 2.28. Shall I send a patch to add the comment in >the >code? I think it's a good idea so that we can remove the workaround >eventually. Not sure about sending a patch for just a comment

Re: [ovs-dev] [PATCH v3] netdev: Retry getting interfaces on inconsistent dumps from kernel

2018-08-18 Thread Daniel Alvarez Sanchez
Thanks a lot Ben. It was fixed in glibc 2.28. Shall I send a patch to add the comment in the code? I think it's a good idea so that we can remove the workaround eventually. Not sure about sending a patch for just a comment though :) On Wed, Aug 15, 2018 at 10:40 PM Ben Pfaff wrote: > On Mon,