Re: [ovs-dev] Possible OVN enhancement: implementing OpenShift's "unidling" behavior

2018-11-19 Thread Han Zhou
Hi Mark, thanks for writing up the interesting topic. I agree with Guru that holding packets and waiting for control plane change to get ready doesn't seem to work/scale. I am curious about the problem and I want to make sure I understand it correctly. It sounds like some FaaS scenario, is it? Is

Re: [ovs-dev] [PATCH] pinctrl: Check requested IP in DHCPREQUEST messages

2018-11-19 Thread Numan Siddique
On Tue, Nov 20, 2018 at 1:37 AM Gregory Smith wrote: > Numan Siddique wrote: > > On Fri, Nov 16, 2018 at 11:03 PM Gregory Smith > wrote: > > > > > See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the > > > server should validate that the client's requested IP matches the > > >

Re: [ovs-dev] [patch v9 06/11] Userspace datapath: Add fragmentation handling.

2018-11-19 Thread Darrell Ball
I folded in the following incremental locally to address: 1/ Below mentioned capitalization inconsistency in 'releases.rst'. 2/ Misplaced counter increment. Darrell diff --git a/Documentation/faq/releases.rst b/Documentation/faq/releases.rst index d281c97..1fb3b1c 100644 ---

Re: [ovs-dev] [PATCH 01/10] ovsdb-idl: Avoid sending transactions when the DB is not synced up.

2018-11-19 Thread Ben Pfaff
Thanks. I applied patches 1 through 9 to master and backported an appropriate subset to branch-2.10, and the use-after-free fix as far as branch-2.7. I'm going to shift patch 10 to a new series. On Fri, Nov 16, 2018 at 03:36:11PM -0500, Mark Michelson wrote: > For the series, looks good by my

Re: [ovs-dev] [PATCH] configure: Check for more specific function to pull in pthread library.

2018-11-19 Thread Ben Pfaff
Thanks, I applied this to master. On Mon, Nov 19, 2018 at 11:40:23AM -0800, Yifeng Sun wrote: > Thanks for the fix. > > Tested-by: Yifeng Sun > Reviewed-by: Yifeng Sun > > On Thu, Nov 15, 2018 at 8:59 AM Ben Pfaff wrote: > > > On my laptop, pthread_create() is always available without

Re: [ovs-dev] [patch v9 06/11] Userspace datapath: Add fragmentation handling.

2018-11-19 Thread Darrell Ball
On Mon, Nov 19, 2018 at 11:11 AM Darrell Ball wrote: > Fragmentation handling is added for supporting conntrack. > Both v4 and v6 are supported. > > After discussion with several people, I decided to not store > configuration state in the database to be more consistent with > the kernel in

Re: [ovs-dev] [PATCH] configure: Check for more specific function to pull in pthread library.

2018-11-19 Thread Yifeng Sun
Thanks for the fix. Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun On Thu, Nov 15, 2018 at 8:59 AM Ben Pfaff wrote: > On my laptop, pthread_create() is always available without -lpthread, but > when I use -fsanitize=address, -lpthread is required to pull in other > threading functions such as

[ovs-dev] [patch v9 11/11] ipf: Add fragmentation status reporting.

2018-11-19 Thread Darrell Ball
A new command "ovs-appctl dpctl/ipf-get-status" is added for userspace datapath conntrack fragmentation support. The command shows the configuration status, fragment counters and ipf lists state. Signed-off-by: Darrell Ball --- NEWS | 2 + lib/ct-dpif.c

[ovs-dev] [patch v9 10/11] ipf: Add set maximum fragments supported command.

2018-11-19 Thread Darrell Ball
A new command "ovs-appctl dpctl/ipf-set-max-nfrags" is added for userspace datapath conntrack fragmentation support. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 30

[ovs-dev] [patch v9 09/11] ipf: Add set minimum fragment size command.

2018-11-19 Thread Darrell Ball
A new command "ovs-appctl dpctl/ipf-set-min-frag" is added for userspace datapath conntrack v4/v6 fragmentation support. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 40

[ovs-dev] [patch v9 06/11] Userspace datapath: Add fragmentation handling.

2018-11-19 Thread Darrell Ball
Fragmentation handling is added for supporting conntrack. Both v4 and v6 are supported. After discussion with several people, I decided to not store configuration state in the database to be more consistent with the kernel in future, similarity with other conntrack configuration which will not be

[ovs-dev] [patch v9 08/11] ipf: Add command to disable fragmentation handling.

2018-11-19 Thread Darrell Ball
Commands are added to disable and also enable V4/V6 fragmentation handling for conntrack, which is enabled by default. Signed-off-by: Darrell Ball --- NEWS| 2 ++ lib/ct-dpif.c | 8 lib/ct-dpif.h | 1 + lib/dpctl.c | 47

[ovs-dev] [patch v9 05/11] ovs-atomic: Add 64 bit apis.

2018-11-19 Thread Darrell Ball
Signed-off-by: Darrell Ball --- lib/ovs-atomic.h | 36 1 file changed, 36 insertions(+) diff --git a/lib/ovs-atomic.h b/lib/ovs-atomic.h index 4664eef..19b49c8 100644 --- a/lib/ovs-atomic.h +++ b/lib/ovs-atomic.h @@ -479,6 +479,42 @@

[ovs-dev] [patch v9 07/11] dpctl: Simplify opt_dpif_open().

2018-11-19 Thread Darrell Ball
The commonly used function, opt_dpif_open(), recently became more complex to check for a datapath argument. Unnecessary dummy parameters for most users were hence added. Revert back and call the intended api, dp_arg_exists(), to query for a datapath argument being supplied. Fixes: 4eeec031d4c4

[ovs-dev] [patch v9 04/11] conntrack: Reword conntrack_execute() description.

2018-11-19 Thread Darrell Ball
Use 'must' instead of 'should'. Suggested-by: Justin Pettit Signed-off-by: Darrell Ball --- lib/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 682feb9..3f50fc8 100644 --- a/lib/conntrack.c +++ b/lib/conntrack.c @@ -1294,7

[ovs-dev] [patch v9 03/11] tests: Add missed local stack checks.

2018-11-19 Thread Darrell Ball
Acked-by: Justin Pettit Signed-off-by: Darrell Ball --- tests/system-traffic.at | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 4c52431..840fea9 100644 --- a/tests/system-traffic.at +++ b/tests/system-traffic.at @@ -2972,6 +2972,7 @@

[ovs-dev] [patch v9 02/11] flow: Enhance parse_ipv6_ext_hdrs.

2018-11-19 Thread Darrell Ball
Acked-by: Justin Pettit Signed-off-by: Darrell Ball --- lib/conntrack.c | 4 ++-- lib/flow.c | 40 ++-- lib/flow.h | 3 ++- 3 files changed, 34 insertions(+), 13 deletions(-) diff --git a/lib/conntrack.c b/lib/conntrack.c index 974f985..682feb9

[ovs-dev] [patch v9 01/11] dp-packet: Add const qualifiers for checksum apis.

2018-11-19 Thread Darrell Ball
Acked-by: Justin Pettit Signed-off-by: Darrell Ball --- lib/dp-packet.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index 7b85dd9..a6e2a4f 100644 --- a/lib/dp-packet.h +++ b/lib/dp-packet.h @@ -509,28 +509,28 @@

[ovs-dev] [patch v9 00/11] Userspace datapath: Add fragmentation support.

2018-11-19 Thread Darrell Ball
Fragmentation support for userspace datapath conntrack is added; both v4 and v6 are supported. See the patches for additional details. Fragmentation tests for the userspace datapath are enabled by the patches and other test enhancements are added. v8->v9: Exported ipf status type to

Re: [ovs-dev] [PATCH] pinctrl: Check requested IP in DHCPREQUEST messages

2018-11-19 Thread Gregory Smith
Numan Siddique wrote: > On Fri, Nov 16, 2018 at 11:03 PM Gregory Smith wrote: > > > See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the > > server should validate that the client's requested IP matches the > > offered IP. > > When we added the native DHCP support in OVN, we

Re: [ovs-dev] [PATCH 1/2] ovn: Avoid tunneling for VLAN packets redirected to a gateway chassis

2018-11-19 Thread Numan Siddique
Thanks Guru for the review and comments. I have addressed the comments and submitted v2 here - https://patchwork.ozlabs.org/patch/999893/ Thanks Numan On Thu, Nov 15, 2018 at 11:33 PM Guru Shetty wrote: > > > On Fri, 5 Oct 2018 at 10:15, wrote: > >> From: Numan Siddique >> >> An OVN

[ovs-dev] [PATCH v2] ovn: Avoid tunneling for VLAN packets redirected to a gateway chassis

2018-11-19 Thread nusiddiq
From: Numan Siddique An OVN deployment can have multiple logical switches each with a localnet port connected to a distributed logical router in which one logical switch may provide external connectivity and the rest of the localnet logical switches use VLAN tagging in the physical network. As

Re: [ovs-dev] [PATCH] OVN: add selected mac address to MACAM in update_dynamic_addresses

2018-11-19 Thread Numan Siddique
On Sat, Nov 17, 2018 at 2:10 AM Mark Michelson wrote: > Acked-by: Mark Michelson > > On 11/16/2018 06:31 AM, Lorenzo Bianconi wrote: > > Add selected dynamic mac address to MACAM in update_dynamic_addresses > > and not just in in ipam_add_port_addresses/ipam_insert_lsp_addresses > > since the

Re: [ovs-dev] Packet Drop Issue in OVS-DPDK L2FWD Application

2018-11-19 Thread Ian Stokes
On 11/18/2018 8:16 PM, vkrishnabhat k wrote: Hi Team, I am new to OVS and DPDK. While I am using l2fwd application with OVS and DPDK I am seeing packet drop issue in OVS bridge. Topology : My topology has Ubuntu machine (Ubuntu 18.04 LTS). I have installed Qemu-KVM 2.11.1 version. Also I am

Re: [ovs-dev] [PATCH] pinctrl: Check requested IP in DHCPREQUEST messages

2018-11-19 Thread Numan Siddique
On Fri, Nov 16, 2018 at 11:03 PM Gregory Smith wrote: > See RFC 2131, section 4.3.2. When handling a DHCPREQUEST message, the > server should validate that the client's requested IP matches the > offered IP. If not, the server should reply with a DHCPNAK. The client's > requested IP is either

[ovs-dev] Troubles with bonding commands

2018-11-19 Thread Sara Escribano
Hi everyone, I'm having several troubles with *bonding* functionalities. I'm beginning in this world and I made a topology like this one on my virtual machine: ++ |ns1 |