Re: [ovs-dev] [PATCH] datapath: Add support for kernel 4.18.x

2019-01-29 Thread Yifeng Sun
Thanks Greg for reviewing, I ran the tests locally and there is no issue. Ben, could you backport this patch to 2.11 if you can? thanks! Yifeng On Tue, Jan 29, 2019 at 4:45 PM Gregory Rose wrote: > > On 1/29/2019 2:18 PM, Yifeng Sun wrote: > > No code changing is necessary to support 4.18.x.

Re: [ovs-dev] [PATCH] datapath: Add support for kernel 4.18.x

2019-01-29 Thread Gregory Rose
On 1/29/2019 2:18 PM, Yifeng Sun wrote: No code changing is necessary to support 4.18.x. Only one kernel test failed and it is in the process of being fixed. Updated .travis.yml to include 4.18.x and also use latest 4.17 version. Updated test files to test 4.18 kernel. Signed-off-by: Yifeng

[ovs-dev] Paquete turisticos para visitar Italia

2019-01-29 Thread Turismo en ITALIA via dev
( http://www.turismoenitalia.net/ )   ( http://www.turismoenitalia.net/ ) ( http://www.turismoenitalia.net/ ) ( http://www.turismoenitalia.net/ ) ( http://www.turismoenitalia.net/ )     ( http://www.turismoenitalia.net/ )   0221 424- / 421-8982 turismoenita...@corredorproductivo.net   MAS

[ovs-dev] [RFC v2 0/7] Fast OVSDB resync after restart or failover.

2019-01-29 Thread Han Zhou
v1 -> v2: - Fixed a bug in json cache handling in patch 3/7. - Fixed XXXs. - Other minor improvements. --- In scalability test with ovn-scale-test, ovsdb-server SB load is not a problem at least with 1k HVs. However, if we restart the ovsdb-server, depending on the number of HVs and scale of

Re: [ovs-dev] suspicious skiplist code

2019-01-29 Thread Ben Pfaff
Thank you for the analysis. On Tue, Jan 29, 2019 at 05:24:52PM -0500, Mark Michelson wrote: > Hi Ben, > > I've taken a look at the code in skiplist.c and I think your concerns aren't > an issue. My search isn't exhaustive by any means, but I haven't seen any > way to make the implementation

Re: [ovs-dev] suspicious skiplist code

2019-01-29 Thread Mark Michelson
Hi Ben, I've taken a look at the code in skiplist.c and I think your concerns aren't an issue. My search isn't exhaustive by any means, but I haven't seen any way to make the implementation explode on itself. The implementation mirrors the pseudocode used in the skiplist paper that is

[ovs-dev] [PATCH] datapath: Add support for kernel 4.18.x

2019-01-29 Thread Yifeng Sun
No code changing is necessary to support 4.18.x. Only one kernel test failed and it is in the process of being fixed. Updated .travis.yml to include 4.18.x and also use latest 4.17 version. Updated test files to test 4.18 kernel. Signed-off-by: Yifeng Sun --- .travis.yml|

[ovs-dev] [RFC v2 5/7] ovsdb-monitor: Support monitor_cond_since.

2019-01-29 Thread Han Zhou
From: Han Zhou Support the new monitor method monitor_cond_since so that a client can request monitoring start from a specific point instead of always from beginning. This will reduce the cost at scenarios when server is restarted/failed-over but client still has all existing data. In these

[ovs-dev] [RFC v2 7/7] ovsdb-idl.c: Fast resync from server when connection reset.

2019-01-29 Thread Han Zhou
From: Han Zhou Use monitor_cond_since to request changes after last version of local data when connection to server is reset, without clearing the local data. It falls back to clearing and repopulate all the data when the requested id cannot be fulfilled by the server. Signed-off-by: Han Zhou

[ovs-dev] [RFC v2 6/7] ovsdb-idl.c: Support monitor_cond_since method in C IDL.

2019-01-29 Thread Han Zhou
From: Han Zhou Use monitor_cond_since in C IDL. If it is not supported by server, fall back to old method (monitor_cond, or monitor). Signed-off-by: Han Zhou --- lib/ovsdb-idl.c | 206 +++- 1 file changed, 158 insertions(+), 48 deletions(-)

[ovs-dev] [RFC v2 3/7] ovsdb-monitor: Refactor ovsdb monitor implementation.

2019-01-29 Thread Han Zhou
From: Han Zhou Current ovsdb monitor maintains pending changes through an incremental integer to figure out if the set of changes should be flushed. And it uses number 0 to represent that the change set contains all data for initial client population. It is a smart way but it prevents further

[ovs-dev] [RFC v2 4/7] ovsdb-server: Transaction history tracking.

2019-01-29 Thread Han Zhou
From: Han Zhou Maintaining last N (n = 100) transactions in memory, which will be used for future patches for generating monitor data from any point in this N transactions. Signed-off-by: Han Zhou --- ovsdb/ovsdb-server.c | 11 + ovsdb/ovsdb.c| 3 ++ ovsdb/ovsdb.h| 10

[ovs-dev] [RFC v2 2/7] ovsdb_monitor: Fix style of prototypes.

2019-01-29 Thread Han Zhou
From: Han Zhou Ommiting the parameter names in prototypes, as suggested by coding style: Omit parameter names from function prototypes when the names do not give useful information. Adjust orders of parameters as suggested by coding style. Signed-off-by: Han Zhou --- ovsdb/jsonrpc-server.c |

[ovs-dev] [RFC v2 1/7] ovsdb-client.c: fix typo

2019-01-29 Thread Han Zhou
From: Han Zhou Signed-off-by: Han Zhou --- ovsdb/ovsdb-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovsdb/ovsdb-client.c b/ovsdb/ovsdb-client.c index 83c3c12..0215357 100644 --- a/ovsdb/ovsdb-client.c +++ b/ovsdb/ovsdb-client.c @@ -1267,7 +1267,7 @@

[ovs-dev] Mes salutations

2019-01-29 Thread Mr Philippe
Mes salutations, Je me présente Monsieur Philippe MARTINEZ, je vous contacte suite à un don de 1 525 000 € que je veux vous offrir, car mes jours sont comptés. Pour plus de renseignements, je vous prie de bien vouloir me contacter à mon adresse émail personnel : philippeemarti...@gmail.com. Que le

[ovs-dev] Millennials, generación Z, baby boomers.

2019-01-29 Thread Reclutamiento de puestos operativos
Cursos escenciales - Webinar Interactivo – Jueves 07 de Febrero Reclutamiento y selección eficiente de puestos operativos La dificultad de reclutar puestos operativos puede encontrar excelentes aliados en las redes sociales, las plataformas profesionales, los blogs y el internet. Nuestro

Re: [ovs-dev] [PATCH V2 0/2] Include libverbs and libmlx4/5 when needed

2019-01-29 Thread Timothy Redaelli
On Tue, 29 Jan 2019 16:00:45 +0200 Eli Britstein wrote: > This patch set automatically links with the necessary libraries for > MLX4/5 DPDK PMDs. > > Patch 1 automatically links with the necessary libraries for MLX5 PMD > > Patch 2 automatically links with the necessary libraries for MLX4 PMD

[ovs-dev] Actualización fiscal 2019

2019-01-29 Thread Sueldos, Salarios y Prestaciones
Curso Fiscal- Webinar Interactivo - Miércoles 06 de Febrero ACTUALIZACIÓN FISCAL 2019 Sueldos, salarios y prestaciones. Estar al día en los recientes cambios fiscales derivados de la miscelánea fiscal y las reformas fiscales para el ejercicio 2019, para hacer los ajustes necesarios e

[ovs-dev] [PATCH V2 2/2] acinclude: Include libverbs and libmlx4 when needed

2019-01-29 Thread Eli Britstein
DPDK 18.11 uses libverbs and libmlx4 when MLX4 PMD is enabled. This commit makes OVS to link to libverbs and libmlx4 when MLX4 PMD is enabled on DPDK. Signed-off-by: Eli Britstein Reviewed-by: Asaf Penso --- acinclude.m4 | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-)

[ovs-dev] [PATCH V2 1/2] acinclude: Include libverbs and libmlx5 when needed

2019-01-29 Thread Eli Britstein
DPDK 18.11 uses libverbs and libmlx5 when MLX5 PMD is enabled. This commit makes OVS to link to libverbs and libmlx5 when MLX5 PMD is enabled on DPDK. Signed-off-by: Eli Britstein Reviewed-by: Shahaf Shuler Reviewed-by: Asaf Penso --- acinclude.m4 | 26 ++ 1 file

[ovs-dev] [PATCH V2 0/2] Include libverbs and libmlx4/5 when needed

2019-01-29 Thread Eli Britstein
This patch set automatically links with the necessary libraries for MLX4/5 DPDK PMDs. Patch 1 automatically links with the necessary libraries for MLX5 PMD Patch 2 automatically links with the necessary libraries for MLX4 PMD Eli Britstein (2): acinclude: Include libverbs and libmlx5 when

Re: [ovs-dev] [PATCH 1/2] dpdk: Use svec instead of re-inventing.

2019-01-29 Thread Aaron Conole
Ilya Maximets writes: > On 28.01.2019 22:21, Ian Stokes wrote: >> On 1/22/2019 1:22 PM, Ilya Maximets wrote: >>> No need to implement dynamic vector to store arguments. >>> 'svec' perfectly covers all the needed functionality. >>> >> >> Thanks for this Ilya, testing this this the last few days

Re: [ovs-dev] [PATCH] acinclude: Also use LIBS from dpkg pkg-config

2019-01-29 Thread Aaron Conole
Christian Ehrhardt writes: > On Fri, Jan 25, 2019 at 5:53 PM Aaron Conole wrote: >> >> Luca Boccassi writes: >> >> > On Fri, 2019-01-25 at 16:39 +, Luca Boccassi wrote: >> >> On Fri, 2019-01-25 at 11:28 -0500, Aaron Conole wrote: >> >> > Christian Ehrhardt writes: >> >> > >> >> > > DPDK

Re: [ovs-dev] [PATCH] dpdk: Limit DPDK memory usage.

2019-01-29 Thread Ilya Maximets
On 25.01.2019 21:56, Ben Pfaff wrote: > On Fri, Jan 25, 2019 at 04:08:10PM +0300, Ilya Maximets wrote: >> On 23.01.2019 15:40, Aaron Conole wrote: >>> Ilya Maximets writes: >>> Aaron, what do you think about supporting tags like 'Based-on' in ovsrobot ? For example, patchew in

[ovs-dev] [PATCH] skiplist: Drop data comparison in skiplist_delete.

2019-01-29 Thread Ilya Maximets
Current version of 'skiplist_delete' uses data comparator to check if the node that we're removing exists on current level. i.e. our node 'x' is the next of update[i] on the level i. But it's enough to just check pointers for that purpose. Here is the small example of how the data structures

[ovs-dev] [PATCHv7 1/3] Improved Packet Drop Statistics in OVS

2019-01-29 Thread Anju Thomas
Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in table stats. These can only be interpreted by controllers that know the

Re: [ovs-dev] [PATCH 1/1] acinclude: Include libverbs and libmlx5 when needed

2019-01-29 Thread Timothy Redaelli
On Tue, 29 Jan 2019 12:28:08 +0200 Eli Britstein wrote: > DPDK 18.11 uses libverbs and libmlx5 when MLX5 PMD is enabled. > > This commit makes OVS to link to libverbs and libmlx5 when MLX5 PMD is > enabled on DPDK. > > Signed-off-by: Eli Britstein > Reviewed-by: Shahaf Shuler > Reviewed-by:

Re: [ovs-dev] skiplist: Remove 'height' from skiplist_node.

2019-01-29 Thread Ilya Maximets
On 28.01.2019 20:48, Ilya Maximets wrote: > On 25.01.2019 23:22, Ben Pfaff wrote: >> This member was write-only: it was initialized and never used later on. >> >> Thanks to Esteban Rodriguez Betancourt for the >> following additional rationale: >> >> In this case you are right, the "height"

[ovs-dev] [PATCH 1/1] acinclude: Include libverbs and libmlx5 when needed

2019-01-29 Thread Eli Britstein
DPDK 18.11 uses libverbs and libmlx5 when MLX5 PMD is enabled. This commit makes OVS to link to libverbs and libmlx5 when MLX5 PMD is enabled on DPDK. Signed-off-by: Eli Britstein Reviewed-by: Shahaf Shuler Reviewed-by: Asaf Penso --- acinclude.m4 | 26 ++ 1 file

[ovs-dev] [PATCH v2 2/2] dpdk: Limit DPDK memory usage.

2019-01-29 Thread Ilya Maximets
Since 18.05 release, DPDK moved to dynamic memory model in which hugepages could be allocated on demand. At the same time '--socket-mem' option was re-defined as a size of pre-allocated memory, i.e. memory that should be allocated at startup and could not be freed. So, DPDK with a new memory model

[ovs-dev] [PATCH v2 1/2] dpdk: Use svec instead of re-inventing.

2019-01-29 Thread Ilya Maximets
No need to implement dynamic vector to store arguments. 'svec' perfectly covers all the needed functionality. Signed-off-by: Ilya Maximets Acked-by: Aaron Conole --- lib/dpdk.c | 221 + 1 file changed, 68 insertions(+), 153 deletions(-) diff

[ovs-dev] [PATCH v2 0/2] dpdk: svec for args + socket-limit.

2019-01-29 Thread Ilya Maximets
Version 2: * Dropped "dynamic-string" patch as already applied. * Minor changes: - s/needle/value/. - Additionally changed both "dpdk_extras" to "dpdk-extra". - Fixed indentation near "auto_determine = false;". * --socket-limit related patch added to the set (minor rebase).

Re: [ovs-dev] [PATCH 1/2] dpdk: Use svec instead of re-inventing.

2019-01-29 Thread Ilya Maximets
On 28.01.2019 22:21, Ian Stokes wrote: > On 1/22/2019 1:22 PM, Ilya Maximets wrote: >> No need to implement dynamic vector to store arguments. >> 'svec' perfectly covers all the needed functionality. >> > > Thanks for this Ilya, testing this this the last few days and seems in > working order, I