On Fri, Feb 1, 2019 at 8:37 AM Darrell Ball wrote:
> The call to inet_ntop() in repl_ftp_v6_addr() is 1 short to handle
> the maximum possible V6 address size for v4 mapping case.
>
> Found by inspection.
>
> Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
> Signed-off-by:
The call to inet_ntop() in repl_ftp_v6_addr() is 1 short to handle
the maximum possible V6 address size for v4 mapping case.
Found by inspection.
Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
Signed-off-by: Darrell Ball
---
v2: s/IPV6_SCAN_LEN/INET6_ADDRSTRLEN/ in
char
When replacing the ipv4 address in repl_ftp_v4_addr(), the remaining size
was incorrectly calculated which could lead to the wrong replacement
adjustment.
This goes unnoticed most of the time, unless you choose carefully your
initial and replacement addresses.
Example fail address combination
Hi all,
Currently, when insert/delete/lookup the shash list struct ofproto‘s
port_by_name, we have no lock to protect this list. This list was used lots of
other functions.
Is there something race issues? Can we make sure it's only used in the main
ovs thread?
Thanks.
Thanks Darrell, I will send a new version tomorrow.
On Thu, Jan 31, 2019 at 5:19 PM Darrell Ball wrote:
> Minor comments about the commit message Yifeng
>
> On Thu, Jan 31, 2019 at 3:10 PM Yifeng Sun wrote:
>
>> Test "flow resume with geneve tun_metadata" failed because there is
>> no
Can you send patch with this information in commit msg?
On Thu, Jan 31, 2019 at 3:32 AM Eli Britstein wrote:
>
> ping
>
> for the using patch, i put below the v1 of it. here is v2:
>
> https://patchwork.ozlabs.org/patch/1023406/
>
>
> On 1/27/2019 8:37 AM, Eli Britstein wrote:
> >
> > On
On Thu, Jan 31, 2019 at 08:59:31PM -0500, 0-day Robot wrote:
> Bleep bloop. Greetings Hyong Youb Kim via dev, I am a robot and I have tried
> out your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> checkpatch:
>
Bleep bloop. Greetings Hyong Youb Kim via dev, I am a robot and I have tried
out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author should not be mailing list.
Lines checked: 38, Warnings: 0, Errors: 1
Run ovs-tcpdump without --span, and it throws the following
exception. Define mirror_select_all to avoid the error.
Traceback (most recent call last):
File "/usr/local/bin/ovs-tcpdump", line 488, in
main()
File "/usr/local/bin/ovs-tcpdump", line 454, in main
mirror_select_all)
Minor comments about the commit message Yifeng
On Thu, Jan 31, 2019 at 3:10 PM Yifeng Sun wrote:
> Test "flow resume with geneve tun_metadata" failed because there is
> no controller running to send controller(pause) message.
The controller receives a 'pause' related to the continuation.
The
On Thu, Jan 31, 2019 at 05:03:12PM -0500, Aaron Conole wrote:
> Hyong Youb Kim via dev writes:
>
> > Run ovs-tcpdump with --span, and it throws the following
> > exception. Define mirror_select_all to avoid the error.
> >
> > Traceback (most recent call last):
> > File
Hmmm...
I used the accepted (or at least previously accepted) method for
upstream commits. Has something changed?
- Greg
On 1/31/2019 1:59 PM, 0-day Robot wrote:
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered
OVS supports Nicira version of Flow Monitor feature which allows an OpenFlow
controller to keep track of any changes in the flow table. (The changes can
done by the controller itself or by any other controller connected to OVS.)
This patch adds support for the OpenFlow 1.4+ OFPMP_FLOW_MONITOR
Test "flow resume with geneve tun_metadata" failed because there is
no controller running to send controller(pause) message. A previous
commit deleted the line that starts ovs-ofctl as a controller in
order to avoid a race condition on monitor log. This patch adds
back this line but omits the log
Kmod tests 122 and 123 failed and kernel reports a "Duplicate key of
type 6" error. Further debugging reveals that nl_attr_find__() should
start looking for OVS_KEY_ATTR_ETHERTYPE from offset returned by
a previous called nl_msg_start_nested(). This patch fixes it.
Tests 122 and 123 were skipped
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Yi-Hung Wei needs to sign off.
WARNING: Unexpected sign-offs from developers who
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Yi-Hung Wei needs to sign off.
WARNING: Unexpected sign-offs from developers who
Hyong Youb Kim via dev writes:
> Run ovs-tcpdump with --span, and it throws the following
> exception. Define mirror_select_all to avoid the error.
>
> Traceback (most recent call last):
> File "/usr/local/bin/ovs-tcpdump", line 488, in
> main()
> File "/usr/local/bin/ovs-tcpdump", line
Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Ross Lagerwall needs to sign off.
WARNING: Unexpected sign-offs from developers who
On Thu, Jan 31, 2019 at 1:17 PM Greg Rose wrote:
>
> From: Ross Lagerwall
>
> Upstream commit:
> commit 04a4af334b971814eedf4e4a413343ad3287d9a9
> Author: Ross Lagerwall
> Date: Mon Jan 14 09:16:56 2019 +
>
> openvswitch: Avoid OOB read when parsing flow nlattrs
>
>
From: Yi-Hung Wei
Upstream commit:
commit 41e4e2cd75346667b0c531c07dab05cce5b06d15
Author: Yi-Hung Wei
Date: Thu Jan 3 09:51:57 2019 -0800
openvswitch: Fix IPv6 later frags parsing
The previous commit fa642f08839b
("openvswitch: Derive IP protocol number for IPv6
From: Ross Lagerwall
Upstream commit:
commit 04a4af334b971814eedf4e4a413343ad3287d9a9
Author: Ross Lagerwall
Date: Mon Jan 14 09:16:56 2019 +
openvswitch: Avoid OOB read when parsing flow nlattrs
For nested and variable attributes, the expected length of an attribute
From: Yi-Hung Wei
Upstream commit:
commit fa642f08839bf2ff35b2f6c6a6c062aee8121ba8
Author: Yi-Hung Wei
Date: Tue Sep 4 15:33:41 2018 -0700
openvswitch: Derive IP protocol number for IPv6 later frags
Currently, OVS only parses the IP protocol number for the first
IPv6
Martin Xu writes:
> OVS init.d script calls ovs-ctl with $OVS_CTL_OPTS defined in the
> config file. This variable is replaced by OPTIONS in systemd service
> files. This patch addes $OVS_CTL_OPTS back to be passed along with $OPTIONS
> for backward compatibility.
>
> VMware-BZ: #2036847
>
>
Want to make white background for your images?
We can add clipping path, or give retouching for your photos if needed.
Let's start testing for your photos.
Thanks,
Julie
Heilbronn
Siegburg
___
dev mailing list
d...@openvswitch.org
On 31.01.2019 17:17, Ilya Maximets wrote:
> On 31.01.2019 15:39, Ian Stokes wrote:
>> On 1/29/2019 8:11 AM, Ilya Maximets wrote:
>>> Since 18.05 release, DPDK moved to dynamic memory model in which
>>> hugepages could be allocated on demand. At the same time '--socket-mem'
>>> option was
On 31/01/2019 15:32, Roi Dayan wrote:
>
> On 31/01/2019 11:58, Simon Horman wrote:
>> On Mon, Jan 21, 2019 at 05:32:37PM +0200, Adi Nissim wrote:
>>> Currently the TC tunnel_key action is always
>>> initialized with the given tunnel id value. However,
>>> some tunneling protocols define the
On 31.01.2019 15:39, Ian Stokes wrote:
> On 1/29/2019 8:11 AM, Ilya Maximets wrote:
>> Since 18.05 release, DPDK moved to dynamic memory model in which
>> hugepages could be allocated on demand. At the same time '--socket-mem'
>> option was re-defined as a size of pre-allocated memory, i.e. memory
On 31/01/2019 11:58, Simon Horman wrote:
> On Mon, Jan 21, 2019 at 05:32:37PM +0200, Adi Nissim wrote:
>> Currently the TC tunnel_key action is always
>> initialized with the given tunnel id value. However,
>> some tunneling protocols define the tunnel id as an optional field.
>>
>> This patch
On 1/29/2019 8:11 AM, Ilya Maximets wrote:
Since 18.05 release, DPDK moved to dynamic memory model in which
hugepages could be allocated on demand. At the same time '--socket-mem'
option was re-defined as a size of pre-allocated memory, i.e. memory
that should be allocated at startup and could
ping
for the using patch, i put below the v1 of it. here is v2:
https://patchwork.ozlabs.org/patch/1023406/
On 1/27/2019 8:37 AM, Eli Britstein wrote:
>
> On 1/27/2019 1:04 AM, David Miller wrote:
>> From: Eli Britstein
>> Date: Thu, 24 Jan 2019 11:46:47 +0200
>>
>>> Declare ovs key
Yes you're right, the master branch has no problem here. I am sorry for that
it's my own code's errors causing the deadlock.
We MUST make sure that dp->port_mutex is not used in pmd thread context.
Thanks very much.
> -Original Message-
> From: Ilya Maximets
On Mon, Jan 21, 2019 at 05:32:37PM +0200, Adi Nissim wrote:
> Currently the TC tunnel_key action is always
> initialized with the given tunnel id value. However,
> some tunneling protocols define the tunnel id as an optional field.
>
> This patch initializes the id field of tunnel_key:set and
On Thu, Jan 31, 2019 at 07:21:53AM +, Roi Dayan wrote:
> Hi Simon,
>
> Just pinging about this change.
Sorry for the delay, I am looking at it now.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Jan 28, 2019 at 12:29:06PM +, Pieter Jansen van Vuuren wrote:
> Hi all,
>
> This set fixes and subsequently extends the ovs-tc pedit interface
> to allow setting ipv4 dscp and ecn fields as well as ipv6 traffic
> class in tc via pedit. Patch 1 introduces a new sparse header which
>
Hi.
On 31.01.2019 8:57, Lilijun wrote:
> This patch fix the dead lock when using dpdk userspace datapath. The
> problem is described as follows:
> 1) when add or delete port, the main thread will call
> reconfigure_datapath() in the function dpif_netdev_run()
> 2) Here the dp->port_mutex is
Bleep bloop. Greetings Hyong Youb Kim via dev, I am a robot and I have tried
out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author should not be mailing list.
Lines checked: 38, Warnings: 0, Errors: 1
This patch fix the dead lock when using dpdk userspace datapath. The
problem is described as follows:
1) when add or delete port, the main thread will call
reconfigure_datapath() in the function dpif_netdev_run()
2) Here the dp->port_mutex is locked. In dp_netdev_reload_pmd__(), it
will notify
On Thu, Jan 31, 2019 at 12:21:52AM -0800, Hyong Youb Kim wrote:
> Run ovs-tcpdump with --span, and it throws the following
> exception. Define mirror_select_all to avoid the error.
Oops, a typo. "with" should be "without". I can send v2 if really
necessary..
-Hyong
Run ovs-tcpdump with --span, and it throws the following
exception. Define mirror_select_all to avoid the error.
Traceback (most recent call last):
File "/usr/local/bin/ovs-tcpdump", line 488, in
main()
File "/usr/local/bin/ovs-tcpdump", line 454, in main
mirror_select_all)
40 matches
Mail list logo
