[ovs-dev] [PATCH net-next v3] openvswitch: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

2019-03-25 Thread wenxu
From: wenxu There is currently no support for the multicast/broadcast aspects of VXLAN in ovs. In the datapath flow the tun_dst must specific. But in the IP_TUNNEL_INFO_BRIDGE mode the tun_dst can not be specific. And the packet can forward through the fdb table of vxlan devcice. In this mode the

Re: [ovs-dev] [PATCH 2/2] ovs: tests: Adjust the test cases about group stats

2019-03-25 Thread solomon
Roi Dayan wrote> > > Hi, > > the title of the patch has non utf8 chars after the word 'tests'. > can you check please. > > I see it as > > ovs: tests???Adjust the test cases about group stats yes, there is a Chinese colon in original title. > > Thanks, > Roi > __

Re: [ovs-dev] [PATCH v4 2/5] ovn: Add generic HA chassis group

2019-03-25 Thread Han Zhou
Mostly looks good to me, just minor comments. On Thu, Mar 14, 2019 at 12:32 PM wrote: > > +static void > +build_lrouter_groups__(struct hmap *ports, struct ovn_datapath *od) > +{ > +ovs_assert((od && od->nbr && od->lr_group)); > + > +if (od->l3dgw_port && od->l3redirect_port) { > +

Re: [ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-25 Thread solomon
Ben Pfaff wrote: > On Thu, Mar 21, 2019 at 10:41:05AM +0800, solomon wrote: >> Ben Pfaff wrote: >>> On Wed, Mar 20, 2019 at 08:16:18PM +0800, Li Wei wrote: After inserting/removing a bucket, we don't update the bucket counter. When we call ovs-ofctl dump-group-stats br-int, a panic

[ovs-dev] [PATCH v2 net-next] net: openvswitch: Add a new action check_pkt_len

2019-03-25 Thread nusiddiq
From: Numan Siddique This patch adds a new action - 'check_pkt_len' which checks the packet length and executes a set of actions if the packet length is greater than the specified length or executes another set of actions if the packet length is lesser or equal to. This action takes below nlattr

Re: [ovs-dev] [PATCH] hmap: Improve debug log message when reporting unusually large buckets.

2019-03-25 Thread Han Zhou
On Mon, Mar 25, 2019 at 4:57 PM Ben Pfaff wrote: > > I was seeing a lot of these messages, including a lot of them suppressed > by rate-limiting, and I wondered whether any really big messages were > being suppressed. By reporting the largest bucket, instead of just every > large bucket, it becom

[ovs-dev] [PATCH] hmap: Improve debug log message when reporting unusually large buckets.

2019-03-25 Thread Ben Pfaff
I was seeing a lot of these messages, including a lot of them suppressed by rate-limiting, and I wondered whether any really big messages were being suppressed. By reporting the largest bucket, instead of just every large bucket, it becomes more likely that the truly too-large buckets get reported

Re: [ovs-dev] [PATCH V7 2/2] odp-util: Do not rewrite fields with the same values as matched

2019-03-25 Thread Ben Pfaff
On Thu, Mar 21, 2019 at 07:44:16AM +, Eli Britstein wrote: > To improve performance and avoid wasting resources for HW offloaded > flows, do not rewrite fields that are matched with the same value. > > Signed-off-by: Eli Britstein > Reviewed-by: Roi Dayan Thanks. I applied this series to m

Re: [ovs-dev] [PATCH v5] ovsdb raft: Sync commit index to followers without delay.

2019-03-25 Thread Han Zhou
On Mon, Mar 25, 2019 at 2:00 PM Ben Pfaff wrote: > > On Sat, Mar 23, 2019 at 09:44:26AM -0700, Han Zhou wrote: > > From: Han Zhou > > > > When update is requested from follower, the leader sends AppendRequest > > to all followers and wait until AppendReply received from majority, and > > then it

[ovs-dev] Camaras de seguridad y reloj checadores a el mejor precio

2019-03-25 Thread Seguridad Patrimonial
Promoción Cámaras de Seguridad, 8 Cámaras de Seguridad todo Incluido. No Incluye Instalación Precio Original$10,953.00 20% Costo Actual $8,764.80 Sistema TURBOHD 1080p / DVR 8 Canales / 8 Cámaras Bala (exterior 2.8 mm) / Transceptores / Conectores / Fuente

Re: [ovs-dev] [PATCH 0/3] OVN: Fixes regarding RA prefixes

2019-03-25 Thread Ben Pfaff
On Mon, Mar 25, 2019 at 05:29:53PM -0400, Mark Michelson wrote: > This is a series of patches that fix some errors with router > advertisements. Each individual patch will explain the issues more > completely. > > This patch series is built against OVS master, but it will need to be > backported a

Re: [ovs-dev] [PATCH v3 0/2] ovn-controller: Add a new thread in pinctrl module to process packet-ins

2019-03-25 Thread Ben Pfaff
On Sat, Mar 16, 2019 at 11:27:06AM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > This series attempts to add a new thread in pinctrl module. This thread > will handle the packet-ins. > > > v2 -> v3 > - >* Fixed the clang errors. > > v1 -> v2 > -- > * Added a new pa

[ovs-dev] [PATCH 3/3] OVN: Make periodic RAs consistent with RA responder.

2019-03-25 Thread Mark Michelson
This commit makes periodic RAs from OVN consistent with the RAs sent in response to RSs. Specifically, this ensures that prefix flags are set correctly for each address mode. This commit also gets rid of some redundant definitions for RA prefix option flags from packets.h in favor of the ones in o

[ovs-dev] [PATCH 2/3] OVN: Always send prefix option in RAs

2019-03-25 Thread Mark Michelson
OVN's behavior when sending router advertisements has been to include IP prefix information only if the address mode is set to "slaac" or "dhcp_stateless". In these modes, sending the prefix to the client is necessary so that it may automatically provision its IP address. We do not send the prefix

[ovs-dev] [PATCH 1/3] OVN: Use offset instead of pointer into ofpbuf

2019-03-25 Thread Mark Michelson
In general, maintaining a pointer into an ofpbuf is risky. As the ofpbuf grows, it can reallocate its data. If this happens, then pointers into the data will become invalid. A safer practice is to track an offset into the ofpbuf's data where a structure you are interested in is kept. This way, if

[ovs-dev] [PATCH 0/3] OVN: Fixes regarding RA prefixes

2019-03-25 Thread Mark Michelson
This is a series of patches that fix some errors with router advertisements. Each individual patch will explain the issues more completely. This patch series is built against OVS master, but it will need to be backported as far back as 2.9 Mark Michelson (3): OVN: Use offset instead of pointer

Re: [ovs-dev] [patch v1] tests: Remove maximum version kernel check.

2019-03-25 Thread Ben Pfaff
On Sat, Mar 16, 2019 at 11:50:24AM -0700, Darrell Ball wrote: > The macro 'OVS_CHECK_KERNEL' was checking for maximum supported kernel > version. This means checks like 'OVS_CHECK_KERNEL(3, 10, 4, 18)' > in various tests need to be updated when each new kernel version is > supported. This is unnec

Re: [ovs-dev] [PATCH v5] ovsdb raft: Sync commit index to followers without delay.

2019-03-25 Thread Ben Pfaff
On Sat, Mar 23, 2019 at 09:44:26AM -0700, Han Zhou wrote: > From: Han Zhou > > When update is requested from follower, the leader sends AppendRequest > to all followers and wait until AppendReply received from majority, and > then it will update commit index - the new entry is regarded as committ

Re: [ovs-dev] [PATCH] ovs: fix the bug of bucket counter is not updated

2019-03-25 Thread Ben Pfaff
On Thu, Mar 21, 2019 at 10:41:05AM +0800, solomon wrote: > Ben Pfaff wrote: > > On Wed, Mar 20, 2019 at 08:16:18PM +0800, Li Wei wrote: > >> > >> After inserting/removing a bucket, we don't update the bucket counter. > >> When we call ovs-ofctl dump-group-stats br-int, a panic happened. > > > > Th

[ovs-dev] explanation and workaround (was: Re: OVS mailing lists *sometimes* replace the From: address by the list address)

2019-03-25 Thread Ben Pfaff
I obtained an explanation from LF about this issue. It is not due to an mailing list configuration change. It results from DMARC, which is a setting for email sender domains that causes receivers to reject email that is allegedly from the domain if it cannot be verified that it really came from i

Re: [ovs-dev] [PATCH net-next v2] openvswitch: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

2019-03-25 Thread Pravin Shelar
On Sat, Mar 23, 2019 at 4:03 AM wrote: > > From: wenxu > > There is currently no support for the multicast/broadcast aspects > of VXLAN in ovs. In the datapath flow the tun_dst must specific. > But in the IP_TUNNEL_INFO_BRIDGE mode the tun_dst can not be specific. > And the packet can forward thr

Re: [ovs-dev] [PATCH net-next] openvswitch: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

2019-03-25 Thread Pravin Shelar
On Sun, Mar 24, 2019 at 6:24 PM wenxu wrote: > > On 2019/3/25 上午2:46, Pravin Shelar wrote: > > On Sun, Mar 24, 2019 at 12:03 AM wenxu wrote: > >> On 2019/3/24 上午5:39, Pravin Shelar wrote: > >>> On Sat, Mar 23, 2019 at 2:18 AM wenxu wrote: > On 2019/3/23 下午3:50, Pravin Shelar wrote: > >

[ovs-dev] [PATCH net-next v2] openvswitch: add seqadj extension when NAT is used.

2019-03-25 Thread Flavio Leitner
When the conntrack is initialized, there is no helper attached yet so the nat info initialization (nf_nat_setup_info) skips adding the seqadj ext. A helper is attached later when the conntrack is not confirmed but is going to be committed. In this case, if NAT is needed then adds the seqadj ext as

[ovs-dev] [PATCH v2] OVN: Add support for Transport Zones

2019-03-25 Thread lmartins
From: Lucas Alvares Gomes This patch is adding support for Transport Zones. Transport zones (a.k.a TZs) is way to enable users of OVN to separate Chassis into different logical groups that will form tunnels only between members of the same group(s). Each Chassis can belong to one or more Transpo

Re: [ovs-dev] [PATCH v2] datapath-windows: Address memory allocation issues for OVS_BUFFER_CONTEXT

2019-03-25 Thread aserdean
-Original Message- From: ovs-dev-boun...@openvswitch.org On Behalf Of Anand Kumar via dev Sent: Thursday, March 21, 2019 1:55 AM To: d...@openvswitch.org Subject: [ovs-dev] [PATCH v2] datapath-windows: Address memory allocation issues for OVS_BUFFER_CONTEXT With current implementation, wh

Re: [ovs-dev] [PATCH] OVN: Add support for Transport Zones

2019-03-25 Thread Lucas Alvares Gomes Martins
Hi, Thanks a lot Mark for the quick review. On Mon, Mar 25, 2019 at 3:40 PM Mark Michelson wrote: > > Hi Lucas, > > Thanks for the patch. It's mostly good but I have a few issues with it. > See below. > > On 3/25/19 10:36 AM, lmart...@redhat.com wrote: > > From: Lucas Alvares Gomes > > > > This

Re: [ovs-dev] [RFC v4 1/1] datapath: Add a new action check_pkt_len

2019-03-25 Thread Gregory Rose
On 3/25/2019 5:30 AM, Numan Siddique wrote: On Mon, Mar 25, 2019 at 12:07 AM Numan Siddique > wrote: On Fri, Mar 22, 2019 at 9:10 PM Gregory Rose mailto:gvrose8...@gmail.com>> wrote: On 3/22/2019 2:58 AM, Numan Siddique wrote: On Fri, M

Re: [ovs-dev] [RFC v4 1/1] datapath: Add a new action check_pkt_len

2019-03-25 Thread Gregory Rose
On 3/24/2019 11:37 AM, Numan Siddique wrote: On Fri, Mar 22, 2019 at 9:10 PM Gregory Rose > wrote: On 3/22/2019 2:58 AM, Numan Siddique wrote: On Fri, Mar 22, 2019 at 6:16 AM Gregory Rose mailto:gvrose8...@gmail.com>> wrote: On 3/21/201

Re: [ovs-dev] [PATCH v5 3/3] dpif-netdev: split out generic lookup function

2019-03-25 Thread Van Haaren, Harry
> -Original Message- > From: Ilya Maximets [mailto:i.maxim...@samsung.com] > Sent: Friday, March 22, 2019 1:19 PM > To: Van Haaren, Harry ; Eelco Chaudron > > Cc: ovs-dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v5 3/3] dpif-netdev: split out generic lookup > function > > On 22.03.

Re: [ovs-dev] [PATCH] OVN: Add support for Transport Zones

2019-03-25 Thread Mark Michelson
Hi Lucas, Thanks for the patch. It's mostly good but I have a few issues with it. See below. On 3/25/19 10:36 AM, lmart...@redhat.com wrote: From: Lucas Alvares Gomes This patch is adding support for Transport Zones. Transport zones (a.k.a TZs) is way to enable users of OVN to separate Chas

[ovs-dev] Rotación Cero - ultimos lugares

2019-03-25 Thread Estrategias de fidelización de personal.
Cursos TOP - Webinar Interactivo – Miércoles 03 de Abril Rotación Cero - Abril 03 La rotación de personal es un fenómeno que afecta a la mayoría de las organizaciones y merma el rendimiento de los colaboradores. Presentaremos los fundamentos para identificar el impacto que la rotación de perso

Re: [ovs-dev] [PATCH net-next] openvswitch: add seqadj extension when NAT is used.

2019-03-25 Thread Flavio Leitner
On Sat, Mar 23, 2019 at 12:32:37PM -0700, Pravin Shelar wrote: > On Thu, Mar 21, 2019 at 9:52 AM Flavio Leitner wrote: > > > > When the conntrack is initialized, there is no helper attached > > yet so the nat info initialization (nf_nat_setup_info) skips > > adding the seqadj ext. > > > > A helper

[ovs-dev] [PATCH] OVN: Add support for Transport Zones

2019-03-25 Thread lmartins
From: Lucas Alvares Gomes This patch is adding support for Transport Zones. Transport zones (a.k.a TZs) is way to enable users of OVN to separate Chassis into different logical groups that will form tunnels only between members of the same group(s). Each Chassis can belong to one or more Transpo

Re: [ovs-dev] [RFC v4 1/1] datapath: Add a new action check_pkt_len

2019-03-25 Thread Numan Siddique
On Mon, Mar 25, 2019 at 12:07 AM Numan Siddique wrote: > > > On Fri, Mar 22, 2019 at 9:10 PM Gregory Rose wrote: > >> >> On 3/22/2019 2:58 AM, Numan Siddique wrote: >> >> >> >> On Fri, Mar 22, 2019 at 6:16 AM Gregory Rose >> wrote: >> >>> >>> >>> On 3/21/2019 5:38 PM, Gregory Rose wrote: >>> >

Re: [ovs-dev] [PATCH] bridge: Propagate patch port pairing errors to db.

2019-03-25 Thread Eelco Chaudron
On 22 Mar 2019, at 13:58, Ilya Maximets wrote: > Virtual ports like 'patch' ports that almost fully implemented on > 'ofproto' layer could have internal to 'ofproto' statuses that > could not be retrieved from 'netdev' or other layers. For example, > in current implementation there is no way to

Re: [ovs-dev] [ovs-dev, RFC] vswitchd: warn about misconfigured interface type on netdev bridge

2019-03-25 Thread Eelco Chaudron
On 20 Mar 2019, at 10:28, Ilya Maximets wrote: On 20.03.2019 12:18, Ilya Maximets wrote: On 20.03.2019 11:34, Ilya Maximets wrote: On 20.03.2019 11:01, Eelco Chaudron wrote: On 19 Mar 2019, at 16:51, Ilya Maximets wrote: On 19.03.2019 12:23, Eelco Chaudron wrote: When debugging an issue

[ovs-dev] [PATCH] [windows][wmi] Switch from internal port to all ports defined

2019-03-25 Thread Alin Gabriel Serdean
This patch changes the way we try to figure out if a port is defined on a given switch. Instead of looking only in the internal ports defined switch to all ports defined. This caused issues when trying to add a Hyper-V container port to a given OVS bridge. Reported-by: Danting Liu Signed-off

Re: [ovs-dev] [PATCH v3] dpif-netdev: dfc_process optimization by prefetching EMC entry.

2019-03-25 Thread Yanqin Wei (Arm Technology China)
Hi Ilya, Thanks for your reply. We could have a look at test results in x86 by then. I can understand patch 1054571. If both patches are apply to master, I could rebase prefetch EMC patch for it. Mandatory hash computing in the ingress makes logic simple a lot, and it only costs a small price ev