Re: [ovs-dev] [PATCH v10] Improved Packet Drop Statistics in OVS

Bleep bloop. Greetings Anju Thomas, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: :804: new blank line at EOF. + warning: 1 line adds whitespace errors. Failed to merge in the change

Re: [ovs-dev] [PATCH v10] Improved Packet Drop Statistics in OVS

Please disregard this path .. Sending an updated v10 -Original Message- From: 0-day Robot Sent: Friday, June 7, 2019 9:31 AM To: Anju Thomas Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v10] Improved Packet Drop Statistics in OVS Bleep bloop. Greetings Anju Thomas, I am a r

[ovs-dev] [PATCH v10] Improved Packet Drop Statistics in OVS

Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in table stats. These can only be interpreted by controllers that know the semantics of the c

Re: [ovs-dev] [PATCH v10] Improved Packet Drop Statistics in OVS

Bleep bloop. Greetings Anju Thomas, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: -e 's,[@]DBDIR[@],/usr/local/etc/openvswitch,g' \ -e 's,[@]PYTHON[@],/bin/python2,g' \ -e

[ovs-dev] [PATCH v10] Improved Packet Drop Statistics in OVS

Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in table stats. These can only be interpreted by controllers that know the semantics of the

Re: [ovs-dev] [PATCH v9] Improved Packet Drop Statistics in OVS

Hi, Oh.. You are right I did send the wrong version. Let me send the latest version. Regards Anju -Original Message- From: Ilya Maximets Sent: Thursday, June 6, 2019 8:18 PM To: Anju Thomas ; ovs-dev@openvswitch.org Cc: Eelco Chaudron Subject: Re: [ovs-dev] [PATCH v9] Improved Packet D

[ovs-dev] Hallo

Hallo, Ich bin sophie Wie geht es Ihnen?? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ip_tunnel: Fix bugs that could crash kernel

I am so sorry, replied in the wrong patch. I send another email in the correct patch. Thanks, Yifeng On Thu, Jun 6, 2019 at 5:39 PM Ben Pfaff wrote: > > Would you mind looking again? For me, > git log origin/branch-2.10 --grep 'ip_tunnel: Fix bugs' > does show this commit. > > On Thu, J

Re: [ovs-dev] [PATCH v2 1/4] ip6_gre: Fix a bug that clears address bits

Hi Ben, Can you please backport this patch to 2.10, thanks. Yifeng On Thu, Aug 16, 2018 at 9:14 AM Gregory Rose wrote: > > > On 8/15/2018 6:24 AM, Yifeng Sun wrote: > > In compatable gre module, skb->cb is solely used as ovs_gso_cb. > > However, IPCB(skb) also points to skb->cb. IPCB(skb)->flag

Re: [ovs-dev] [PATCH] ip_tunnel: Fix bugs that could crash kernel

Would you mind looking again? For me, git log origin/branch-2.10 --grep 'ip_tunnel: Fix bugs' does show this commit. On Thu, Jun 06, 2019 at 04:47:59PM -0700, Yifeng Sun wrote: > Hi Ben, > > Could you check and backport this patch to branch-2.10. > I checked and branch-2.10 doesn't conta

Re: [ovs-dev] [PATCH] ip_tunnel: Fix bugs that could crash kernel

Hi Ben, Could you check and backport this patch to branch-2.10. I checked and branch-2.10 doesn't contain this fix. Thanks Greg for the checking! Thanks, Yifeng On Wed, Aug 15, 2018 at 1:28 PM Ben Pfaff wrote: > > On Fri, Jul 20, 2018 at 04:13:14PM -0700, William Tu wrote: > > On Fri, Jul 20,

Re: [ovs-dev] [PATCH] ovn: Send GARP for the router ports connected to localnet switches

On Wed, May 1, 2019 at 9:04 AM wrote: > > From: Numan Siddique > > With the commit [1], the routing for the provider logical switches > connected to a router is centralized on the master gateway chassis > (if the option - reside-on-redirect-chassis) is set. When the > failover happens and a stand

Re: [ovs-dev] [PATCH v9 2/2] OVN: Enable N-S Traffic, Vlan backed DVR

Hi Numan, Thanks for trying out the patch and providing feedback. I am planning to change this series to reflect only the E-W and would send out separate patches for N-S improvements. Following is the reasoning: == a. I agree that the network_type construct is adding to the c

[ovs-dev] [patch v4] conntrack: Optimize recirculations.

Cache the 'conn' context and use it when it is valid. The cached 'conn' context will get reset if it is not expected to be valid; a negative test is added to check this. Signed-off-by: Darrell Ball --- v4: Reset 'conn' cache context automatically when tuple changes, rather than needing an e

Re: [ovs-dev] [PATCH v6 1/2] Avoid packet drop on LACP bond after link up

On Thu, Jun 06, 2019 at 06:40:19AM +, Nitin Katiyar wrote: > > > > -Original Message- > > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: Tuesday, June 04, 2019 11:39 PM > > To: Nitin Katiyar > > Cc: ovs-dev@openvswitch.org; Manohar Krishnappa Chidambaraswamy > > > > Subject: Re: [o

Re: [ovs-dev] [PATCH 0/3] Fix sparse build with DPDK and --enable-Werror on Travis.

On 06.06.2019 17:54, Ben Pfaff wrote: > On Tue, May 28, 2019 at 06:05:48PM +0300, Ilya Maximets wrote: >> This patch-set fixed broken "sparse" build with DPDK >> and uses "--enable-Werror" to prevent regressions and >> also catch flake8 warnings that was ignored previously. > > Works for me. > >

Re: [ovs-dev] [PATCH 0/2] dpif-netdev: Flow mark leak + cross-dp offloading.

On 06.06.2019 13:25, Roni Bar Yanai wrote: > Acked-By: Roni Bar Yanai Thanks! Applied to master and backported down to branch-2.10. Best regards, Ilya Maximets. > >> -Original Message- >> From: Ilya Maximets >> Sent: Thursday, June 6, 2019 1:16 PM >> To: ovs-dev@openvswitch.org >> Cc:

Re: [ovs-dev] [PATCH 0/3] Fix sparse build with DPDK and --enable-Werror on Travis.

On Tue, May 28, 2019 at 06:05:48PM +0300, Ilya Maximets wrote: > This patch-set fixed broken "sparse" build with DPDK > and uses "--enable-Werror" to prevent regressions and > also catch flake8 warnings that was ignored previously. Works for me. For all the patches: Acked-by: Ben Pfaff _

Re: [ovs-dev] [PATCH v9] Improved Packet Drop Statistics in OVS

On 06.06.2019 17:28, Anju Thomas wrote: > Hi Ilya, > Yes, I have addressed those comments in v9. That is really strange. Maybe you've sent the wrong version? That is what I (and everyone else) received: https://mail.openvswitch.org/pipermail/ovs-dev/2019-February/356743.html It's the same code

Re: [ovs-dev] [PATCH v9] Improved Packet Drop Statistics in OVS

Hi Ilya, Yes, I have addressed those comments in v9. Regards & Thanks Anju -Original Message- From: Ilya Maximets Sent: Tuesday, June 4, 2019 12:33 PM To: ovs-dev@openvswitch.org; Anju Thomas Cc: Eelco Chaudron Subject: Re: Re: [ovs-dev] [PATCH v9] Improved Packet Drop Statistics in

[ovs-dev] WebMail Login Notification

Attention d...@openvswitch.org, Recently we received some notifications regarding your account: d...@openvswitch.org. We will ensure that we block your account if you do not update your email security.Please kindly click the link below to carry out the maintenance o

Re: [ovs-dev] [dpdk-latest PATCH] netdev-dpdk: Prefix network structures with rte_.

On Thu, Jun 6, 2019 at 1:25 PM Ian Stokes wrote: > On 6/4/2019 12:14 PM, David Marchand wrote: > > On Tue, Jun 4, 2019 at 11:29 AM David Marchand > > mailto:david.march...@redhat.com>> wrote: > > > > Following a rework of dpdk network structures names [1], update the > > concerned parts.

Re: [ovs-dev] [dpdk-latest PATCH] netdev-dpdk: Prefix network structures with rte_.

On 6/4/2019 12:14 PM, David Marchand wrote: On Tue, Jun 4, 2019 at 11:29 AM David Marchand mailto:david.march...@redhat.com>> wrote: Following a rework of dpdk network structures names [1], update the concerned parts. Ran Olivier script: sh prefix-net-rte.sh $(find -name "*dpdk

Re: [ovs-dev] [PATCH v4 1/4] netdev: Dynamic per-port Flow API.

On 06.06.2019 13:38, Roni Bar Yanai wrote: > Hi Ilya, > was curious myself. Mark & RSS is working (didn't test with representors > yet). Hi. Thanks for testing! > I've tested offload is supported on vport using !has_system_port, do you > think failing in this test is enough to say that this i

Re: [ovs-dev] [PATCH v4 1/4] netdev: Dynamic per-port Flow API.

Hi Ilya, was curious myself. Mark & RSS is working (didn't test with representors yet). I've tested offload is supported on vport using !has_system_port, do you think failing in this test is enough to say that this is netdev bridge port? When I returned supported, "dpdk_put" was called as expec

Re: [ovs-dev] [PATCH 0/2] dpif-netdev: Flow mark leak + cross-dp offloading.

Acked-By: Roni Bar Yanai >-Original Message- >From: Ilya Maximets >Sent: Thursday, June 6, 2019 1:16 PM >To: ovs-dev@openvswitch.org >Cc: Ian Stokes ; Flavio Leitner ; >Ophir >Munk ; Kevin Traynor ; Roni >Bar Yanai >Subject: Re: [PATCH 0/2] dpif-netdev: Flow mark leak + cross-dp offloa

Re: [ovs-dev] [PATCH 0/2] dpif-netdev: Flow mark leak + cross-dp offloading.

Hi everyone. These patches are bug fixes for issues that affects not only the master branch. It'll be good if someone could review them. Best regards, Ilya Maximets. On 13.05.2019 17:01, Ilya Maximets wrote: > Ilya Maximets (2): > dpif-netdev: Fix flow mark leak on port lookup failure. > dpi

Re: [ovs-dev] [PATCH 0/5] Quicker pmd threads reloads

On Thu, Jun 6, 2019 at 10:16 AM Stokes, Ian wrote: > Hi David, > > > > My apologies, I’ve been busy off the mailing list lately so unfortunately > I didn’t have a chance to look at this, I’ll try to take a look over the > next few days. > No worries, I understand everyone is busy with their own

Re: [ovs-dev] [PATCH] ofproto: Preserve ofport number for failed ofport across restarts

> > > > This patch reserves the ofport port number for the duration the ofport > > entry persists in the ovsdb. Once the entry is deleted from ovsdb the > > ofport number is recirculated on LRU basis. > > > > Signed-off-by: Vishal Deep Ajmera > > This is an interesting patch and I like the idea.

Re: [ovs-dev] [PATCH 0/5] Quicker pmd threads reloads

Hi David, My apologies, I’ve been busy off the mailing list lately so unfortunately I didn’t have a chance to look at this, I’ll try to take a look over the next few days. Regards Ian From: David Marchand [mailto:david.march...@redhat.com] Sent: Thursday, June 6, 2019 8:36 AM To: Ilya Maximets

Re: [ovs-dev] [PATCH 0/5] Quicker pmd threads reloads

On 06.06.2019 10:35, David Marchand wrote: > Hello guys, > > On Thu, May 23, 2019 at 4:27 PM David Marchand > wrote: > > We have been testing the rebalance code in different situations while > having traffic going through OVS. > Those tests have show

Re: [ovs-dev] [PATCH 0/5] Quicker pmd threads reloads

Hello guys, On Thu, May 23, 2019 at 4:27 PM David Marchand wrote: > We have been testing the rebalance code in different situations while > having traffic going through OVS. > Those tests have shown that part of the observed packets losses is due to > some time wasted in signaling/waiting for th