[ovs-dev] [RFE] Event mechanism for a pro-active packet drop detection and recovery

2019-06-27 Thread Gowrishankar Muthukrishnan
Today (*), when a packet journey in the data path is disrupted and leading towards its drop, we have OVS counters to auto-detect it and show at the request of user space commands. Some category of drops are related to the interfaces that can be queried from OVS DB table for that interface [2],

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-27 Thread William Tu
Hi Ilya, Thanks for the feedback. > > +static struct dp_packet_afxdp * > > +dp_packet_cast_afxdp(const struct dp_packet *d) > > +{ > > +ovs_assert(d->source == DPBUF_AFXDP); > > +return CONTAINER_OF(d, struct dp_packet_afxdp, packet); > > +} > > + > > +static inline void > >

[ovs-dev] [PATCH v1] doc: Remove experimental tag for SMC cache.

2019-06-27 Thread Yipeng Wang
SMC cache was introduced in 2.10 with experimental tag. SMC cache is a layer of software cache located after EMC cache. The purpose is to improve the performance of use cases that many flows missing the EMC cache. One can enable SMC cache using smc-enable=true option. Signed-off-by: Yipeng Wang

[ovs-dev] Rotación Cero - Presencial

2019-06-27 Thread Ariel Lara
16 de agosto | Ciudad de México | 7 horas efectivas -ROTACIÓN CERO- ¿De qué hablaremos? La rotación de personal es un fenómeno que afecta a la mayoría de las organizaciones y mermael rendimiento de los colaboradores. Partiendo de ese panorama, en este curso se revisarán las bases teóricas

Re: [ovs-dev] [PATCH] faq: Correct supported kernel versions for OVS 2.11.x.

2019-06-27 Thread Yifeng Sun
Got it, thanks for the fix. Reviewed-by: Yifeng Sun On Thu, Jun 27, 2019 at 6:51 AM Ben Pfaff wrote: > > I don't think we're planning to backport 5.0 support to OVS 2.11.x, because > that would be counter to our usual practice. > > CC: Yifeng Sun > Fixes: 2adada0e3db2 ("datapath: Support

Re: [ovs-dev] [PATCH v9 5/5] dpif-netdev: add specialized generic scalar functions

2019-06-27 Thread Malvika Gupta
Hi Harry, Thank you for your reply. Please see the inline comments below. Also, I have also added the Tested-by tag after the Signed-off-by tag if that's okay with you. Best, Malvika > -Original Message- > From: Van Haaren, Harry > Sent: Thursday, June 27, 2019 7:26 AM > To: Malvika

Re: [ovs-dev] [PATCHv4] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-06-27 Thread William Tu
On Thu, Jun 27, 2019 at 9:10 AM Gregory Rose wrote: > > > > On 6/27/2019 7:51 AM, Ben Pfaff wrote: > > On Wed, Jun 26, 2019 at 03:21:49PM -0700, Gregory Rose wrote: > >> On 6/26/2019 11:59 AM, Ben Pfaff wrote: > >>> On Wed, Jun 26, 2019 at 08:22:07AM -0700, William Tu wrote: > The patch adds

Re: [ovs-dev] [PATCH v2] vswitchd: Always cleanup userspace datapath.

2019-06-27 Thread Ilya Maximets
On 26.06.2019 21:27, Ben Pfaff wrote: > On Tue, Jun 25, 2019 at 01:12:11PM +0300, Ilya Maximets wrote: >> 'netdev' datapath is implemented within ovs-vswitchd process and can >> not exist without it, so it should be gracefully terminated with a >> full cleanup of resources upon ovs-vswitchd exit.

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-27 Thread Ilya Maximets
Just a few comments inline. Best regards, Ilya Maximets. On 19.06.2019 22:51, William Tu wrote: > The patch introduces experimental AF_XDP support for OVS netdev. > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > type built upon the eBPF and XDP technology. It is

[ovs-dev] [PATCH] ovn-controller: Provide the option to configure inactivity probe interval for OpenFlow conn

2019-06-27 Thread nusiddiq
From: Numan Siddique If the ovn-controller main loop takes more than 5 seconds (if there are lots of logical flows) before it calls poll_block(), it causes the poll_block to wake up immediately, since rconn module has to send echo request. With the incremental processing, this is not an issue

Re: [ovs-dev] [PATCHv4] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-06-27 Thread Gregory Rose
On 6/27/2019 7:51 AM, Ben Pfaff wrote: On Wed, Jun 26, 2019 at 03:21:49PM -0700, Gregory Rose wrote: On 6/26/2019 11:59 AM, Ben Pfaff wrote: On Wed, Jun 26, 2019 at 08:22:07AM -0700, William Tu wrote: The patch adds ip6gretap support. Tunnel type 'ip6gretap' is a layer 2 GRE tunnel over

Re: [ovs-dev] [PATCH] ovsdb-idl: Improve comments.

2019-06-27 Thread Numan Siddique
On Thu, Jun 27, 2019 at 2:32 AM Ben Pfaff wrote: > Suggested-by: Numan Siddique > Signed-off-by: Ben Pfaff > Thanks. This is really useful for me. Acked-by: Numan Siddique > --- > lib/ovsdb-idl.h | 76 - > 1 file changed, 63 insertions(+),

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Reset queue number for vhost devices on vm shutdown.

2019-06-27 Thread Ian Stokes
On 6/27/2019 3:51 PM, Ilya Maximets wrote: On 27.06.2019 17:17, Ian Stokes wrote: On 6/27/2019 10:43 AM, David Marchand wrote: Rather than poll all disabled queues and waste some memory for vms that have been shutdown, we can reconfigure when receiving a destroy connection notification from

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Reset queue number for vhost devices on vm shutdown.

2019-06-27 Thread David Marchand
On Thu, Jun 27, 2019 at 4:18 PM Ian Stokes wrote: > On 6/27/2019 10:43 AM, David Marchand wrote: > > Rather than poll all disabled queues and waste some memory for vms that > > have been shutdown, we can reconfigure when receiving a destroy > > connection notification from the vhost library. > >

Re: [ovs-dev] [PATCH v3] ovn-controller: Omit alert for Port_Binding.external_ids changes

2019-06-27 Thread Numan Siddique
On Thu, Jun 27, 2019 at 2:33 AM Ben Pfaff wrote: > On Thu, Jun 27, 2019 at 12:43:18AM +0530, Numan Siddique wrote: > > On Thu, Jun 27, 2019 at 12:19 AM Ben Pfaff wrote: > > > > > On Wed, Jun 26, 2019 at 07:46:25PM +0530, nusid...@redhat.com wrote: > > > > From: Numan Siddique > > > > > > > >

Re: [ovs-dev] [PATCHv4] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-06-27 Thread Ben Pfaff
On Thu, Jun 27, 2019 at 06:31:24AM +, Eli Britstein wrote: > > On 6/27/2019 1:21 AM, Gregory Rose wrote: > > > > On 6/26/2019 11:59 AM, Ben Pfaff wrote: > >> On Wed, Jun 26, 2019 at 08:22:07AM -0700, William Tu wrote: > >>> The patch adds ip6gretap support. Tunnel type 'ip6gretap' is a layer

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Reset queue number for vhost devices on vm shutdown.

2019-06-27 Thread Ilya Maximets
On 27.06.2019 17:17, Ian Stokes wrote: > On 6/27/2019 10:43 AM, David Marchand wrote: >> Rather than poll all disabled queues and waste some memory for vms that >> have been shutdown, we can reconfigure when receiving a destroy >> connection notification from the vhost library. >> >> $ while true;

Re: [ovs-dev] [PATCHv4] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-06-27 Thread Ben Pfaff
On Wed, Jun 26, 2019 at 03:21:49PM -0700, Gregory Rose wrote: > > On 6/26/2019 11:59 AM, Ben Pfaff wrote: > > On Wed, Jun 26, 2019 at 08:22:07AM -0700, William Tu wrote: > > > The patch adds ip6gretap support. Tunnel type 'ip6gretap' is a layer 2 GRE > > > tunnel over IPv6, carrying inner

Re: [ovs-dev] [PATCH v3 2/4] doc: Add info on vhost tx retries.

2019-06-27 Thread Ian Stokes
On 6/27/2019 1:02 PM, 0-day Robot wrote: Bleep bloop. Greetings Kevin Traynor, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Reset queue number for vhost devices on vm shutdown.

2019-06-27 Thread Stokes, Ian
> On 27/06/2019 15:17, Ian Stokes wrote: > > On 6/27/2019 10:43 AM, David Marchand wrote: > >> Rather than poll all disabled queues and waste some memory for vms that > >> have been shutdown, we can reconfigure when receiving a destroy > >> connection notification from the vhost library. > >> > >>

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Reset queue number for vhost devices on vm shutdown.

2019-06-27 Thread Kevin Traynor
On 27/06/2019 15:17, Ian Stokes wrote: > On 6/27/2019 10:43 AM, David Marchand wrote: >> Rather than poll all disabled queues and waste some memory for vms that >> have been shutdown, we can reconfigure when receiving a destroy >> connection notification from the vhost library. >> >> $ while true;

Re: [ovs-dev] [PATCHv4] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-06-27 Thread William Tu
On Wed, Jun 26, 2019 at 11:31 PM Eli Britstein wrote: > > > On 6/27/2019 1:21 AM, Gregory Rose wrote: > > > > On 6/26/2019 11:59 AM, Ben Pfaff wrote: > >> On Wed, Jun 26, 2019 at 08:22:07AM -0700, William Tu wrote: > >>> The patch adds ip6gretap support. Tunnel type 'ip6gretap' is a layer > >>> 2

Re: [ovs-dev] [PATCH v3 4/4] netdev-dpdk: Enable vhost-tx-retries config.

2019-06-27 Thread Flavio Leitner via dev
On Thu, Jun 27, 2019 at 12:12:32PM +0100, Kevin Traynor wrote: > vhost tx retries can provide some mitigation against > dropped packets due to a temporarily slow guest/limited queue > size for an interface, but on the other hand when a system > is fully loaded those extra cycles retrying could

Re: [ovs-dev] [PATCH v4] netdev-dpdk: Reset queue number for vhost devices on vm shutdown.

2019-06-27 Thread Ian Stokes
On 6/27/2019 10:43 AM, David Marchand wrote: Rather than poll all disabled queues and waste some memory for vms that have been shutdown, we can reconfigure when receiving a destroy connection notification from the vhost library. $ while true; do ovs-appctl dpif-netdev/pmd-rxq-show |awk '

Re: [ovs-dev] openvswitch-2.11.1 not supported to kernel version 5.0 and 4.20

2019-06-27 Thread Ben Pfaff
On Thu, Jun 27, 2019 at 02:51:32PM +0530, rakesh kumar wrote: > I tried compiling the ovs source cod in Linux 5.0 version but got an error > stating "Newer version than 4.18.x is not supoorted". > > Could it be made to support Linux 5.0 ? No, we don't normally backport kernel version support.

[ovs-dev] [PATCH] faq: Correct supported kernel versions for OVS 2.11.x.

2019-06-27 Thread Ben Pfaff
I don't think we're planning to backport 5.0 support to OVS 2.11.x, because that would be counter to our usual practice. CC: Yifeng Sun Fixes: 2adada0e3db2 ("datapath: Support kernel version 5.0.x") Signed-off-by: Ben Pfaff --- Documentation/faq/releases.rst | 2 +- 1 file changed, 1

Re: [ovs-dev] [PATCH 1/1] netdev-tc-offloads: Support match on priority tags

2019-06-27 Thread Louis Peens
On Fri, Jun 14, 2019 at 6:01 PM Eli Britstein wrote: > > On 6/14/2019 5:40 PM, Louis Peens wrote: > > > > On Wed, Jun 12, 2019 at 11:53 AM Eli Britstein wrote: > >> >> On 6/11/2019 2:21 PM, Ilya Maximets wrote: >> >> On Mon, Jun 3, 2019 at 4:42 PM Simon Horman > netronome.com >>

Re: [ovs-dev] [PATCH v9 5/5] dpif-netdev: add specialized generic scalar functions

2019-06-27 Thread Van Haaren, Harry
Sorry for double post - if you're happy with the changes please add a Tested-by: tag? > -Original Message- > From: Van Haaren, Harry > Sent: Thursday, June 27, 2019 1:07 PM > To: 'Malvika Gupta' > Cc: nd ; Yanqin Wei (Arm Technology China) ; > d...@openvswitch.org > Subject: RE:

Re: [ovs-dev] [PATCH v9 5/5] dpif-netdev: add specialized generic scalar functions

2019-06-27 Thread Van Haaren, Harry
> -Original Message- > From: Malvika Gupta [mailto:malvika.gu...@arm.com] > Sent: Tuesday, June 25, 2019 8:19 PM > To: Van Haaren, Harry > Cc: nd ; Yanqin Wei (Arm Technology China) ; > d...@openvswitch.org > Subject: RE: [ovs-dev] [PATCH v9 5/5] dpif-netdev: add specialized generic >

Re: [ovs-dev] [PATCH v3 2/4] doc: Add info on vhost tx retries.

2019-06-27 Thread 0-day Robot
Bleep bloop. Greetings Kevin Traynor, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #49 FILE:

Re: [ovs-dev] [PATCH v3 0/4] vhost tx retry updates

2019-06-27 Thread Eelco Chaudron
> v3: > - 2/4 really updated text to NETDEV_MAX_BURST this time > - 4/4 comments from Flavio. Made max retries limit 32. > > v2: > - 1/4 - split out minor fix from docs patch > - 2/4 - updated text, NETDEV_MAX_BURST, QEMU/libvirt versions > - 3/4 - removed unneeded MIN() > - 4/4 - explicitly

[ovs-dev] [PATCH v3 1/4] netdev-dpdk: Fix additional vhost tx retry.

2019-06-27 Thread Kevin Traynor
Fix minor issue of one possible additional retry. Fixes: c6ec9d176dbf ("netdev-dpdk: Fix vHost stats.") Signed-off-by: Kevin Traynor Acked-by: Eelco Chaudron Acked-by: Flavio Leitner --- lib/netdev-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-dpdk.c

[ovs-dev] [PATCH v3 4/4] netdev-dpdk: Enable vhost-tx-retries config.

2019-06-27 Thread Kevin Traynor
vhost tx retries can provide some mitigation against dropped packets due to a temporarily slow guest/limited queue size for an interface, but on the other hand when a system is fully loaded those extra cycles retrying could mean packets are dropped elsewhere. Up to now max vhost tx retries have

[ovs-dev] [PATCH v3 3/4] netdev-dpdk: Add stats for vhost tx retries.

2019-06-27 Thread Kevin Traynor
vhost tx retries may occur, and it can be a sign that the guest is not optimally configured. Add some stats so a user will know if vhost tx retries are occurring and hence give a hint that guest config should be examined. Signed-off-by: Kevin Traynor Acked-by: Flavio Leitner Acked-by: Eelco

[ovs-dev] [PATCH v3 2/4] doc: Add info on vhost tx retries.

2019-06-27 Thread Kevin Traynor
Add documentation about vhost tx retries and external configuration that can help reduce/avoid them. Signed-off-by: Kevin Traynor Acked-by: Eelco Chaudron Acked-by: Flavio Leitner --- Documentation/topics/dpdk/vhost-user.rst | 36 1 file changed, 36 insertions(+)

[ovs-dev] [PATCH v3 0/4] vhost tx retry updates

2019-06-27 Thread Kevin Traynor
v3: - 2/4 really updated text to NETDEV_MAX_BURST this time - 4/4 comments from Flavio. Made max retries limit 32. v2: - 1/4 - split out minor fix from docs patch - 2/4 - updated text, NETDEV_MAX_BURST, QEMU/libvirt versions - 3/4 - removed unneeded MIN() - 4/4 - explicitly range check, removed

Re: [ovs-dev] [PATCH v2 4/4] netdev-dpdk: Enable vhost-tx-retries config.

2019-06-27 Thread Kevin Traynor
On 26/06/2019 16:10, Kevin Traynor wrote: >>> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c >>> index 65161deaf..97a90d4a5 100644 >>> --- a/lib/netdev-dpdk.c >>> +++ b/lib/netdev-dpdk.c >>> @@ -160,4 +160,5 @@ typedef uint16_t dpdk_port_t; >>> >>> #define VHOST_ENQ_RETRY_NUM 8 >>> +#define

[ovs-dev] [PATCH v4] netdev-dpdk: Reset queue number for vhost devices on vm shutdown.

2019-06-27 Thread David Marchand
Rather than poll all disabled queues and waste some memory for vms that have been shutdown, we can reconfigure when receiving a destroy connection notification from the vhost library. $ while true; do ovs-appctl dpif-netdev/pmd-rxq-show |awk ' /port: / { tot++; if ($5 == "(enabled)")

Re: [ovs-dev] [PATCH v2 4/4] netdev-dpdk: Enable vhost-tx-retries config.

2019-06-27 Thread Eelco Chaudron
On 25 Jun 2019, at 16:57, Kevin Traynor wrote: vhost tx retries can provide some mitigation against dropped packets due to a temporarily slow guest/limited queue size for an interface, but on the other hand when a system is fully loaded those extra cycles retrying could mean packets are

Re: [ovs-dev] [PATCH v2 3/4] netdev-dpdk: Add stats for vhost tx retries.

2019-06-27 Thread Eelco Chaudron
On 25 Jun 2019, at 16:57, Kevin Traynor wrote: > vhost tx retries may occur, and it can be a sign that > the guest is not optimally configured. > > Add some stats so a user will know if vhost tx retries are > occurring and hence give a hint that guest config should be > examined. > >

[ovs-dev] openvswitch-2.11.1 not supported to kernel version 5.0 and 4.20

2019-06-27 Thread rakesh kumar
Hello Team, I tried compiling the ovs source cod in Linux 5.0 version but got an error stating "Newer version than 4.18.x is not supoorted". Could it be made to support Linux 5.0 ? *Regards* Rakesh Kumar ___ dev mailing list d...@openvswitch.org

[ovs-dev] Faire le bilan

2019-06-27 Thread Réflexion personnelle
Les Guides Du Digital Guide Bilan de competences Vous souhaitez faire le point sur vos competences pour envisager une evolution de carriere ? Vous lancer dans ce processus de reflexion personnelle et professionnelle demande une certaine preparation. Notre guide de 22 pages vous eclaire sur

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

2019-06-27 Thread Ian Stokes
On 6/27/2019 8:26 AM, David Marchand wrote: Hello Ian, On Wed, Jun 26, 2019 at 11:10 PM Ian Stokes > wrote: On 4/18/2019 3:44 PM, Ilya Maximets wrote: > On 18.04.2019 17:05, David Marchand wrote: >> Ok, how should I proceed ? >> Can I still

Re: [ovs-dev] [PATCH v2 branch-2.11] dpdk: Use DPDK 18.11.2 release.

2019-06-27 Thread Ian Stokes
On 6/27/2019 9:21 AM, Kevin Traynor wrote: On 26/06/2019 22:06, Ian Stokes wrote: Modify travis linux build script to use the latest DPDK stable release 18.11.2. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- Acked-by: Kevin Traynor Thanks for the review

Re: [ovs-dev] [PATCH v2] dpdk: Use DPDK 18.11.2 release.

2019-06-27 Thread Ian Stokes
On 6/27/2019 9:17 AM, Kevin Traynor wrote: On 26/06/2019 22:06, Ian Stokes wrote: Modify travis linux build script to use the latest DPDK stable release 18.11.2. Update docs for latest DPDK stable releases. Signed-off-by: Ian Stokes --- Acked-by: Kevin Traynor Thasnk all for the

Re: [ovs-dev] [PATCH v2 branch-2.11] dpdk: Use DPDK 18.11.2 release.

2019-06-27 Thread Kevin Traynor
On 26/06/2019 22:06, Ian Stokes wrote: > Modify travis linux build script to use the latest DPDK stable release > 18.11.2. Update docs for latest DPDK stable releases. > > Signed-off-by: Ian Stokes > --- Acked-by: Kevin Traynor ___ dev mailing list

Re: [ovs-dev] [PATCH v2] dpdk: Use DPDK 18.11.2 release.

2019-06-27 Thread Kevin Traynor
On 26/06/2019 22:06, Ian Stokes wrote: > Modify travis linux build script to use the latest DPDK stable release > 18.11.2. Update docs for latest DPDK stable releases. > > Signed-off-by: Ian Stokes > --- Acked-by: Kevin Traynor ___ dev mailing list

Re: [ovs-dev] [PATCH v2] dpdk: Use DPDK 18.11.2 release.

2019-06-27 Thread David Marchand
On Wed, Jun 26, 2019 at 11:06 PM Ian Stokes wrote: > Modify travis linux build script to use the latest DPDK stable release > 18.11.2. Update docs for latest DPDK stable releases. > > Signed-off-by: Ian Stokes > --- > V1 -> V2 > * Remove DPDK minimum requirement 18.11.2 notice in NEWS. > *

Re: [ovs-dev] [PATCH v2 3/3] netdev-dpdk: reset queue number for vhost devices on vm shutdown

2019-06-27 Thread David Marchand
Hello Ian, On Wed, Jun 26, 2019 at 11:10 PM Ian Stokes wrote: > On 4/18/2019 3:44 PM, Ilya Maximets wrote: > > On 18.04.2019 17:05, David Marchand wrote: > >> Ok, how should I proceed ? > >> Can I still submit the 3 patches together, to finish handling the last > comments ? > > > > Yes, I think

Re: [ovs-dev] [PATCHv4] tunnel: Add layer 2 IPv6 GRE encapsulation support.

2019-06-27 Thread Eli Britstein
On 6/27/2019 1:21 AM, Gregory Rose wrote: > > On 6/26/2019 11:59 AM, Ben Pfaff wrote: >> On Wed, Jun 26, 2019 at 08:22:07AM -0700, William Tu wrote: >>> The patch adds ip6gretap support. Tunnel type 'ip6gretap' is a layer >>> 2 GRE >>> tunnel over IPv6, carrying inner ethernet packets and encap