Re: [ovs-dev] [PATCH v2] OVN: Enhance ovndb-servers.ocf to handle inactive_probe_interval updates

2019-06-28 Thread Numan Siddique
On Thu, Jun 27, 2019 at 12:43 AM Numan Siddique wrote: > > > On Thu, Jun 27, 2019 at 12:41 AM Ben Pfaff wrote: > >> On Wed, Jun 26, 2019 at 11:59:30AM +0100, lmart...@redhat.com wrote: >> > From: Lucas Alvares Gomes >> > >> > This patch is enhacing the ovndb-servers.ocf script to handle

Re: [ovs-dev] [PATCH 1/3] compat: Remove duplicate metadata destination code

2019-06-28 Thread Gregory Rose
On 6/28/2019 1:40 PM, Greg Rose wrote: ip_gre.c and ip6_gre.c both had duplicate code for handling the tunnel metadata destinations. Move the duplicate code over into the right header file, dst_metadata.h. Signed-off-by: Greg Rose --- datapath/linux/compat/include/net/dst_metadata.h | 136

[ovs-dev] [PATCH 3/3] compat: Clean up tunnel_id_to_key

2019-06-28 Thread Greg Rose
This function was just a duplicate of tunnel_id_to_key32 - I'm not sure why it was ever needed but let's dump it now. Signed-off-by: Greg Rose --- datapath/linux/compat/ip_gre.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/datapath/linux/compat/ip_gre.c

[ovs-dev] [PATCH 2/3] compat: Clean up gre_calc_hlen

2019-06-28 Thread Greg Rose
It's proliferated throughout three .c files so let's pull them all together in gre.h where the inline function belongs. This requires some adjustments to the compat layer so that the various iterations of gre_calc_hlen and ip_gre_calc_hlen since the 3.10 kernel are handled correctly.

[ovs-dev] [PATCH 1/3] compat: Remove duplicate metadata destination code

2019-06-28 Thread Greg Rose
ip_gre.c and ip6_gre.c both had duplicate code for handling the tunnel metadata destinations. Move the duplicate code over into the right header file, dst_metadata.h. Signed-off-by: Greg Rose --- datapath/linux/compat/include/net/dst_metadata.h | 136 ++-

[ovs-dev] [PATCH 0/3] Cleanup gre related tunnel code

2019-06-28 Thread Greg Rose
This patch set passes Travis: https://travis-ci.org/gvrose8192/ovs-experimental/builds/551890800 I ran some light touch tests and the kernel check-kmod test on a few machines with no regressions. There should be no functional change. Greg Rose (3): compat: Remove duplicate metadata

Re: [ovs-dev] [PATCH] OVN: Enhance ovndb-servers.ocf to handle inactive_probe_interval updates

2019-06-28 Thread Lucas Alvares Gomes
On Fri, 28 Jun 2019, 19:17 Numan Siddique, wrote: > On Fri, Jun 28, 2019 at 11:46 PM Numan Siddique > wrote: > > > > > > > On Wed, Jun 26, 2019 at 2:42 PM wrote: > > > >> From: Lucas Alvares Gomes > >> > >> This patch is enhacing the ovndb-servers.ocf script to handle updates to > >> the

Re: [ovs-dev] [PATCH] OVN: Enhance ovndb-servers.ocf to handle inactive_probe_interval updates

2019-06-28 Thread Numan Siddique
On Fri, Jun 28, 2019 at 11:46 PM Numan Siddique wrote: > > > On Wed, Jun 26, 2019 at 2:42 PM wrote: > >> From: Lucas Alvares Gomes >> >> This patch is enhacing the ovndb-servers.ocf script to handle updates to >> the inactive_probe_interval via pacemaker. For example, one could run: >> >> $

Re: [ovs-dev] [PATCH] OVN: Enhance ovndb-servers.ocf to handle inactive_probe_interval updates

2019-06-28 Thread Numan Siddique
On Wed, Jun 26, 2019 at 2:42 PM wrote: > From: Lucas Alvares Gomes > > This patch is enhacing the ovndb-servers.ocf script to handle updates to > the inactive_probe_interval via pacemaker. For example, one could run: > > $ sudo crm_resource --resource ovndb_servers --set-parameter >

Re: [ovs-dev] [PATCH v12] OVN: Enable E-W Traffic, Vlan backed DVR

2019-06-28 Thread Ankur Sharma
Hi Ben, Gentle reminder. This patch has been acked. Please let me know, if it can be applied to master. I will be happy to address, if there are more review comments. Thanks Regards, Ankur From: Ankur Sharma Sent: Wednesday, June 19, 2019 6:36 PM To:

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-28 Thread William Tu
> > > +int > > +netdev_afxdp_batch_send(struct netdev *netdev, int qid, > > +struct dp_packet_batch *batch, > > +bool concurrent_txq) > > +{ > > +struct netdev_linux *dev = netdev_linux_cast(netdev); > > +struct xsk_socket_info *xsk_info =

Re: [ovs-dev] [PATCH v3 4/4] netdev-dpdk: Enable vhost-tx-retries config.

2019-06-28 Thread Kevin Traynor
On 28/06/2019 15:39, Ian Stokes wrote: > On 6/27/2019 12:12 PM, Kevin Traynor wrote: >> vhost tx retries can provide some mitigation against >> dropped packets due to a temporarily slow guest/limited queue >> size for an interface, but on the other hand when a system >> is fully loaded those extra

Re: [ovs-dev] [PATCH v3 4/4] netdev-dpdk: Enable vhost-tx-retries config.

2019-06-28 Thread Kevin Traynor
On 28/06/2019 13:34, Ilya Maximets wrote: > On 27.06.2019 14:12, Kevin Traynor wrote: >> vhost tx retries can provide some mitigation against >> dropped packets due to a temporarily slow guest/limited queue >> size for an interface, but on the other hand when a system >> is fully loaded those

Re: [ovs-dev] [PATCH v3 3/4] netdev-dpdk: Add stats for vhost tx retries.

2019-06-28 Thread Kevin Traynor
On 28/06/2019 14:35, Flavio Leitner wrote: > On Fri, Jun 28, 2019 at 04:29:36PM +0300, Ilya Maximets wrote: >> On 28.06.2019 16:17, Flavio Leitner wrote: >>> On Fri, Jun 28, 2019 at 03:21:07PM +0300, Ilya Maximets wrote: On 27.06.2019 14:12, Kevin Traynor wrote: > vhost tx retries may

Re: [ovs-dev] [PATCH v3 4/4] netdev-dpdk: Enable vhost-tx-retries config.

2019-06-28 Thread Ian Stokes
On 6/27/2019 12:12 PM, Kevin Traynor wrote: vhost tx retries can provide some mitigation against dropped packets due to a temporarily slow guest/limited queue size for an interface, but on the other hand when a system is fully loaded those extra cycles retrying could mean packets are dropped

Re: [ovs-dev] [PATCH v3 3/4] netdev-dpdk: Add stats for vhost tx retries.

2019-06-28 Thread Flavio Leitner via dev
On Fri, Jun 28, 2019 at 04:29:36PM +0300, Ilya Maximets wrote: > On 28.06.2019 16:17, Flavio Leitner wrote: > > On Fri, Jun 28, 2019 at 03:21:07PM +0300, Ilya Maximets wrote: > >> On 27.06.2019 14:12, Kevin Traynor wrote: > >>> vhost tx retries may occur, and it can be a sign that > >>> the guest

Re: [ovs-dev] [PATCH v3 3/4] netdev-dpdk: Add stats for vhost tx retries.

2019-06-28 Thread Ilya Maximets
On 28.06.2019 16:17, Flavio Leitner wrote: > On Fri, Jun 28, 2019 at 03:21:07PM +0300, Ilya Maximets wrote: >> On 27.06.2019 14:12, Kevin Traynor wrote: >>> vhost tx retries may occur, and it can be a sign that >>> the guest is not optimally configured. >>> >>> Add some stats so a user will know

Re: [ovs-dev] [PATCH] OVN: add the possibility to specify tunnel dst port

2019-06-28 Thread Ben Pfaff
On Fri, Jun 28, 2019 at 03:08:31PM +0200, Lorenzo Bianconi wrote: > > > > On Tue, Jun 25, 2019 at 12:35:26PM +0200, Lorenzo Bianconi wrote: > > > Introduce dst_port in options column of Encap table in order to add the > > > capability to configure destination port used for tunnel encapsulation > >

Re: [ovs-dev] [PATCH v3 3/4] netdev-dpdk: Add stats for vhost tx retries.

2019-06-28 Thread Flavio Leitner
On Fri, Jun 28, 2019 at 03:21:07PM +0300, Ilya Maximets wrote: > On 27.06.2019 14:12, Kevin Traynor wrote: > > vhost tx retries may occur, and it can be a sign that > > the guest is not optimally configured. > > > > Add some stats so a user will know if vhost tx retries are > > occurring and

Re: [ovs-dev] [PATCH] OVN: add the possibility to specify tunnel dst port

2019-06-28 Thread Lorenzo Bianconi
> > On Tue, Jun 25, 2019 at 12:35:26PM +0200, Lorenzo Bianconi wrote: > > Introduce dst_port in options column of Encap table in order to add the > > capability to configure destination port used for tunnel encapsulation > > > > Signed-off-by: Lorenzo Bianconi > > Thank you. I think that the

Re: [ovs-dev] [PATCH] OVN: add the possibility to specify tunnel dst port

2019-06-28 Thread Ben Pfaff
On Tue, Jun 25, 2019 at 12:35:26PM +0200, Lorenzo Bianconi wrote: > Introduce dst_port in options column of Encap table in order to add the > capability to configure destination port used for tunnel encapsulation > > Signed-off-by: Lorenzo Bianconi Thank you. I think that the documentation can

Re: [ovs-dev] [PATCHv13] netdev-afxdp: add new netdev type for AF_XDP.

2019-06-28 Thread Ilya Maximets
Few more bits. On 19.06.2019 22:51, William Tu wrote: > The patch introduces experimental AF_XDP support for OVS netdev. > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket > type built upon the eBPF and XDP technology. It is aims to have comparable > performance to DPDK

Re: [ovs-dev] [PATCH v3 4/4] netdev-dpdk: Enable vhost-tx-retries config.

2019-06-28 Thread Ilya Maximets
On 27.06.2019 14:12, Kevin Traynor wrote: > vhost tx retries can provide some mitigation against > dropped packets due to a temporarily slow guest/limited queue > size for an interface, but on the other hand when a system > is fully loaded those extra cycles retrying could mean > packets are

Re: [ovs-dev] [PATCH v3 3/4] netdev-dpdk: Add stats for vhost tx retries.

2019-06-28 Thread Ilya Maximets
On 27.06.2019 14:12, Kevin Traynor wrote: > vhost tx retries may occur, and it can be a sign that > the guest is not optimally configured. > > Add some stats so a user will know if vhost tx retries are > occurring and hence give a hint that guest config should be > examined. > > Signed-off-by:

Re: [ovs-dev] [PATCH v2 3/3] rconn: Increase precision of timers.

2019-06-28 Thread Ilya Maximets
On 11.06.2019 19:55, Ben Pfaff wrote: > Until now, the rconn timers have been precise only to the nearest second. > This increases them to millisecond precision, which seems cleaner these > days. > > Signed-off-by: Ben Pfaff > --- > include/openvswitch/rconn.h | 7 +- > lib/rconn.c

Re: [ovs-dev] [PATCH v2 2/3] rconn: Remove write-only struct members.

2019-06-28 Thread Ilya Maximets
On 11.06.2019 19:55, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/rconn.c | 16 > 1 file changed, 16 deletions(-) Acked-by: Ilya Maximets BTW, I'm curious if these members was ever used? I didn't find any related code parts in current git repo.

Re: [ovs-dev] [PATCH v2 1/3] sat-math: Add functions for saturating arithmetic on "long long int".

2019-06-28 Thread Ilya Maximets
On 11.06.2019 19:55, Ben Pfaff wrote: > The first users will be added in an upcoming commit. > > Also add tests. > > Signed-off-by: Ben Pfaff > --- > lib/sat-math.h| 72 +-- > tests/library.at | 5 > tests/test-util.c | 42

Re: [ovs-dev] [PATCH] OVN: add the possibility to specify tunnel dst port

2019-06-28 Thread Numan Siddique
On Tue, Jun 25, 2019 at 4:06 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Introduce dst_port in options column of Encap table in order to add the > capability to configure destination port used for tunnel encapsulation > > Signed-off-by: Lorenzo Bianconi > Acked-by: Numan

[ovs-dev] [PATCH v4] ovn-controller: Omit tracking external_ids columns

2019-06-28 Thread nusiddiq
From: Numan Siddique Running the command "ovn-nbctl set logical_switch_port foo external_ids:foo=bar" results in the incremetal processing engine to recompute the flows on the chassis where the logical port 'foo' is claimed. This patch avoids this unnecessary recomputation by omitting the

Re: [ovs-dev] [PATCH] ofproto-dpif-upcall: Remove unused macro MAX_QUEUE_LENGTH.

2019-06-28 Thread wangyunjian
Friendly ping > -Original Message- > From: wangyunjian > Sent: Wednesday, June 19, 2019 12:23 PM > To: d...@openvswitch.org > Cc: xudingke ; wangyunjian > > Subject: [ovs-dev] [PATCH] ofproto-dpif-upcall: Remove unused macro > MAX_QUEUE_LENGTH. > > Signed-off-by: Yunjian Wang > --- >

Re: [ovs-dev] [PATCH v3 2/4] doc: Add info on vhost tx retries.

2019-06-28 Thread Ian Stokes
On 6/27/2019 12:12 PM, Kevin Traynor wrote: Add documentation about vhost tx retries and external configuration that can help reduce/avoid them. Signed-off-by: Kevin Traynor Acked-by: Eelco Chaudron Acked-by: Flavio Leitner --- Documentation/topics/dpdk/vhost-user.rst | 36

Re: [ovs-dev] [PATCH] stream-ssl: Fix crash on NULL private key and valid certificate.

2019-06-28 Thread Ilya Maximets
On 26.06.2019 21:29, Ben Pfaff wrote: > On Tue, Jun 25, 2019 at 06:48:15PM +0300, Ilya Maximets wrote: >> Running ovsdb-server with empty private-key and non-empty certificate >> (or otherwise) causes crash: >> >> # ovsdb-tool create ./etc/openvswitch/conf.db ./vswitch.ovsschema >> #

Re: [ovs-dev] [PATCH v2 1/4] netdev-dpdk: Fix additional vhost tx retry.

2019-06-28 Thread Ian Stokes
On 6/28/2019 10:22 AM, Ian Stokes wrote: On 6/25/2019 3:57 PM, Kevin Traynor wrote: Fix minor issue of one possible additional retry. Fixes: c6ec9d176dbf ("netdev-dpdk: Fix vHost stats.") Signed-off-by: Kevin Traynor Acked-by: Eelco Chaudron ---   lib/netdev-dpdk.c | 2 +-   1 file changed, 1

Re: [ovs-dev] [PATCH v2 1/4] netdev-dpdk: Fix additional vhost tx retry.

2019-06-28 Thread Ian Stokes
On 6/25/2019 3:57 PM, Kevin Traynor wrote: Fix minor issue of one possible additional retry. Fixes: c6ec9d176dbf ("netdev-dpdk: Fix vHost stats.") Signed-off-by: Kevin Traynor Acked-by: Eelco Chaudron --- lib/netdev-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [ovs-dev] [PATCH v2 2/3] ovn: Send GARP for the router ports with reside-on-redirect-chassis options set

2019-06-28 Thread Dumitru Ceara
On Fri, Jun 14, 2019 at 2:38 PM wrote: > > From: Numan Siddique > > With the commit [1], the routing for the provider logical switches > connected to a router is centralized on the master gateway chassis > (if the option - reside-on-redirect-chassis) is set. When the > failover happens and a

Re: [ovs-dev] [PATCH v2 1/3] ovn-northd: Refactor the code which sets nat_addresses

2019-06-28 Thread Dumitru Ceara
On Fri, Jun 14, 2019 at 2:37 PM wrote: > > From: Numan Siddique > > The present code which sets the Port_Binding.nat_addresses > can be simplied. This patch does this. This would help in > upcoming commits to set the nat_addresses column with the > mac and IPs of distributed logical router ports

Re: [ovs-dev] [PATCH] ovn-controller: Provide the option to configure inactivity probe interval for OpenFlow conn

2019-06-28 Thread Dumitru Ceara
On Thu, Jun 27, 2019 at 6:15 PM wrote: > > From: Numan Siddique > > If the ovn-controller main loop takes more than 5 seconds (if there are lots > of logical > flows) before it calls poll_block(), it causes the poll_block to wake up > immediately, > since rconn module has to send echo request.