[ovs-dev] [PATCH v12] Improved Packet Drop Statistics in OVS

2019-07-24 Thread Anju Thomas
Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in table stats. These can only be interpreted by controllers that know the semantics of the

Re: [ovs-dev] [PATCH] committer-responsibilities: Add guidelines for fixing up mistakes.

2019-07-24 Thread Ben Pfaff
On Wed, Jul 24, 2019 at 08:25:54PM +0300, Ilya Maximets wrote: > On 24.07.2019 20:05, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > > Based on an off-lst discussion with Ilya. This is just my first, off-hand > > thought on the topic. Feedback welcome! > > We could also consider

[ovs-dev] [PATCH RFC] netdev-afxdp: Enable loading XDP program.

2019-07-24 Thread William Tu
Now netdev-afxdp unconditionally forwards all packets to userspace because we are using libbpf's default XDP program, see xsk_load_xdp_prog. However, there are some cases when users want to keep packets in the kernel, for example, the management traffic such as SSH, and the rest of the traffic

Re: [ovs-dev] [PATCH v2 0/3] ovn-controller: Fix and refactor chassis ovn-sbdb record init

2019-07-24 Thread Han Zhou
On Mon, Jul 8, 2019 at 2:11 PM Ben Pfaff wrote: > > On Mon, Jul 08, 2019 at 12:06:45PM +0200, Dumitru Ceara wrote: > > The chassis_run code didn't take into account the scenario when the > > system-id was changed in the Open_vSwitch table. Due to this the code > > was trying to insert a new

Re: [ovs-dev] [PATCH] ovs: datapath: hide clang frame-overflow warnings

2019-07-24 Thread David Miller
From: Arnd Bergmann Date: Mon, 22 Jul 2019 17:00:01 +0200 > Some functions in the datapath code are factored out so that each > one has a stack frame smaller than 1024 bytes with gcc. However, > when compiling with clang, the functions are inlined more aggressively > and combined again so we get

Re: [ovs-dev] [PATCH] ovn-controller: Fix the chassis row recreation issue

2019-07-24 Thread Dumitru Ceara
On Wed, Jul 24, 2019 at 12:06 PM wrote: > > From: Numan Siddique > > Before the commit [1], ovn-controller would always recreate its > chassis row if deleted externally. After this commit, it no longer > recreates it. This is regression and needs to be fixed. > > [1] -

Re: [ovs-dev] [PATCH] ovn-controller: Fix the chassis row recreation issue

2019-07-24 Thread Han Zhou
On Wed, Jul 24, 2019 at 3:07 AM wrote: > > From: Numan Siddique > > Before the commit [1], ovn-controller would always recreate its > chassis row if deleted externally. After this commit, it no longer > recreates it. This is regression and needs to be fixed. > > [1] -

Re: [ovs-dev] OVS / OVN split - post 2.12

2019-07-24 Thread Mark Michelson
Numan and I have discussed this, and we're planning to perform the split tomorrow July 25. Numan will be applying the commits he referenced below to the ovn-org branch to get it up to date. I will be submitting a review for OVS to remove all of the OVN code, documentation, etc. from it. If

Re: [ovs-dev] [PATCH] ovsdb-data: Don't put strings with digits in quotes.

2019-07-24 Thread Ilya Maximets
On 24.07.2019 20:08, Ben Pfaff wrote: > On Wed, Jul 24, 2019 at 07:54:29PM +0300, Ilya Maximets wrote: >> No need to use quotes for strings like "br0". >> >> Signed-off-by: Ilya Maximets > > One of the goals here is to quote anything that could be mistaken for > another type. I think that it

Re: [ovs-dev] [PATCH] committer-responsibilities: Add guidelines for fixing up mistakes.

2019-07-24 Thread Ilya Maximets
On 24.07.2019 20:05, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > Based on an off-lst discussion with Ilya. This is just my first, off-hand > thought on the topic. Feedback welcome! We could also consider suggesting a git hook like that: --- $ cat .git/hooks/pre-push #!/bin/bash

Re: [ovs-dev] [PATCH] ovsdb-data: Don't put strings with digits in quotes.

2019-07-24 Thread Ben Pfaff
On Wed, Jul 24, 2019 at 07:54:29PM +0300, Ilya Maximets wrote: > No need to use quotes for strings like "br0". > > Signed-off-by: Ilya Maximets One of the goals here is to quote anything that could be mistaken for another type. I think that it rejects digits because strings with letters and

[ovs-dev] [PATCH] committer-responsibilities: Add guidelines for fixing up mistakes.

2019-07-24 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- Based on an off-lst discussion with Ilya. This is just my first, off-hand thought on the topic. Feedback welcome! diff --git a/Documentation/internals/committer-responsibilities.rst b/Documentation/internals/committer-responsibilities.rst index

[ovs-dev] [PATCH] ovsdb-data: Don't put strings with digits in quotes.

2019-07-24 Thread Ilya Maximets
No need to use quotes for strings like "br0". Signed-off-by: Ilya Maximets --- lib/ovsdb-data.c | 2 +- tests/ovn-controller-vtep.at | 8 tests/ovn-nbctl.at | 6 +++--- tests/ovn-sbctl.at | 20 ++-- tests/ovs-vsctl.at | 32

Re: [ovs-dev] [PATCH] netdev-afxdp: Convert AFXDP_DEBUG to custom stats.

2019-07-24 Thread Ilya Maximets
On 24.07.2019 17:57, William Tu wrote: > On Wed, Jul 24, 2019 at 05:07:25PM +0300, Ilya Maximets wrote: >> On 24.07.2019 1:19, William Tu wrote: >>> On Tue, Jul 23, 2019 at 06:16:46PM +0300, Ilya Maximets wrote: These are valid statistics of a network interface and should be exposed via

Re: [ovs-dev] [PATCH RFC v2 0/8] Introduce connection tracking tc offload

2019-07-24 Thread Paul Blakey
On 7/19/2019 12:59 AM, Marcelo Ricardo Leitner wrote: > > Hi Paul, > > Sometimes I'm seeing ghosts^Wbogus values with nat: > > [root@localhost ~]# ovs-ofctl dump-flows br0 > cookie=0x0, duration=788.595s, table=0, n_packets=3, n_bytes=180, > priority=50,ct_state=-trk,tcp,in_port="ns2-veth-ab"

[ovs-dev] [PATCH] netdev-afxdp: Error when no XDP program loaded.

2019-07-24 Thread William Tu
netdev-afxdp requires XDP program to be loaded. When prog_id == 0, it indicates no XDP program, so return error and free resources. Signed-off-by: William Tu --- v2: combining if statement to avoid duplication --- lib/netdev-afxdp.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)

Re: [ovs-dev] [PATCH] netdev-afxdp: Convert AFXDP_DEBUG to custom stats.

2019-07-24 Thread William Tu
On Wed, Jul 24, 2019 at 05:07:25PM +0300, Ilya Maximets wrote: > On 24.07.2019 1:19, William Tu wrote: > > On Tue, Jul 23, 2019 at 06:16:46PM +0300, Ilya Maximets wrote: > >> These are valid statistics of a network interface and should be > >> exposed via custom stats. > >> > >> The same MACRO

[ovs-dev] [PATCH] windows, tests: Modify service test

2019-07-24 Thread Alin Gabriel Serdean
The database is now called "_Server" so look for that instead of "Open_vSwitch". Modify the test so it always stops and deletes the service. Signed-off-by: Alin Gabriel Serdean --- tests/daemon.at | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/tests/daemon.at

Re: [ovs-dev] [PATCH] netdev-afxdp: Error when no XDP program loaded.

2019-07-24 Thread William Tu
On Wed, Jul 24, 2019 at 05:14:14PM +0300, Ilya Maximets wrote: > On 24.07.2019 1:58, William Tu wrote: > > netdev-afxdp requires XDP program to be loaded. When prog_id == 0, > > it indicates no XDP program, so return error and free resources. > > > > Signed-off-by: William Tu > > --- > >

[ovs-dev] [PATCH] tests: Queue for termination all OVSDB IDL pids

2019-07-24 Thread Alin Gabriel Serdean
When running OVSDB cluster tests on Windows not all the ovsdb processes are terminated. Queue up the pids of the started processes for termination when the test stops. Signed-off-by: Alin Gabriel Serdean --- tests/ovsdb-idl.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [ovs-dev] [PATCH] netdev-afxdp: Error when no XDP program loaded.

2019-07-24 Thread Ilya Maximets
On 24.07.2019 1:58, William Tu wrote: > netdev-afxdp requires XDP program to be loaded. When prog_id == 0, > it indicates no XDP program, so return error and free resources. > > Signed-off-by: William Tu > --- > lib/netdev-afxdp.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [ovs-dev] [PATCH] netdev-afxdp: Convert AFXDP_DEBUG to custom stats.

2019-07-24 Thread Ilya Maximets
On 24.07.2019 1:19, William Tu wrote: > On Tue, Jul 23, 2019 at 06:16:46PM +0300, Ilya Maximets wrote: >> These are valid statistics of a network interface and should be >> exposed via custom stats. >> >> The same MACRO trick as in vswitchd/bridge.c is used to reduce code >> duplication and easily

[ovs-dev] [PATCH] ovn-controller: Fix the chassis row recreation issue

2019-07-24 Thread nusiddiq
From: Numan Siddique Before the commit [1], ovn-controller would always recreate its chassis row if deleted externally. After this commit, it no longer recreates it. This is regression and needs to be fixed. [1] - 242f1799fc22("ovn-controller: Refactor chassis.c to abstract the string

Re: [ovs-dev] [PATCH v5] Detailed packet drop statistics per dpdk and vhostuser ports

2019-07-24 Thread Sriram Vatala via dev
Hi, @Ben : Thanks for the response. @Ilya, @Ian : Can you please review the patch and provide comments if any. Thanks, Sriram. -Original Message- From: Ben Pfaff Sent: 22 July 2019 21:37 To: Sriram Vatala Cc: ovs-dev@openvswitch.org Subject: Re: [PATCH v5] Detailed packet drop

Re: [ovs-dev] [PATCH] ovn-controller: Fix flow installation latency caused by recompute.

2019-07-24 Thread Numan Siddique
On Wed, Jul 24, 2019 at 8:23 AM Han Zhou wrote: > From: Han Zhou > > When there are in-flight flow-installations pending to ovs-vswitchd, > current incremental processing logic prioritizes new change handling. > However, in scenarios where frequent recomputes are triggered, the > later

[ovs-dev] Диснеевские мультфильмы - большая коллекция в отличном качестве. 13_05_2019 02_03 198707

2019-07-24 Thread Роман Колунов via dev
ДИСНЕЕВСКИЕ МУЛЬТФИЛЬМЫ Большая коллекция, состоящая из 83 мультфильмов! Предлагаем Вашему вниманию коллекцию полнометражных диснеевских мультфильмов, все вошедшие в коллекцию мультики сделаны как фильмы – это очень красивые и интересные мультфильмы, которые всегда учат добру и имеют мораль.