Re: [ovs-dev] [PATCH v2 7/9] datapath: Add support for conntrack timeout policy

> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote: > > This patch adds support for specifying a timeout policy for a > connection in connection tracking system in kernel datapath. > The timeout policy will be attached to a connection when the > connection is committed to conntrack. > > This

Re: [ovs-dev] [PATCH v2 6/9] datapath: compat: Backport nf_conntrack_timeout support

> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote: > > This patch brings in nf_ct_timeout_put() and nf_ct_set_timeout() > when it is not available in the kernel. > > Three symbols are created in acinclude.m4. > > * HAVE_NF_CT_SET_TIMEOUT is used to determine if upstream net-next commit >

Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

> On Aug 5, 2019, at 8:07 PM, Darrell Ball wrote: > > On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei wrote: > >> +struct ct_timeout_policy { >> +struct uuid uuid; >> +unsigned int last_used_seqno; >> +struct ct_dpif_timeout_policy cdtp; >> +struct cmap_node node; /*

Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote: > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index 751535249e21..6336494e0bc8 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > > +static struct ct_timeout_policy * > +ct_timeout_policy_alloc(struct

[ovs-dev] [PATCH] datapath: Apply bug fixes of nf_conncount for different kernel versions

In upstream kernel, there are several critical bug fixes for nf_conncount between 5c789e1 ("netfilter: nf_conncount: Add list lock and gc worker, and RCU for init tree search") and c78e781 ("netfilter: nf_conncount: replace CONNCOUNT_LOCK_SLOTS with CONNCOUNT_SLOTS"). This fixes are already

[ovs-dev] [PATCH v2] datapath: compat: Backports bugfixes for nf_conncount

This patch backports several critical bug fixes related to locking and data consistency in nf_conncount code. This backport is based on the following upstream net-next upstream commits. 4cd273b ("netfilter: nf_conncount: don't skip eviction when age is negative") d4e7df1 ("netfilter:

[ovs-dev] OVN: Guest VLAN Tagging proposal

Hi, PROBLEM STATEMENT: === OVN does not provide support for guest vlan tagging, i.e where a VIF can vlan tag the packets. a. This feature can also be addressed as Trunking support as well (from logical switch port perspective). b. Main use case would be

[ovs-dev] ФИЗИКА - увлекательная видеоколлекция для детей. 13_05_2019 02_03 198707

ФИЗИКА Увлекательная видеоколлекция для детей. Почему Земля имеет форму шара? Существует ли вечный двигатель? Можно ли самому изготовить лупу? Где можно услышать эхо и с какой скоростью движется звук? Как образуется радуга? почему не падает самолет и не тонет корабль? Почему космонавты не

[ovs-dev] [RFC ovn] Modify release document for OVN.

This is an RFC to discuss the modified release cycle of OVN compared to OVS. The document is mostly unchanged, with two exceptions: * The release cycle for OVN is modified to be 3 months instead of 6. * The version numbering for OVN is modified to use the year and month of the release instead

[ovs-dev] [PATCH] datapath: compat: Backports bugfixes for nf_conncount

This patch backports several critical bug fixes related to locking and data consistency in nf_conncount code. This backport is based on the following upstream net-next upstream commits. d4e7df1 ("netfilter: nf_conncount: use rb_link_node_rcu() instead of rb_link_node()") 53ca0f2 ("netfilter:

Re: [ovs-dev] OVN Mailing list and patch submission

On 7/30/19 2:08 PM, Mark Michelson wrote: Hi, Now that the OVN repo is created and new OVN changes are being targeted for it, it seems like a good idea to bring up the topic of creating a mailing list for OVN again. Would it be possible to get a new OVN mailing list? A subject that goes

Re: [ovs-dev] [PATCH v2 9/9] system-traffic: Add zone-based conntrack timeout policy test

On Tue, Aug 6, 2019 at 11:07 AM Yi-Hung Wei wrote: > On Tue, Aug 6, 2019 at 10:21 AM Darrell Ball wrote: > > > > > > I did some more testing and found a similar problem as in V1. > > > > This test can be run successfully once and then fails after that. > > Maybe you want to look into that. It

[ovs-dev] [RFC ovn] Document process for compatibility between OVS and OVN.

This document serves to provide an explanation for how OVN will remain compatible with OVS. It provides instructions for OVN contributors for how to maintain compatibility even across older versions of OVS when possible. Note that the document currently makes reference to some non-existent items.

Re: [ovs-dev] [PATCH v2 9/9] system-traffic: Add zone-based conntrack timeout policy test

On Tue, Aug 6, 2019 at 10:21 AM Darrell Ball wrote: > > > I did some more testing and found a similar problem as in V1. > > This test can be run successfully once and then fails after that. > Maybe you want to look into that. It is probably related to: > > dball@ubuntu:~/openvswitch/ovs$ lsmod |

Re: [ovs-dev] [PATCH v2 8/9] ofproto-dpif-xlate: Translate timeout policy in ct action

On Mon, Aug 5, 2019 at 8:51 PM Darrell Ball wrote: > Thanks for the patch > > The main comment I had from the V1 patch was adding the check > > +if (ofc->flags & NX_CT_F_COMMIT) { > > in compose_conntrack_action() > > I see that was done. > > After a quick scan, I had one minor comment

Re: [ovs-dev] [PATCH v2 9/9] system-traffic: Add zone-based conntrack timeout policy test

On Mon, Aug 5, 2019 at 9:03 PM Darrell Ball wrote: > Thanks for the patch > > I see the test is much improved now from V1 and passes - thanks > > Ideally, tests should be associated with some code for context > It could be folded into patch 8 > I did some more testing and found a similar

Re: [ovs-dev] [PATCH v5] Detailed packet drop statistics per dpdk and vhostuser ports

On 24.07.2019 11:55, Sriram Vatala wrote: > Hi, > > @Ben : Thanks for the response. > > @Ilya, @Ian : Can you please review the patch and provide comments if any. Hi. Thanks for working on this! One thing about the patch is that it modifies the hot path, thus needs a performance evaluation

Re: [ovs-dev] [PATCH ovn] Correct the include path when including the header files from lib folder

On Tue, Aug 6, 2019 at 8:26 PM Mark Michelson wrote: > Acked-by: Mark Michelson > Thanks for the review. I applied this to master. Numan > > On 8/6/19 8:56 AM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Compilation will fail when we try to build ovn from external ovs >

Re: [ovs-dev] [PATCH ovn] Correct the include path when including the header files from lib folder

Acked-by: Mark Michelson On 8/6/19 8:56 AM, nusid...@redhat.com wrote: From: Numan Siddique Compilation will fail when we try to build ovn from external ovs directory. Earlier commit [1] missed changing the include path for lib/*.c files. [1] - a469954c00c4 ("Include ovn header files from

Re: [ovs-dev] [PATCH ovn] RHEL: Suppress systemd status message during pre-installation.

Thanks, I applied this to master. On 8/5/19 3:37 PM, Numan Siddique wrote: On Mon, Aug 5, 2019 at 11:45 PM Mark Michelson > wrote: When running the pre-installation hook, the spec file attempts to determine if the old openvswitch-provided OVN services are

Re: [ovs-dev] [PATCH ovn] Add -u option to ovn-nbctl

Thanks, I pushed this to master. On 8/2/19 1:04 PM, Numan Siddique wrote: On Fri, Aug 2, 2019 at 12:14 AM Mark Michelson > wrote: This option can be used in one of two ways. When paired with --detach, this creates a unixctl socket with the name given

Re: [ovs-dev] [PATCH 0/3] travis: Build time optimization.

Ilya Maximets writes: > These are low-hanging optimizations for TravisCI that allows > to speed up build without changing the test scope. > > On 'xenial' images this patch set gives ~30% build time improvement. > Example: > > Before: > Ran for 1 hr 22 min 26 sec > Total time 5 hrs 40

[ovs-dev] [PATCH branch 2.12] OVN: fix default L4 default proto reported by ovn-nbctl

If no protcol is specified defining a load balancing rule TCP is selected as default but ovn-nbctl lb-list reports 'tcp/udp' in this case. Fix it reporting tcp in this case Fixes: e2bfcad6cbb0 ("ovn-nbctl: Add LB commands") Acked-by: Dumitru Ceara Signed-off-by: Lorenzo Bianconi ---

Re: [ovs-dev] [PATCH branch-2.5] travis: Drop 2.6.32 kernel build.

Ilya Maximets writes: > gcc >= 5 can't build Linux kernel 2.6.32 and this will never > change because 2.6.32 is not supported for a last few years. > > TravsCI migrated to use Ubuntu Xenial by defualt with gcc 5 > installed. Dropping the 2.6.32 build item to unlock green build. > >

[ovs-dev] [PATCH branch-2.5] travis: Drop 2.6.32 kernel build.

gcc >= 5 can't build Linux kernel 2.6.32 and this will never change because 2.6.32 is not supported for a last few years. TravsCI migrated to use Ubuntu Xenial by defualt with gcc 5 installed. Dropping the 2.6.32 build item to unlock green build. Signed-off-by: Ilya Maximets --- Sending this

[ovs-dev] [PATCH ovn] Correct the include path when including the header files from lib folder

From: Numan Siddique Compilation will fail when we try to build ovn from external ovs directory. Earlier commit [1] missed changing the include path for lib/*.c files. [1] - a469954c00c4 ("Include ovn header files from lib/ instead of ovn/lib/") Signed-off-by: Numan Siddique ---

Re: [ovs-dev] memory leak in internal_dev_create

On Tue, 06 Aug 2019 01:58:05 -0700 > Hello, > > syzbot found the following crash on: > > HEAD commit:1e78030e Merge tag 'mmc-v5.3-rc1' of git://git.kernel.org/.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=148d3d1a60 > kernel config:

Re: [ovs-dev] [branch 2.12] ovn-northd: fixed memory leak in ovn_port_update_sbrec()

Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

[ovs-dev] [PATCH 3/3] travis: Drop OSX workarounds.

TravisCI currently uses xcode9.4 as a default image and it it has good version of libtool out-of-the-box. Removing these workarounds saves 4-6 minutes of OSX build. Signed-off-by: Ilya Maximets --- .travis/osx-prepare.sh | 3 --- 1 file changed, 3 deletions(-) diff --git

[ovs-dev] [PATCH 2/3] travis: Combine kernel builds.

Single kernel build job takes ~3 minutes in average. Most of this time takes VM spawning and initial configuration. Combining these 24 jobs in 4 allows us to better utilize workers and not waste time on spawning VMs. Before: 24 jobs * 3 minutes = 72 minutes 72 minutes / 5 workers = 14.4

[ovs-dev] [PATCH 0/3] travis: Build time optimization.

These are low-hanging optimizations for TravisCI that allows to speed up build without changing the test scope. On 'xenial' images this patch set gives ~30% build time improvement. Example: Before: Ran for 1 hr 22 min 26 sec Total time 5 hrs 40 min 56 sec After (second run after the

[ovs-dev] [PATCH 1/3] travis: Cache DPDK build.

This change enables cache for DPDK build directory, so we'll never build same version of DPDK again. This speeds up each DPDK related job by 4-6 minutes effectively saving 30-50 minutes of the total time. Ex. Full TravisCI run on 'trusty' images: Without cache: Ran for 1 hr 9 min 29 sec

Re: [ovs-dev] [PATCH 1/1] ovn-northd: fixed memory leak in ovn_port_update_sbrec()

On Fri, Aug 2, 2019 at 9:43 PM Numan Siddique wrote: > > > On Fri, Aug 2, 2019 at 5:45 PM Damijan Skvarc > wrote: > >> Memory leak happens because of redundand memory allocation for array >> of single pointer. Issue was solved by removing this redundand allocation >> and using address of

[ovs-dev] [branch 2.12] ovn-northd: fixed memory leak in ovn_port_update_sbrec()

From: Damijan Skvarc Memory leak happens because of redundand memory allocation for array of single pointer. Issue was solved by removing this redundand allocation and using address of pointer to created chassis sb_ha_entity instead. Signed-off-by: Damijan Skvarc Acked-by: Numan Siddique

Re: [ovs-dev] [PATCH 1/1] Fixed memory leak in ovn-controller while handling port binding changes.

On Tue, Jul 23, 2019 at 4:47 PM Dumitru Ceara wrote: > On Tue, Jul 23, 2019 at 12:33 PM Damijan Skvarc > wrote: > > > > Signed-off-by: Damijan Skvarc > > Looks good to me. Thanks! > Acked-by: Dumitru Ceara > Thank for the fix. I pushed this patch to ovn master. We do need to backport this

[ovs-dev] memory leak in internal_dev_create

Hello, syzbot found the following crash on: HEAD commit:1e78030e Merge tag 'mmc-v5.3-rc1' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=148d3d1a60 kernel config: https://syzkaller.appspot.com/x/.config?x=30cef20daf3e9977

Re: [ovs-dev] [branch 2.12] ovn-controller: Encode the virtual port key in vport_bind action in network byte order

Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 ovn-controller: Encode the virtual port key

[ovs-dev] Видеоуроки по школьным предметам: Математика, Русский, Английский, Химия, Физика, Биология, География, Природоведение, Словесность, Рисование, Рукоделие, Астрономия, Музыка. 13_05_2019 02_03

ВИДЕОУРОКИ ПО ШКОЛЬНЫМ ПРЕДМЕТАМ Математика, Русский, Английский, Химия, Физика, Биология, География, Природоведение, Словесность, Рисование, Рукоделие, Астрономия, Музыка. Предлагаем вашему вниманию замечательные видеоуроки по школьным предметам, которые порадуют не только школьников, но и их

[ovs-dev] [branch 2.12] ovn-controller: Encode the virtual port key in vport_bind action in network byte order

From: Numan Siddique The commit [1] encoded the vport key using uint32_t and the test case "action parsing" is failing for s380 arch. This patch fixes this issue by encoding the vport key in the network byte order. [1] - 054f4c85c413("Add a new logical switch port type - 'virtual'") Fixes: