Re: [ovs-dev] [PATCH v3 ovn] Add missing checkpatch.py script

0-day Robot writes: > Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out > your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > git-am: > error: The following untracked working tree files would

Re: [ovs-dev] [PATCH v2 9/9] system-traffic: Add zone-based conntrack timeout policy test

On Mon, Aug 12, 2019 at 5:22 PM Yi-Hung Wei wrote: > On Sun, Aug 11, 2019 at 12:30 PM Darrell Ball wrote: > > > > I did some further testing and ran into another issue; in this case, > one, I did not expect. > > > > I added an additional sending of packets at the end of the test after > this

Re: [ovs-dev] [PATCH v4 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

On Tue, Aug 20, 2019 at 12:30 PM Yi-Hung Wei wrote: > On Tue, Aug 20, 2019 at 12:46 AM Darrell Ball wrote: > > After fixing a bug in my proposed incremental and adding tracking of an > already removed sub timeout policy: > > Pls double check. > > Thanks for the proposed incremental. > > I

Re: [ovs-dev] [PATCH v4 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

On Tue, Aug 20, 2019 at 12:46 AM Darrell Ball wrote: > After fixing a bug in my proposed incremental and adding tracking of an > already removed sub timeout policy: > Pls double check. Thanks for the proposed incremental. I checked all the other logging places in dpif-netlink, we usually do

Re: [ovs-dev] [PATCH v1] ovs-lib: Fix standalone db migration to raft

On Mon, Aug 19, 2019 at 6:36 PM Aliasgar Ginwala wrote: > > Current code of create-cluster from standalone db takes backup of existing > standalone db and then generates a new clustered dbs from backup dbs. Hence, > during migration if nb and sb dbs are still present, create-cluster will fail >

Re: [ovs-dev] [PATCH v3 ovn] Add missing checkpatch.py script

Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: The following untracked working tree files would be overwritten by merge:

[ovs-dev] [PATCH v3 ovn] Add missing checkpatch.py script

Add utility checkpatch.py script used to check patch correctness before submitting it. Introduce checkpatch.at unit tests Signed-off-by: Lorenzo Bianconi --- Changes since v2: - add checkpatch.at unit test Changes since v1: - fix subject --- tests/automake.mk |1 +

[ovs-dev] Productos especiales de acero inoxidable

( https://www.ofequipamientos.com/ ) . ARMARIOS METALICOS ESTANTERIAS METALICOS LOCKERS Y GUARDARROPA CARROS Y PRODUCTOS DE ALAMBRE RIELERAS Y GANCHERAS PARA CAMARAS FRIGORIFICAS MESADAS Y PRODUCTOS ESPECIALES DE ACERO INOXIDABLE . ( https://www.ofequipamientos.com/ ) . CONSULTAS CLICK ACA ( 

Re: [ovs-dev] [PATCHv18] netdev-afxdp: add new netdev type for AF_XDP.

On 20.08.2019 14:19, Eelco Chaudron wrote: > > > On 20 Aug 2019, at 12:10, Ilya Maximets wrote: > >> On 14.08.2019 19:16, William Tu wrote: >>> On Wed, Aug 14, 2019 at 7:58 AM William Tu wrote: On Wed, Aug 14, 2019 at 5:09 AM Eelco Chaudron wrote: > > > > On 8 Aug

Re: [ovs-dev] [PATCH ovn 4/4] rhel: Run ovn services with the 'openvswitch' user

> In regards to hugepages, I would probably stop using the system wide > /dev/hugepages and instead setup a separate mount using hugeadm > properly owned by the openvswitch user. Then we don't need a separate > group setup for that and we don't interfere with the system. In regards to this, now

Re: [ovs-dev] [PATCH ovn 4/4] rhel: Run ovn services with the 'openvswitch' user

> This is patch 4 of the series. Patch 1 takes care of adding ovn > specific run dirs (run, log, db dirs). > Can you please take a look at the series ? Sorry, I completely missed those. You can disregard much of what I said. > Is there a way to solve this issue ? If we run ovn services as >

Re: [ovs-dev] [PATCH] Make pidfile_is_running more robust against empty pidfiles

On Tue, Aug 20, 2019 at 2:52 PM Ilya Maximets wrote: > On 20.08.2019 12:16, Ilya Maximets wrote: > > On 20.08.2019 11:48, Numan Siddique wrote: > >> > >> > >> On Wed, Aug 14, 2019 at 9:21 PM Michele Baldessari > wrote: > >> > >> On Wed, Aug 14, 2019 at 02:28:13PM

Re: [ovs-dev] [PATCH] test: do not require python2 for CHECK_CONNTRACK macro

I applied this patch to OVN master as this fix is required for ovn repo too. Thanks Numan On Tue, Jul 30, 2019 at 11:51 PM Darrell Ball wrote: > On Tue, Jul 30, 2019 at 10:41 AM Mark Michelson > wrote: > > > Why do these macros require python at all? > > > > alg test tools > > > > > > > On

Re: [ovs-dev] [PATCHv18] netdev-afxdp: add new netdev type for AF_XDP.

On 20 Aug 2019, at 12:10, Ilya Maximets wrote: On 14.08.2019 19:16, William Tu wrote: On Wed, Aug 14, 2019 at 7:58 AM William Tu wrote: On Wed, Aug 14, 2019 at 5:09 AM Eelco Chaudron wrote: On 8 Aug 2019, at 17:38, Ilya Maximets wrote: I see a rather high number of

Re: [ovs-dev] [PATCH] dpif-netdev: Add core id in the PMD thread name.

On Tue, Aug 20, 2019 at 12:06 PM Ilya Maximets wrote: > > On 20.08.2019 13:00, David Marchand wrote: > > On Wed, Aug 14, 2019 at 9:45 AM Ilya Maximets > > wrote: > >> > >> On 13.08.2019 19:46, Eelco Chaudron wrote: > >>> This is a really good idea :) One remark should we make it %03d? > >> > >>

[ovs-dev] [PATCH 1/1] [PATCH v3 ovn] logical-fields: fix memory leak while initializing ovnfield_by_name

>This patch named "fix memory leak ...", but I don't see any leaks fixed >in the code. It seems that you've sent diff between v1 and v2 instead of >the patch itself. If so, you need to squash this into your v1 patch and >send as v3. > >Best regards, Ilya Maximets. Yes, Ilya, you are right. I

Re: [ovs-dev] [PATCHv18] netdev-afxdp: add new netdev type for AF_XDP.

On 14.08.2019 19:16, William Tu wrote: > On Wed, Aug 14, 2019 at 7:58 AM William Tu wrote: >> >> On Wed, Aug 14, 2019 at 5:09 AM Eelco Chaudron wrote: >>> >>> >>> >>> On 8 Aug 2019, at 17:38, Ilya Maximets wrote: >>> >>> >>> >>> I see a rather high number of afxdp_cq_skip, which should to

Re: [ovs-dev] [PATCH v12] Improved Packet Drop Statistics in OVS

On 20 Aug 2019, at 11:57, Anju Thomas wrote: Thanks for the comments Eelco. I will address them in the next patch. On a similar note, are these the final set of comments for this patch ? I reviewed the complete code, but not the self test parts. Regards Anju -Original Message-

Re: [ovs-dev] [PATCH] dpif-netdev: Add core id in the PMD thread name.

On 20.08.2019 13:00, David Marchand wrote: > On Wed, Aug 14, 2019 at 9:45 AM Ilya Maximets wrote: >> >> On 13.08.2019 19:46, Eelco Chaudron wrote: >>> >>> >>> On 13 Aug 2019, at 18:37, Ilya Maximets wrote: >>> This is highly useful to see on which core PMD is running by only looking at

Re: [ovs-dev] [PATCH] dpif-netdev: Add core id in the PMD thread name.

On Wed, Aug 14, 2019 at 9:45 AM Ilya Maximets wrote: > > On 13.08.2019 19:46, Eelco Chaudron wrote: > > > > > > On 13 Aug 2019, at 18:37, Ilya Maximets wrote: > > > >> This is highly useful to see on which core PMD is running by > >> only looking at the thread name. Thread Id still allows to > >>

Re: [ovs-dev] [PATCH v12] Improved Packet Drop Statistics in OVS

Thanks for the comments Eelco. I will address them in the next patch. On a similar note, are these the final set of comments for this patch ? Regards Anju -Original Message- From: Eelco Chaudron Sent: Monday, August 12, 2019 5:48 PM To: Anju Thomas Cc: d...@openvswitch.org; Keshav

Re: [ovs-dev] [PATCH v2 2/2] netdev-dpdk: Refactor vhost custom stats for extensibility.

On Mon, Aug 19, 2019 at 1:19 PM Ilya Maximets wrote: > > vHost interfaces currently has only one custom statistic, but there > might be others in the near future. This refactoring makes the code > work in the same way as it done for dpdk and afxdp stats to keep the > common style over the

Re: [ovs-dev] [PATCH v2 1/2] netdev-dpdk: Fix not reporting rx_oversize_errors in stats.

On Mon, Aug 19, 2019 at 1:19 PM Ilya Maximets wrote: > > There is a big code duplication issue with DPDK xstats that led to > missed "rx_oversize_errors" statistics. It's defined but not used. Good catch. > Fix that by actually using this stat along with code refactoring that > will allow us

Re: [ovs-dev] [PATCH] Make pidfile_is_running more robust against empty pidfiles

On 20.08.2019 12:16, Ilya Maximets wrote: > On 20.08.2019 11:48, Numan Siddique wrote: >> >> >> On Wed, Aug 14, 2019 at 9:21 PM Michele Baldessari > > wrote: >> >> On Wed, Aug 14, 2019 at 02:28:13PM +0300, Ilya Maximets wrote: >> > On 14.08.2019 11:39, Michele

Re: [ovs-dev] [PATCH] Make pidfile_is_running more robust against empty pidfiles

On 20.08.2019 11:48, Numan Siddique wrote: > > > On Wed, Aug 14, 2019 at 9:21 PM Michele Baldessari > wrote: > > On Wed, Aug 14, 2019 at 02:28:13PM +0300, Ilya Maximets wrote: > > On 14.08.2019 11:39, Michele Baldessari wrote: > > > In some of our

Re: [ovs-dev] [PATCH] Make pidfile_is_running more robust against empty pidfiles

On Wed, Aug 14, 2019 at 9:21 PM Michele Baldessari wrote: > On Wed, Aug 14, 2019 at 02:28:13PM +0300, Ilya Maximets wrote: > > On 14.08.2019 11:39, Michele Baldessari wrote: > > > In some of our destructive testing of ovn-dbs inside containers managed > > > by pacemaker we reached a situation

Re: [ovs-dev] [PATCH v2, ovn] Make pid_exists() more robust against empty pid argument

On Wed, Aug 14, 2019 at 5:49 PM Michele Baldessari wrote: > > In some of our destructive testing of ovn-dbs inside containers managed > by pacemaker we reached a situation where /var/run/openvswitch had > empty .pid files. The current code does not deal well with them > and pidfile_is_running()

Re: [ovs-dev] [PATCH v4 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

On Mon, Aug 19, 2019 at 7:41 PM Darrell Ball wrote: > > > On Mon, Aug 19, 2019 at 12:42 PM Darrell Ball wrote: > >> >> >> On Mon, Aug 19, 2019 at 10:52 AM Yi-Hung Wei >> wrote: >> >>> On Fri, Aug 16, 2019 at 5:07 PM Darrell Ball wrote: >>> > >>> > Thanks for the patch >>> > >>> > Pls let me