Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around
From: Numan Siddique
This was missing when OVN was split from OVS.
Signed-off-by: Numan Siddique
---
Makefile.am | 17 +
TODO_SPLIT.rst | 6 ---
automake.mk | 84 +
ovn-nb.xml | 2 +-
From: Numan Siddique
Now that OVN has it's own rundir, "ovs-appctl -t ovn-controller/ovn-northd"
doesn't work. To fix this, ovn-appctl utility is added which
looks for the OVN pid/ctl files in the ovn rundir.
The code is taken from ovs-appctl.c and modified to use ovn_rundir()
instead of
On Sat, Aug 31, 2019 at 2:48 AM Han Zhou wrote:
>
>
> On Thu, Aug 29, 2019 at 11:36 PM Numan Siddique
> wrote:
> >
> >
> >
> > On Fri, Aug 30, 2019 at 1:04 AM Han Zhou wrote:
> >>
> >>
> >>
> >> On Thu, Aug 29, 2019 at 12:16 PM Numan Siddique
> wrote:
> >>>
> >>>
> >>>
> >>> On Fri, Aug 30,
On Mon, Sep 2, 2019 at 3:38 PM Ilya Maximets wrote:
>
> On 02.09.2019 16:17, David Marchand wrote:
> > On Mon, Sep 2, 2019 at 3:15 PM Ilya Maximets wrote:
> >>
> >> On 02.09.2019 16:09, David Marchand wrote:
> >>> On Mon, Sep 2, 2019 at 1:27 PM Ilya Maximets
> >>> wrote:
>
> This
On 02.09.2019 16:17, David Marchand wrote:
> On Mon, Sep 2, 2019 at 3:15 PM Ilya Maximets wrote:
>>
>> On 02.09.2019 16:09, David Marchand wrote:
>>> On Mon, Sep 2, 2019 at 1:27 PM Ilya Maximets wrote:
This allows to decrease code duplication and avoid using Linux-specific
Hi Han,
On Fri, Aug 30, 2019 at 10:37 PM Han Zhou wrote:
>
> On Fri, Aug 30, 2019 at 1:25 PM Numan Siddique wrote:
> >
> > Hi Han,
> >
> > I am thinking of this approach to solve this problem. I still need to
> test it.
> > If you have any comments or concerns do let me know.
> >
> >
> >
On Mon, Sep 2, 2019 at 3:15 PM Ilya Maximets wrote:
>
> On 02.09.2019 16:09, David Marchand wrote:
> > On Mon, Sep 2, 2019 at 1:27 PM Ilya Maximets wrote:
> >>
> >> This allows to decrease code duplication and avoid using Linux-specific
> >> functions (this might be useful in the future if we'll
On 02.09.2019 16:09, David Marchand wrote:
> On Mon, Sep 2, 2019 at 1:27 PM Ilya Maximets wrote:
>>
>> This allows to decrease code duplication and avoid using Linux-specific
>> functions (this might be useful in the future if we'll try to allow
>> running OvS+DPDK on FreeBSD).
>>
>>
On Fri, Aug 30, 2019 at 8:18 PM Han Zhou wrote:
>
>
>
> On Fri, Aug 30, 2019 at 6:46 AM Mark Michelson wrote:
> >
> > On 8/30/19 5:39 AM, Daniel Alvarez Sanchez wrote:
> > > On Thu, Aug 29, 2019 at 10:01 PM Mark Michelson
> > > wrote:
> > >>
> > >> On 8/29/19 2:39 PM, Numan Siddique wrote:
> >
On Mon, Sep 2, 2019 at 1:27 PM Ilya Maximets wrote:
>
> This allows to decrease code duplication and avoid using Linux-specific
> functions (this might be useful in the future if we'll try to allow
> running OvS+DPDK on FreeBSD).
>
> Signed-off-by: Ilya Maximets
> Acked-by: William Tu
> ---
>
On Mon, Sep 2, 2019 at 1:27 PM Ilya Maximets wrote:
>
> Unlike 'rte_get_tsc_cycles()' which doesn't need any specific
> initialization, 'rte_get_tsc_hz()' could be used only after successfull
> call to 'rte_eal_init()'. 'rte_eal_init()' estimates the TSC frequency
> for later use by
On Mon, Sep 2, 2019 at 1:27 PM Ilya Maximets wrote:
>
> New functions to get and set CPU affinity using CPU dumps.
> This will abstract OS specific implementation details from the
> cross-platform code.
>
> Signed-off-by: Ilya Maximets
> ---
> lib/ovs-numa.c | 72
This allows to decrease code duplication and avoid using Linux-specific
functions (this might be useful in the future if we'll try to allow
running OvS+DPDK on FreeBSD).
Signed-off-by: Ilya Maximets
Acked-by: William Tu
---
lib/dpdk.c | 27 ---
1 file changed, 12
Unlike 'rte_get_tsc_cycles()' which doesn't need any specific
initialization, 'rte_get_tsc_hz()' could be used only after successfull
call to 'rte_eal_init()'. 'rte_eal_init()' estimates the TSC frequency
for later use by 'rte_get_tsc_hz()'. Fairly said, we're not allowed
to use
New functions to get and set CPU affinity using CPU dumps.
This will abstract OS specific implementation details from the
cross-platform code.
Signed-off-by: Ilya Maximets
---
lib/ovs-numa.c | 72 ++
lib/ovs-numa.h | 2 ++
2 files changed, 69
Version 2:
* Removed redundant OVS_UNUSED.
* 'ovs_numa_thread_setaffinity_core' reimplemented via
'ovs_numa_thread_setaffinity_dump' to reduce code duplication.
* Added Ack from William to patches #2 and #3 as they wasn't changed.
Ilya Maximets (3):
ovs-numa: Add dump based thread
The padding length is (packet size - ipv6 header length - ipv6 plen). This
patch fixes incorrect padding size checking in ipv6_sanity_check.
Reviewed-by: Gavin Hu
Signed-off-by: Yanqin Wei
---
lib/flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/flow.c
Modify travis linux build script to use the latest DPDK stable release
17.11.6. Update docs for latest DPDK stable releases.
Signed-off-by: Lukasz Pawlik
---
.travis/linux-build.sh | 2 +-
Documentation/faq/releases.rst | 2 +-
Documentation/intro/install/dpdk.rst
Modify travis linux build script to use the latest DPDK stable release
17.11.6. Update docs for latest DPDK stable releases.
Signed-off-by: Lukasz Pawlik
---
.travis/linux-build.sh | 2 +-
Documentation/faq/releases.rst | 4 ++--
Documentation/intro/install/dpdk.rst
Hi Ilya,
Thanks for reviewing the patch and suggestions. Will address your comments in
next patch.
Thanks & Regards,
Sriram.
-Original Message-
From: Ilya Maximets
Sent: 30 August 2019 18:53
To: Sriram Vatala ; ovs-dev@openvswitch.org
Cc: b...@ovn.org; ian.sto...@intel.com; Kevin
21 matches
Mail list logo
