> On Aug 28, 2019, at 3:14 PM, Yi-Hung Wei wrote:
>
> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> index 751535249e21..4b4c4d722645 100644
> --- a/ofproto/ofproto-dpif.c
> +++ b/ofproto/ofproto-dpif.c
>
> +static void
> +ct_timeout_policy_destroy(struct ct_timeout_policy
Hi Timo,
Please try to format your patch in raw text.
Thanks,
Yifeng
On Wed, Sep 11, 2019 at 7:55 PM Timo_Liu wrote:
>
>
>
> Nowadays some Nics support hw offloading via dpdk rte_flow lib. Many
> layer2-layer4 fields can be offloaded to nics, including smac/dmac ipv4
> sip/dip etc. Also some
On Thu, Sep 12, 2019 at 11:45:41AM -0400, Aaron Conole wrote:
> It's possible that a port added to the system with certain kinds
> of invalid parameters will cause the 'could not add' log to be
> triggered. When this happens, the vswitch run loop can continually
> re-attempt adding the port.
> On Sep 13, 2019, at 11:06 AM, William Tu wrote:
>
> On Fri, Sep 13, 2019 at 10:48 AM Justin Pettit wrote:
>>
>>
>>> On Sep 13, 2019, at 10:41 AM, William Tu wrote:
>>>
Is there a reason you limited this to 18 arguments and not use INT_MAX?
>>>
>>> I use 18 because at most we have
On Fri, Sep 13, 2019 at 11:40 AM Aaron Conole wrote:
>
> William Tu writes:
>
> > Hi Aaron,
> >
> > I think this might be a false positive?
>
> Looks like it.
Hi Aaron,
I looked at the checkpatch.py.
Adding a space in front of /sys makes it PASSED, but I couldn't figure it out
a solution to
Acked-by: Daniel Alvarez
On Fri, Sep 13, 2019 at 11:02 PM Mark Michelson wrote:
>
> Acked-by: Mark Michelson
>
> It sucks that we lose the efficiency of the conjunctive match altogether
> on port groups because of this error, but I understand this is a huge
> bug and needs fixing.
If I'm not
Acked-by: Mark Michelson
It sucks that we lose the efficiency of the conjunctive match altogether
on port groups because of this error, but I understand this is a huge
bug and needs fixing.
Perhaps it would be good to start up a discussion on this list about a
more longterm solution that
From: Numan Siddique
If there are multiple ACLs associated with a port group and they
match on a range of some field, then ovn-controller doesn't install
the flows properly and this results in broken ACL functionality.
For example, if there is a port group - pg1 with logical ports - [p1, p2]
Acked-by: Mark Michelson
On 9/10/19 1:00 PM, Lorenzo Bianconi wrote:
Add empty load balancer controller_event support to logical router
pipeline. Update northd documentation even for logical switch pipeline
Signed-off-by: Lorenzo Bianconi
---
Changes since v2:
- improve code readability
Hi,
Greetings of the day!
Would you be interested in acquiring an email list of "Boat Owner List" from
USA?
We also have data for RV Owners, Cruise Travelers, Fishing Enthusiasts, Scuba
Divers List, Food Lovers, Car Owners, Apparel Buyers, Time-Share Owners, Real
Estate Investors, Spa and
William Tu writes:
> Hi Aaron,
>
> I think this might be a false positive?
Looks like it.
> I didn't find any lack whitespace here
>
> On Fri, Sep 13, 2019 at 11:01 AM 0-day Robot wrote:
>>
>> Bleep bloop. Greetings William Tu, I am a robot and I have tried out your
>> patch.
>> Thanks
Hi Aaron,
I think this might be a false positive?
I didn't find any lack whitespace here
On Fri, Sep 13, 2019 at 11:01 AM 0-day Robot wrote:
>
> Bleep bloop. Greetings William Tu, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error
On Fri, Sep 13, 2019 at 10:48 AM Justin Pettit wrote:
>
>
> > On Sep 13, 2019, at 10:41 AM, William Tu wrote:
> >
> >> Is there a reason you limited this to 18 arguments and not use INT_MAX?
> >
> > I use 18 because at most we have 11 tcp, 3 udp, 2 icmp, total of 16 and plus
> > (dp_name,
Bleep bloop. Greetings William Tu, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
#35 FILE: lib/netdev-afxdp.c:561:
Thanks Yifeng:
Sure I revisited the trigger flow and even if its disconnected with
trigger_success(), ovsdb_jsonrpc_trigger_complete will indeed take care of
destroying t->reply via jsonrpc_msg_destroy() which I missed. So you are
right, we don't need to json_destroy(result) explicitly here. I
> On Sep 13, 2019, at 10:41 AM, William Tu wrote:
>
>> Is there a reason you limited this to 18 arguments and not use INT_MAX?
>
> I use 18 because at most we have 11 tcp, 3 udp, 2 icmp, total of 16 and plus
> (dp_name, zone_id), so total is 18.
> I think using INT_MAX is fine, because at db
Hi Justin,
Thanks for your feedbacks.
On Thu, Sep 12, 2019 at 02:14:56PM -0700, Justin Pettit wrote:
>
> > On Aug 28, 2019, at 3:14 PM, Yi-Hung Wei wrote:
> >
> > diff --git a/utilities/ovs-vsctl.8.in b/utilities/ovs-vsctl.8.in
> > index 7c09df79bd29..5b9883ae1c3d 100644
> > ---
Signed-off-by: Aaron Conole
---
utilities/automake.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/utilities/automake.mk b/utilities/automake.mk
index c379596fd..58f743e04 100644
--- a/utilities/automake.mk
+++ b/utilities/automake.mk
@@ -156,6 +156,7 @@ endif
FLAKE8_PYFILES +=
The pid variable is being shadowed by the list comprehension in the
os.execvp() call. This can generate flakes / warnings in some environments
so fix it.
Signed-off-by: Aaron Conole
---
utilities/ovs-check-dead-ifs.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The print call changed in python3, so update it.
Signed-off-by: Aaron Conole
---
utilities/ovs-check-dead-ifs.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/utilities/ovs-check-dead-ifs.in b/utilities/ovs-check-dead-ifs.in
index ac54f6c9c..f398a3401 100755
---
The patch detects the numa node id from the name of the netdev,
by reading the '/sys/class/net//device/numa_node'.
If not available, ex: virtual device, or any error happens,
return numa id 0.
Signed-off-by: William Tu
---
lib/netdev-afxdp.c | 38 +-
1 file
On Tue, Sep 10, 2019 at 09:08:59AM -0700, William Tu wrote:
> On Tue, Sep 10, 2019 at 9:06 AM Gregory Rose wrote:
> >
> >
> > On 9/10/2019 7:02 AM, Thomas Goirand wrote:
> > > Hi Ben and others,
> > >
> > > I just want to know: does OVS 2.10 has support for IPv6 mac learning /
> > > NDP, so that
Thanks Aginwala,
Could you please double check if 'json_destroy(result)' is necessary here?
If result != NULL, then it is passed in trigger_success(), which puts
result in 't->reply',
later, jsonrpc_msg_destroy() will free it.
Thanks,
Yifeng
On Thu, Sep 12, 2019 at 2:00 PM aginwala wrote:
>
>
Signed-off-by: Dumitru Ceara
---
.gitignore | 8
include/ovn/.gitignore | 2 ++
utilities/.gitignore | 1 +
3 files changed, 11 insertions(+)
create mode 100644 include/ovn/.gitignore
diff --git a/.gitignore b/.gitignore
index 2366fe5..6fee075 100644
--- a/.gitignore
+++
On Wed, Sep 11, 2019 at 7:22 PM Lorenzo Bianconi
wrote:
>
> Add set_queue() action for qos capable localnet port in
> S_SWITCH_OUT_PORT_SEC_L2 stage of logical switch pipeline
>
> Signed-off-by: Lorenzo Bianconi
> ---
> northd/ovn-northd.8.xml | 7 ++-
> northd/ovn-northd.c | 12
On Wed, Sep 11, 2019 at 7:21 PM Lorenzo Bianconi
wrote:
>
> Introduce add_egress_interface_mappings routine in order to collect as
> egress interfaces all ovs bridge interfaces marked with ovn-egress-iface
> in the external_ids column of ovs interface table.
> ovn-egress-iface is used to indicate
On Wed, Sep 11, 2019 at 8:37 PM Matteo Croce wrote:
>
> On Tue, Sep 10, 2019 at 11:53 AM Vishal Deep Ajmera
> wrote:
> >
> > v5->v6:
> > Addressed comments from Ilya Maximets.
> > https://mail.openvswitch.org/pipermail/ovs-dev/2019-August/362001.html
> > Rebased to OVS master.
> >
> > v4->v5:
On Sat, 10 Aug 2019 00:34:55 -0700
Pravin Shelar wrote:
> On Thu, Aug 8, 2019 at 8:55 PM Hillf Danton wrote:
> >
> >
> > syzbot found the following crash on:
> >
> > HEAD commit:1e78030e Merge tag 'mmc-v5.3-rc1' of git://git.kernel.org/..
> > git tree: upstream
> > console output:
28 matches
Mail list logo
