[ovs-dev] [PATCH] lacp: report desync in ovs threads enabling slave

2019-10-21 Thread Gowrishankar Muthukrishnan
It is helpful in reporting main thread that is yet to enable bond slave, but link state was brought up by lacp thread and capture this desync between ovs threads for debugging. Fixes: a8448cb170 ("lacp: Avoid packet drop on LACP bond after link up") Signed-off-by: Gowrishankar Muthukrishnan ---

Re: [ovs-dev] [PATCH ovn] tests: Fix check-valgrind and check-lcov.

2019-10-21 Thread Han Zhou
On Mon, Oct 21, 2019 at 4:29 PM Ben Pfaff wrote: > > On Mon, Oct 21, 2019 at 04:17:30PM -0700, Han Zhou wrote: > > After split from OVS, make check-valgrind and check-lcov are not > > working any more, because the $ovs_srcdir are missing for these tests. > > > > Signed-off-by: Han Zhou > > Seems

[ovs-dev] [PATCH ovn v2] tests: Fix check-valgrind and check-lcov.

2019-10-21 Thread Han Zhou
After split from OVS, make check-valgrind and check-lcov are not working any more, because the $ovs_srcdir are missing for these tests. Instead of add ovs_srcdir=$(ovs_srcdir) for each target, this patch export ovs_srcdir once for all. Signed-off-by: Han Zhou --- tests/automake.mk | 4 +++- 1

[ovs-dev] [PATCH ovn] lflow.c: Fix memory leak of lflow_ref_list_node->ref_name.

2019-10-21 Thread Han Zhou
The ref_name is copied in lflow_resource_add(), but forgot to free in lflow_resource_destroy_lflow(). It can be fixed by freeing it in lflow_resource_destroy_lflow(). However, this field is never really used, so just delete it from lflow_ref_list_node, together with the "type" field. Fixes:

Re: [ovs-dev] [PATCH net-next v4 00/10] optimize openvswitch flow looking up

2019-10-21 Thread Tonghao Zhang
On Tue, Oct 22, 2019 at 1:14 AM William Tu wrote: > > On Wed, Oct 16, 2019 at 5:50 AM wrote: > > > > From: Tonghao Zhang > > > > This series patch optimize openvswitch for performance or simplify > > codes. > > > > Patch 1, 2, 4: Port Pravin B Shelar patches to > > linux upstream with little

[ovs-dev] [PATCH ovn] ovn-controller.c: Fix memory leak of local_datapath->ports.

2019-10-21 Thread Han Zhou
Fixes: 89f5048f960c ("ovn-controller: Minimize SB DB port_binding lookups.") Signed-off-by: Han Zhou --- controller/ovn-controller.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c index b46a1d1..9ab98be 100644 ---

[ovs-dev] [PATCH] faq: Give specific versions that introduced various features.

2019-10-21 Thread Ben Pfaff
Some users would find it useful to know the particular OVS version that introduced a feature to the OVS tree kernel module or to the OVS userspace (DPDK) datapath implementation. This patch updates the FAQ to include that information. This information is primarily gleaned from the top-level NEWS

Re: [ovs-dev] [PATCH ovn] tests: Fix check-valgrind and check-lcov.

2019-10-21 Thread Ben Pfaff
On Mon, Oct 21, 2019 at 04:17:30PM -0700, Han Zhou wrote: > After split from OVS, make check-valgrind and check-lcov are not > working any more, because the $ovs_srcdir are missing for these tests. > > Signed-off-by: Han Zhou Seems reasonable. Another possibility could be to add "export

[ovs-dev] [PATCH ovn] tests: Fix check-valgrind and check-lcov.

2019-10-21 Thread Han Zhou
After split from OVS, make check-valgrind and check-lcov are not working any more, because the $ovs_srcdir are missing for these tests. Signed-off-by: Han Zhou --- tests/automake.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/automake.mk b/tests/automake.mk

Re: [ovs-dev] [PATCH] travis: Test build with afxdp.

2019-10-21 Thread Ilya Maximets
On 21.10.2019 21:28, Aaron Conole wrote: Ilya Maximets writes: We can't easily update the kernel on TravisCI to run system tests with AF_XDP, but we could run build tests with libbpf and headers from newer kernels. Signed-off-by: Ilya Maximets ---

Re: [ovs-dev] [PATCH net] net: openvswitch: free vport unless register_netdevice() succeeds

2019-10-21 Thread Gregory Rose
On 10/21/2019 3:01 AM, Stefano Brivio wrote: From: Hillf Danton syzbot found the following crash on: HEAD commit:1e78030e Merge tag 'mmc-v5.3-rc1' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=148d3d1a60 kernel config:

Re: [ovs-dev] [RFC ovn PATCH 0/5] Separate pinctrl to its own process

2019-10-21 Thread Han Zhou
Hi Mark, Thanks for the patch. We had a brief discussion during last OVN meeting. Let me put my points inlined. On Fri, Oct 18, 2019 at 1:43 PM Mark Michelson wrote: > > This proposes a set of patches to move pinctrl operations out of the > ovn-controller process and into its own. > > The main

Re: [ovs-dev] [PATCH] travis: Test build with afxdp.

2019-10-21 Thread Aaron Conole
Ilya Maximets writes: > We can't easily update the kernel on TravisCI to run system tests > with AF_XDP, but we could run build tests with libbpf and headers > from newer kernels. > > Signed-off-by: Ilya Maximets > --- https://travis-ci.org/ovsrobot/ovs/jobs/600899950 Nice. Looks like the

[ovs-dev] Deterrent: Security update needed

2019-10-21 Thread GoDaddy
Security update information. This link is valid for ONE USE ONLY and EXPIRES IN 24 HOURS Dear Member, Please for your safety, click security update below to upgrade your GoDaddy account to our new system. Security

Re: [ovs-dev] [PATCH] travis: Test build with afxdp.

2019-10-21 Thread Ben Pfaff
On Mon, Oct 21, 2019 at 08:11:14PM +0200, Ilya Maximets wrote: > We can't easily update the kernel on TravisCI to run system tests > with AF_XDP, but we could run build tests with libbpf and headers > from newer kernels. > > Signed-off-by: Ilya Maximets I read this and it seemed reasonable, but

Re: [ovs-dev] [RFC ovn PATCH 0/5] Separate pinctrl to its own process

2019-10-21 Thread Mark Michelson
I realized that after my latest rebase, there are three tests that are failing with this changeset: IGMP snoop/querier/relay ARP lookup before learning vtep 3HVs, 1 VIFs/HV, 1 GW, 1 LS They don't fail in master, so I know they're the fault of the branch. With that in mind, I will fix these

Re: [ovs-dev] [PATCH ovn] Add DNSSL support to OVN

2019-10-21 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 Add DNSSL support to OVN The copy of the

[ovs-dev] [PATCH] travis: Test build with afxdp.

2019-10-21 Thread Ilya Maximets
We can't easily update the kernel on TravisCI to run system tests with AF_XDP, but we could run build tests with libbpf and headers from newer kernels. Signed-off-by: Ilya Maximets --- .travis.yml| 1 + .travis/linux-build.sh | 34 -- 2 files

Re: [ovs-dev] [PATCH net-next v4 05/10] net: openvswitch: optimize flow-mask looking up

2019-10-21 Thread William Tu
> > Hi Tonghao, > > > > Does this improve performance? After all, the original code simply > > check whether the mask is NULL, then goto next mask. > I tested the performance, but I disable the mask cache, and use the > dpdk-pktgen to generate packets: > The test ovs flow: > ovs-dpctl add-dp

Re: [ovs-dev] [PATCH] rhel: Remove the cond 'build_python3'

2019-10-21 Thread Ben Pfaff
On Mon, Oct 21, 2019 at 03:12:42PM +0530, num...@ovn.org wrote: > From: Numan Siddique > > A previous patch removed python2 support from ovs. So we can remove > this condition and make python3 mandatory for builds. Without this > patch, make rpm-fedora on centos 7 fails unless we pass >

[ovs-dev] [PATCH ovn] Add DNSSL support to OVN

2019-10-21 Thread Lorenzo Bianconi
Introduce the possibility to specify a DNSSL option to Router Advertisement packets. DNS Search list can be specified using 'dnssl' tag in the ipv6_ra_configs column of logical router port table Signed-off-by: Lorenzo Bianconi --- controller/pinctrl.c | 62

Re: [ovs-dev] [PATCH net-next v4 00/10] optimize openvswitch flow looking up

2019-10-21 Thread William Tu
On Wed, Oct 16, 2019 at 5:50 AM wrote: > > From: Tonghao Zhang > > This series patch optimize openvswitch for performance or simplify > codes. > > Patch 1, 2, 4: Port Pravin B Shelar patches to > linux upstream with little changes. btw, should we keep Pravin as the author of the above three

[ovs-dev] [PATCH v2] ovsdb-server: Allow replication from older schema version servers.

2019-10-21 Thread numans
From: Numan Siddique Presently, replication is not allowed if there is a schema version mismatch between the schema returned by the active ovsdb-server and the local db schema. This is causing failures in OVN DB HA deployments during uprades. In the case of OpenStack tripleo deployment with

Re: [ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

2019-10-21 Thread Kevin Traynor
On 18/10/2019 13:59, Ilya Maximets wrote: > On 16.10.2019 19:48, Kevin Traynor wrote: >> On 16/10/2019 13:16, Ilya Maximets wrote: >>> Hi Kevin, >>> >>> Thanks for review. Some comments inline. >>> >>> On 16.10.2019 12:15, Kevin Traynor wrote: Hi Sriram, Thanks for working on making

[ovs-dev] [PATCH] lacp: warn transmit failure of lacp pdu

2019-10-21 Thread Gowrishankar Muthukrishnan
It might be difficult to trace whether LACP PDU tx (as in response) was successful when the pdu was not transmitted by egress slave for various reasons (including resource contention within NIC) and only way to trace its fate is by looking at ofproto->stats.tx_[packets/bytes] and slave port stats.

Re: [ovs-dev] [PATCHv4] netdev-linux: Detect numa node id.

2019-10-21 Thread Ilya Maximets
On 17.10.2019 22:08, William Tu wrote: The patch detects the numa node id from the name of the netdev, by reading the '/sys/class/net//device/numa_node'. If not available, ex: virtual device, or any error happens, return numa id 0. Currently only the afxdp netdev type uses it, other linux

Re: [ovs-dev] [PATCH net] net: openvswitch: free vport unless register_netdevice() succeeds

2019-10-21 Thread Stefano Brivio
On Mon, 21 Oct 2019 19:08:01 +0800 Hillf Danton wrote: > Hey Stefano > > On Mon, 21 Oct 2019 18:02:48 +0800 Stefano Brivio wrote: > > > > --- > > This patch was sent to d...@openvswitch.org and appeared on netdev > > only as Pravin replied to it, giving his Acked-by. I contacted the > >

Re: [ovs-dev] [PATCH net] net: openvswitch: free vport unless register_netdevice() succeeds

2019-10-21 Thread Hillf Danton
Hey Stefano On Mon, 21 Oct 2019 18:02:48 +0800 Stefano Brivio wrote: > > --- > This patch was sent to d...@openvswitch.org and appeared on netdev > only as Pravin replied to it, giving his Acked-by. I contacted the Correct. I am unable to find the patches I sent to lkml on

[ovs-dev] [PATCH net] net: openvswitch: free vport unless register_netdevice() succeeds

2019-10-21 Thread Stefano Brivio
From: Hillf Danton syzbot found the following crash on: HEAD commit:1e78030e Merge tag 'mmc-v5.3-rc1' of git://git.kernel.org/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=148d3d1a60 kernel config:

[ovs-dev] [PATCH] rhel: Remove the cond 'build_python3'

2019-10-21 Thread numans
From: Numan Siddique A previous patch removed python2 support from ovs. So we can remove this condition and make python3 mandatory for builds. Without this patch, make rpm-fedora on centos 7 fails unless we pass RPMBUILD_OPT="--with build_python3". Signed-off-by: Numan Siddique ---

Re: [ovs-dev] [PATCH ovn] ovn.at: Fix vtep autotest.

2019-10-21 Thread Dumitru Ceara
On Fri, Oct 18, 2019 at 8:01 PM Numan Siddique wrote: > > > > On Fri, Oct 18, 2019 at 10:57 PM Ben Pfaff wrote: >> >> On Thu, Oct 17, 2019 at 03:51:42PM +0200, Dumitru Ceara wrote: >> > With the removal of the OVS subtree the vtep autotest stopped working >> > because the vtep.ovsschema couldn't

[ovs-dev] [PATCH] lldp: Fix for OVS crashes when a LLDP-enabled port is deleted

2019-10-21 Thread Surya Rudra via dev
Issue: When LLDP is enabled on a port, a structure to hold LLDP related state is created and that structure has a reference to the port. The ofproto monitor thread accesses the LLDP structure to periodically send packets over the associated port. When the port is deleted, the LLDP structure is not

Re: [ovs-dev] [PATCH] tc: Limit the max action number to 16

2019-10-21 Thread Roi Dayan
On 2019-10-18 1:00 PM, Simon Horman wrote: > On Wed, Oct 16, 2019 at 11:53:52AM +, Roi Dayan wrote: >> >> >> On 2019-10-16 2:40 PM, Simon Horman wrote: >>> On Wed, Oct 16, 2019 at 11:37:14AM +0300, Roi Dayan wrote: From: Chris Mi Currently, ovs supports to offload max