Re: [ovs-dev] [PATCH net-next v4] net: openvswitch: add hash info to upcall

2019-11-13 Thread Pravin Shelar
On Wed, Nov 13, 2019 at 7:05 AM wrote: > > From: Tonghao Zhang > > When using the kernel datapath, the upcall don't > include skb hash info relatived. That will introduce > some problem, because the hash of skb is important > in kernel stack. For example, VXLAN module uses > it to select UDP src

[ovs-dev] Formación en Comercio Exterior

2019-11-13 Thread Cierre de Inscripciones
Buen día El cupo del curso está por llenarse y quise aprovechar la oportunidad de hacerte una última invitación: •Nombre: Formación en Comercio Exterior •¿Cuándo?: Viernes 22 de Noviembre •Formato: En línea con interacción en vivo. •Lugar: En Vivo desde su

Re: [ovs-dev] [PATCH v4 ovn 0/3] Improve ovn-detrace support for parsing OpenFlow cookies.

2019-11-13 Thread Han Zhou
On Wed, Nov 13, 2019 at 1:51 AM Dumitru Ceara wrote: > > Commit eb25a7da639e ("Improve debuggability of OVN to OpenFlow translations.") > added support for more types of cookies (partial SB uuids) that are stored > in OpenFlow entries created by ovn-controller. > > The last patch in this series

Re: [ovs-dev] [PATCH v7 ovn 2/2] ovn-northd: Limit ARP/ND broadcast domain whenever possible.

2019-11-13 Thread Han Zhou
On Wed, Nov 13, 2019 at 8:14 AM Dumitru Ceara wrote: > > On Wed, Nov 13, 2019 at 4:30 PM Han Zhou wrote: > > > > > > > > On Wed, Nov 13, 2019 at 2:42 AM Dumitru Ceara wrote: > >> > >> On Tue, Nov 12, 2019 at 8:50 PM Han Zhou wrote: > >> > > >> > > >> > > >> > > >> > On Tue, Nov 12, 2019 at

Re: [ovs-dev] [PATCH ovn v2 00/13] OVN Interconnection

2019-11-13 Thread Numan Siddique
On Thu, Oct 31, 2019 at 2:43 AM Han Zhou wrote: > > The series supports interconnecting multiple OVN deployments (e.g. located at > multiple data centers) through logical routers connected with tansit logical > switches with overlay tunnels, managed through OVN control plane. See the >

Re: [ovs-dev] [PATCH v3] travis: support ppc64le builds

2019-11-13 Thread dwilder
On 2019-11-12 17:24, Lance Yang (Arm Technology China) wrote: Hi, For pip missing issue, we have a workaround. In .travis/linux-prepare.sh. You can install pip or something else with package management commands. For arm64 on travis, we check the environment variables in the container and

[ovs-dev] [PATCH] ovsdb raft: Fix election timer parsing in snapshot RPC.

2019-11-13 Thread Han Zhou
Commit a76ba825 took care of saving and restoring election timer in file header snapshot, but it didn't handle the parsing of election timer in install_snapshot_request/reply RPC, which results in problems, e.g. when election timer change log is compacted in snapshot and then a new node join the

Re: [ovs-dev] [PATCH] compat: Add missing inline keyword

2019-11-13 Thread Gregory Rose
On 11/5/2019 5:03 PM, Gregory Rose wrote: On 11/5/2019 3:14 PM, Ben Pfaff wrote: On Tue, Nov 05, 2019 at 02:14:24PM -0800, Greg Rose wrote: The missing inline keyword before the definition of the rpl_nf_ct_tmpl_free() function causes spurious warnings about the function not being used on

[ovs-dev] [PATCH] dpif-netdev: Modify dfc_processing function to void function

2019-11-13 Thread Malvika Gupta
dfc_processing function returns the number of packets left to be processed in 'packets' array via dp_packet_batch_size() function. dfc_processing function is called only from dp_netdev_input__ and its return value is not checked upon function return. Moreover, dp_packet_batch_is_empty() called

[ovs-dev] [PATCH] dpif-netdev-perf: aarch64 support for accurate timing update of TSC cycle counter

2019-11-13 Thread Malvika Gupta
The accurate timing implementation in this patch gets the wall clock counter via cntvct_el0 register access. This call is portable to all aarch64 architectures and has been verified on an 64-bit arm server. Suggested-by: Yanqin Wei Signed-off-by: Malvika Gupta --- lib/dpif-netdev-perf.h | 5

Re: [ovs-dev] [PATCH v3] dpdk: Migrate to the new pdump API.

2019-11-13 Thread David Marchand
On Wed, Nov 13, 2019 at 4:48 PM Ilya Maximets wrote: > On 12.11.2019 21:13, David Marchand wrote: > > This is pure speculation, but when I saw the crash before, I thought > > that the problem was in the way ovs creates its thread without the > > dpdk being aware of it. > > At least, lcore_ids are

Re: [ovs-dev] [PATCH v7 ovn 2/2] ovn-northd: Limit ARP/ND broadcast domain whenever possible.

2019-11-13 Thread Dumitru Ceara
On Wed, Nov 13, 2019 at 4:30 PM Han Zhou wrote: > > > > On Wed, Nov 13, 2019 at 2:42 AM Dumitru Ceara wrote: >> >> On Tue, Nov 12, 2019 at 8:50 PM Han Zhou wrote: >> > >> > >> > >> > >> > On Tue, Nov 12, 2019 at 10:10 AM Dumitru Ceara wrote: >> > > >> > > On Tue, Nov 12, 2019 at 6:17 PM Han

Re: [ovs-dev] [PATCH v3] dpdk: Migrate to the new pdump API.

2019-11-13 Thread Ilya Maximets
On 12.11.2019 21:13, David Marchand wrote: > On Tue, Nov 12, 2019 at 8:41 PM Ilya Maximets wrote: >> >> On 12.11.2019 19:51, Stokes, Ian wrote: >>> >>> >>> On 11/12/2019 5:15 PM, David Marchand wrote: On Tue, Nov 12, 2019 at 6:07 PM Stokes, Ian wrote: > On 11/11/2019 3:01 PM, Ilya

Re: [ovs-dev] [PATCH v7 ovn 2/2] ovn-northd: Limit ARP/ND broadcast domain whenever possible.

2019-11-13 Thread Han Zhou
On Wed, Nov 13, 2019 at 2:42 AM Dumitru Ceara wrote: > On Tue, Nov 12, 2019 at 8:50 PM Han Zhou wrote: > > > > > > > > > > On Tue, Nov 12, 2019 at 10:10 AM Dumitru Ceara > wrote: > > > > > > On Tue, Nov 12, 2019 at 6:17 PM Han Zhou wrote: > > > > > > > > > > > > > > > > On Tue, Nov 12, 2019

Re: [ovs-dev] [PATCH] dpdk: Deprecate pdump support.

2019-11-13 Thread Flavio Leitner
On Mon, 11 Nov 2019 19:52:56 +0100 Ilya Maximets wrote: > The conventional way for packet dumping in OVS is to use ovs-tcpdump > that works via traffic mirroring. DPDK pdump could probably be used > for some lower level debugging, but it is not commonly used for > various reasons. > > There

Re: [ovs-dev] [PATCH v3] dpdk: Migrate to the new pdump API.

2019-11-13 Thread Ilya Maximets
On 13.11.2019 15:28, Stokes, Ian wrote: > > > On 11/12/2019 7:40 PM, Ilya Maximets wrote: >> On 12.11.2019 19:51, Stokes, Ian wrote: >>> >>> >>> On 11/12/2019 5:15 PM, David Marchand wrote: On Tue, Nov 12, 2019 at 6:07 PM Stokes, Ian wrote: > On 11/11/2019 3:01 PM, Ilya Maximets wrote:

[ovs-dev] [PATCH net-next v4] net: openvswitch: add hash info to upcall

2019-11-13 Thread xiangxia . m . yue
From: Tonghao Zhang When using the kernel datapath, the upcall don't include skb hash info relatived. That will introduce some problem, because the hash of skb is important in kernel stack. For example, VXLAN module uses it to select UDP src port. The tx queue selection may also use the hash in

Re: [ovs-dev] [PATCH v3] dpdk: Migrate to the new pdump API.

2019-11-13 Thread Stokes, Ian
On 11/12/2019 7:40 PM, Ilya Maximets wrote: On 12.11.2019 19:51, Stokes, Ian wrote: On 11/12/2019 5:15 PM, David Marchand wrote: On Tue, Nov 12, 2019 at 6:07 PM Stokes, Ian wrote: On 11/11/2019 3:01 PM, Ilya Maximets wrote: DPDK commit 660098d61f57 ("pdump: use generic multi-process

Re: [ovs-dev] [PATCH v2] netdev-afxdp: Best-effort configuration of XDP mode.

2019-11-13 Thread Ilya Maximets
On 13.11.2019 1:21, William Tu wrote: > On Thu, Nov 7, 2019 at 3:36 AM Ilya Maximets wrote: >> >> Until now there was only two options for XDP mode in OVS: SKB or DRV. >> i.e. 'generic XDP' or 'native XDP with zero-copy enabled'. >> >> Devices like 'veth' interfaces in Linux supports native XDP,

Re: [ovs-dev] [PATCH v2] netdev-afxdp: Best-effort configuration of XDP mode.

2019-11-13 Thread Ilya Maximets
On 08.11.2019 15:22, William Tu wrote: > On Thu, Nov 07, 2019 at 12:36:33PM +0100, Ilya Maximets wrote: >> Until now there was only two options for XDP mode in OVS: SKB or DRV. >> i.e. 'generic XDP' or 'native XDP with zero-copy enabled'. >> >> Devices like 'veth' interfaces in Linux supports

Re: [ovs-dev] [PATCH v7 ovn 2/2] ovn-northd: Limit ARP/ND broadcast domain whenever possible.

2019-11-13 Thread Dumitru Ceara
On Tue, Nov 12, 2019 at 8:50 PM Han Zhou wrote: > > > > > On Tue, Nov 12, 2019 at 10:10 AM Dumitru Ceara wrote: > > > > On Tue, Nov 12, 2019 at 6:17 PM Han Zhou wrote: > > > > > > > > > > > > On Tue, Nov 12, 2019 at 2:29 AM Dumitru Ceara wrote: > > > > > > > > ARP request and ND NS packets for

[ovs-dev] [PATCH v4 ovn 3/3] ovn-detrace: Add support for other types of SB cookies.

2019-11-13 Thread Dumitru Ceara
Commit eb25a7da639e ("Improve debuggability of OVN to OpenFlow translations.") added cookies for Port_Binding, Mac_Binding, Multicast_Group, Chassis records to the OpenfFlow entries they generate. Add support for parsing such cookies in ovn-detrace too. Also: - refactor ovn-detrace to allow a

[ovs-dev] [PATCH v4 ovn 2/3] ovn-detrace: Fix line parsing.

2019-11-13 Thread Dumitru Ceara
The script was not properly parsing rows containing flows from tables 0-9 because ofproto/trace adds leading whitespace for pretty printing flows. Also, add a check to make sure that the cookie refers to a Logical_Flow before trying to print the record. Signed-off-by: Dumitru Ceara ---

[ovs-dev] [PATCH v4 ovn 1/3] ovn-detrace: Fix rundir.

2019-11-13 Thread Dumitru Ceara
After the separation of OVS and OVN rundirs, the ovn-detrace script hasn't been updated to use the OVN rundir instead of the OVS one. Acked-by: Mark Michelson Signed-off-by: Dumitru Ceara --- utilities/ovn-detrace.in |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[ovs-dev] [PATCH v4 ovn 0/3] Improve ovn-detrace support for parsing OpenFlow cookies.

2019-11-13 Thread Dumitru Ceara
Commit eb25a7da639e ("Improve debuggability of OVN to OpenFlow translations.") added support for more types of cookies (partial SB uuids) that are stored in OpenFlow entries created by ovn-controller. The last patch in this series implements support for parsing all these different cookies in

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Fix use of dangling pointers in I-P runtime_data.

2019-11-13 Thread Dumitru Ceara
On Fri, Nov 8, 2019 at 8:27 PM Han Zhou wrote: > > > > On Fri, Nov 8, 2019 at 11:22 AM Han Zhou wrote: > > > > 1. storage data and the void *arg of init() breaks the engine node data > > encapsulation. > > 2. engine_node_valid(_flow_output, engine_run_id) is not needed? Should > > use storage

Re: [ovs-dev] [PATCH v3 ovn 2/3] ovn-detrace: Fix line parsing.

2019-11-13 Thread Dumitru Ceara
On Tue, Nov 12, 2019 at 11:16 PM Han Zhou wrote: > > > Hi Dumitru, > > Thanks for improving the tool. Hi Han, Thanks for the review. > > On Tue, Nov 12, 2019 at 8:47 AM Dumitru Ceara wrote: > > > > The script was never parsing the first cookie in the input. Also, add a > > check to make sure