[ovs-dev] How do i send these funds to your bank account?

Hi Dear, This is to notify that your over due fund which has been delayed since years ago is now ready for payment but i don't know how i am to explain this to you because what i was able to retrieve from the bank is only but $459,000.00 which i don't know how i am to send these funds across to

Re: [ovs-dev] [PATCH ovn] testsuite.at: Add ovn-performance.at back to testsuite.

On Mon, Dec 2, 2019 at 11:28 PM Numan Siddique wrote: > > On Tue, Dec 3, 2019 at 4:50 AM Han Zhou wrote: > > > > It seems the ovn-performance.at was missing when spliting from OVS. > > This patch just add it back. > > > > Signed-off-by: Han Zhou > > Acked-by: Numan Siddique > Thanks Numan. I

Re: [ovs-dev] [PATCH ovn] testsuite.at: Add ovn-performance.at back to testsuite.

On Tue, Dec 3, 2019 at 4:50 AM Han Zhou wrote: > > It seems the ovn-performance.at was missing when spliting from OVS. > This patch just add it back. > > Signed-off-by: Han Zhou Acked-by: Numan Siddique > --- > tests/testsuite.at | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[ovs-dev] [patch v3] conntrack: Support zone limits.

Signed-off-by: Darrell Ball --- v3: recent merge conflict. v2: Address review comment from Ben; one involves creating an admit zone in the connection entry to track the zone used for zone limit accounting when the entry was created and use that zone at cleanup time accounting.

[ovs-dev] [patch v2] conntrack: Support zone limits.

Signed-off-by: Darrell Ball --- v2: Address review comment from Ben; one involves creating an admit zone in the connection entry to track the zone used for zone limit accounting when the entry was created and use that zone at cleanup time accounting. Updated dpctl.man. Fixed

Re: [ovs-dev] [patch v1] conntrack: Support zone limits.

Thanks for the review Ben On Mon, Dec 2, 2019 at 12:19 PM Ben Pfaff wrote: > On Mon, Dec 02, 2019 at 11:41:27AM -0800, Darrell Ball wrote: > > Signed-off-by: Darrell Ball > > Thanks. I'm glad to see this code growing closer to parity with the > kernel implementation. The implementation also

Re: [ovs-dev] datapath-windows: Don't delete internal port

Bleep bloop. Greetings Jinjun Gao via dev, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: corrupt patch at line 29 Repository lacks necessary blobs to fall back on 3-way

[ovs-dev] datapath-windows: Don't delete internal port

According to the microsoft doc: https://docs.microsoft.com/en-us/windows-hardware/drivers/network/hyper-v-extensible-switch-port-and-network-adapter-states Below OID request sequence is validation: OID_SWITCH_NIC_CONNECT -> OID_SWITCH_NIC_DISCONNECT ^

Re: [ovs-dev] [PATCH] ofproto: fix stack-buffer-overflow

Hi, Ben Pfaff Thank you. Give a like. > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, December 3, 2019 4:21 AM > To: Numan Siddique > Cc: Linhaifeng ; d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] ofproto: fix stack-buffer-overflow > > On Fri, Nov

Re: [ovs-dev] [PATCH v7 ovn 2/3] ovn-controller: Add separate I-P engine node for processing ct-zones.

On Wed, Nov 27, 2019 at 5:15 AM Dumitru Ceara wrote: > > Signed-off-by: Dumitru Ceara > --- > controller/ovn-controller.c | 117 +-- > 1 file changed, 78 insertions(+), 39 deletions(-) > > diff --git a/controller/ovn-controller.c

Re: [ovs-dev] [PATCH v7 ovn 1/3] ovn-controller: Add per node states to I-P engine.

On Wed, Nov 27, 2019 at 5:15 AM Dumitru Ceara wrote: > > This commit transforms the 'changed' field in struct engine_node in a > 'state' field. Possible node states are: > - "Stale": data in the node is not up to date with the DB. > - "Updated": data in the node is valid but was updated during >

Re: [ovs-dev] [PATCH] ofproto-dpif: Refactor the get capability code.

On Fri, Nov 22, 2019 at 09:28:14AM -0800, Ben Pfaff wrote: > On Thu, Nov 21, 2019 at 11:09:02AM -0800, William Tu wrote: > > Make the code simpler by removing the use of > > xasprintf and free, and use smap_add_format. > > > > Cc: Ben Pfaff > > Signed-off-by: William Tu > > Looks good to me. >

Re: [ovs-dev] [PATCH ovn] ofctrl_check_and_add_flow: Replace the actions of an existing flow if actions have changed.

On Mon, Dec 2, 2019 at 12:41 AM Numan Siddique wrote: > > On Mon, Dec 2, 2019 at 1:53 PM Han Zhou wrote: > > > > On Sun, Dec 1, 2019 at 11:59 PM Numan Siddique wrote: > > > > > > On Mon, Dec 2, 2019 at 12:44 PM Han Zhou wrote: > > > > > > > > On Fri, Nov 29, 2019 at 1:08 AM wrote: > > > > > >

[ovs-dev] Taller de Planeación Estratégica

12 de Diciembre | Horario de 10:00 a 17:00 hrs. | (hora del centro de México) Taller práctico de Planeación Estratégica A través de las metodologías de planeación, se definen con la participación de la alta dirección y funcionarios clave las líneas y los objetivos estratégicos para la

Re: [ovs-dev] Loan Offer

See attach file, I await your response. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH ovn] testsuite.at: Add ovn-performance.at back to testsuite.

It seems the ovn-performance.at was missing when spliting from OVS. This patch just add it back. Signed-off-by: Han Zhou --- tests/testsuite.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/testsuite.at b/tests/testsuite.at index c1ba734..da8157d 100644 --- a/tests/testsuite.at +++

Re: [ovs-dev] [PATCH] ovsdb-server: Allow OVSDB clients to specify the UUID for inserted rows.

Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 82 characters long (recommended limit is 79) #116 FILE: ovsdb/transaction.c:1: /*

Re: [ovs-dev] [PATCH V3] Add offload packets statistics

Simon, would you mind taking a look at this too? On Mon, Oct 28, 2019 at 08:19:48PM +0800, zhaozhanxu wrote: > Add argument '-m' or '--more' for command ovs-appctl bridge/dump-flows > to display the offloaded packets statistics. > > The commands display as below: > > orignal command: > >

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Add missing port group lflow references.

On Mon, Dec 2, 2019 at 2:38 PM Han Zhou wrote: > > > > On Mon, Dec 2, 2019 at 5:20 AM Dumitru Ceara wrote: > > > > The commit that adds incremental processing for port-group changes > > doesn't store logical flow references for port groups. If a port group > > is updated (e.g., a port is added)

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Add command to trigger an I-P full recompute.

On Mon, Dec 2, 2019 at 10:03 AM Dumitru Ceara wrote: > > Incremental processing tries to minimize the number of times > ovn-controller has to fully reprocess the contents of the southbound > database. However, if a bug in the I-P code causes ovn-controller to > end up in an inconsistent state, we

Re: [ovs-dev] [PATCH v2] netdev: use acquire-release semantics for change_seq in netdev

On Tue, Nov 26, 2019 at 03:35:23PM +0800, Yanqin Wei wrote: > "rxq_enabled" of netdev is writen in the vhost thread and read by pmd > thread once it observes 'change_seq' is updated. This patch is to keep > order on aarch64 or other weak memory model CPU to ensure 'rxq_enabled' is > observed

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Prevent duplicating of traffic to a mirror port

On Sun, Nov 03, 2019 at 11:11:53AM +0200, Roi Dayan wrote: > From: Dmytro Linkin > > Currently ofproto design disallow duplicating output packet on forwarding > and mirroring to/from same ovs port. Next scenario reveal lack of design: > 1. Send ping between regular ovs ports (VFs, for ex.), stop

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Add missing port group lflow references.

On Mon, Dec 2, 2019 at 5:20 AM Dumitru Ceara wrote: > > The commit that adds incremental processing for port-group changes > doesn't store logical flow references for port groups. If a port group > is updated (e.g., a port is added) no logical flow recalculation will be > performed. > > To fix

Re: [ovs-dev] [PATCH] datapath: make generic netlink group const

On Mon, Nov 25, 2019 at 02:20:44PM -0800, Greg Rose wrote: > Upstream commit: > commit 48e48a70c08a8a68f8697f8b30cb83775bda8001 > Author: stephen hemminger > Date: Wed Jul 16 11:25:52 2014 -0700 > > openvswitch: make generic netlink group const > > Generic netlink tables

Re: [ovs-dev] [patch v1] faq: Correct fragment reassembly release.

On Mon, Nov 25, 2019 at 06:39:34PM -0800, Darrell Ball wrote: > Correct fragment reassembly release for the userspace datapath. > > Signed-off-by: Darrell Ball Thanks, applied to master. ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH] ovsdb-server: Allow OVSDB clients to specify the UUID for inserted rows.

Requested-by: Leonid Ryzhyk Signed-off-by: Ben Pfaff --- RFC->v1: Rebase. Documentation/ref/ovsdb-server.7.rst | 9 + NEWS | 1 + ovsdb/execution.c| 26 ++ ovsdb/transaction.c | 22

[ovs-dev] [PATCHv3] userspace: Add GTP-U support.

GTP, GPRS Tunneling Protocol, is a group of IP-based communications protocols used to carry general packet radio service (GPRS) within GSM, UMTS and LTE networks. GTP protocol has two parts: Signalling (GTP-Control, GTP-C) and User data (GTP-User, GTP-U). GTP-C is used for setting up GTP-U

[ovs-dev] New Purchase order

Find attached copy of new purchase order. Regards, Jacques De Bruyn | Specialist - Procurement & Purchasing | +27 11 741 3990 Timken South Africa PTY Ltd | Mail Code: TSA-01 | Cnr Great North Road and Elgin Street Pomona, Kempton Park | Johannesburg, Gauteng, 1619 | Stronger. By

[ovs-dev] Congratulation

Address: Ring Rd E, Accra Hours: Closed · Opens 7:30AM Phone: 30 221 5665 Attention: Congratulation! United Nations has approved Two Million Dollars ($2m) compensation for you for more details contact Mr.John Guaranty Trust Bank Director West Africa Ghana. with this email :jduggan...@gmail.com

Re: [ovs-dev] [PATCH v2 1/2] sparse: Get rid of obsolete rte_flow header.

On Mon, Dec 2, 2019 at 9:19 PM Stokes, Ian wrote: > >>> This header had been copied to cope with issues on the dpdk side. > >>> Now that the problems have been fixed [1], let's drop this file as it is > >>> now out of sync with dpdk. > >>> > >>> 1:

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Restore table ID on error in xlate_table_action().

On Wed, Nov 27, 2019 at 10:04:24AM -0800, Yi-Hung Wei wrote: > On Mon, Oct 14, 2019 at 4:33 PM Ben Pfaff wrote: > > > > Found by inspection. > > > > Signed-off-by: Ben Pfaff > > --- > > ofproto/ofproto-dpif-xlate.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git

Re: [ovs-dev] [PATCH] debian: Update list of copyright holders.

On Wed, Nov 27, 2019 at 10:25:36AM -0800, Yi-Hung Wei wrote: > On Wed, Oct 9, 2019 at 10:35 AM Ben Pfaff wrote: > > > > The list of copyright holders was incomplete and out of date. This > > updates it based on a "grep" for copyright notices, which I reviewed by > > hand. > > > > CC:

Re: [ovs-dev] [PATCH] Documentation: Convert multiple manpages to ReST.

On Thu, Nov 28, 2019 at 12:57:16PM +0530, Numan Siddique wrote: > On Thu, Nov 28, 2019 at 12:49 PM Numan Siddique wrote: > > > > On Wed, Nov 27, 2019 at 4:10 AM Ben Pfaff wrote: > > > > > > On Thu, Oct 10, 2019 at 02:29:42PM -0700, Ben Pfaff wrote: > > > > Signed-off-by: Ben Pfaff > > > > > >

Re: [ovs-dev] [PATCH] ofproto: fix stack-buffer-overflow

On Fri, Nov 29, 2019 at 04:15:59PM +0530, Numan Siddique wrote: > On Fri, Nov 29, 2019 at 11:44 AM Linhaifeng wrote: > > > > Should use flow->actions not >actions. > > > > here is ASAN report: > > = > > ==57189==ERROR:

Re: [ovs-dev] [patch v1] conntrack: Support zone limits.

On Mon, Dec 02, 2019 at 11:41:27AM -0800, Darrell Ball wrote: > Signed-off-by: Darrell Ball Thanks. I'm glad to see this code growing closer to parity with the kernel implementation. The implementation also looks pretty clean. I'm appending some style suggestions. They should not change

Re: [ovs-dev] [PATCH v2 1/2] sparse: Get rid of obsolete rte_flow header.

On 10/15/2019 1:46 PM, Stokes, Ian wrote: On 10/3/2019 7:15 PM, David Marchand wrote: On Thu, Oct 3, 2019 at 8:12 PM David Marchand wrote: This header had been copied to cope with issues on the dpdk side. Now that the problems have been fixed [1], let's drop this file as it is now out

[ovs-dev] [patch v1] conntrack: Support zone limits.

Signed-off-by: Darrell Ball --- Documentation/faq/releases.rst | 4 +- NEWS | 1 + lib/conntrack-private.h | 1 + lib/conntrack.c | 142 +++ lib/conntrack.h | 17 +

Re: [ovs-dev] [PATCH ovn v1] northd: Remove misleading warning log message

On Mon, Dec 2, 2019 at 3:45 AM Numan Siddique wrote: > > On Mon, Dec 2, 2019 at 8:54 AM Russell Bryant wrote: > > > > While debugging an ovn-kubernetes cluster, I spotted several > > "Duplicate MAC set" warning messages in the ovn-northd log. It looks > > like this message was emitted from this

Re: [ovs-dev] [PATCH] rhel: Support RHEL7.7 build and packaging

Thanks. On Mon, Dec 2, 2019 at 10:42 AM Ben Pfaff wrote: > > Done. > > On Mon, Dec 02, 2019 at 09:15:03AM -0800, Yifeng Sun wrote: > > Thanks Ben. Can you please backport this patch to 2.12? > > > > Yifeng > > > > On Thu, Oct 24, 2019 at 3:12 PM Ben Pfaff wrote: > > > > > > On Fri, Oct 11, 2019

Re: [ovs-dev] [PATCH] rhel: Support RHEL7.7 build and packaging

Done. On Mon, Dec 02, 2019 at 09:15:03AM -0800, Yifeng Sun wrote: > Thanks Ben. Can you please backport this patch to 2.12? > > Yifeng > > On Thu, Oct 24, 2019 at 3:12 PM Ben Pfaff wrote: > > > > On Fri, Oct 11, 2019 at 02:49:14PM -0700, Yifeng Sun wrote: > > > This patch provides essential

[ovs-dev] [PATCH ovn v2] ovn-controller: Add command to trigger an I-P full recompute.

Incremental processing tries to minimize the number of times ovn-controller has to fully reprocess the contents of the southbound database. However, if a bug in the I-P code causes ovn-controller to end up in an inconsistent state, we have no easy way to force a full recalculation of the openflow

Re: [ovs-dev] [PATCH ovn] ovn-controller: Add command to trigger an I-P full recompute.

On Mon, Dec 2, 2019 at 5:48 PM Daniel Alvarez Sanchez wrote: > > This is very handy! Can you please add the command to [0]? > > [0] > https://github.com/ovn-org/ovn/blob/master/controller/ovn-controller.8.xml#L403 Thanks for the review Daniel! Yes, i'll add it to the documentation in v2, sorry

Re: [ovs-dev] [PATCH] dpif-netdev: Use netdev-offload API for port lookup while offloading.

On 02.12.2019 13:43, Ophir Munk wrote: > > >> -Original Message- >> From: Ilya Maximets >> Sent: Saturday, November 30, 2019 2:07 PM >> To: Ophir Munk ; Ilya Maximets >> ; ovs-dev@openvswitch.org >> Cc: Roni Bar Yanai ; Eli Britstein >> ; Ian Stokes ; Ameer >> Mahagneh >> Subject: Re:

Re: [ovs-dev] [PATCH] rhel: Support RHEL7.7 build and packaging

Thanks Ben. Can you please backport this patch to 2.12? Yifeng On Thu, Oct 24, 2019 at 3:12 PM Ben Pfaff wrote: > > On Fri, Oct 11, 2019 at 02:49:14PM -0700, Yifeng Sun wrote: > > This patch provides essential fixes for OVS to support > > RHEL7.7's new kernel. > > > > make rpm-fedora-kmod \ > >

Re: [ovs-dev] [PATCH ovn] ovn-controller: Add missing port group lflow references.

Thanks for this patch. This can be a security issue as ACLs applied to a Port Group may not be taking effect. Tested this patch on an OpenStack environment that recreated the issue and I confirm that it fixes the problem. On Mon, Dec 2, 2019 at 1:40 PM Dumitru Ceara wrote: > The commit that

Re: [ovs-dev] [PATCH ovn] ovn-controller: Add command to trigger an I-P full recompute.

This is very handy! Can you please add the command to [0]? [0] https://github.com/ovn-org/ovn/blob/master/controller/ovn-controller.8.xml#L403 On Mon, Dec 2, 2019 at 5:19 PM Dumitru Ceara wrote: > Incremental processing tries to minimize the number of times > ovn-controller has to fully

[ovs-dev] [RFC PATCH] netdev-dpdk: Narrow down txq critical section.

tx_lock protects the NIC/vhost queue from concurrent access. Move it closer to the parts it protects and let packets duplication (when source is not DPDK) and the egress policer run out of it. Signed-off-by: David Marchand --- I caught this by code review, but I imagine this could make the

[ovs-dev] [PATCH ovn] ovn-controller: Add command to trigger an I-P full recompute.

Incremental processing tries to minimize the number of times ovn-controller has to fully reprocess the contents of the southbound database. However, if a bug in the I-P code causes ovn-controller to end up in an inconsistent state, we have no easy way to force a full recalculation of the openflow

[ovs-dev] [PATCH] dpdk: Support running PMD threads on cores > RTE_MAX_LCORE.

Most DPDK components make the assumption that rte_lcore_id() returns a valid lcore_id in [0..RTE_MAX_LCORE] range (with the exception of the LCORE_ID_ANY special value). OVS does not currently check which value is set in RTE_PER_LCORE(_lcore_id) which exposes us to potential crashes on DPDK side.

[ovs-dev] Contratación de mandos operativos y medios

11 de Diciembre | Horario de 10:00 a 17:00 hrs. | (hora del centro de México) - Contratación eficiente de mandos operativos y medios - Una empresa puede tener las mejores instalaciones, los mejores instrumentos de trabajo, incluso, lo mejores directivos, pero le haría falta un elemento

Re: [ovs-dev] [PATCH] dpif-netdev: Use netdev-offload API for port

> Acked-by: Eli Britstein Thanks. Assuming this was sent for the patch "dpif-netdev: Use netdev-offload API for port lookup while offloading.". Best regards, Ilya Maximets. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 15/20] netdev-offload-dpdk-flow: Support offload of output action

On 01.12.2019 9:29, Eli Britstein wrote: > > On 11/30/2019 1:59 PM, Ilya Maximets wrote: >> On 24.11.2019 14:22, Eli Britstein wrote: >>> On 11/22/2019 6:19 PM, Ilya Maximets wrote: On 20.11.2019 16:28, Eli Britstein wrote: > Signed-off-by: Eli Britstein > Reviewed-by: Oz Shlomo

Re: [ovs-dev] [PATCH 3/4] dp-packet: handle new dpdk buffer flags

Bleep bloop. Greetings Flavio Leitner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (lib/dp-packet.h). Repository lacks necessary

Re: [ovs-dev] [PATCH v2 03/10] tc: Introduce tc_id to specify a tc filter

On Sun, Dec 01, 2019 at 07:38:35AM +, Paul Blakey wrote: > > On 11/27/2019 4:07 PM, Marcelo Ricardo Leitner wrote: > > On Wed, Nov 27, 2019 at 02:55:09PM +0200, Roi Dayan wrote: >> From: Paul > > Blakey >> >> Move all that > > is needed to identify a tc filter to

[ovs-dev] [PATCH 2/4] vhost: Disable multi-segmented buffers

There is no support for multi-segmented buffers, so flag that to vhost library. Signed-off-by: Flavio Leitner --- lib/netdev-dpdk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 2423d26ee..cd035f76e 100644 --- a/lib/netdev-dpdk.c +++

[ovs-dev] [PATCH 4/4] netdev-dpdk: Add TCP Segmentation Offload support

Abbreviated as TSO, TCP Segmentation Offload is a feature which enables the network stack to delegate the TCP segmentation to the NIC reducing the per packet CPU overhead. A guest using vhostuser interface with TSO enabled can send TCP packets much bigger than the MTU, which saves CPU cycles

[ovs-dev] [PATCH 1/4] dp-packet: preserve headroom when cloning a pkt batch

The headroom is useful if the packet needs to insert additional header, so preserve the original headroom when cloning the batch. Signed-off-by: Flavio Leitner --- lib/dp-packet.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/dp-packet.h b/lib/dp-packet.h index

[ovs-dev] [PATCH 3/4] dp-packet: handle new dpdk buffer flags

DPDK included a couple flags EXT_ATTACHED_MBUF and IND_ATTACHED_MBUF which are not really offloading flags, so this patch fixes to reset only offloading flags or to reset only those flags when needed. Signed-off-by: Flavio Leitner --- lib/dp-packet.c | 4 +++- lib/dp-packet.h | 2 +- 2 files

[ovs-dev] [PATCH 0/4] Add support for TSO with DPDK

Abbreviated as TSO, TCP Segmentation Offload is a feature which enables the network stack to delegate the TCP segmentation to the NIC reducing the per packet CPU overhead. A guest using vhost-user interface with TSO enabled can send TCP packets much bigger than the MTU, which saves CPU cycles

[ovs-dev] [PATCH ovn v2] ovn-controller: Add missing port group lflow references.

The commit that adds incremental processing for port-group changes doesn't store logical flow references for port groups. If a port group is updated (e.g., a port is added) no logical flow recalculation will be performed. To fix this, when parsing the flow expression also store the referenced

Re: [ovs-dev] [PATCH ovn] ovn-controller: Add missing port group lflow references.

Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Remove Gerrit Change-Id's before submitting upstream. 21: Change-Id:

Re: [ovs-dev] [PATCH] dpif-netdev: Use netdev-offload API for port lookup while offloading.

> -Original Message- > From: Ilya Maximets > Sent: Saturday, November 30, 2019 2:07 PM > To: Ophir Munk ; Ilya Maximets > ; ovs-dev@openvswitch.org > Cc: Roni Bar Yanai ; Eli Britstein > ; Ian Stokes ; Ameer > Mahagneh > Subject: Re: [PATCH] dpif-netdev: Use netdev-offload API for

[ovs-dev] [PATCH ovn] ovn-controller: Add missing port group lflow references.

The commit that adds incremental processing for port-group changes doesn't store logical flow references for port groups. If a port group is updated (e.g., a port is added) no logical flow recalculation will be performed. To fix this, when parsing the flow expression also store the referenced

Re: [ovs-dev] [PATCH V2 08/19] netdev-offload-dpdk: Framework for actions offload

Bleep bloop. Greetings Eli Britstein, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #144 FILE:

Re: [ovs-dev] [PATCH V2 11/19] dpif-netdev: Read hw stats during flow_dump_next() call

Bleep bloop. Greetings Eli Britstein, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #83 FILE:

Re: [ovs-dev] [PATCH ovn v1] northd: Remove misleading warning log message

On Mon, Dec 2, 2019 at 8:54 AM Russell Bryant wrote: > > While debugging an ovn-kubernetes cluster, I spotted several > "Duplicate MAC set" warning messages in the ovn-northd log. It looks > like this message was emitted from this code path by mistake, where > it correctly avoided assigning a

[ovs-dev] [PATCH V2 08/19] netdev-offload-dpdk: Framework for actions offload

Currently HW offload is accelerating only the rule matching sequence. Introduce a framework for offloading rule actions as a pre-step for processing the rule actions in HW. In case of a failure, fallback to the legacy partial offload scheme. Note: a flow will be fully offloaded only if it can

[ovs-dev] [PATCH V2 16/19] netdev-offload-dpdk-flow: Support offload of set MAC actions

Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- NEWS | 3 +- lib/netdev-offload-dpdk-flow.c | 122 + 2 files changed, 124 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 45eef591f..b372e703a 100644 ---

[ovs-dev] [PATCH V2 19/19] netdev-offload-dpdk-flow: Support offload of set TCP/UDP ports actions

Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- NEWS | 4 ++-- lib/netdev-offload-dpdk-flow.c | 48 ++ 2 files changed, 50 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 2ccc19b90..cbdaaeb43 100644 ---

[ovs-dev] [PATCH V2 13/19] netdev-dpdk: Getter function for dpdk port id API

Add a getter function for using the dpdk port id outside the scope of netdev-dpdk.c to be used for HW offload. Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- lib/netdev-dpdk.c | 9 + lib/netdev-dpdk.h | 2 ++ 2 files changed, 11 insertions(+) diff --git a/lib/netdev-dpdk.c

[ovs-dev] [PATCH V2 17/19] netdev-offload-dpdk-flow: Support offload of set IPv4 actions

Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- NEWS | 4 ++-- lib/netdev-offload-dpdk-flow.c | 50 ++ 2 files changed, 52 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index b372e703a..19fe2b72b 100644 ---

[ovs-dev] [PATCH V2 18/19] netdev-offload-dpdk-flow: Support offload of clone tnl_push/output actions

Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- NEWS | 4 +-- lib/netdev-offload-dpdk-flow.c | 61 ++ 2 files changed, 63 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 19fe2b72b..2ccc19b90 100644 ---

[ovs-dev] [PATCH V2 12/19] dpif-netdev: Populate dpif class field in offload struct

Populate dpif class field in offload struct to be used in offloading flow put. Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- lib/dpif-netdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index bfeb1e7b0..22f032ab0 100644 ---

[ovs-dev] [PATCH V2 15/19] netdev-offload-dpdk-flow: Support offload of drop action

Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- NEWS | 2 +- lib/netdev-offload-dpdk-flow.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/NEWS b/NEWS index 33882d2af..45eef591f 100644 --- a/NEWS +++ b/NEWS @@ -26,7 +26,7 @@

[ovs-dev] [PATCH V2 04/19] netdev-offload-dpdk: Fix typo

Fixes: e8a2b5bf92bb ("netdev-dpdk: implement flow offload with rte flow") Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- lib/netdev-offload-dpdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index

[ovs-dev] [PATCH V2 02/19] netdev-offload-dpdk: Refactor flow patterns and actions code

Refactor the flow patterns and actions code to a new source file for better readability and towards adding more code to it. Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- lib/automake.mk | 4 +- lib/netdev-offload-dpdk-flow.c| 479

[ovs-dev] [PATCH V2 05/19] netdev-dpdk: Improve HW offload flow debuggability

Add debug prints when creating and destroying rte flows, with all the flow details (attributes, patterns, actions). Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- lib/netdev-dpdk.c | 29 +++ lib/netdev-offload-dpdk-flow.c| 168

[ovs-dev] [PATCH V2 03/19] netdev-offload-dpdk-flow: Dynamically allocate pattern items

Instead of statically allocated pattern items on the stack, dynamically allocate only the required items while parsing the required matches, to simplify the parsing and make it self-contained, without need of external types. Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo ---

[ovs-dev] [PATCH V2 14/19] netdev-offload-dpdk-flow: Support offload of output action

Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- Documentation/howto/dpdk.rst | 8 ++-- NEWS | 1 + lib/netdev-offload-dpdk-flow.c | 91 -- 3 files changed, 93 insertions(+), 7 deletions(-) diff --git

[ovs-dev] [PATCH V2 01/19] sparse: rte_flow.h: Adapt according to DPDK 18.11.2

In dpdk-latest branch, this file was removed. This patch is temporary, should not be merged, and only exist to pass sparse travis tests. Signed-off-by: Eli Britstein --- include/sparse/rte_flow.h | 810 +++--- 1 file changed, 759 insertions(+), 51

[ovs-dev] [PATCH V2 00/19] netdev datapath actions offload

Currently, netdev datapath offload only accelerates the flow match sequence by associating a mark per flow. This series introduces the full offload of netdev datapath flows by having the HW also perform the flow actions. This series adds HW offload for output, drop, set MAC, set IPv4, set TCP/UDP

[ovs-dev] [PATCH V2 10/19] netdev-offload-dpdk: Implement flow dump next method

Implement the flow dump next method for DPDK, to get the statistics of the provided ufid, towards reading statistics of fully offloaded flows. Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- lib/netdev-offload-dpdk.c | 36 1 file changed, 36

[ovs-dev] [PATCH V2 06/19] netdev-dpdk: Introduce flow_flush method

Introduce this method to orderly flush the rules when upper layers request it. Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- lib/netdev-dpdk.c | 13 + lib/netdev-dpdk.h | 3 +++ 2 files changed, 16 insertions(+) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index

[ovs-dev] [PATCH V2 09/19] netdev-dpdk: Introduce rte flow query function

Introduce a rte flow query function as a pre-step towards reading HW statistics of fully offloaded flows. Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- lib/netdev-dpdk.c | 25 + lib/netdev-dpdk.h | 6 ++ 2 files changed, 31 insertions(+) diff --git

[ovs-dev] [PATCH V2 11/19] dpif-netdev: Read hw stats during flow_dump_next() call

From: Ophir Munk Use netdev dump flow next API in order to update the statistics of fully offloaded flows. Co-authored-by: Eli Britstein Signed-off-by: Ophir Munk Reviewed-by: Oz Shlomo Signed-off-by: Eli Britstein --- lib/dpif-netdev.c | 42 -- 1

[ovs-dev] [PATCH V2 07/19] netdev-offload-dpdk: Introduce flow flush callback

Introduce flow flush callback for dpdk offloaded flows. Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- lib/netdev-offload-dpdk.c | 16 1 file changed, 16 insertions(+) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index 6e1ca8a0d..64873759d

Re: [ovs-dev] [PATCH ovn] ofctrl_check_and_add_flow: Replace the actions of an existing flow if actions have changed.

On Mon, Dec 2, 2019 at 1:53 PM Han Zhou wrote: > > On Sun, Dec 1, 2019 at 11:59 PM Numan Siddique wrote: > > > > On Mon, Dec 2, 2019 at 12:44 PM Han Zhou wrote: > > > > > > On Fri, Nov 29, 2019 at 1:08 AM wrote: > > > > > > > > From: Numan Siddique > > > > > > > > If

Re: [ovs-dev] [OVN][RAFT] Follower refusing new entries from leader

Sorry for the late reply. It was holiday here. I didn't see such problem when there is no compaction. Did you see this problem when DB compaction didn't happen? The difference is that after compaction the RAFT log doesn't have any entries and all the data is in the snapshot. On Fri, Nov 29, 2019

Re: [ovs-dev] [PATCH ovn] ofctrl_check_and_add_flow: Replace the actions of an existing flow if actions have changed.

On Sun, Dec 1, 2019 at 11:59 PM Numan Siddique wrote: > > On Mon, Dec 2, 2019 at 12:44 PM Han Zhou wrote: > > > > On Fri, Nov 29, 2019 at 1:08 AM wrote: > > > > > > From: Numan Siddique > > > > > > If ofctrl_check_and_add_flow(F') is called where flow F' has > > match-actions (M, A2) > > > and

Re: [ovs-dev] [PATCH ovn] ofctrl_check_and_add_flow: Replace the actions of an existing flow if actions have changed.

On Mon, Dec 2, 2019 at 12:44 PM Han Zhou wrote: > > On Fri, Nov 29, 2019 at 1:08 AM wrote: > > > > From: Numan Siddique > > > > If ofctrl_check_and_add_flow(F') is called where flow F' has > match-actions (M, A2) > > and if there already exists a flow F with match-actions (M, A1) in the >