[ovs-dev] [PATCH ovn v1 1/2] tests: Updated expected log message

2019-12-07 Thread Russell Bryant
A previous commit added more detail to this log message. Fix the test to reflect the new text. Signed-off-by: Russell Bryant --- tests/ovn.at | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 8f4d9a440..1d5369341 100644 ---

[ovs-dev] [PATCH ovn v1 2/2] northd: Log all dynamic address assignments

2019-12-07 Thread Russell Bryant
This patch adds INFO level log messages for all dynamic address assignments (MAC, IPv4, IPv6). While debugging some issues in ovn-kubernetes, I found it would be helpful to see ovn-northd's view of what addresses were assigned where and when from its perspective. Signed-off-by: Russell Bryant

Re: [ovs-dev] [PATCH ovn] ovn-controller: Run I-P engine even when no SB txn is available.

2019-12-07 Thread Han Zhou
On Sat, Dec 7, 2019 at 3:21 AM Dumitru Ceara wrote: > > On Sat, Dec 7, 2019 at 1:36 AM Han Zhou wrote: > > > > Thanks Dumitru for the patch. Please see my comments below. > > > > Hi Han, > > Thanks for the review. > > > On Fri, Dec 6, 2019 at 5:38 AM Dumitru Ceara wrote: > > > > > > If the last

[ovs-dev] [PATCH 1/3] dpif-netdev: Avoid infinite re-addition of misconfigured ports.

2019-12-07 Thread Ilya Maximets
Infinite re-addition of failed ports happens if the device in userspace datapath has a linux network interface and it's not able to be configured. For example, if the first reconfiguration fails because of misconfiguration or bad initial device state. In current code victims are afxdp ports and

[ovs-dev] [PATCH 0/3] dpif-netdev: Avoid infinite re-addition of misconfigured ports.

2019-12-07 Thread Ilya Maximets
See detailed description of the problem in commit-message for patch #1. Suggestions on how to fully fix the issue are very welcome. Ilya Maximets (3): dpif-netdev: Avoid infinite re-addition of misconfigured ports. netdev-afxdp: Avoid removing of XDP program if not loaded. system-afxdp.at:

[ovs-dev] [PATCH 3/3] system-afxdp.at: Add test for infinite re-addition of failed ports.

2019-12-07 Thread Ilya Maximets
New file created for AF_XDP specific tests. Signed-off-by: Ilya Maximets --- tests/automake.mk | 3 ++- tests/system-afxdp-testsuite.at | 1 + tests/system-afxdp.at | 24 3 files changed, 27 insertions(+), 1 deletion(-) create mode 100644

[ovs-dev] [PATCH 2/3] netdev-afxdp: Avoid removing of XDP program if not loaded.

2019-12-07 Thread Ilya Maximets
'bpf_set_link_xdp_fd' generates netlink event regardless of actual changes it does, so if-notifier will receive link update even if there was no XDP program previously loaded on the interface. OVS tries to remove XDP program if device configuration was not successful triggering if-notifier that

Re: [ovs-dev] [PATCH ovn v1] nbctl: Log the source of duplicate IP addresses

2019-12-07 Thread Russell Bryant
On Fri, Dec 6, 2019 at 7:39 PM Han Zhou wrote: > > > On Fri, Dec 6, 2019 at 12:13 PM Russell Bryant wrote: > > > > When doing an lsp-add, ovn-nbctl will ensure that there is not another > > port on the same logical switch with the same IP address. I'm seeing > > this error occur with

[ovs-dev] [PATCH ovn] ovn-northd: Consider load balancer active backends in router pipeline

2019-12-07 Thread numans
From: Numan Siddique The commit [1] which added lood balancer health check support missed out on updating the logical flows to consider only active backends in the logical router pipeline if a load balancer is associated. This patch fixes it. It also refactors the code a bit. Without this, an

[ovs-dev] 答复: [openvswitch.org代发]Re: [PATCH] Use batch process recv for tap and raw socket in netdev datapath

2019-12-07 Thread 杨�D
William, thank you for your test, it is one of solutions to OVS DPDK issues in OVS Conference :-), this is a kind of very cheap improving way, the performance isn't that bad, it is basically acceptable for common use cases which don't expect high network performance. -邮件原件- 发件人: dev

Re: [ovs-dev] [PATCH ovn] ovn-controller: Run I-P engine even when no SB txn is available.

2019-12-07 Thread Dumitru Ceara
On Sat, Dec 7, 2019 at 1:36 AM Han Zhou wrote: > > Thanks Dumitru for the patch. Please see my comments below. > Hi Han, Thanks for the review. > On Fri, Dec 6, 2019 at 5:38 AM Dumitru Ceara wrote: > > > > If the last ovn-controller main loop run started a transaction to the > > Southbound DB