[ovs-dev] New mail (25)

2019-12-16 Thread arivumani
View message... ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 2/3] travis: Move x86-only addon packages to linux-prepare.sh

2019-12-16 Thread Lance Yang (Arm Technology China)
> -Original Message- > From: Ilya Maximets > Sent: Saturday, December 14, 2019 1:55 AM > To: dwilder ; Lance Yang (Arm Technology China) > > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org; b...@ovn.org; Yanqin Wei (Arm > Technology China) ; Gavin Hu (Arm Technology China) > ; Ruifeng

[ovs-dev] XDP/AF_XDP checksum use case in OVS

2019-12-16 Thread William Tu
Hi, We are measuring the performance of OVS using AF_XDP, and have the following use case for XDP checksum: High level Topology, two physical machines (PM1,2):   VM1 -> OVS encap with Geneve (PM1) -> physical NIC   -> network ->   physical NIC -> OVS decap (PM2) -> VM2 When running an iperf TCP

Re: [ovs-dev] thundering herd wakeup of handler threads

2019-12-16 Thread David Ahern
On 12/16/19 2:42 PM, Aaron Conole wrote: > Can you try the following and see if your scalability issue is > addressed? I think it could be better integrated, but this is a > different quick 'n dirty. I'll to get to it before the end of the week. ___

Re: [ovs-dev] [PATCH v3 ovn 2/2] northd: add logical flows for dhcpv6 pfd parsing

2019-12-16 Thread Numan Siddique
On Thu, Dec 5, 2019 at 5:51 AM Lorenzo Bianconi wrote: > > Introduce logical flows in ovn router pipeline in order to parse dhcpv6 > advertise/reply from IPv6 prefix delegation router. > Do not overwrite ipv6_ra_pd_list info in options column of SB port_binding > table written by ovn-controller >

Re: [ovs-dev] thundering herd wakeup of handler threads

2019-12-16 Thread Aaron Conole
David Ahern writes: > On 12/13/19 1:52 PM, Aaron Conole wrote: >> Jason Baron via dev writes: >> >>> On 12/10/19 5:20 PM, David Ahern wrote: On 12/10/19 3:09 PM, Jason Baron wrote: > Hi David, > > The idea is that we try and queue new work to 'idle' threads in an > attempt

Re: [ovs-dev] [PATCH V4 12/17] netdev-offload-dpdk: Framework for actions offload

2019-12-16 Thread Ilya Maximets
On 16.12.2019 16:10, Eli Britstein wrote: > Currently HW offload is accelerating only the rule matching sequence. > Introduce a framework for offloading rule actions as a pre-step for > processing the rule actions in HW. In case of a failure, fallback to the > legacy partial offload scheme. > >

Re: [ovs-dev] [PATCH V4 04/17] netdev-offload-dpdk: Improve HW offload flow debuggability

2019-12-16 Thread Ilya Maximets
On 16.12.2019 16:10, Eli Britstein wrote: > Add debug prints when creating and destroying rte flows, with all the > flow details (attributes, patterns, actions). > > Signed-off-by: Eli Britstein > Reviewed-by: Oz Shlomo > --- > lib/netdev-offload-dpdk.c | 200 >

[ovs-dev] Is this d...@openvswitch.org still active?

2019-12-16 Thread Nelson Corey
I have tried to email this your d...@openvswitch.org account severally but I got no response, Please get back to me at your earliest convenience if you receive this email. Sincerely, Nelson Corey Ich habe versucht, Ihrem Konto d...@openvswitch.org eine E-Mail zu senden, habe jedoch keine

Re: [ovs-dev] [PATCH V4 17/17] netdev-offload-dpdk: Support offload of set TCP/UDP ports actions

2019-12-16 Thread Ilya Maximets
On 16.12.2019 16:10, Eli Britstein wrote: > Signed-off-by: Eli Britstein > Reviewed-by: Oz Shlomo > --- > Documentation/howto/dpdk.rst | 1 + > NEWS | 4 +-- > lib/netdev-offload-dpdk.c| 85 > > 3 files changed, 88

Re: [ovs-dev] [PATCH ovn] system-ovn.at: Fix failing system tests.

2019-12-16 Thread Dumitru Ceara
On Mon, Dec 16, 2019 at 6:44 PM Numan Siddique wrote: > > On Mon, Dec 16, 2019 at 10:16 AM Mark Michelson wrote: > > > > Acked-by: Mark Michelson > > > > Thanks Dumitru and Mark. I applied this patch to master. > > Numan Thanks! > > > On 12/6/19 10:14 AM, Dumitru Ceara wrote: > > > Upstream

Re: [ovs-dev] [PATCH] Use batch process recv for tap and raw socket in netdev datapath

2019-12-16 Thread William Tu
On Fri, Dec 06, 2019 at 02:09:24AM -0500, yang_y...@163.com wrote: > From: Yi Yang > > Current netdev_linux_rxq_recv_tap and netdev_linux_rxq_recv_sock > just receive single packet, that is very inefficient, per my test > case which adds two tap ports or veth ports into OVS bridge >

Re: [ovs-dev] [PATCH V4 08/17] dpif-netdev: Update offloaded flows statistics

2019-12-16 Thread Ilya Maximets
On 16.12.2019 16:10, Eli Britstein wrote: > From: Ophir Munk > > In case a flow is HW offloaded, packets do not reach the SW, thus not > counted for statistics. Use netdev flow get API in order to update the > statistics of flows by the HW statistics. > > Co-authored-by: Eli Britstein >

Re: [ovs-dev] [PATCH] ovs-thread: Avoid huge alignment on a base spinlock structure.

2019-12-16 Thread William Tu
On Mon, Dec 16, 2019 at 03:22:00PM +0100, Ilya Maximets wrote: > Marking the structure as 64 bytes aligned forces compiler to produce > big holes in the containing structures in order to fulfill this > requirement. Also, any structure that contains this one as a member > automatically inherits

Re: [ovs-dev] [PATCH] netdev-afxdp: Add pcap dump support.

2019-12-16 Thread William Tu
On Mon, Dec 16, 2019 at 9:47 AM Ilya Maximets wrote: > > On 16.12.2019 18:23, William Tu wrote: > > On Mon, Dec 16, 2019 at 7:27 AM Ilya Maximets wrote: > >> > >> On 16.12.2019 15:27, William Tu wrote: > >>> On Mon, Dec 16, 2019 at 5:57 AM Ilya Maximets wrote: > > On 16.12.2019 14:43,

Re: [ovs-dev] [PATCH v5 06/10] tc: Move tunnel_key unset action before output ports

2019-12-16 Thread Marcelo Ricardo Leitner
On Mon, Dec 16, 2019 at 05:53:17PM +0200, Paul Blakey wrote: > diff --git a/lib/tc.c b/lib/tc.c > index b2d8ca7..7a4acce 100644 > --- a/lib/tc.c > +++ b/lib/tc.c > @@ -665,6 +665,12 @@ nl_parse_flower_tunnel(struct nlattr **attrs, struct > tc_flower *flower) Not sure why but my 'git am' can't

Re: [ovs-dev] [PATCH] netdev-afxdp: Add pcap dump support.

2019-12-16 Thread Ilya Maximets
On 16.12.2019 18:23, William Tu wrote: > On Mon, Dec 16, 2019 at 7:27 AM Ilya Maximets wrote: >> >> On 16.12.2019 15:27, William Tu wrote: >>> On Mon, Dec 16, 2019 at 5:57 AM Ilya Maximets wrote: On 16.12.2019 14:43, William Tu wrote: > On Mon, Dec 16, 2019 at 1:41 AM Ilya Maximets

Re: [ovs-dev] [PATCH ovn] system-ovn.at: Fix failing system tests.

2019-12-16 Thread Numan Siddique
On Mon, Dec 16, 2019 at 10:16 AM Mark Michelson wrote: > > Acked-by: Mark Michelson > Thanks Dumitru and Mark. I applied this patch to master. Numan > On 12/6/19 10:14 AM, Dumitru Ceara wrote: > > Upstream OVS commit: > > commit 03ccfe482ffdc6c1132aeb62467e0fbe6768f25d > > Author:

Re: [ovs-dev] [PATCH] Documentation: Fix ovs-tcpdump options.

2019-12-16 Thread Gregory Rose
On 12/16/2019 6:18 AM, William Tu wrote: Signed-off-by: William Tu --- Documentation/ref/ovs-tcpdump.8.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/ref/ovs-tcpdump.8.rst b/Documentation/ref/ovs-tcpdump.8.rst index 048b70f23daf..b9f8cdf6f786 100644

Re: [ovs-dev] [PATCH] netdev-afxdp: Add pcap dump support.

2019-12-16 Thread William Tu
On Mon, Dec 16, 2019 at 7:27 AM Ilya Maximets wrote: > > On 16.12.2019 15:27, William Tu wrote: > > On Mon, Dec 16, 2019 at 5:57 AM Ilya Maximets wrote: > >> > >> On 16.12.2019 14:43, William Tu wrote: > >>> On Mon, Dec 16, 2019 at 1:41 AM Ilya Maximets wrote: > > On 13.12.2019 21:59,

Re: [ovs-dev] [PATCH V4 12/17] netdev-offload-dpdk: Framework for actions offload

2019-12-16 Thread 0-day Robot
Bleep bloop. Greetings Eli Britstein, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #145 FILE:

[ovs-dev] [PATCH v5 04/10] netdev-offload-tc: Implement netdev tc flush via tc filter del

2019-12-16 Thread Paul Blakey
To be consistent with our tc-ufid mapping after flush, and to support tc chains flushing in the next commit, implement flush operation via deleting all the filters we actually added and delete their mappings. This will also not delete the configured qos policing via matchall filters, while old

[ovs-dev] [PATCH v5 08/10] netdev-offload-tc: Add conntrack support

2019-12-16 Thread Paul Blakey
Zone and ct_state first. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- Changelog: V4->V5: Removed unused int err in parse_put_flow_ct_action --- lib/dpif-netlink.c | 2 + lib/netdev-offload-tc.c | 135 lib/tc.c

[ovs-dev] [PATCH v5 10/10] netdev-offload-tc: Add conntrack nat support

2019-12-16 Thread Paul Blakey
Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- Changelog: V4->V5: Moved the unused 'int err' from patch 4/10 to it's first usage here V2->V3: Ipv6 nat dump fix (missing unspec type in policy) Renamed tc range struct to be consistent with NL ATTRIBUTES and ovs V1->V2:

[ovs-dev] [PATCH v5 01/10] match: Add match_set_ct_zone_masked helper

2019-12-16 Thread Paul Blakey
Sets zone in match. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- include/openvswitch/match.h | 2 ++ lib/match.c | 10 -- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/include/openvswitch/match.h b/include/openvswitch/match.h index

[ovs-dev] [PATCH v5 06/10] tc: Move tunnel_key unset action before output ports

2019-12-16 Thread Paul Blakey
Since OvS datapath gets packets already decapsulated from tunnel devices, it doesn't explicitly decapsulate them. So in a recirculation setup, the tunnel matching continues in the recirculation as the tunnel metadata still exists on the SKB. Tunnel key unset action unsets this metadata. Some

[ovs-dev] [PATCH v5 03/10] tc: Introduce tcf_id to specify a tc filter

2019-12-16 Thread Paul Blakey
Move all that is needed to identify a tc filter to a new structure, tcf_id. This removes a lot of duplication in accessing/creating tc filters. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- Changelog: V3->V4: Fix accidently removed Block_id in flow_put() V2->V3: Renamed

[ovs-dev] [PATCH v5 07/10] netdev-offload-tc: Add recirculation support via tc chains

2019-12-16 Thread Paul Blakey
Each recirculation id will create a tc chain, and we translate the recirculation action to a tc goto chain action. We check for kernel support for this by probing OvS Datapath for the tc recirc id sharing feature. If supported, we can offload rules that match on recirc_id, and recirculation

[ovs-dev] [PATCH v5 00/10] Add support for offloading CT datapath rules to TC

2019-12-16 Thread Paul Blakey
The following patchset introduces hardware offload of OVS connection tracking datapath rules. OVS uses ct() and recirc() (recirculation) actions and recirc_id()/ct_state() matches to support connection tracking. The datapath rules are in the form of:

[ovs-dev] [PATCH v5 09/10] netdev-offload-tc: Add conntrack label and mark support

2019-12-16 Thread Paul Blakey
Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- Changelog: V2->V3: Added missing match on ct_mark. --- lib/dpif-netlink.c | 2 ++ lib/netdev-offload-tc.c | 66 + lib/tc.c| 53

[ovs-dev] [PATCH v5 02/10] compat: Add tc ct action and flower matches defines for older kernels

2019-12-16 Thread Paul Blakey
Update kernel UAPI to support conntrack matches, and the tc actions ct and goto chain. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- include/linux/automake.mk| 3 ++- include/linux/pkt_cls.h | 46 +--- include/linux/tc_act/tc_ct.h | 41

[ovs-dev] [PATCH v5 05/10] dpif: Add support to set user features

2019-12-16 Thread Paul Blakey
This enables user features on the kernel datapath via the DP_CMD_SET command, and also retrieves them to check for actual support and not just an older kernel ignoring the requested features. This will be used in next patch to enable recirc_id sharing with tc. Signed-off-by: Paul Blakey

Re: [ovs-dev] [PATCH] netdev-afxdp: Add pcap dump support.

2019-12-16 Thread Ilya Maximets
On 16.12.2019 15:27, William Tu wrote: > On Mon, Dec 16, 2019 at 5:57 AM Ilya Maximets wrote: >> >> On 16.12.2019 14:43, William Tu wrote: >>> On Mon, Dec 16, 2019 at 1:41 AM Ilya Maximets wrote: On 13.12.2019 21:59, William Tu wrote: > Debugging netdev-afxdp is hard because

Re: [ovs-dev] [PATCH ovn] system-ovn.at: Fix failing system tests.

2019-12-16 Thread Mark Michelson
Acked-by: Mark Michelson On 12/6/19 10:14 AM, Dumitru Ceara wrote: Upstream OVS commit: commit 03ccfe482ffdc6c1132aeb62467e0fbe6768f25d Author: William Tu Date: Tue Jun 25 14:52:38 2019 -0700 vswitchd: Separate disable system and route. Previously,

[ovs-dev] [PATCH V4 03/17] netdev-offload-dpdk: Dynamically allocate pattern items

2019-12-16 Thread Eli Britstein
Instead of statically allocated pattern items on the stack, dynamically allocate only the required items while parsing the matches, to simplify the parsing and make it self-contained, without need of external types, making it easier to support more matches in the future. Signed-off-by: Eli

[ovs-dev] [PATCH V4 15/17] netdev-offload-dpdk: Support offload of set MAC actions

2019-12-16 Thread Eli Britstein
Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- Documentation/howto/dpdk.rst | 1 + NEWS | 3 +- lib/netdev-offload-dpdk.c| 114 +++ 3 files changed, 117 insertions(+), 1 deletion(-) diff --git

[ovs-dev] [PATCH V4 07/17] netdev-offload-dpdk: Implement flow get method

2019-12-16 Thread Eli Britstein
Implement the flow get method for DPDK, to get the statistics of the provided ufid, towards reading statistics of fully offloaded flows. Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- lib/netdev-offload-dpdk.c | 38 ++ 1 file changed, 38

[ovs-dev] [PATCH V4 09/17] dpif-netdev: Populate dpif class field in offload struct

2019-12-16 Thread Eli Britstein
Populate dpif class field in offload struct to be used in offloading flow put. Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- lib/dpif-netdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index be3205a7c..b4fed6416 100644 ---

[ovs-dev] [PATCH V4 08/17] dpif-netdev: Update offloaded flows statistics

2019-12-16 Thread Eli Britstein
From: Ophir Munk In case a flow is HW offloaded, packets do not reach the SW, thus not counted for statistics. Use netdev flow get API in order to update the statistics of flows by the HW statistics. Co-authored-by: Eli Britstein Signed-off-by: Ophir Munk Reviewed-by: Oz Shlomo

[ovs-dev] [PATCH V4 02/17] netdev-offload-dpdk: Refactor action items freeing scheme

2019-12-16 Thread Eli Britstein
Action item data structures are pointed by rte_flow_action items. Refactor the code to free the data structures when freeing the rte_flow_action items, allowing simpler future actions simpler to add to the code. Signed-off-by: Eli Britstein --- lib/netdev-offload-dpdk.c | 92

[ovs-dev] [PATCH V4 16/17] netdev-offload-dpdk: Support offload of set IPv4 actions

2019-12-16 Thread Eli Britstein
Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- Documentation/howto/dpdk.rst | 1 + NEWS | 4 +-- lib/netdev-offload-dpdk.c| 69 3 files changed, 72 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [PATCH V4 14/17] netdev-offload-dpdk: Support offload of drop action

2019-12-16 Thread Eli Britstein
Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- Documentation/howto/dpdk.rst | 1 + NEWS | 2 +- lib/netdev-offload-dpdk.c| 6 +++--- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Documentation/howto/dpdk.rst b/Documentation/howto/dpdk.rst

[ovs-dev] [PATCH V4 12/17] netdev-offload-dpdk: Framework for actions offload

2019-12-16 Thread Eli Britstein
Currently HW offload is accelerating only the rule matching sequence. Introduce a framework for offloading rule actions as a pre-step for processing the rule actions in HW. In case of a failure, fallback to the legacy partial offload scheme. Note: a flow will be fully offloaded only if it can

[ovs-dev] [PATCH V4 04/17] netdev-offload-dpdk: Improve HW offload flow debuggability

2019-12-16 Thread Eli Britstein
Add debug prints when creating and destroying rte flows, with all the flow details (attributes, patterns, actions). Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- lib/netdev-offload-dpdk.c | 200 ++ 1 file changed, 130 insertions(+), 70

[ovs-dev] [PATCH V4 01/17] netdev-offload-dpdk: Refactor flow patterns

2019-12-16 Thread Eli Britstein
Refactor the flow patterns code to a helper function for better readability and towards supporting more matches. Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- lib/netdev-offload-dpdk.c | 207 +- 1 file changed, 111 insertions(+), 96

[ovs-dev] [PATCH V4 06/17] netdev-offload-dpdk: Return UFID-rte_flow entry in find method

2019-12-16 Thread Eli Britstein
Change the find method to return the whole entry of UFID-rte_flow association instead of only the rte_flow field in it, as a pre-step towards adding and using more fields into that map entry. Signed-off-by: Eli Britstein --- lib/netdev-offload-dpdk.c | 29 ++--- 1 file

[ovs-dev] [PATCH V4 05/17] netdev-dpdk: Introduce rte flow query function

2019-12-16 Thread Eli Britstein
Introduce a rte flow query function as a pre-step towards reading HW statistics of fully offloaded flows. Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- lib/netdev-dpdk.c | 30 ++ lib/netdev-dpdk.h | 6 ++ 2 files changed, 36 insertions(+) diff --git

[ovs-dev] [PATCH V4 11/17] netdev-offload: Introduce a function to validate same flow api handle

2019-12-16 Thread Eli Britstein
Signed-off-by: Eli Britstein --- lib/netdev-offload-provider.h | 1 + lib/netdev-offload.c | 12 2 files changed, 13 insertions(+) diff --git a/lib/netdev-offload-provider.h b/lib/netdev-offload-provider.h index 4e1c4251d..5a809c0cd 100644 ---

[ovs-dev] [PATCH V4 13/17] netdev-offload-dpdk: Support offload of output action

2019-12-16 Thread Eli Britstein
Support offload of output action, also configuring count action for allowing query statistics of HW offloaded flows. Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- Documentation/howto/dpdk.rst | 17 +++-- NEWS | 1 + lib/netdev-offload-dpdk.c| 89

[ovs-dev] [PATCH V4 10/17] netdev-dpdk: Getter function for dpdk port id API

2019-12-16 Thread Eli Britstein
Add a getter function for using the dpdk port id outside the scope of netdev-dpdk.c to be used for HW offload. Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- lib/netdev-dpdk.c | 18 ++ lib/netdev-dpdk.h | 2 ++ 2 files changed, 20 insertions(+) diff --git

[ovs-dev] [PATCH V4 17/17] netdev-offload-dpdk: Support offload of set TCP/UDP ports actions

2019-12-16 Thread Eli Britstein
Signed-off-by: Eli Britstein Reviewed-by: Oz Shlomo --- Documentation/howto/dpdk.rst | 1 + NEWS | 4 +-- lib/netdev-offload-dpdk.c| 85 3 files changed, 88 insertions(+), 2 deletions(-) diff --git

[ovs-dev] [PATCH V4 00/17] netdev datapath actions offload

2019-12-16 Thread Eli Britstein
Currently, netdev datapath offload only accelerates the flow match sequence by associating a mark per flow. This series introduces the full offload of netdev datapath flows by having the HW also perform the flow actions. This series adds HW offload for output, drop, set MAC, set IPv4, set TCP/UDP

Re: [ovs-dev] [PATCH] netdev-afxdp: Add pcap dump support.

2019-12-16 Thread William Tu
On Mon, Dec 16, 2019 at 5:57 AM Ilya Maximets wrote: > > On 16.12.2019 14:43, William Tu wrote: > > On Mon, Dec 16, 2019 at 1:41 AM Ilya Maximets wrote: > >> > >> On 13.12.2019 21:59, William Tu wrote: > >>> Debugging netdev-afxdp is hard because tcpdump does not work > >>> at all, even for

[ovs-dev] [PATCH] ovs-thread: Avoid huge alignment on a base spinlock structure.

2019-12-16 Thread Ilya Maximets
Marking the structure as 64 bytes aligned forces compiler to produce big holes in the containing structures in order to fulfill this requirement. Also, any structure that contains this one as a member automatically inherits this huge alignment making resulted memory layout not efficient. For

[ovs-dev] [PATCH] Documentation: Fix ovs-tcpdump options.

2019-12-16 Thread William Tu
Signed-off-by: William Tu --- Documentation/ref/ovs-tcpdump.8.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/ref/ovs-tcpdump.8.rst b/Documentation/ref/ovs-tcpdump.8.rst index 048b70f23daf..b9f8cdf6f786 100644 --- a/Documentation/ref/ovs-tcpdump.8.rst +++

Re: [ovs-dev] [PATCH] netdev-afxdp: Add pcap dump support.

2019-12-16 Thread Ilya Maximets
On 16.12.2019 14:43, William Tu wrote: > On Mon, Dec 16, 2019 at 1:41 AM Ilya Maximets wrote: >> >> On 13.12.2019 21:59, William Tu wrote: >>> Debugging netdev-afxdp is hard because tcpdump does not work >>> at all, even for generic mode. ovs-tcpdump which uses port >>> mirroring also does not

Re: [ovs-dev] [PATCH] netdev-afxdp: Add pcap dump support.

2019-12-16 Thread William Tu
On Mon, Dec 16, 2019 at 1:41 AM Ilya Maximets wrote: > > On 13.12.2019 21:59, William Tu wrote: > > Debugging netdev-afxdp is hard because tcpdump does not work > > at all, even for generic mode. ovs-tcpdump which uses port > > mirroring also does not work for netdev-afxdp. > > Hmm. Why

Re: [ovs-dev] [PATCH v4 08/10] netdev-offload-tc: Add conntrack support

2019-12-16 Thread 0-day Robot
Bleep bloop. Greetings Paul Blakey, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: /bin/sh ./libtool --tag=CC --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I

Re: [ovs-dev] [PATCH v4 07/10] netdev-offload-tc: Add recirculation support via tc chains

2019-12-16 Thread 0-day Robot
Bleep bloop. Greetings Paul Blakey, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 92 characters long (recommended limit is 79) #46 FILE: lib/dpif-netlink.c:376:

[ovs-dev] Why did you authorized Mrs. Lyndia Paulson to receive your funds $4.800.000 us dollars from this office?,

2019-12-16 Thread Mrs. ALAN UDE, Official Director.Money Gram-Benin
MONEY GRAM. AROPORT INTL DE COTONOU COTONOU. Office of Mrs. ALAN UDE. Attn,Dear Funds beneficiary. I am Mrs. ALAN UDE., Official Director.Money Gram-Benin Confirm to us urgent, Why did you authorized Mrs. Lyndia Paulson to receive your funds $4.800.000 us dollars from this office?, I need your

[ovs-dev] [PATCH v4 00/10] Add support for offloading CT datapath rules to TC

2019-12-16 Thread Paul Blakey
The following patchset introduces hardware offload of OVS connection tracking datapath rules. OVS uses ct() and recirc() (recirculation) actions and recirc_id()/ct_state() matches to support connection tracking. The datapath rules are in the form of:

[ovs-dev] [PATCH v4 06/10] tc: Move tunnel_key unset action before output ports

2019-12-16 Thread Paul Blakey
Since OvS datapath gets packets already decapsulated from tunnel devices, it doesn't explicitly decapsulate them. So in a recirculation setup, the tunnel matching continues in the recirculation as the tunnel metadata still exists on the SKB. Tunnel key unset action unsets this metadata. Some

[ovs-dev] [PATCH v4 07/10] netdev-offload-tc: Add recirculation support via tc chains

2019-12-16 Thread Paul Blakey
Each recirculation id will create a tc chain, and we translate the recirculation action to a tc goto chain action. We check for kernel support for this by probing OvS Datapath for the tc recirc id sharing feature. If supported, we can offload rules that match on recirc_id, and recirculation

[ovs-dev] [PATCH v4 08/10] netdev-offload-tc: Add conntrack support

2019-12-16 Thread Paul Blakey
Zone and ct_state first. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/dpif-netlink.c | 2 + lib/netdev-offload-tc.c | 136 lib/tc.c| 122 +++ lib/tc.h|

[ovs-dev] [PATCH v4 02/10] compat: Add tc ct action and flower matches defines for older kernels

2019-12-16 Thread Paul Blakey
Update kernel UAPI to support conntrack matches, and the tc actions ct and goto chain. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- include/linux/automake.mk| 3 ++- include/linux/pkt_cls.h | 46 +--- include/linux/tc_act/tc_ct.h | 41

[ovs-dev] [PATCH v4 05/10] dpif: Add support to set user features

2019-12-16 Thread Paul Blakey
This enables user features on the kernel datapath via the DP_CMD_SET command, and also retrieves them to check for actual support and not just an older kernel ignoring the requested features. This will be used in next patch to enable recirc_id sharing with tc. Signed-off-by: Paul Blakey

[ovs-dev] [PATCH v4 10/10] netdev-offload-tc: Add conntrack nat support

2019-12-16 Thread Paul Blakey
Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- Changelog: V2->V3: Ipv6 nat dump fix (missing unspec type in policy) Renamed tc range struct to be consistent with NL ATTRIBUTES and ovs V1->V2: Missing ntohs/htons on nat port range. --- lib/netdev-offload-tc.c | 104

[ovs-dev] [PATCH v4 04/10] netdev-offload-tc: Implement netdev tc flush via tc filter del

2019-12-16 Thread Paul Blakey
To be consistent with our tc-ufid mapping after flush, and to support tc chains flushing in the next commit, implement flush operation via deleting all the filters we actually added and delete their mappings. This will also not delete the configured qos policing via matchall filters, while old

[ovs-dev] [PATCH v4 03/10] tc: Introduce tcf_id to specify a tc filter

2019-12-16 Thread Paul Blakey
Move all that is needed to identify a tc filter to a new structure, tcf_id. This removes a lot of duplication in accessing/creating tc filters. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- Changelog: V3->V4: Fix accidently removed Block_id in flow_put() V2->V3: Renamed

[ovs-dev] [PATCH v4 01/10] match: Add match_set_ct_zone_masked helper

2019-12-16 Thread Paul Blakey
Sets zone in match. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- include/openvswitch/match.h | 2 ++ lib/match.c | 10 -- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/include/openvswitch/match.h b/include/openvswitch/match.h index

[ovs-dev] [PATCH v4 09/10] netdev-offload-tc: Add conntrack label and mark support

2019-12-16 Thread Paul Blakey
Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- Changelog: V2->V3: Added missing match on ct_mark. --- lib/dpif-netlink.c | 2 ++ lib/netdev-offload-tc.c | 66 + lib/tc.c| 53

[ovs-dev] Reply

2019-12-16 Thread Barrister. Adolf Robert
Greetings Dear, I write to know if you receive my previous email? I wait to hear from you as a matter of urgency. Best Regards, Robert Adolf. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3 07/10] netdev-offload-tc: Add recirculation, support via tc chains

2019-12-16 Thread Ilya Maximets
On 15.12.2019 14:35, Paul Blakey wrote: > > On 12/13/2019 2:05 PM, Ilya Maximets wrote: >>> Hi sorry for late reply, didn't get this email. >>> >>> On 03.12.2019 16:16, Ilya Maximets wrote: >>> > From: Ilya Maximets >>> > On 03.12.2019 14:45, Roi Dayan wrote: >>> > > From: Paul Blakey >>>

Re: [ovs-dev] [PATCH] netdev-afxdp: Add pcap dump support.

2019-12-16 Thread Ilya Maximets
On 13.12.2019 21:59, William Tu wrote: > Debugging netdev-afxdp is hard because tcpdump does not work > at all, even for generic mode. ovs-tcpdump which uses port > mirroring also does not work for netdev-afxdp. Hmm. Why ovs-tcpdump doesn't work for you? It should not depend on port type. If

Re: [ovs-dev] [PATCH v17] Improved Packet Drop Statistics in OVS

2019-12-16 Thread Ilya Maximets
On 16.12.2019 05:07, Anju Thomas wrote: > Thanks for the review Ilya, > > For the below comment > > >> @@ -7086,10 +7105,16 @@ dp_execute_cb(void *aux_, struct dp_packet_batch >> *packets_, >> * the ownership of these packets. Thus, we can avoid performing >> * the

Re: [ovs-dev] [PATCH 15/20] netdev-offload-dpdk-flow: Support offload of output action

2019-12-16 Thread Sriharsha Basavapatna via dev
On Sun, Dec 8, 2019 at 3:08 PM Eli Britstein wrote: > > > On 12/5/2019 6:46 PM, Sriharsha Basavapatna wrote: > > On Wed, Dec 4, 2019 at 8:55 PM Eli Britstein wrote: > >> > >> On 12/3/2019 5:19 PM, Sriharsha Basavapatna wrote: > >>> On Wed, Nov 20, 2019 at 9:07 PM Eli Britstein wrote: >