Re: [ovs-dev] [PATCH V7 10/18] dpif-netdev: Update offloaded flows statistics

2020-01-14 Thread Eli Britstein
On 1/14/2020 11:53 PM, Ilya Maximets wrote: > On 09.01.2020 08:46, Eli Britstein wrote: >> From: Ophir Munk >> >> In case a flow is HW offloaded, packets do not reach the SW, thus not >> counted for statistics. Use netdev flow get API in order to update the >> statistics of flows by the HW

Re: [ovs-dev] [PATCH v1 ovn 0/1] Forwarding group to load balance l2 traffic with liveness detection

2020-01-14 Thread Manoj Sharma
Hi Numan, Please see my answers inline: On 1/13/20, 11:37 PM, "Numan Siddique" wrote: On Sat, Jan 11, 2020 at 6:31 AM Manoj Sharma wrote: > > Thank you for the review Numan. > > On 1/8/20, 11:14 PM, "Numan Siddique" wrote: > > Hi Manoj, > >

Re: [ovs-dev] [PATCH ovn v4 0/2] Add a way to delete QoS directly

2020-01-14 Thread Han Zhou
On Tue, Jan 14, 2020 at 1:11 AM taoyunxi...@cmss.chinamobile.com < taoyunxi...@cmss.chinamobile.com> wrote: > > Hi Han, >Thank you for your patience in answering my questions. I agree with your comments. >I am interested in "specifying uuid when creating a row is not yet

Re: [ovs-dev] [PATCH 2/3] ovn-controller.c: Move the position of handling OVN-SB related settings.

2020-01-14 Thread Han Zhou
On Tue, Jan 14, 2020 at 1:24 PM Mark Michelson wrote: > > The commit message doesn't make much sense to me. The external-ids are > set outside of ovn-controller, so the concept of them being handled in > "the same iteration" or "the next one" only works if ovn-controller is > setting them at some

Re: [ovs-dev] [PATCH 1/3] ovn-controller.c: Fix possible NULL pointer dereference.

2020-01-14 Thread Han Zhou
Hi Mark, Thanks for the review! In fact, if cfg was NULL, this function would never have a chance to set probe interval, because before setting the interval it would have already crashed, at this line: int interval = smap_get_int(>external_ids, So, the behavior change of this patch is only

Re: [ovs-dev] [PATCH v3 3/3] netdev-dpdk: Add TCP Segmentation Offload support

2020-01-14 Thread Flavio Leitner
On Tue, Jan 14, 2020 at 06:48:14PM +0100, Ilya Maximets wrote: > On 09.01.2020 15:44, Flavio Leitner wrote: > > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables > > the network stack to delegate the TCP segmentation to the NIC reducing > > the per packet CPU overhead. > > >

Re: [ovs-dev] [PATCH V7 10/18] dpif-netdev: Update offloaded flows statistics

2020-01-14 Thread Ilya Maximets
On 09.01.2020 08:46, Eli Britstein wrote: > From: Ophir Munk > > In case a flow is HW offloaded, packets do not reach the SW, thus not > counted for statistics. Use netdev flow get API in order to update the > statistics of flows by the HW statistics. > > Co-authored-by: Eli Britstein >

Re: [ovs-dev] [PATCH 1/3] ovn-controller.c: Fix possible NULL pointer dereference.

2020-01-14 Thread Mark Michelson
Hi Han. This patch introduces a small behavior change in the case where cfg is NULL. In the earlier version, we would always set the probe interval on the southbound database. With this version of the patch, we exit early when cfg is NULL and do not set the probe interval. On 1/13/20 5:52

Re: [ovs-dev] [PATCH 2/3] ovn-controller.c: Move the position of handling OVN-SB related settings.

2020-01-14 Thread Mark Michelson
The commit message doesn't make much sense to me. The external-ids are set outside of ovn-controller, so the concept of them being handled in "the same iteration" or "the next one" only works if ovn-controller is setting them at some point in the loop. Couldn't this have a negative effect on

[ovs-dev] WE NEED YOUR PRODUCTS

2020-01-14 Thread John Lewis & Partners
-- Dear Sir, We are Located in the united kingdom, the famous brand John Lewis PLC, is UK's largest multi-channel retailer with over 45 shops furnished with European products. We are looking for new products to attract new customers and also retain our existing ones, create new partnerships with

Re: [ovs-dev] [PATCH] netdev-offload-tc: Fix crash if offloading is not configured on outdev.

2020-01-14 Thread Ben Pfaff
On Tue, Jan 14, 2020 at 09:30:17PM +0100, Ilya Maximets wrote: > If output device is not yet added to netdev-offload, netdev_ports_get() > will not find it leading to NULL pointer dereference inside > netdev_get_inindex(). > > Fixes: 8f283af89298 ("netdev-tc-offloads: Implement netdev flow put

[ovs-dev] [PATCH] netdev-offload-tc: Fix crash if offloading is not configured on outdev.

2020-01-14 Thread Ilya Maximets
If output device is not yet added to netdev-offload, netdev_ports_get() will not find it leading to NULL pointer dereference inside netdev_get_inindex(). Fixes: 8f283af89298 ("netdev-tc-offloads: Implement netdev flow put using tc interface") Signed-off-by: Ilya Maximets ---

[ovs-dev] To A Good Friend

2020-01-14 Thread sambo.salifou2
Please lets make joint business I am, Dr. Salifou Sambo a bank auditor, I am in-charge of transferring out funds or my village, which our village generates from the sales of our local mined gold. I have some left over fund in the bank here that I alone is aware of, and want to transfer it out. My

Re: [ovs-dev] [v2] dpif-netdev: Modified ovs-appctl dpctl/dump-flows command

2020-01-14 Thread Ilya Maximets
On 14.01.2020 16:41, Emma Finn wrote: > Modified ovs-appctl dpctl/dump-flows command to output > the miniflow bits for a given flow when -m option is passed. > > $ ovs-appctl dpctl/dump-flows -m > > Signed-off-by: Emma Finn > > --- > > RFC -> v1 > > * Changed revision from RFC to v1 > *

Re: [ovs-dev] [PATCH v2] ovsdb-server: Allow OVSDB clients to specify the UUID for inserted rows.

2020-01-14 Thread Ben Pfaff
I don't understand that claim. Which name column do you think we can delete, from which schema? On Fri, Jan 10, 2020 at 05:14:44PM +0800, taoyunupt wrote: > Hi Ben, >It will be appreciated,if you give more explanation for the resaon > to summit this patch. In my opinion, it makes

Re: [ovs-dev] [PATCH] socket-util: Emulate recvmmsg() and sendmmsg() on Linux only.

2020-01-14 Thread Ben Pfaff
On Tue, Jan 14, 2020 at 07:09:36PM +0100, Ilya Maximets wrote: > On 13.01.2020 19:03, Ben Pfaff wrote: > > These functions failed to build on OS X because MSG_WAITFORONE is not > > defined there. There are pitfalls for trying to define our own MSG_* > > constants, since it's hard to pick a

Re: [ovs-dev] [PATCH] socket-util: Emulate recvmmsg() and sendmmsg() on Linux only.

2020-01-14 Thread Ilya Maximets
On 13.01.2020 19:03, Ben Pfaff wrote: > These functions failed to build on OS X because MSG_WAITFORONE is not > defined there. There are pitfalls for trying to define our own MSG_* > constants, since it's hard to pick a constant that is not used by the > system already. Because OVS only uses

Re: [ovs-dev] [PATCH v3 3/3] netdev-dpdk: Add TCP Segmentation Offload support

2020-01-14 Thread Ilya Maximets
On 09.01.2020 15:44, Flavio Leitner wrote: > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables > the network stack to delegate the TCP segmentation to the NIC reducing > the per packet CPU overhead. > > A guest using vhostuser interface with TSO enabled can send TCP packets

Re: [ovs-dev] [PATCH v4 2/2] netdev-dpdk: Add new DPDK RFC 4115 egress policer

2020-01-14 Thread Stokes, Ian
On 1/14/2020 4:21 PM, Eelco Chaudron wrote: On 14 Jan 2020, at 16:21, Stokes, Ian wrote: On 1/14/2020 2:13 PM, Eelco Chaudron wrote: On 14 Jan 2020, at 12:23, Stokes, Ian wrote: On 1/13/2020 8:32 PM, Stokes, Ian wrote: Hi Eelco, I'm seeing a crash in OVS while running this with

Re: [ovs-dev] [PATCH v4 2/2] netdev-dpdk: Add new DPDK RFC 4115 egress policer

2020-01-14 Thread Eelco Chaudron
On 14 Jan 2020, at 16:21, Stokes, Ian wrote: On 1/14/2020 2:13 PM, Eelco Chaudron wrote: On 14 Jan 2020, at 12:23, Stokes, Ian wrote: On 1/13/2020 8:32 PM, Stokes, Ian wrote: Hi Eelco, I'm seeing a crash in OVS while running this with just a port and a default queue 0 (phy to phy

Re: [ovs-dev] [PATCH v3 3/3] netdev-dpdk: Add TCP Segmentation Offload support

2020-01-14 Thread Flavio Leitner
On Tue, Jan 14, 2020 at 03:41:57PM +, Stokes, Ian wrote: > > > On 1/9/2020 2:44 PM, Flavio Leitner wrote: > > Abbreviated as TSO, TCP Segmentation Offload is a feature which enables > > the network stack to delegate the TCP segmentation to the NIC reducing > > the per packet CPU overhead. >

[ovs-dev] [PATCH v5 1/2] netdev-dpdk: Add support for multi-queue QoS to the DPDK datapath

2020-01-14 Thread Eelco Chaudron
This patch adds support for multi-queue QoS to the DPDK datapath. Most of the code is based on an earlier patch from a patchset sent out by zhaozhanxu. The patch was titled "[ovs-dev, v2, 1/4] netdev-dpdk.c: Support the multi-queue QoS configuration for dpdk datapath" Co-authored-by: zhaozhanxu

[ovs-dev] [PATCH v5 0/2] netdev-dpdk: Add new DPDK RFC 4115 egress policer

2020-01-14 Thread Eelco Chaudron
netdev-dpdk: Add new DPDK RFC 4115 egress policer This patch adds a new policer to the DPDK datapath based on RFC 4115's Two-Rate, Three-Color marker. It's a two-level hierarchical policer which first does a color-blind marking of the traffic at the queue level, followed by a color-aware marking

[ovs-dev] [PATCH v5 2/2] netdev-dpdk: Add new DPDK RFC 4115 egress policer

2020-01-14 Thread Eelco Chaudron
This patch adds a new policer to the DPDK datapath based on RFC 4115's Two-Rate, Three-Color marker. It's a two-level hierarchical policer which first does a color-blind marking of the traffic at the queue level, followed by a color-aware marking at the port level. At the end traffic marked as

Re: [ovs-dev] [PATCH v4 2/2] netdev-dpdk: Add new DPDK RFC 4115 egress policer

2020-01-14 Thread Eelco Chaudron
On 14 Jan 2020, at 12:57, Neil Horman wrote: On Tue, Jan 14, 2020 at 09:35:33AM +0100, David Marchand wrote: Hey Eelco, On Mon, Jan 13, 2020 at 4:57 PM Eelco Chaudron wrote: [snip] diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 128963f..3f164c8 100644 --- a/lib/netdev-dpdk.c

Re: [ovs-dev] [PATCH v3 3/3] netdev-dpdk: Add TCP Segmentation Offload support

2020-01-14 Thread Stokes, Ian
On 1/9/2020 2:44 PM, Flavio Leitner wrote: Abbreviated as TSO, TCP Segmentation Offload is a feature which enables the network stack to delegate the TCP segmentation to the NIC reducing the per packet CPU overhead. A guest using vhostuser interface with TSO enabled can send TCP packets much

[ovs-dev] [v2] dpif-netdev: Modified ovs-appctl dpctl/dump-flows command

2020-01-14 Thread Emma Finn
Modified ovs-appctl dpctl/dump-flows command to output the miniflow bits for a given flow when -m option is passed. $ ovs-appctl dpctl/dump-flows -m Signed-off-by: Emma Finn --- RFC -> v1 * Changed revision from RFC to v1 * Reformatted based on comments * Fixed same classifier being dumped

Re: [ovs-dev] [PATCH v4 2/2] netdev-dpdk: Add new DPDK RFC 4115 egress policer

2020-01-14 Thread Stokes, Ian
On 1/14/2020 2:13 PM, Eelco Chaudron wrote: On 14 Jan 2020, at 12:23, Stokes, Ian wrote: On 1/13/2020 8:32 PM, Stokes, Ian wrote: Hi Eelco, I'm seeing a crash in OVS while running this with just a port and a default queue 0 (phy to phy setup). It seems related to the call to

Re: [ovs-dev] [PATCH v4 2/2] netdev-dpdk: Add new DPDK RFC 4115 egress policer

2020-01-14 Thread Eelco Chaudron
On 14 Jan 2020, at 12:23, Stokes, Ian wrote: On 1/13/2020 8:32 PM, Stokes, Ian wrote: Hi Eelco, I'm seeing a crash in OVS while running this with just a port and a default queue 0 (phy to phy setup). It seems related to the call to rte_meter_trtcm_rfc4115_color_blind_check. I've

[ovs-dev] [PATCH 1/1] flow: Fix parsing l3_ofs with partial offloading

2020-01-14 Thread Eli Britstein
l3_ofs should be set all Ethernet packets, not just IPv4/IPv6 ones. For example for ARP over VLAN tagged packets, it may cause wrong processing like in changing the VLAN ID action. Fix it. Fixes: aab96ec4d81e ("dpif-netdev: retrieve flow directly from the flow mark") Signed-off-by: Eli Britstein

Re: [ovs-dev] [PATCH v4 2/2] netdev-dpdk: Add new DPDK RFC 4115 egress policer

2020-01-14 Thread Neil Horman
On Tue, Jan 14, 2020 at 09:35:33AM +0100, David Marchand wrote: > Hey Eelco, > > On Mon, Jan 13, 2020 at 4:57 PM Eelco Chaudron wrote: > [snip] > > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > > index 128963f..3f164c8 100644 > > --- a/lib/netdev-dpdk.c > > +++ b/lib/netdev-dpdk.c > > @@

Re: [ovs-dev] [PATCH v4 2/2] netdev-dpdk: Add new DPDK RFC 4115 egress policer

2020-01-14 Thread Eelco Chaudron
On 14 Jan 2020, at 12:23, Stokes, Ian wrote: On 1/13/2020 8:32 PM, Stokes, Ian wrote: On 1/13/2020 3:56 PM, Eelco Chaudron wrote: This patch adds a new policer to the DPDK datapath based on RFC 4115's Two-Rate, Three-Color marker. It's a two-level hierarchical policer which first does a

Re: [ovs-dev] [PATCH v4 2/2] netdev-dpdk: Add new DPDK RFC 4115 egress policer

2020-01-14 Thread Stokes, Ian
On 1/13/2020 8:32 PM, Stokes, Ian wrote: On 1/13/2020 3:56 PM, Eelco Chaudron wrote: This patch adds a new policer to the DPDK datapath based on RFC 4115's Two-Rate, Three-Color marker. It's a two-level hierarchical policer which first does a color-blind marking of the traffic at the queue

[ovs-dev] [PATCH v6 ovn 1/2] controller: add ipv6 prefix delegation state machine

2020-01-14 Thread Lorenzo Bianconi
Introduce IPv6 Prefix delegation state machine according to RFC 3633 https://tools.ietf.org/html/rfc3633. Add handle_dhcpv6_reply controller action to parse advertise/reply from IPv6 delegation server. Advertise/reply are parsed running respectively: - pinctrl_parse_dhcv6_advt -

[ovs-dev] [PATCH v6 ovn 2/2] northd: add logical flows for dhcpv6 pfd parsing

2020-01-14 Thread Lorenzo Bianconi
Introduce logical flows in ovn router pipeline in order to parse dhcpv6 advertise/reply from IPv6 prefix delegation router. Do not overwrite ipv6_ra_pd_list info in options column of SB port_binding table written by ovn-controller Introduce ipv6_prefix column in NB Logical_router_port table to

[ovs-dev] [PATCH v6 ovn 0/2] Add IPv6 Prefix delegation (RFC3633)

2020-01-14 Thread Lorenzo Bianconi
Introduce IPv6 Prefix delegation state machine according to RFC 3633 https://tools.ietf.org/html/rfc3633. Add handle_dhcpv6_reply controller action to parse advertise/reply from IPv6 delegation server. Introduce logical flows in ovn router pipeline in order to parse dhcpv6 advertise/reply from

Re: [ovs-dev] [PATCH] tc: handle packet mark of zero

2020-01-14 Thread Simon Horman
On Mon, Jan 13, 2020 at 06:50:50PM +0800, Tonghao Zhang wrote: > On Mon, Jan 13, 2020 at 6:03 PM Simon Horman > wrote: > > > > Hi, > > > > On Mon, Jan 13, 2020 at 05:28:04PM +0800, Tonghao Zhang wrote: > > > On Fri, Jan 10, 2020 at 7:06 PM Simon Horman > > > wrote: > > > > > > > > From: John

Re: [ovs-dev] [PATCH ovn v4 0/2] Add a way to delete QoS directly

2020-01-14 Thread taoyunxi...@cmss.chinamobile.com
Hi Han, Thank you for your patience in answering my questions. I agree with your comments. I am interested in "specifying uuid when creating a row is not yet supported by the ctl tools", I will try to summit patch to support it . Do you have some sugesstion?

Re: [ovs-dev] [PATCH] Documentation: add notes for TSO & i40e

2020-01-14 Thread Loftus, Ciara
> -Original Message- > From: David Marchand > Sent: Monday 13 January 2020 15:58 > To: Loftus, Ciara > Cc: ovs dev ; Flavio Leitner ; > Stokes, Ian > Subject: Re: [ovs-dev] [PATCH] Documentation: add notes for TSO & i40e > > On Mon, Jan 13, 2020 at 4:49 PM Ciara Loftus wrote: > > >

Re: [ovs-dev] [PATCH v4 2/2] netdev-dpdk: Add new DPDK RFC 4115 egress policer

2020-01-14 Thread David Marchand
Hey Eelco, On Mon, Jan 13, 2020 at 4:57 PM Eelco Chaudron wrote: [snip] > diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c > index 128963f..3f164c8 100644 > --- a/lib/netdev-dpdk.c > +++ b/lib/netdev-dpdk.c > @@ -26,7 +26,10 @@ > #include > #include > > +/* The below is needed as

Re: [ovs-dev] [PATCH] ofproto: Add support to watch controller port liveness in fast-failover group

2020-01-14 Thread Vishal Deep Ajmera via dev
> > Thanks for the new feature. > > Please add an item to NEWS. > > OVS is currently in "soft freeze" for the next release. We should fork > for the next release at the end of the week. Therefore, please resubmit > your patch next week. Thanks Ben. Sure I will post new patch after fork is