Re: [ovs-dev] [ovn] stableids

2020-02-07 Thread Ben Pfaff
Yes, that's the branch I meant (I'm starting from it as a place to get the ddlog code up to speed with OVN master). That makes sense. Thanks. On Fri, Feb 07, 2020 at 04:01:04PM -0800, Justin Pettit wrote: > I think this is in the ddlog-dev-v2 branch, not master, correct? That branch > was a

Re: [ovs-dev] [ovn] stableids

2020-02-07 Thread Justin Pettit
I think this is in the ddlog-dev-v2 branch, not master, correct? That branch was a working directory for me, and I probably just pulled those patches in the wrong order. Does that make sense? --Justin > On Feb 7, 2020, at 2:58 PM, Ben Pfaff wrote: > > Hi Justin. > > In the OVN repo,

[ovs-dev] [PATCH] conntrack: Fix TCP conntrack state

2020-02-07 Thread Yi-Hung Wei
If a TCP connection is in SYN_SENT state, receiving another SYN packet would just renew the timeout of that conntrack entry rather than create a new one. Thus, tcp_conn_update() should return CT_UPDATE_VALID_NEW. This also fixes regressions of a couple of OVN system tests. Fixes: a867c010ee91

[ovs-dev] [ovn] stableids

2020-02-07 Thread Ben Pfaff
Hi Justin. In the OVN repo, commit 00523aa8e970 ("tests: Add function to handle ddlog's id allocation.") adds a stableid utility and uses it in ovn.at. A few commits later, commit 15e5a8b00cdf ("ovn.at: Break "ovn.at" into "ovn-components.at" and "ovn-e2e.at".") stops using it and also drops a

Re: [ovs-dev] [PATCH] Datapath: Change in openvswitch kernel module to support MPLS label depth of 3 in ingress direction.

2020-02-07 Thread Ben Pfaff
Done. On Fri, Feb 07, 2020 at 10:02:06PM +0530, Martin Varghese wrote: > Thanks Ben, > Please keep martin.vargh...@nokia.com > > On Fri, Feb 7, 2020 at 9:33 PM Ben Pfaff wrote: > > > Of course. > > > > I see a couple of email addresses for you. Which one is best for the > > authors file? > >

[ovs-dev] [PATCH v3 2/2] ovs-numa: Dpdk options with non-consecutive nodes.

2020-02-07 Thread David Wilder
If not supplied by the user --socket-mem and --socket-limit EAL options are set to a default value based system topology. The assumption that numa nodes must be numbered consecutive is removed by this change. These options can be seen in the ovs-vswitchd.log. For example: a system containing

[ovs-dev] [PATCH v3 0/2] Support for non-consecutive numa nodes and core ids.

2020-02-07 Thread David Wilder
Ovs-numa currently makes the assumption that numa node ids and cpu core ids will be numbered consecutively. Current Power systems don't always follow this model. Furthermore, cpus on Power may be on/off lined based the setting of Simultaneous multithreading (SMT). The result can be gaps in the

[ovs-dev] [PATCH v3 1/2] ovs-numa: Non-consecutively numa nodes and cores

2020-02-07 Thread David Wilder
This change removes the assumption that numa nodes and cores are numbered consecutively in linux. This change is required to support some Power systems. An additional check has been added to verify that cores are online, offline cores result in non-consecutively numbered cores. I manually

Re: [ovs-dev] Question Regarding ovs_packet_cmd_execute in Kernel Datapath

2020-02-07 Thread Dincer Beken
Hello, Further looking at the code, when upcall_xlate is performed, we create a hardcoded status block to represent the first packet: stats.n_packets = 1; stats.n_bytes = dp_packet_size(upcall->packet); stats.used = time_msec(); stats.tcp_flags = ntohs(upcall->flow->tcp_flags);

Re: [ovs-dev] [PATCH] Datapath: Change in openvswitch kernel module to support MPLS label depth of 3 in ingress direction.

2020-02-07 Thread Martin Varghese
Thanks Ben, Please keep martin.vargh...@nokia.com On Fri, Feb 7, 2020 at 9:33 PM Ben Pfaff wrote: > Of course. > > I see a couple of email addresses for you. Which one is best for the > authors file? > > On Fri, Feb 07, 2020 at 04:47:42PM +0530, Martin Varghese wrote: > > HI > > I checked the

Re: [ovs-dev] [PATCH v2] Use TPACKET_V3 to accelerate veth for userspace datapath

2020-02-07 Thread Ilya Maximets
On 2/7/20 12:50 PM, yang_y...@126.com wrote: > From: Yi Yang > > We can avoid high system call overhead by using TPACKET_V3 > and using DPDK-like poll to receive and send packets (Note: send > still needs to call sendto to trigger final packet transmission). > >>From Linux kernel 3.10 on,

Re: [ovs-dev] [PATCH] dp-packet: prefetch the next packet when cloning a batch.

2020-02-07 Thread 0-day Robot
Bleep bloop. Greetings Flavio Leitner, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #27 FILE: lib/dp-packet.h:1052:

[ovs-dev] [PATCH] dp-packet: prefetch the next packet when cloning a batch.

2020-02-07 Thread Flavio Leitner
There is a cache miss when accessing mbuf->data_off while cloning a batch and using prefetch improved the throughput by ~2.3%. Before: 13709416.30 pps After: 14031475.80 pps Fixes: d48771848560 ("dp-packet: preserve headroom when cloning a pkt batch") Signed-off-by: Flavio Leitner ---

[ovs-dev] [PATCH v2] Use TPACKET_V3 to accelerate veth for userspace datapath

2020-02-07 Thread yang_y_yi
From: Yi Yang We can avoid high system call overhead by using TPACKET_V3 and using DPDK-like poll to receive and send packets (Note: send still needs to call sendto to trigger final packet transmission). >From Linux kernel 3.10 on, TPACKET_V3 has been supported, so all the Linux kernels current

Re: [ovs-dev] [PATCH] Datapath: Change in openvswitch kernel module to support MPLS label depth of 3 in ingress direction.

2020-02-07 Thread Martin Varghese
HI I checked the Authors file today and coudn't find my name. I would like to see my name there :) if i meet the criteria Thanks, Martin On Fri, Nov 22, 2019 at 10:57 PM Ben Pfaff wrote: > On Fri, Nov 22, 2019 at 08:32:53AM -0800, Gregory Rose wrote: > > On 11/21/2019 10:07 PM, Martin Varghese

Re: [ovs-dev] [PATCH] netdev-dpdk: Don't enable offloading on HW device if not requested.

2020-02-07 Thread Ilya Maximets
On 2/6/20 2:35 PM, Ilya Maximets wrote: > DPDK drivers has different implementations of transmit functions. > Enabled offloading may cause driver to choose slower variant > significantly affecting performance if userspace TSO wasn't requested. > > Fixes: 29cf9c1b3b9c ("userspace: Add TCP

Re: [ovs-dev] Question Regarding ovs_packet_cmd_execute in Kernel Datapath

2020-02-07 Thread Dincer Beken
Just repeating last mail with fixed indentations (mail was in wrong format): Hello Ben, Pravin, Thank you for your consideration. >> It is also simpler to fix the stats issue using this approach. >There's no stats issue.  Userspace just counts the number of packets it >sent and adds them

Re: [ovs-dev] Question Regarding ovs_packet_cmd_execute in Kernel Datapath

2020-02-07 Thread Dincer Beken
Hello Ben, Pravin, Thank you for your consideration. > It is also simpler to fix the stats issue using this approach. There's no stats issue. Userspace just counts the number of packets it sent and adds them in. Regarding the stats issue. In case of LTE Broadcast, I have tight synchronization

[ovs-dev] [PATCH 3/3] Add file descriptor persistence

2020-02-07 Thread anton . ivanov
From: Anton Ivanov 1. Provides signigificant performance improvement in large OVSDB installs such as southdb in OVN by removing the current "feature" of "trying to break an EAGAIN wall" in all streams. All streams will attempt IO IF AND ONLY IF there is IO pending. If there is no IO signalled by

[ovs-dev] [PATCH 2/3] Run JSON RPC if there is backlog

2020-02-07 Thread anton . ivanov
From: Anton Ivanov Run JSON RPC every time there is a backlog and not only if backlog was created on this iteration. Signed-off-by: Anton Ivanov --- lib/jsonrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/jsonrpc.c b/lib/jsonrpc.c index ed748dbde..fc354e517

[ovs-dev] [PATCH 1/3] Replace direct use of POLLXXX macros with OVS_POLLXXX

2020-02-07 Thread anton . ivanov
From: Anton Ivanov In order to allow switching between poll and epoll we need to switch from the direct use of POLLXXX macros to OVS_POLLXXX which can be either POLLXXX or EPOLLXXX depending on the actual backend. Signed-off-by: Anton Ivanov --- include/openvswitch/poll-loop.h | 6 ++