William. here I don't use my patch, I just showed you tap is ok, veth is not
ok, by capturing packets, I'm very sure the packets are truncated, veth's
packets are different from tap's, during big packets, all the packet sizes are
about 64K, but not such pattern, 1514 followed a big packet, so I
On Wed, Feb 26, 2020 at 9:42 AM Greg Rose wrote:
>
> Since this commit in the Linux upstream kernel:
> 'commit 9b9a3f20cbe0 ("kbuild: split final module linking out into
> Makefile.modfinal")'
> The openvswitch kernel module fails to build against the upstream
> Linux kernel. The cause of the
On Wed, Feb 26, 2020 at 9:42 AM Greg Rose wrote:
>
> Changes for in kernel generated netlink attribute parsing functions
> require our out of tree driver to use the deprecated forms of those
> functions. Otherwise the message parsing will return -EINVAL because
> NLA_F_NESTED is not set in the
On Wed, Feb 26, 2020 at 9:42 AM Greg Rose wrote:
>
> The FIELD_SIZEOF macro is removed in Linux kernel release 5.5 but
> is still needed in our out of tree kernel module for compatibility
> with older kernels.
>
> Signed-off-by: Greg Rose
> ---
> datapath/linux/compat/include/linux/kernel.h | 4
On Wed, Feb 26, 2020 at 9:41 AM Greg Rose wrote:
>
> Flex array support is removed since kernel 5.1. Convert to use
> kvmalloc_array instead.
>
> Signed-off-by: Greg Rose
> ---
Thanks for the patch. Looks good to me.
Acked-by: Yi-Hung Wei
___
dev
On Wed, Feb 26, 2020 at 9:41 AM Greg Rose wrote:
>
> The policy field of the genl_ops structure has been removed in recent
> kernels.
>
> Signed-off-by: Greg Rose
> ---
> acinclude.m4 | 3 +++
> datapath/conntrack.c | 8
> datapath/datapath.c | 32
On Wed, Feb 26, 2020 at 9:41 AM Greg Rose wrote:
>
> Since Linux kernel release 5.1 the fragments field of the inet_frag_queue
> structure is removed and now only the rb_fragments structure with an
> rb_node pointer is used for both ipv4 and ipv6. In addition, the
> atomic_sub and atomic_add
Thanks for submitting your final patches here. I think with all our
efforts, we've got everything in, with a couple of exceptions. I've
acked the following two patches:
https://patchwork.ozlabs.org/patch/1245917/
https://patchwork.ozlabs.org/patch/1244375/
However, I didn't feel comfortable
*sigh*
Acked-by: Mark Michelson
:(
On 2/25/20 10:50 AM, num...@ovn.org wrote:
From: Numan Siddique
This patch reverts the below patches which added lflow expr caching
supported and follow up patches which fixed few issues.
With the present lflow expr caching we still have issues with
I've merged the change to master and branch-20.03.
On 2/27/20 2:37 PM, Numan Siddique wrote:
On Thu, Feb 27, 2020 at 4:04 PM Lorenzo Bianconi
wrote:
ovn-controller is currently running as non-root so it is not allowed to
configure system networking breaking ovn QoS support. Fix the issue
Hi Damijan,
Thanks for finding the memory leak and patching it. To me,
ovnfield_by_name is a really strangely handled structure. There is an
explicit function to destroy the ovnfield_by_name structure, but its
creation is a side effect from ovn_symtab_init. The result is that
lflow.c calls
The patch adds a new netdev class 'afxdp-nonpmd' to enable afxdp
interrupt mode. This is similar to 'type=afxdp', except that the
is_pmd field is set to false. As a result, the packet processing
is handled by main thread, not pmd thread. This avoids burning
the CPU to always 100% when there is no
Acked-by: Mark Michelson
On 2/27/20 10:54 AM, Dumitru Ceara wrote:
It can happen that all ports on which IGMP/MLD join reports were
received for a multicast group are already configured to flood multicast
traffic. In such cases we can safely skip the IGMP_Group record
completely. Otherwise we
On Thu, Feb 27, 2020 at 11:10 AM William Tu wrote:
>
> On Thu, Feb 27, 2020 at 9:54 AM Ilya Maximets wrote:
> >
> > On 2/27/20 6:51 PM, William Tu wrote:
> > > On Thu, Feb 27, 2020 at 9:42 AM Ilya Maximets wrote:
> > >>
> > >> On 2/27/20 6:30 PM, William Tu wrote:
> > >>> The patch adds a new
On Tue, Feb 25, 2020 at 3:03 PM Numan Siddique wrote:
>
> On Tue, Feb 25, 2020 at 5:09 AM Ben Pfaff wrote:
> >
> > The series that introduced redirect-type first used "vlan" as the
> > name for the feature, then changed to "bridged" without updating all
> > the comments and the documentation.
On Tue, Feb 25, 2020 at 3:02 PM Numan Siddique wrote:
>
> On Tue, Feb 25, 2020 at 2:43 PM Dumitru Ceara wrote:
> >
> > On 2/25/20 12:39 AM, Ben Pfaff wrote:
> > > The call to packet_set_ipv6() calls into packet_rh_present(), which in
> > > turn iterates through the L3 content. Without this
On Thu, Feb 27, 2020 at 4:04 PM Lorenzo Bianconi
wrote:
>
> ovn-controller is currently running as non-root so it is not allowed to
> configure system networking breaking ovn QoS support. Fix the issue
> granting CAP_NET_ADMIN capability to ovn-controller process
>
> Tested-by: Ying Xu
>
On Thu, Feb 27, 2020 at 9:54 AM Ilya Maximets wrote:
>
> On 2/27/20 6:51 PM, William Tu wrote:
> > On Thu, Feb 27, 2020 at 9:42 AM Ilya Maximets wrote:
> >>
> >> On 2/27/20 6:30 PM, William Tu wrote:
> >>> The patch adds a new netdev class 'afxdp-nonpmd' to enable afxdp
> >>> interrupt mode.
On 2/27/20 6:51 PM, William Tu wrote:
> On Thu, Feb 27, 2020 at 9:42 AM Ilya Maximets wrote:
>>
>> On 2/27/20 6:30 PM, William Tu wrote:
>>> The patch adds a new netdev class 'afxdp-nonpmd' to enable afxdp
>>> interrupt mode. This is similar to 'type=afxdp', except that the
>>> is_pmd field is
On Thu, Feb 27, 2020 at 9:42 AM Ilya Maximets wrote:
>
> On 2/27/20 6:30 PM, William Tu wrote:
> > The patch adds a new netdev class 'afxdp-nonpmd' to enable afxdp
> > interrupt mode. This is similar to 'type=afxdp', except that the
> > is_pmd field is set to false. As a result, the packet
OVN currently performs L2 address resolution and IP buffering on the
gw node. If the system relies on FIPs, OVN will re-inject the buffered
IP packets on the gw node, while following packets will go though
the localnet port on the compute node resulting in a ToR switch
misconfiguration. This patch
On 2/27/20 6:30 PM, William Tu wrote:
> The patch adds a new netdev class 'afxdp-nonpmd' to enable afxdp
> interrupt mode. This is similar to 'type=afxdp', except that the
> is_pmd field is set to false. As a result, the packet processing
> is handled by main thread, not pmd thread. This avoids
The patch adds a new netdev class 'afxdp-nonpmd' to enable afxdp
interrupt mode. This is similar to 'type=afxdp', except that the
is_pmd field is set to false. As a result, the packet processing
is handled by main thread, not pmd thread. This avoids burning
the CPU to always 100% when there is no
Hi Ilya,
V3 has been updated based on your comments. Thanks.
Best Regards,
Wei Yanqin
> -Original Message-
> From: Ilya Maximets
> Sent: Wednesday, February 26, 2020 9:41 PM
> To: Yanqin Wei ; d...@openvswitch.org
> Cc: nd ; Lijian Zhang ; Gavin Hu
> ; i.maxim...@ovn.org
> Subject: Re:
Read/write concurrency of pvector library is implemented by a temp vector
and RCU protection. Considering performance reason, insertion does not
follow this scheme.
In insertion function, a thread fence ensures size incrementation is done
after new entry is stored. But there is no barrier in the
On 2/27/20 4:27 PM, Mark Michelson wrote:
> Acked-by: Mark Michelson
>
Thanks Mark! I had however to send a v2 to fix an additional bug in the
same function:
https://patchwork.ozlabs.org/patch/1245917/
> Should this be backported to branch-20.03 as well?
Yes, if possible.
Thanks,
Dumitru
>
Estimado
cliente, d...@openvswitch.org
Se
adjunta su factura electrónica para elmes de marzo.
Factura
10.03.2020(652KB).PDF
It can happen that all ports on which IGMP/MLD join reports were
received for a multicast group are already configured to flood multicast
traffic. In such cases we can safely skip the IGMP_Group record
completely. Otherwise we risk trying to install an entry in the
Southbound DB Multicast_Group
ping
On 2/18/2020 3:49 PM, Eli Britstein wrote:
Follow up to commit eb540c0f5fc8 ("flow: Fix parsing l3_ofs with partial
offloading") that fixed the issue, add a unit-test for it.
Signed-off-by: Eli Britstein
Reviewed-by: Roi Dayan
---
tests/dpif-netdev.at | 77
On 2/27/20 4:25 PM, Eli Britstein wrote:
> ping
>
> On 2/18/2020 3:49 PM, Eli Britstein wrote:
>> Follow up to commit eb540c0f5fc8 ("flow: Fix parsing l3_ofs with partial
>> offloading") that fixed the issue, add a unit-test for it.
>>
>> Signed-off-by: Eli Britstein
>> Reviewed-by: Roi Dayan
On 2/26/20 10:18 PM, William Tu wrote:
> On Mon, Feb 24, 2020 at 5:31 PM William Tu wrote:
>>
>> On Mon, Feb 24, 2020 at 2:47 AM Ilya Maximets wrote:
>>>
>>> On 2/21/20 9:24 PM, William Tu wrote:
The patch adds a new option 'use-intr' to enable afxdp interrupt
mode. At receive path,
On Tue, Feb 25, 2020 at 5:41 PM Yi Yang (杨燚)-云服务集团 wrote:
>
> In the same environment, but I used tap but not veth, retr number is 0 for
> the case without this patch (of course, I applied Flavio's tap enable patch)
>
Right, because tap does not use the tpacket_v3 mmap packet, so it works fine.
Acked-by: Mark Michelson
Should this be backported to branch-20.03 as well?
On 2/27/20 9:57 AM, Dumitru Ceara wrote:
It can happen that all ports on which IGMP/MLD join reports were
received for a multicast group are already configured to flood multicast
traffic. In such cases we can safely
From: Dmytro Linkin
OVS can fail to attach ingress block on iface when init tc flow api,
if block already exist with rules on it and is shared with other iface.
Fix by flush all existing rules on the ingress block prior to deleting
it.
Fixes: 093c9458fb02 ("tc: allow offloading of block ids")
It can happen that all ports on which IGMP/MLD join reports were
received for a multicast group are already configured to flood multicast
traffic. In such cases we can safely skip the IGMP_Group record
completely. Otherwise we risk trying to install an entry in the
Southbound DB Multicast_Group
ovnfield_by_name is hash of strings which is used to quickly find
field by name. This hash is initialized from ovn_init_symtab(). In case
the latter function is called multiple times then also ovnfield_by_name is
initialized multiple times but without freeing previously allocated
memory resources
There is a pattern among CMSes to create a `localnet` port
binding without any chassis affiliation.
It is then up to the user to configure chassis with external
connectivity by adding a mapping under the
`external_ids:ovn-bridge-mappings` key in the Open_vSwitch
table of the local OVS instance.
Bleep bloop. Greetings Frode Nordahl, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Author Frode Nordahl needs to sign off.
Lines checked: 53, Warnings: 0, Errors: 1
There is a pattern among CMSes to create a `localnet` port
binding without any chassis affiliation.
It is then up to the user to configure chassis with external
connectivity by adding a mapping under the
`external_ids:ovn-bridge-mappings` key in the Open_vSwitch
table of the local OVS instance.
On 2/20/20 8:54 PM, Mark Michelson wrote:
> Hi everyone,
>
> We've had the OVN 20.03 branch created for a couple of weeks now, and
> we've seen some important issues found and fixed since then. Great job!
>
> As the branch becomes more stable, we look at the possibility of
> creating the 20.03.0
ovn-controller is currently running as non-root so it is not allowed to
configure system networking breaking ovn QoS support. Fix the issue
granting CAP_NET_ADMIN capability to ovn-controller process
Tested-by: Ying Xu
Signed-off-by: Lorenzo Bianconi
---
controller/ovn-controller.c | 2 +-
1
Skip IGMP entries learned for local multicast groups when generating
logical flows. We still allow ovn-controller to learn them as
it might be useful information for administrators to see that hosts
register for the groups even though they are not expected to send JOIN
messages for this range.
On 2/26/2020 2:31 PM, Ilya Maximets wrote:
On 2/26/20 1:05 PM, Eli Britstein wrote:
On 2/24/2020 1:06 PM, Ilya Maximets wrote:
On 2/23/20 3:32 PM, Eli Britstein wrote:
On 2/21/2020 4:54 PM, Ilya Maximets wrote:
If the offloading queue is big and filled continuously, offloading
thread may
--
Attn:
I do have the authorization of a wealthy client who has an interest in
investing in your country into a Joint Venture / Partnership. He has funds
available meant for investment. We would be delighted to work with you.
Kindly let me know so we can discuss further.
Best Regards,
Harry
On 2/27/20 8:52 AM, Numan Siddique wrote:
> On Thu, Feb 27, 2020 at 2:24 AM Mark Michelson wrote:
>>
>> Acked-by: Mark Michelson
>
> Thanks Dumitru and Mark.
>
> I applied this patch to master and branch-20.03
>
> Thanks
> Numan
>
Thanks Mark and Numan!
45 matches
Mail list logo
