Re: [ovs-dev] [PATCH] datapath-windows: Update flow key in SET action

Thanks for review, Alin. I have updated the patch and uploaded v2 patch. Please help review again. Also, the PR (https://github.com/openvswitch/ovs/pull/326) has pasted in issue (https://github.com/openvswitch/ovs-issues/issues/190). Please help link them. - Jinjun From: Alin Serdean Date:

Re: [ovs-dev] [PATCH v2] odp-util: Fix clearing match mask if set action is partially unnecessary.

On 7/28/2020 7:32 PM, Ilya Maximets wrote: On 7/28/20 4:16 PM, Eli Britstein wrote: it is not "wildcarded". "wildcarded" means it had a match and it was removed. the case here it was only not "expanded". It actually had a match on a filed and that match was removed from the original flow

[ovs-dev] [PATCH v2] datapath-windows: Update flow key in SET action

The flow key is not updated when process OVS_ACTION_ATTR_SET action. It will impact follow-up actions, such as, conntrack module cannot find created conntrack entry if passing old flow key to it. Reported-by: Rui Cao Signed-off-by: Jinjun Gao --- v2: Separated assignment to happy MSFT SDV tool

Re: [ovs-dev] [PATCH ovn v2] Avoid nb_cfg update notification flooding

On Fri, Mar 27, 2020 at 6:31 PM Han Zhou wrote: > > Hi Lucas, > > Thanks for v2. Please see my comments below. > > On Mon, Mar 23, 2020 at 8:19 AM wrote: > > > > From: Lucas Alvares Gomes > > > > nb_cfg as a mechanism to "ping" OVN control plane is very useful > > in many ways. However, the

Re: [ovs-dev] OVN: resync nb-db to sb-db

On Tue, Jul 28, 2020 at 2:09 PM Tony Liu wrote: > > Hi, > > When I run a script to create bunch of networks and routers from OpenStack, for whatever reason, > nb-db is fully updated, but sb-db is only partially updated. For example, there are 500 logical routers > in nb-db, but only 218 datapath

Re: [ovs-dev] OVN nb-db and sb-db election timer

On Mon, Jul 27, 2020 at 1:40 PM Tony Liu wrote: > > Hi, > > During scaling test, when sb-db is busy, followers believe the leader is dead and started election > request. Some inconsistency happens during such leader switch. Two datapath bindings are created > for the same logical switch. To avoid

[ovs-dev] OVN: resync nb-db to sb-db

Hi, When I run a script to create bunch of networks and routers from OpenStack, for whatever reason, nb-db is fully updated, but sb-db is only partially updated. For example, there are 500 logical routers in nb-db, but only 218 datapath bindings in sb-db. In this case, is there any way to

Re: [ovs-dev] [PATCH ovn v4 5/5] Add ECMP symmetric replies.

Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around

Re: [ovs-dev] [PATCH ovn v4 4/5] Used nested actions in ct_commit

Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 111 characters long (recommended limit is 79) #297 FILE: ovn-sb.xml:1267:

[ovs-dev] Hallo Gr??e,

Hallo Gr??e, Ich bin Francisc Coulibaly. Seien Sie nicht beleidigt, wenn Sie ohne Ihre Erlaubnis in Ihre Privatsph?re eindringen. Gestatten Sie mir den Gefallen, um Ihre aufrichtige Unterst?tzung zu bitten, um die Summe von 4,3 Millionen Dollar in Ihr Land zu verlagern und zu investieren. Ich

[ovs-dev] [PATCH ovn v3 0/5] Add ECMP symmetric replies

In some cases, it is important that traffic that arrived over an ECMP route has its replies sent out over that same route. This series of commits adds some prerequisite changes in order to facilitate using conntrack labels to store information about the incoming traffic. The final commit adds the

[ovs-dev] [PATCH ovn v4 5/5] Add ECMP symmetric replies.

When traffic arrives over an ECMP route, there is no guarantee that the reply traffic will egress over the same route. Sometimes, the nature of the traffic (or the intervening equipment) means that it is important for reply traffic to go out the same route it came in. This commit introduces

[ovs-dev] [PATCH ovn v4 3/5] Add expression writeability scopes.

Logical fields are defined as either being writeable or read-only. There is no way to make fields writeable only in specific scenarios. This commit changes the boolean writeability field to a field of flags indicating contexts where a field is writeable. Any time that nested actions are used

[ovs-dev] [PATCH ovn v4 4/5] Used nested actions in ct_commit

ct_commit allows for ct_label and ct_mark to be set within. However, there are some restrictions with the current implementation: * It is not possible to address the indiviual bits within the ct_mark or ct_label. * It is not possible to set these to the value of a register. Only explicit

[ovs-dev] [PATCH ovn v4 1/5] Add IP address normalization to ovn-utils.

This moves a couple of existing IP address normalization routines from ovn-nbctl.c to ovn-util.c. It also adds a new normalization function for a v46_address. This new function is not used in this commit but will be used in a future commit in this series. Signed-off-by: Mark Michelson ---

[ovs-dev] [PATCH ovn v4 2/5] Don't check for writeability of rhs during assignment.

The only condition under which the right-hand side of an assignment needs to be checked for writeability is if it is an exchange (<->) operation. Signed-off-by: Mark Michelson --- lib/actions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/actions.c b/lib/actions.c

Re: [ovs-dev] [PATCH ovn] ovn-controller: Release lport if the ofport of the VIF is -1.

On Tue, Jul 28, 2020 at 11:51 PM Mark Michelson wrote: > Acked-by: Mark Michelson > > Thanks Mark. I applied this patch to master and branch-20.06. Numan > On 7/28/20 4:37 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > If ofport of an OVS interface is set -1 for some reason,

Re: [ovs-dev] [PATCH ovn] ovn-controller: Release lport if the ofport of the VIF is -1.

Acked-by: Mark Michelson On 7/28/20 4:37 AM, num...@ovn.org wrote: From: Numan Siddique If ofport of an OVS interface is set -1 for some reason, then ovn-controller is not releasing the logical port which maps to the OVS interface. This patch fixes this issue. Fixes:

Re: [ovs-dev] [PATCH v2] odp-util: Fix clearing match mask if set action is partially unnecessary.

On 7/28/20 4:16 PM, Eli Britstein wrote: > > it is not "wildcarded". "wildcarded" means it had a match and it was removed. > the case here it was only not "expanded". > >> It actually had a match on a filed and that match was removed from >> the original flow while committing set() action. 

Re: [ovs-dev] [PATCH ovn v3 5/5] Add ECMP symmetric replies.

On Tue, Jul 28, 2020 at 8:38 PM Mark Michelson wrote: > On 7/28/20 9:23 AM, Numan Siddique wrote: > > > > > > On Tue, Jul 28, 2020 at 2:51 AM Mark Michelson > > wrote: > > > > When traffic arrives over an ECMP route, there is no guarantee that > the > > reply

Re: [ovs-dev] [PATCH] datapath-windows: Update flow key in SET action

Thanks a lot for testing and fixing this as discussed offline. Can you please split the assignment via the form: “key->ipKey.nwDst = ipHdr->daddr = ipAttr->ipv4_dst” It confuses the SDV tool from msft for some reason:

Re: [ovs-dev] [PATCH v3] datapath-windows: Reset ct_mark/ct_label to support ALG

Acked-by: Alin Gabriel Serdean ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v3 5/5] Add ECMP symmetric replies.

On 7/28/20 9:23 AM, Numan Siddique wrote: On Tue, Jul 28, 2020 at 2:51 AM Mark Michelson > wrote: When traffic arrives over an ECMP route, there is no guarantee that the reply traffic will egress over the same route. Sometimes, the nature of the

Re: [ovs-dev] [PATCH v3] ovsdb-tool: Add a db consistency check to the ovsdb-tool check-cluster command

On 7/15/20 4:51 PM, Dumitru Ceara wrote: > On 7/15/20 4:22 PM, Federico Paolinelli wrote: >> >> >> On Tue, Jul 14, 2020 at 10:22 AM Dumitru Ceara > > wrote: >> >> On 7/10/20 10:18 AM, Federico Paolinelli wrote: >> > There are some occurrences where the database

Re: [ovs-dev] [PATCH v2] odp-util: Fix clearing match mask if set action is partially unnecessary.

it is not "wildcarded". "wildcarded" means it had a match and it was removed. the case here it was only not "expanded". It actually had a match on a filed and that match was removed from the original flow while committing set() action. That is the bug that this patch intended to fix. See

Re: [ovs-dev] [PATCH ovn v3 5/5] Add ECMP symmetric replies.

On Tue, Jul 28, 2020 at 2:51 AM Mark Michelson wrote: > When traffic arrives over an ECMP route, there is no guarantee that the > reply traffic will egress over the same route. Sometimes, the nature of > the traffic (or the intervening equipment) means that it is important > for reply traffic to

Re: [ovs-dev] [PATCH v2] odp-util: Fix clearing match mask if set action is partially unnecessary.

On 7/28/20 12:58 PM, Eli Britstein wrote: > > On 7/27/2020 9:58 PM, Ilya Maximets wrote: >> While committing set() actions, commit() could wildcard all the fields >> that are same in match key and in the set action.  This leads to >> situation where mask after commit could actually contain less

Re: [ovs-dev] [PATCH v2] odp-util: Fix clearing match mask if set action is partially unnecessary.

On 7/27/2020 9:58 PM, Ilya Maximets wrote: While committing set() actions, commit() could wildcard all the fields that are same in match key and in the set action. This leads to situation where mask after commit could actually contain less bits than it was before. And if set action was

Re: [ovs-dev] [PATCH ovn 0/2] Improve ovn-detrace usability with clustered DBs.

On 7/28/20 11:07 AM, Numan Siddique wrote: > > > On Tue, Jul 28, 2020 at 1:57 PM Dumitru Ceara > wrote: > > On 7/23/20 3:53 PM, Numan Siddique wrote: > > > > > > On Tue, Jul 7, 2020 at 9:23 PM Dumitru Ceara > >

Re: [ovs-dev] [PATCH ovn 0/2] Improve ovn-detrace usability with clustered DBs.

On Tue, Jul 28, 2020 at 1:57 PM Dumitru Ceara wrote: > On 7/23/20 3:53 PM, Numan Siddique wrote: > > > > > > On Tue, Jul 7, 2020 at 9:23 PM Dumitru Ceara > > wrote: > > > > Patch 1 of the series adds support for multiple remotes when > connecting > > to OVSDBs.

[ovs-dev] [PATCH ovn] ovn-controller: Release lport if the ofport of the VIF is -1.

From: Numan Siddique If ofport of an OVS interface is set -1 for some reason, then ovn-controller is not releasing the logical port which maps to the OVS interface. This patch fixes this issue. Fixes: 354bdba51abf("ovn-controller: I-P for SB port binding and OVS interface in runtime_data.")

Re: [ovs-dev] [PATCH ovn 0/2] Improve ovn-detrace usability with clustered DBs.

On 7/23/20 3:53 PM, Numan Siddique wrote: > > > On Tue, Jul 7, 2020 at 9:23 PM Dumitru Ceara > wrote: > > Patch 1 of the series adds support for multiple remotes when connecting > to OVSDBs. This is useful when the NB/SB DBs are clustered. > > Patch 2 of

Re: [ovs-dev] [ovs-discuss] OVN scale

On Mon, Jul 27, 2020 at 10:16 AM Tony Liu wrote: > Hi Han, > > Just some updates here. > > I tried with 4K networks on single router. Configuration was done without > any issues. I checked both > nb-db and sb-db, they all look good. It's just that router configuration > is huge (in Neutron DB,