Re: [ovs-dev] [PATCH] tc: Use skip_hw flag when probing tc features

2020-08-03 Thread Roi Dayan
On 2020-08-04 2:44 AM, Ilya Maximets wrote: > On 8/3/20 12:58 PM, Roi Dayan wrote: >> There is no need to pass tc rules to hw when just probing >> for tc features. this will avoid redundant errors from hw drivers >> that may happen. > > That makes sense. Thanks! > Few comments inline. > >> >>

[ovs-dev] [PATCH v2] tc: Use skip_hw flag when probing tc features

2020-08-03 Thread Roi Dayan
There is no need to pass tc rules to hw when just probing for tc features. this will avoid redundant errors from hw drivers that may happen. Signed-off-by: Roi Dayan Acked-By: Vlad Buslov --- Notes: v2 - Add missing ack from Vlad - Style fix for comment - Add build assertion for

Re: [ovs-dev] [PATCH v1] ovn-controller: Fix the CT zone assignment logic for logical routers

2020-08-03 Thread 0-day Robot
Bleep bloop. Greetings Ankur Sharma, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: sha1 information is lacking or useless (controller/ovn-controller.c). error: could not build

[ovs-dev] [PATCH v1] ovn-controller: Fix the CT zone assignment logic for logical routers

2020-08-03 Thread Ankur Sharma
From: Ankur Sharma BACKGROUND: a. ovn-controller assigns CT ZONES for local ports and datapaths. b. If a local port/datapath is cleaned up from a chassis, then corresponding CT ZONE is "unassigned"/"freed" up. ISSUE: Above logic and implementations leaves stale CT entries in the datapath, whi

Re: [ovs-dev] [OVN] no response to inactivity probe

2020-08-03 Thread Tony Liu
In my deployment, on each Neutron server, there are 13 Neutron server processes. I see 12 of them (monitor, maintenance, RPC, API) connect to both ovn-nb-db and ovn-sb-db. With 3 Neutron server nodes, that's 36 OVSDB clients. Is so many clients OK? Any suggestions how to figure out which side does

Re: [ovs-dev] [ovs-discuss] [OVN] ovn-northd takes much CPU when no configuration update

2020-08-03 Thread Tony Liu
The probe awakes recomputing? There is probe every 5 seconds. Without any connection up/down or failover, ovn-northd will recompute everything every 5 seconds, no matter what? Really? Anyways, I will increase the probe interval for now, see if that helps. Thanks! Tony > -Original Message--

Re: [ovs-dev] [ovs-discuss] [OVN] ovn-northd takes much CPU when no configuration update

2020-08-03 Thread Han Zhou
Sorry that I didn't make it clear enough. The OVSDB probe itself doesn't take much CPU, but the probe awakes ovn-northd main loop, which recompute everything, which is why you see CPU spike. It will be solved by incremental-processing, when only delta is processed, and in case of probe handling, th

Re: [ovs-dev] [ovs-discuss] [OVN] ovn-northd takes much CPU when no configuration update

2020-08-03 Thread Tony Liu
Health check (5 sec internal) taking 30%-100% CPU is definitely not acceptable, if that's really the case. There must be some blocking (and not yielding CPU) in coding, which is not supposed to be there. Could you point me to the coding for such health check? Is it single thread? Does it use any e

[ovs-dev] [OVN] no response to inactivity probe

2020-08-03 Thread Tony Liu
Hi, Neutron OVN ML2 driver was disconnected by ovn-nb-db. There are many error messages from ovn-nb-db leader. 2020-08-04T02:31:39.751Z|03138|reconnect|ERR|tcp:10.6.20.81:58620: no response to inactivity probe after 5 seconds, disconnecting 2020-08-04T02:31:42.484Z|03139|reconnect|ERR|tc

[ovs-dev] [ovs-dev v2] odp-util: clearing padding in the nd_extension

2020-08-03 Thread hepeng.0320
From: Peng He Silimar to the patch 67eb8110171f ("odp-util: Fix passing uninitialized bytes in OVS_KEY_ATTR_CT_ORIG_TUPLE_IPV*.") when change from flow into the netlink format, the tail padding of nd_extension should be cleared. this fixes the following warning logs: 2020-07-28T05:54:33.298Z|00

Re: [ovs-dev] [PATCH] tc: Use skip_hw flag when probing tc features

2020-08-03 Thread Ilya Maximets
On 8/3/20 12:58 PM, Roi Dayan wrote: > There is no need to pass tc rules to hw when just probing > for tc features. this will avoid redundant errors from hw drivers > that may happen. That makes sense. Thanks! Few comments inline. > > Signed-off-by: Roi Dayan > --- > lib/netdev-offload-tc.c |

Re: [ovs-dev] [Linux-kernel-mentees] [PATCH net] openvswitch: Prevent kernel-infoleak in ovs_ct_put_key()

2020-08-03 Thread Peilin Ye
On Mon, Aug 03, 2020 at 03:10:38PM -0700, David Miller wrote: > From: Peilin Ye > Date: Fri, 31 Jul 2020 00:48:38 -0400 > > > ovs_ct_put_key() is potentially copying uninitialized kernel stack memory > > into socket buffers, since the compiler may leave a 3-byte hole at the end > > of `struct ovs

[ovs-dev] New Order

2020-08-03 Thread Sales
Good Day, Here is the product required by my client, Please attached is our quotation list, check and get back to us with your PI and delivery method Thanks Regards, Ahmed Purchase Manager, Kashish Export Tel : +98 21 88459891-3 Fax: +98 21 88459890 Address: Unit 3, No.10 Zaitoon St.,Shariat

Re: [ovs-dev] [PATCH net-next v4 0/2] net: openvswitch: masks cache enhancements

2020-08-03 Thread David Miller
From: Eelco Chaudron Date: Fri, 31 Jul 2020 14:20:34 +0200 > This patchset adds two enhancements to the Open vSwitch masks cache. > > Signed-off-by: Eelco Chaudron Series applied, thank you. ___ dev mailing list d...@openvswitch.org https://mail.open

Re: [ovs-dev] [Linux-kernel-mentees] [PATCH net] openvswitch: Prevent kernel-infoleak in ovs_ct_put_key()

2020-08-03 Thread David Miller
From: Peilin Ye Date: Fri, 31 Jul 2020 00:48:38 -0400 > ovs_ct_put_key() is potentially copying uninitialized kernel stack memory > into socket buffers, since the compiler may leave a 3-byte hole at the end > of `struct ovs_key_ct_tuple_ipv4` and `struct ovs_key_ct_tuple_ipv6`. Fix > it by initia

Re: [ovs-dev] [PATCH branch-2.13 0/2] Release patches for v2.13.1.

2020-08-03 Thread Ilya Maximets
On 7/30/20 12:44 AM, Ilya Maximets wrote: > > Ilya Maximets (2): > Set release date for 2.13.1. > Prepare for 2.13.2. > > NEWS | 14 +- > configure.ac | 2 +- > debian/changelog | 8 +++- > 3 files changed, 17 insertions(+), 7 deletions(-) > Kind reminder.

[ovs-dev] [OVN] constraint violation error from Neutron OVN ML2 driver

2020-08-03 Thread Tony Liu
Hi, Any clues about this error? It is reproduceable but not consistently. There are 3 Neutron nodes and 3 OVN DB nodes (RAFT cluster). It happened when connecting network to router by OpenStack cli. === 2020-08-03 12:30:17.054 22 ERROR ovsdbapp.backend.ovs_idl.tran

Re: [ovs-dev] [ovs-dev v1] odp-util: clearing padding in the nd_extension

2020-08-03 Thread Ilya Maximets
Hi. Thanks for the fix! It looks good to me in general. Few comments inline. Best regards, Ilya Maximets. On 7/31/20 2:44 AM, hepeng.0320 wrote: > From: Peng He > > Silimar to the patch fffd3ae2866255cb740457b50a217c0b586f9223, There is no such object in git. Did you mean commit 67eb8110171

[ovs-dev] [PATCH] ovsdb: Add unixctl command to show storage status.

2020-08-03 Thread Dumitru Ceara
If a database enters an error state, e.g., in case of RAFT when reading the DB file contents if applying the RAFT records triggers constraint violations, there's no way to determine this unless a client generates a write transaction. Such write transactions would fail with "ovsdb-error: inconsisten

Re: [ovs-dev] Altium - Proposal

2020-08-03 Thread Kelsey Cooper via dev
Hi,   I have been trying to get in touch with you to see if there is a mutual fit between our company’s expertise and your goals around.   Please review my previous emails and let me know your thoughts.   Await your response.   Regards, Kelsey Cooper - Marketing Executive     Hi, Did you g

Re: [ovs-dev] [PATCH] tc: Use skip_hw flag when probing tc features

2020-08-03 Thread Simon Horman
On Mon, Aug 03, 2020 at 01:58:06PM +0300, Roi Dayan wrote: > There is no need to pass tc rules to hw when just probing > for tc features. this will avoid redundant errors from hw drivers > that may happen. > > Signed-off-by: Roi Dayan Thanks, this looks fine to me. I'll let it sit for a day or

[ovs-dev] [PATCH] checkpatch: Ignore macro definitions of FOR_EACH

2020-08-03 Thread Aaron Conole
When defining a FOR_EACH macro, checkpatch freaks out and generates a control block whitespace error. Create an exception so that it doesn't generate errors for this case. Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2020-August/373509.html Reported-by: Toshiaki Makita Signed-off

[ovs-dev] [PATCH] tc: Use skip_hw flag when probing tc features

2020-08-03 Thread Roi Dayan
There is no need to pass tc rules to hw when just probing for tc features. this will avoid redundant errors from hw drivers that may happen. Signed-off-by: Roi Dayan --- lib/netdev-offload-tc.c | 2 ++ lib/tc.c| 13 ++--- lib/tc.h| 8 3 files ch

Re: [ovs-dev] [PATCH v3 0/2 ovn] External IP based NAT

2020-08-03 Thread Numan Siddique
On Thu, Jul 9, 2020 at 5:55 AM Ankur Sharma wrote: > Another term for this feature is destination based NAT, > especially in the context of SNAT. > > Current NAT implementation is OVN endpoint ip based. > For example, > > # ovn-nbctl lr-nat-list router > TYPE EXTERNAL_IPLOGICA

Re: [ovs-dev] [PATCH ovn 6/7] ovn-northd.c: Remove the use of the REGBIT_SKIP_LOOKUP_NEIGHBOR bit.

2020-08-03 Thread Numan Siddique
On Thu, Jul 30, 2020 at 12:18 PM Han Zhou wrote: > On Wed, Jul 29, 2020 at 10:37 AM Numan Siddique wrote: > > > > > > > > On Thu, Jul 23, 2020 at 10:57 AM Han Zhou wrote: > >> > >> In LR ingress stage LOOKUP_NEIGHBOR and LEARN_NEIGHBOR, the flag > >> REGBIT_SKIP_LOOKUP_NEIGHBOR was used to indi

[ovs-dev] PURCHASE

2020-08-03 Thread Mr. Duncan
Good day, I am Interested in some of your products, could you kindly send me your full catalog of products with clear photos and list of FOB prices in USD with competitive prices for serious starting, Wholesale Prices will be accepted as well, because we just discovered the high interest of you