Re: [ovs-dev] [PATCH 1/9 net-next] net: netdevice.h: sw_netstats_rx_add helper

2020-10-05 Thread Jakub Kicinski
On Mon, 5 Oct 2020 22:34:18 +0200 Fabian Frederick wrote: > +static inline void dev_sw_netstats_rx_add(struct net_device *dev, unsigned > int len) > +{ > + struct pcpu_sw_netstats *tstats = this_cpu_ptr(dev->tstats); > + > + u64_stats_update_begin(>syncp); > + tstats->rx_bytes +=

Re: [ovs-dev] [PATCH v1 1/1] dns-resolve: Allow unbound's config file to be set through an env var.

2020-10-05 Thread Ilya Maximets
On 9/28/20 8:54 PM, Ted Elhourani wrote: > When an unbound context is created, check whether OVS_UNBOUND_CONF has been > set. If a valid config file is supplied then use it to configure the > context. The procedure returns if the config file is invalid. If no config > file is found then the

[ovs-dev] Doctors Dont Want You To Know... (Social media keeps removing the video)

2020-10-05 Thread Loriea Stenner
Having trouble viewing this email? Please follow this link to see the messaged emailed to you. (Unsubscribe Instructions Here) ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH 0/9 net-next] drivers/net: add sw_netstats_rx_add helper

2020-10-05 Thread Fabian Frederick
This small patchset creates netstats addition dev_sw_netstats_rx_add() based on dev_lstats_add() and replaces some open coding in both drivers/net and net branches. Fabian Frederick (9): net: netdevice.h: sw_netstats_rx_add helper vxlan: use dev_sw_netstats_rx_add() geneve: use

[ovs-dev] [PATCH 1/9 net-next] net: netdevice.h: sw_netstats_rx_add helper

2020-10-05 Thread Fabian Frederick
some drivers/network protocols update rx bytes/packets under u64_stats_update_begin/end sequence. Add a specific helper like dev_lstats_add() Signed-off-by: Fabian Frederick --- include/linux/netdevice.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/linux/netdevice.h

[ovs-dev] [PATCH 8/9 net-next] net: openvswitch: use dev_sw_netstats_rx_add()

2020-10-05 Thread Fabian Frederick
use new helper for netstats settings Signed-off-by: Fabian Frederick --- net/openvswitch/vport-internal_dev.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c index

Re: [ovs-dev] [PATCH v1 1/1] dns-resolve: Allow unbound's config file to be set through an env var.

2020-10-05 Thread Ted Elhourani
Thanks Yifeng, Not sure how to move this forward. Ben? Thanks, Ted From: Yifeng Sun Date: Monday, September 28, 2020 at 1:39 PM To: Ted Elhourani Cc: ovs dev Subject: Re: [ovs-dev] [PATCH v1 1/1] dns-resolve: Allow unbound's config file to be set through an env var. Looks good to me,

Re: [ovs-dev] [PATCH ovn 5/5] ovn-northd: Use reject OVN action for reject ACL.

2020-10-05 Thread Numan Siddique
On Mon, Oct 5, 2020 at 11:20 PM wrote: > > From: Numan Siddique > > Before this patch, we were adding 4 lflows for a reject ACL (with no > allow-related) > ACLs and 8 lflows for a reject ACL (with other allow-related ACLs present). > > With this patch, there will be just one lflow for each

[ovs-dev] [PATCH ovn 5/5] ovn-northd: Use reject OVN action for reject ACL.

2020-10-05 Thread numans
From: Numan Siddique Before this patch, we were adding 4 lflows for a reject ACL (with no allow-related) ACLs and 8 lflows for a reject ACL (with other allow-related ACLs present). With this patch, there will be just one lflow for each reject ACL. This reduces the number of lflows and size of

[ovs-dev] [PATCH ovn 3/5] actions: Add a new OVN action - reject {}.

2020-10-05 Thread numans
From: Numan Siddique This action is similar to tcp_reset and icmp4/icmp6 action. If the matching packet is an IPv4 of IPv6 TCP packet, it sends out TCP RST packet else it sends out ICMPv4 or ICMPv6 Destination unreachable packet. A future patch will make use of this action for reject ACL.

[ovs-dev] [PATCH ovn 2/5] ovn-trace: Don't assert for next(stage=ingress, ..).

2020-10-05 Thread numans
From: Numan Siddique The commit [1] allowed next action to advance from ingress to egress pipeline, but ovn-trace was not modified to handle this condition. Also corrected the ovntrace node format message as per the next stage. [1] - b4b68177eb2f("Fix conntrack entry leaks because of TCP RST

[ovs-dev] [PATCH ovn 4/5] actions: Add new OVN logical fields 'ip.src' and ip.dst'.

2020-10-05 Thread numans
From: Numan Siddique Thee new fields are version independent and these can be used in any OVN action. Right now the usage of these fields are restricted to exchanging the IP source and destination fields. Eg. reject {... ip.src <-> ip.dst ... }; "ip.src <-> ip.dst" translates to controller

[ovs-dev] [PATCH ovn 1/5] northd: Use 'enum ovn_stage' for the table value in the 'next' OVN action.

2020-10-05 Thread numans
From: Numan Siddique Multiple places in ovn-northd.c hard codes the table value in the next() OVN action. This patch changes those occurrences to use ovn_stage_get_table('enum ovn_stage' value). Hard coding of the table number can result in errors if new stages are added (like the patch [1]

[ovs-dev] [PATCH ovn 5/5] ovn-northd: Optimize logical flow generation for reject ACLs.

2020-10-05 Thread numans
From: Numan Siddique ovn-northd adds below lflows for a reject ACL with a match - M match = (ip4 && tcp && 'M') action = tcp_reject{} match = (ip6 && tcp && 'M') action = tcp_reject{} match = (ip4 && 'M') action = icmp4{} match = (ip6 && 'M') action = icmp6{} This approach has a couple of

[ovs-dev] [PATCH ovn 0/5] ovn-northd: Optimize logical flow generation for reject ACLs.

2020-10-05 Thread numans
From: Numan Siddique This patch series improves the reject ACL logical flow generation by reducing the number of logical flows for the reject ACL. A new OVN action - reject is added for this. Now only 1 lflow is added per each reject ACL. Patch 1 and 2 are bug fix patches and they need to be

Re: [ovs-dev] [PATCH v2 1/1] DPDK: Remove support for vhost-user zero-copy.

2020-10-05 Thread Stokes, Ian
> On 29/09/2020 17:44, Ilya Maximets wrote: > > On 9/29/20 6:33 PM, Stokes, Ian wrote: > >>> On 9/10/20 7:30 PM, Ian Stokes wrote: > Support for vhost-user dequeue zero-copy was deprecated in OVS 2.14 > >>> with > the aim of removing it for OVS 2.15. > > OVS only supports zero

Re: [ovs-dev] [PATCH v3 8/8] appveyor: Bump outdated links and add artifacts

2020-10-05 Thread Ilya Maximets
On 10/5/20 2:54 PM, Alin Serdean wrote: >> *From: *Ilya Maximets > *Sent: *Friday, September 25, 2020 4:55 PM > *To: *Alin Gabriel Serdean ; ovs-dev@openvswitch.org > > *Cc: *i.maxim...@ovn.org

Re: [ovs-dev] [PATCH] dpctl: Fix broken flow deletion via ovs-dpctl due to missing ufid.

2020-10-05 Thread Ilya Maximets
On 10/5/20 2:04 PM, Eelco Chaudron wrote: > > > On 5 Oct 2020, at 12:09, Ilya Maximets wrote: > >> Current code generates UFID for flows installed by ovs-dpctl.  This >> leads to inability to remove such flows by the same command.  Ex: >> >>   ovs-dpctl add-dp test >>   ovs-dpctl add-if test

Re: [ovs-dev] [PATCH] dpctl: Fix broken flow deletion via ovs-dpctl due to missing ufid.

2020-10-05 Thread Eelco Chaudron
On 5 Oct 2020, at 12:09, Ilya Maximets wrote: Current code generates UFID for flows installed by ovs-dpctl. This leads to inability to remove such flows by the same command. Ex: ovs-dpctl add-dp test ovs-dpctl add-if test vport0 ovs-dpctl add-flow test

[ovs-dev] [PATCH] dpctl: Fix broken flow deletion via ovs-dpctl due to missing ufid.

2020-10-05 Thread Ilya Maximets
Current code generates UFID for flows installed by ovs-dpctl. This leads to inability to remove such flows by the same command. Ex: ovs-dpctl add-dp test ovs-dpctl add-if test vport0 ovs-dpctl add-flow test "in_port(0),eth(),eth_type(0x800),ipv4(src=100.1.0.1)" 0 ovs-dpctl del-flow