Re: [ovs-dev] [PATCH ovn v2] Include OVS as a git submodule.

2021-01-22 Thread 0-day Robot
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has non-spaces leading whitespace #108 FILE: .gitmodules:2: path = ovs

[ovs-dev] [PATCH ovn v2] Include OVS as a git submodule.

2021-01-22 Thread Mark Michelson
OVN developers have had isssues with the current method by which OVS source code is used by OVN. * There is no way to record the minimum commit/version of OVS to use when compiling OVN. * When debugging issues, bisecting OVN commits may also requires simultaneously changing OVS commits. This

Re: [ovs-dev] [PATCH ovs v2] conntrack: Fix the icmp conntrack new state.

2021-01-22 Thread Aaron Conole
xiangxia.m@gmail.com writes: > From: Tonghao Zhang > > The same icmp packet may traverse conntrack module more than once. > Or same icmp packets traverse contranck module in orderly. > > Don't change state to CS_ESTABLISHED before receiving reply or related > packets. > > Fixes:

[ovs-dev] [PATCH] github: Run clang test with AddressSanitizer enabled.

2021-01-22 Thread Ilya Maximets
This commit is based on a similar one from OVN by Dumitru Ceara: a429b24f7bf5 ("ci: Enable AddressSanitizer in Linux clang CI test runs.") It's useful to run testsuite with address sanitizer enabled to catch memory leaks and invalid memory accesses. Skipping re-check if AddressSanitizer

Re: [ovs-dev] [PATCH ovn] northd: add --event option to enable controller_event for empty_lb

2021-01-22 Thread 0-day Robot
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 207 characters long (recommended limit is 79) #79 FILE:

[ovs-dev] [PATCH ovn] northd: add --event option to enable controller_event for empty_lb

2021-01-22 Thread Lorenzo Bianconi
Introduce the --event option to enable empty_lb controller event for a load_balancer with no backends (doing so the option is per-lb and not global). $ovn-nbctl --event lb-add lb0 192.168.0.100:80 "" controller_event_en global variable is not removed for backward compatibility but it is

[ovs-dev] [PATCH] rhel: Update for DPDK 20.11

2021-01-22 Thread Timothy Redaelli
With DPDK 20.11, meson and pkgconfig are used instead of the old Makefile-based system and so --with-dpdk option is changed to only accept shared or static instead of the directory. This commit uses --with-dpdk=shared since Fedora and RHEL ship shared libraries of DPDK. Fixes: 252e1e576443

[ovs-dev] [PATCH ovn] tests: Fix L2 ACL test.

2021-01-22 Thread Dumitru Ceara
The ACLs configured by the "ovn -- L2 Drop and Allow ACL w/ Stateful ACL" test were incorrect because they didn't enclose logical port names in quotes. This caused stateful ACLs to never be applied so the L2 drop rules were not properly tested. ovn-controller was logging the following errors:

[ovs-dev] [PATCH ovn] ovn-controller: Fix wrong conj_id match flows when caching is enabled.

2021-01-22 Thread numans
From: Numan Siddique When the below ACL is added - ovn-nbctl acl-add ls1 to-lport 3 '(ip4.src==10.0.0.1 || ip4.src==10.0.0.2) && (ip4.dst == 10.0.0.3 || ip4.dst == 10.0.0.4)' allow ovn-controller installs the below OF flows table=45, priority=1003,ip,metadata=0x1,nw_dst=10.0.0.4