Re: [ovs-dev] [PATCH v3 2/3] ovsdb-idl: Preserve references for deleted rows.

2021-03-23 Thread Han Zhou
On Tue, Mar 23, 2021 at 3:26 PM Dumitru Ceara wrote: > > On 3/23/21 8:15 PM, Han Zhou wrote: > > On Tue, Mar 23, 2021 at 5:00 AM Dumitru Ceara wrote: > >> > >> On 3/22/21 8:45 PM, Han Zhou wrote: > >>> On Mon, Mar 22, 2021 at 4:27 AM Dumitru Ceara wrote: > > On 3/19/21 6:55 PM, Han

[ovs-dev] [PATCH ovn v2] Support vlan-passthru for tag=0 logical switch ports

2021-03-23 Thread Ihar Hrachyshka
When vlan-passthru is true for LS, for untagged localnet ports, tagged VLAN traffic originating from VIFs should be passed through intact since the VLAN header belongs to VIF user, not the localnet port fabric. This patch adds multinode test cases to cover scenarios where packets traverse through

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Remove "reachable" functions and users of them.

2021-03-23 Thread Mark Michelson
On 3/23/21 6:55 PM, Dumitru Ceara wrote: On 3/23/21 10:02 PM, Mark Michelson wrote: On 3/23/21 12:13 PM, Dumitru Ceara wrote: On 3/23/21 5:05 PM, Numan Siddique wrote: On Fri, Mar 19, 2021 at 2:20 AM Mark Michelson wrote: Self-originated ARPs are intended to be sent to the "owning" router

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Remove "reachable" functions and users of them.

2021-03-23 Thread Dumitru Ceara
On 3/23/21 10:02 PM, Mark Michelson wrote: > On 3/23/21 12:13 PM, Dumitru Ceara wrote: >> On 3/23/21 5:05 PM, Numan Siddique wrote: >>> On Fri, Mar 19, 2021 at 2:20 AM Mark Michelson >>> wrote: Self-originated ARPs are intended to be sent to the "owning" router for a given IP

Re: [ovs-dev] [PATCH v3 2/3] ovsdb-idl: Preserve references for deleted rows.

2021-03-23 Thread Dumitru Ceara
On 3/23/21 8:15 PM, Han Zhou wrote: > On Tue, Mar 23, 2021 at 5:00 AM Dumitru Ceara wrote: >> >> On 3/22/21 8:45 PM, Han Zhou wrote: >>> On Mon, Mar 22, 2021 at 4:27 AM Dumitru Ceara wrote: On 3/19/21 6:55 PM, Han Zhou wrote: > On Fri, Mar 19, 2021 at 1:42 AM Dumitru Ceara >

Re: [ovs-dev] [RFC PATCH] lib: Introduce netlink-devlink library

2021-03-23 Thread Frode Nordahl
On Tue, Mar 23, 2021 at 5:23 PM Ben Pfaff wrote: > > On Tue, Mar 23, 2021 at 03:50:32PM +0100, Frode Nordahl wrote: > > The devlink interface was introduced [0] in the Linux 4.6 time > > frame and has since gained traction among multiple hardware > > vendors. > > > > The devlink-port [1] and

Re: [ovs-dev] [PATCH] openvswitch: perform refragmentation for packets which pass through conntrack

2021-03-23 Thread Flavio Leitner
Hi, On Fri, Mar 19, 2021 at 04:43:07PM -0400, Aaron Conole wrote: > When a user instructs a flow pipeline to perform connection tracking, > there is an implicit L3 operation that occurs - namely the IP fragments > are reassembled and then processed as a single unit. After this, new > fragments

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Remove "reachable" functions and users of them.

2021-03-23 Thread Mark Michelson
On 3/23/21 12:13 PM, Dumitru Ceara wrote: On 3/23/21 5:05 PM, Numan Siddique wrote: On Fri, Mar 19, 2021 at 2:20 AM Mark Michelson wrote: Self-originated ARPs are intended to be sent to the "owning" router for a given IP address, as well as flooded to non-router ports on a logical switch.

Re: [ovs-dev] [PATCH v3 2/3] ovsdb-idl: Preserve references for deleted rows.

2021-03-23 Thread Han Zhou
On Tue, Mar 23, 2021 at 5:00 AM Dumitru Ceara wrote: > > On 3/22/21 8:45 PM, Han Zhou wrote: > > On Mon, Mar 22, 2021 at 4:27 AM Dumitru Ceara wrote: > >> > >> On 3/19/21 6:55 PM, Han Zhou wrote: > >>> On Fri, Mar 19, 2021 at 1:42 AM Dumitru Ceara wrote: > > On 3/19/21 2:41 AM, Han

Re: [ovs-dev] [PATCH ovn] northd: Fix routing loop in LRs with one-to-many SNAT

2021-03-23 Thread Ben Pfaff
On Mon, Mar 22, 2021 at 10:14:46AM +0100, Krzysztof Klimonda wrote: > If there are snat entries on the router, and some logical_ip are set to > network instead of an IP address then given SNAT is masquerade. In such > case ct_snat action is used in lr_in_unsnat table to ensure that the > packet is

Re: [ovs-dev] [PATCH ovn v3] binding: Fix the crashes seen when port binding type changes.

2021-03-23 Thread Dumitru Ceara
On 3/22/21 7:44 PM, Numan Siddique wrote: > On Fri, Mar 19, 2021 at 8:10 PM Dumitru Ceara wrote: >> >> On 3/19/21 1:05 PM, num...@ovn.org wrote: >>> From: Numan Siddique >>> >>> When a port binding type changes from type 'A' to type 'B', then >>> there are many code paths in the existing

Re: [ovs-dev] [RFC PATCH] lib: Introduce netlink-devlink library

2021-03-23 Thread Ben Pfaff
On Tue, Mar 23, 2021 at 03:50:32PM +0100, Frode Nordahl wrote: > The devlink interface was introduced [0] in the Linux 4.6 time > frame and has since gained traction among multiple hardware > vendors. > > The devlink-port [1] and devlink-info[1] interfaces are > particularly useful for managing

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Remove "reachable" functions and users of them.

2021-03-23 Thread Dumitru Ceara
On 3/23/21 5:05 PM, Numan Siddique wrote: > On Fri, Mar 19, 2021 at 2:20 AM Mark Michelson wrote: >> >> Self-originated ARPs are intended to be sent to the "owning" router for >> a given IP address, as well as flooded to non-router ports on a logical >> switch. >> >> When trying to determine the

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Remove "reachable" functions and users of them.

2021-03-23 Thread Numan Siddique
On Fri, Mar 19, 2021 at 2:20 AM Mark Michelson wrote: > > Self-originated ARPs are intended to be sent to the "owning" router for > a given IP address, as well as flooded to non-router ports on a logical > switch. > > When trying to determine the owning router for an IP address, we would >

Re: [ovs-dev] [PATCH ovn v3 1/2] northd: Swap src and dst eth addresses in router egress loop.

2021-03-23 Thread Numan Siddique
On Fri, Mar 19, 2021 at 2:20 AM Mark Michelson wrote: > > When a hairpin scenario is detected (i.e. egressing on gateway router > port to a NAT external address), we loop back to the ingress router > pipeline and swap the inport and outport. This is intended to allow for > the traffic to get

[ovs-dev] [PATCH ovn v4] binding: Fix the crashes seen when port binding type changes.

2021-03-23 Thread numans
From: Numan Siddique When a port binding type changes from type 'A' to type 'B', then there are many code paths in the existing binding.c which results in crashes due to use-after-free or NULL references. Below crashes are seen when a container lport is changed to a normal lport and then

[ovs-dev] [RFC PATCH] lib: Introduce netlink-devlink library

2021-03-23 Thread Frode Nordahl
The devlink interface was introduced [0] in the Linux 4.6 time frame and has since gained traction among multiple hardware vendors. The devlink-port [1] and devlink-info[1] interfaces are particularly useful for managing NICs connected to multiple distinct CPUs such as SmartNICs. In such a

Re: [ovs-dev] [PATCH v12 00/11] Add offload support for sFlow

2021-03-23 Thread Ilya Maximets
On 3/5/21 4:27 AM, Chris Mi wrote: > Hi Ilya, > > I think about your suggestion recently. But I'm still not very clear about > the design. > Please see my reply below: > > On 3/1/2021 8:48 PM, Ilya Maximets wrote: >> On 3/1/21 9:30 AM, Chris Mi wrote: >>> Hi Simon, Ilya, >>> >>> Could I know

Re: [ovs-dev] [PATCH] dpif-netdev-lookup: Allow AVX512 dpcls without building core OVS with SSE4.2.

2021-03-23 Thread Van Haaren, Harry
> -Original Message- > From: Ilya Maximets > Sent: Monday, March 22, 2021 12:55 PM > To: Van Haaren, Harry ; Ilya Maximets > ; ovs-dev@openvswitch.org > Cc: Stokes, Ian ; Timothy Redaelli > ; Flavio Leitner > Subject: Re: [PATCH] dpif-netdev-lookup: Allow AVX512 dpcls without building >

[ovs-dev] [PATCH ovn] pinctrl: Don't send gARPs for localports

2021-03-23 Thread Daniel Alvarez Sanchez
Ports of type 'localport' are present on every hypervisor and ovn-controller is sending gARPs for them which makes upstream switches to see its MAC address flapping. In order to avoid this behavior, the current patch is skipping localports when sending gARP/RARP packets. Reported-at:

Re: [ovs-dev] [PATCH v2] conntrack: Add a test for IPv4 UDP zero checksum

2021-03-23 Thread Aaron Conole
Paolo Valerio writes: > Hi Aaron, > > Aaron Conole writes: > >> Recently, during some conntrack testing a bug was uncovered in a DPDK >> PMD, which doesn't support an IPv4 packet with a zero checksum value. >> In order to show that the connection tracking code in userspace >> supports IPv4 UDP

Re: [ovs-dev] [PATCH v3 2/3] ovsdb-idl: Preserve references for deleted rows.

2021-03-23 Thread Dumitru Ceara
On 3/22/21 8:45 PM, Han Zhou wrote: > On Mon, Mar 22, 2021 at 4:27 AM Dumitru Ceara wrote: >> >> On 3/19/21 6:55 PM, Han Zhou wrote: >>> On Fri, Mar 19, 2021 at 1:42 AM Dumitru Ceara wrote: On 3/19/21 2:41 AM, Han Zhou wrote: > > > On Thu, Mar 18, 2021 at 6:27 PM Han Zhou

Re: [ovs-dev] [PATCH] conntrack: document NULL SNAT behavior and add a test case

2021-03-23 Thread Eelco Chaudron
On 22 Mar 2021, at 19:50, Paolo Valerio wrote: Hi Eelco, Thanks for working on this, very useful indeed. not a full review, but I have a question about a minor thing. Eelco Chaudron writes: Currently, conntrack in the kernel has an undocumented feature referred to as NULL SNAT.

Re: [ovs-dev] [PATCH ovn v2 6/9] tests: Amend release stale port binding test for RBAC

2021-03-23 Thread Frode Nordahl
On Mon, Mar 22, 2021 at 8:47 PM Mark Michelson wrote: > > Hi Frode, > > For patches 6-9: > > Acked-by: Mark Michelson Thank you for the review, much appreciated. > Can you specify which of the patches need to be backported and to which > branches they need to be backported? I can take care of